Skip to content

Commit f21fbee

Browse files
nickiesxa
authored andcommitted
test: update V8 trace events test expectations
The event "V8.GCScavenger" is soon to be deprecated. Most of V8 trace events are either behind flags and disabled by default, or are emitted infrequently. Instead of replacing "V8.GCScavenger" with some other random event, this patch updates the tests to check that there is some event in the category "v8" whose name starts with "V8.". PR-URL: #42120 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent ce86fc3 commit f21fbee

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎test/parallel/test-trace-events-all.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ proc.once('exit', common.mustCall(() => {
2727
returnfalse;
2828
if(trace.cat!=='v8')
2929
returnfalse;
30-
if(trace.name!=='V8.GCScavenger')
30+
if(!trace.name.startsWith('V8.'))
3131
returnfalse;
3232
returntrue;
3333
}));

‎test/parallel/test-trace-events-v8.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ proc.once('exit', common.mustCall(() => {
2929
returnfalse;
3030
if(trace.cat!=='v8')
3131
returnfalse;
32-
if(trace.name!=='V8.GCScavenger')
32+
if(!trace.name.startsWith('V8.'))
3333
returnfalse;
3434
returntrue;
3535
}));

0 commit comments

Comments
 (0)