test: remove common.PORT from multiple tests

PR-URL: #12451
Ref: #12376
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: tarunbatra

test/parallel/test-cluster-master-error.js

@@ -10,7 +10,7 @@ if (cluster.isWorker) {
 consthttp=require('http');
 http.Server(()=>{
 
-}).listen(common.PORT,'127.0.0.1');
+}).listen(0,'127.0.0.1');
 
 }elseif(process.argv[2]==='cluster'){
 

test/parallel/test-cluster-master-kill.js

@@ -7,7 +7,7 @@ if (cluster.isWorker) {
 
 // keep the worker alive
 consthttp=require('http');
-http.Server().listen(common.PORT,'127.0.0.1');
+http.Server().listen(0,'127.0.0.1');
 
 }elseif(process.argv[2]==='cluster'){
 

test/parallel/test-cluster-net-send.js

@@ -46,8 +46,8 @@ if (process.argv[2] !== 'child') {
 socketConnected();
 });
 
-server.listen(common.PORT,function(){
-socket=net.connect(common.PORT,'127.0.0.1',socketConnected);
+server.listen(0,function(){
+socket=net.connect(server.address().port,'127.0.0.1',socketConnected);
 });
 
 process.on('disconnect',function(){

test/parallel/test-cluster-rr-domain-listen.js

@@ -1,5 +1,5 @@
 'use strict';
-constcommon=require('../common');
+require('../common');
 constcluster=require('cluster');
 constdomain=require('domain');
 
@@ -11,7 +11,7 @@ if (cluster.isWorker) {
 d.run(function(){});
 
 consthttp=require('http');
-http.Server(function(){}).listen(common.PORT,'127.0.0.1');
+http.Server(function(){}).listen(0,'127.0.0.1');
 
 }elseif(cluster.isMaster){
 letworker;

test/parallel/test-cluster-rr-ref.js

@@ -10,7 +10,7 @@ if (cluster.isMaster) {
 });
 }else{
 constserver=net.createServer(common.mustNotCall());
-server.listen(common.PORT,function(){
+server.listen(0,function(){
 server.unref();
 server.ref();
 server.close(function(){

test/parallel/test-cluster-shared-leak.js

@@ -13,10 +13,10 @@ if (cluster.isMaster) {
 letconn,worker2;
 
 constworker1=cluster.fork();
-worker1.on('message',common.mustCall(function(){
+worker1.on('listening',common.mustCall(function(address){
 worker2=cluster.fork();
 worker2.on('online',function(){
-conn=net.connect(common.PORT,common.mustCall(function(){
+conn=net.connect(address.port,common.mustCall(function(){
 worker1.disconnect();
 worker2.disconnect();
 }));
@@ -48,6 +48,4 @@ const server = net.createServer(function(c) {
 c.end('bye');
 });
 
-server.listen(common.PORT,function(){
-process.send('listening');
-});
+server.listen(0);

test/parallel/test-cluster-worker-no-exit.js

@@ -1,5 +1,5 @@
 'use strict';
-constcommon=require('../common');
+require('../common');
 constassert=require('assert');
 constcluster=require('cluster');
 constnet=require('net');
@@ -34,7 +34,7 @@ if (cluster.isMaster) {
 success=true;
 });
 
-}).listen(common.PORT,function(){
+}).listen(0,function(){
 constport=this.address().port;
 
 worker=cluster.fork()