perf_hooks: reduce overhead of new performance_entries

H4ad · ruyadorno · commit f40b5ede0225 · 2023-09-27T23:18:48.000-04:00
PR-URL: #49803 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
diff --git a/benchmark/perf_hooks/timerfied.js b/benchmark/perf_hooks/timerfied.js
@@ -0,0 +1,36 @@
+'use strict';
+
+const assert = require('assert');
+const common = require('../common.js');
+
+const {
+ PerformanceObserver,
+ performance,
+} = require('perf_hooks');
+
+function randomFn() {
+ return Math.random();
+}
+
+const bench = common.createBenchmark(main, {
+ n: [1e5],
+ observe: ['function'],
+});
+
+let _result;
+
+function main({ n, observe }) {
+ const obs = new PerformanceObserver(() => {
+ bench.end(n);
+ });
+ obs.observe({ entryTypes: [observe], buffered: true });
+
+ const timerfied = performance.timerify(randomFn);
+
+ bench.start();
+ for (let i = 0; i < n; i++)
+ _result = timerfied();
+
+ // Avoid V8 deadcode (elimination)
+ assert.ok(_result);
+}
diff --git a/lib/internal/perf/performance_entry.js b/lib/internal/perf/performance_entry.js
@@ -2,7 +2,6 @@
 
 const {
 ObjectDefineProperties,
- ReflectConstruct,
 Symbol,
 } = primordials;
 
@@ -25,14 +24,17 @@ const kEntryType = Symbol('PerformanceEntry.EntryType');
 const kStartTime = Symbol('PerformanceEntry.StartTime');
 const kDuration = Symbol('PerformanceEntry.Duration');
 const kDetail = Symbol('NodePerformanceEntry.Detail');
+const kSkipThrow = Symbol('kSkipThrow');
 
 function isPerformanceEntry(obj) {
 return obj?.[kName] !== undefined;
 }
 
 class PerformanceEntry {
- constructor() {
- throw new ERR_ILLEGAL_CONSTRUCTOR();
+ constructor(skipThrowSymbol = undefined) {
+ if (skipThrowSymbol !== kSkipThrow) {
+ throw new ERR_ILLEGAL_CONSTRUCTOR();
+ }
 }
 
 get name() {
@@ -92,9 +94,11 @@ function initPerformanceEntry(entry, name, type, start, duration) {
 }
 
 function createPerformanceEntry(name, type, start, duration) {
- return ReflectConstruct(function PerformanceEntry() {
- initPerformanceEntry(this, name, type, start, duration);
- }, [], PerformanceEntry);
+ const entry = new PerformanceEntry(kSkipThrow);
+
+ initPerformanceEntry(entry, name, type, start, duration);
+
+ return entry;
 }
 
 /**
@@ -119,10 +123,12 @@ class PerformanceNodeEntry extends PerformanceEntry {
 }
 
 function createPerformanceNodeEntry(name, type, start, duration, detail) {
- return ReflectConstruct(function PerformanceNodeEntry() {
- initPerformanceEntry(this, name, type, start, duration);
- this[kDetail] = detail;
- }, [], PerformanceNodeEntry);
+ const entry = new PerformanceNodeEntry(kSkipThrow);
+
+ initPerformanceEntry(entry, name, type, start, duration);
+ entry[kDetail] = detail;
+
+ return entry;
 }
 
 module.exports = {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,36 @@ @@
 +'use strict';
++
 +constassert=require('assert');
 +constcommon=require('../common.js');
++
 +const{
 + PerformanceObserver,
 + performance,
 +}=require('perf_hooks');
++
 +functionrandomFn(){
 +returnMath.random();
 +}
++
 +constbench=common.createBenchmark(main,{
 +n: [1e5],
 +observe: ['function'],
 +});
++
 +let_result;
++
 +functionmain({ n, observe }){
 +constobs=newPerformanceObserver(()=>{
 +bench.end(n);
 +});
 +obs.observe({entryTypes: [observe],buffered: true});
++
 +consttimerfied=performance.timerify(randomFn);
++
 +bench.start();
 +for(leti=0;i<n;i++)
 +_result=timerfied();
++
 +// Avoid V8 deadcode (elimination)
 +assert.ok(_result);
 +}
-Original file line number
+Diff line change
 const{
  ObjectDefineProperties,
 - ReflectConstruct,
  Symbol,
 }=primordials;
 constkStartTime=Symbol('PerformanceEntry.StartTime');
 constkDuration=Symbol('PerformanceEntry.Duration');
 constkDetail=Symbol('NodePerformanceEntry.Detail');
 +constkSkipThrow=Symbol('kSkipThrow');
 functionisPerformanceEntry(obj){
 returnobj?.[kName]!==undefined;
+}
 classPerformanceEntry{
 -constructor(){
 -thrownewERR_ILLEGAL_CONSTRUCTOR();
 +constructor(skipThrowSymbol=undefined){
 +if(skipThrowSymbol!==kSkipThrow){
 +thrownewERR_ILLEGAL_CONSTRUCTOR();
 +}
+}
 getname(){
+}
 functioncreatePerformanceEntry(name,type,start,duration){
 -returnReflectConstruct(functionPerformanceEntry(){
 -initPerformanceEntry(this,name,type,start,duration);
 -},[],PerformanceEntry);
 +constentry=newPerformanceEntry(kSkipThrow);
++
 +initPerformanceEntry(entry,name,type,start,duration);
++
 +returnentry;
+}
 /**
+}
 functioncreatePerformanceNodeEntry(name,type,start,duration,detail){
 -returnReflectConstruct(functionPerformanceNodeEntry(){
 -initPerformanceEntry(this,name,type,start,duration);
 -this[kDetail]=detail;
 -},[],PerformanceNodeEntry);
 +constentry=newPerformanceNodeEntry(kSkipThrow);
++
 +initPerformanceEntry(entry,name,type,start,duration);
 +entry[kDetail]=detail;
++
 +returnentry;
+}
 module.exports={