test: improve coverage for Module getters

juanarbol · targos · commit f43fc6b6cc07 · 2021-06-11T09:29:57.000+02:00
PR-URL: #36950 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/test/parallel/test-vm-module-errors.js b/test/parallel/test-vm-module-errors.js
@@ -6,7 +6,7 @@ const common = require('../common');
 
 const assert = require('assert');
 
-const { SourceTextModule, createContext } = require('vm');
+const { SourceTextModule, createContext, Module } = require('vm');
 
 async function createEmptyLinkedModule() {
 const m = new SourceTextModule('');
@@ -205,6 +205,17 @@ async function checkInvalidOptionForEvaluate() {
 "Received type string ('a-string')",
 code: 'ERR_INVALID_ARG_TYPE'
 });
+
+ {
+ ['link', 'evaluate'].forEach(async (method) => {
+ await assert.rejects(async () => {
+ await Module.prototype[method]();
+ }, {
+ code: 'ERR_VM_MODULE_NOT_MODULE',
+ message: /Provided module is not an instance of Module/
+ });
+ });
+ }
 }
 
 function checkInvalidCachedData() {
@@ -223,6 +234,19 @@ function checkInvalidCachedData() {
 });
 }
 
+function checkGettersErrors() {
+ const getters = ['identifier', 'context', 'namespace', 'status', 'error'];
+ getters.forEach((getter) => {
+ assert.throws(() => {
+ // eslint-disable-next-line no-unused-expressions
+ Module.prototype[getter];
+ }, {
+ code: 'ERR_VM_MODULE_NOT_MODULE',
+ message: /Provided module is not an instance of Module/
+ });
+ });
+}
+
 const finished = common.mustCall();
 
 (async function main() {
@@ -232,5 +256,6 @@ const finished = common.mustCall();
 await checkExecution();
 await checkInvalidOptionForEvaluate();
 checkInvalidCachedData();
+ checkGettersErrors();
 finished();
 })().then(common.mustCall());

-Original file line number
+Diff line change
 constassert=require('assert');
 -const{ SourceTextModule, createContext }=require('vm');
 +const{ SourceTextModule, createContext, Module}=require('vm');
 asyncfunctioncreateEmptyLinkedModule(){
 constm=newSourceTextModule('');
 "Received type string ('a-string')",
 code: 'ERR_INVALID_ARG_TYPE'
 });
++
 +{
 +['link','evaluate'].forEach(async(method)=>{
 +awaitassert.rejects(async()=>{
 +awaitModule.prototype[method]();
 +},{
 +code: 'ERR_VM_MODULE_NOT_MODULE',
 +message: /ProvidedmoduleisnotaninstanceofModule/
 +});
 +});
 +}
+}
 functioncheckInvalidCachedData(){
 });
+}
 +functioncheckGettersErrors(){
 +constgetters=['identifier','context','namespace','status','error'];
 +getters.forEach((getter)=>{
 +assert.throws(()=>{
 +// eslint-disable-next-line no-unused-expressions
 +Module.prototype[getter];
 +},{
 +code: 'ERR_VM_MODULE_NOT_MODULE',
 +message: /ProvidedmoduleisnotaninstanceofModule/
 +});
 +});
 +}
++
 constfinished=common.mustCall();
 (asyncfunctionmain(){
 awaitcheckExecution();
 awaitcheckInvalidOptionForEvaluate();
 checkInvalidCachedData();
 +checkGettersErrors();
 finished();
 })().then(common.mustCall());