assert,util: improve deep object comparison performance

This improves the performance for almost all objects when comparing
them deeply.
PR-URL: #57648
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: BridgeAR

benchmark/assert/deepequal-map.js

@@ -31,7 +31,7 @@ function benchmark(method, n, values, values2) {
 }
 
 functionmain({ n, len, method, strict }){
-constarray=Array(len).fill(1);
+constarray=Array.from({length: len},()=>'');
 
 switch(method){
 case'deepEqual_primitiveOnly': {

benchmark/assert/deepequal-prims-and-objs-big-loop.js

@@ -14,7 +14,6 @@ const primValues = {
 'number': 1_000,
 'boolean': true,
 'object': {property: 'abcdef'},
-'object_other_property': {property: 'abcdef'},
 'array': [1,2,3],
 'set_object': newSet([[1]]),
 'set_simple': newSet([1,2,3]),

benchmark/assert/deepequal-set.js

@@ -6,8 +6,9 @@ const { deepEqual, deepStrictEqual, notDeepEqual, notDeepStrictEqual } =
 
 constbench=common.createBenchmark(main,{
 n: [1e3],
-len: [5e2],
+len: [2,1e2],
 strict: [0,1],
+order: ['insert','random','reversed'],
 method: [
 'deepEqual_primitiveOnly',
 'deepEqual_objectOnly',
@@ -16,12 +17,30 @@ const bench = common.createBenchmark(main, {
 'notDeepEqual_objectOnly',
 'notDeepEqual_mixed',
 ],
+},{
+combinationFilter(p){
+returnp.order!=='random'||p.strict===1&&p.method!=='notDeepEqual_objectOnly';
+},
 });
 
-functionbenchmark(method,n,values,values2){
+functionshuffleArray(array){
+for(leti=array.length-1;i>0;i--){
+constj=Math.floor(Math.random()*(i+1));
+consttemp=array[i];
+array[i]=array[j];
+array[j]=temp;
+}
+}
+
+functionbenchmark(method,n,values,values2,order){
 constactual=newSet(values);
 // Prevent reference equal elements
-constdeepCopy=JSON.parse(JSON.stringify(values2 ? values2 : values));
+letdeepCopy=JSON.parse(JSON.stringify(values2));
+if(order==='reversed'){
+deepCopy=deepCopy.reverse();
+}elseif(order==='random'){
+shuffleArray(deepCopy);
+}
 constexpected=newSet(deepCopy);
 bench.start();
 for(leti=0;i<n;++i){
@@ -30,39 +49,39 @@ function benchmark(method, n, values, values2) {
 bench.end(n);
 }
 
-functionmain({ n, len, method, strict }){
-constarray=Array(len).fill(1);
+functionmain({ n, len, method, strict, order}){
+constarray=Array.from({length: len},()=>'');
 
 switch(method){
 case'deepEqual_primitiveOnly': {
 constvalues=array.map((_,i)=>`str_${i}`);
-benchmark(strict ? deepStrictEqual : deepEqual,n,values);
+benchmark(strict ? deepStrictEqual : deepEqual,n,values,values,order);
 break;
 }
 case'deepEqual_objectOnly': {
 constvalues=array.map((_,i)=>[`str_${i}`,null]);
-benchmark(strict ? deepStrictEqual : deepEqual,n,values);
+benchmark(strict ? deepStrictEqual : deepEqual,n,values,values,order);
 break;
 }
 case'deepEqual_mixed': {
 constvalues=array.map((_,i)=>{
 returni%2 ? [`str_${i}`,null] : `str_${i}`;
 });
-benchmark(strict ? deepStrictEqual : deepEqual,n,values);
+benchmark(strict ? deepStrictEqual : deepEqual,n,values,values,order);
 break;
 }
 case'notDeepEqual_primitiveOnly': {
 constvalues=array.map((_,i)=>`str_${i}`);
 constvalues2=values.slice(0);
 values2[Math.floor(len/2)]='w00t';
-benchmark(strict ? notDeepStrictEqual : notDeepEqual,n,values,values2);
+benchmark(strict ? notDeepStrictEqual : notDeepEqual,n,values,values2,order);
 break;
 }
 case'notDeepEqual_objectOnly': {
 constvalues=array.map((_,i)=>[`str_${i}`,null]);
 constvalues2=values.slice(0);
 values2[Math.floor(len/2)]=['w00t'];
-benchmark(strict ? notDeepStrictEqual : notDeepEqual,n,values,values2);
+benchmark(strict ? notDeepStrictEqual : notDeepEqual,n,values,values2,order);
 break;
 }
 case'notDeepEqual_mixed': {
@@ -71,7 +90,7 @@ function main({ n, len, method, strict }) {
 });
 constvalues2=values.slice();
 values2[0]='w00t';
-benchmark(strict ? notDeepStrictEqual : notDeepEqual,n,values,values2);
+benchmark(strict ? notDeepStrictEqual : notDeepEqual,n,values,values2,order);
 break;
 }
 default:

benchmark/assert/partial-deep-equal.js

@@ -62,7 +62,7 @@ function createSets(length, extraProps, depth = 0) {
 number: i,
 },
 ['array','with','values'],
-!depth ? newSet([1,2,{nested: i}]) : newSet(),
+!depth ? newSet([1,{nested: i}]) : newSet(),
 !depth ? createSets(2,extraProps,depth+1) : null,
 ]));
 }