http2: make compat writeHead not crash if the stream is destroyed

Fixes: #24470
PR-URL: #24723
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: mcollina

lib/internal/http2/compat.js

@@ -568,6 +568,11 @@ class Http2ServerResponse extends Stream {
 if(this[kStream].headersSent)
 thrownewERR_HTTP2_HEADERS_SENT();
 
+// If the stream is destroyed, we return false,
+// like require('http').
+if(this.stream.destroyed)
+returnfalse;
+
 if(typeofstatusMessage==='string')
 statusMessageWarn();
 

test/parallel/test-http2-compat-write-head-destroyed.js

@@ -0,0 +1,29 @@
+'use strict';
+
+constcommon=require('../common');
+if(!common.hasCrypto)
+common.skip('missing crypto');
+consthttp2=require('http2');
+
+// Check that writeHead, write and end do not crash in compatibility mode
+
+constserver=http2.createServer(common.mustCall((req,res)=>{
+// destroy the stream first
+req.stream.destroy();
+
+res.writeHead(200);
+res.write('hello ');
+res.end('world');
+}));
+
+server.listen(0,common.mustCall(()=>{
+constclient=http2.connect(`http://localhost:${server.address().port}`);
+
+constreq=client.request();
+req.on('response',common.mustNotCall());
+req.on('close',common.mustCall((arg)=>{
+client.close();
+server.close();
+}));
+req.resume();
+}));