os: add fallback for undefined CPUs

JungMinu · BridgeAR · commit f4fa04e170a5 · 2019-01-16T15:06:43.000+01:00
For an unsupported OS, a call to os.cpus() throws an error within os.cpus() itself where it tries to get the length of it. This fixes the issue by adding fallback for undefined CPUs. Fixes: #25483 PR-URL: #25493 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/lib/os.js b/lib/os.js
@@ -89,7 +89,8 @@ function loadavg() {
 }
 
 function cpus() {
- const data = getCPUs();
+ // [] is a bugfix for a regression introduced in 51cea61
+ const data = getCPUs() || [];
 const result = [];
 for (var i = 0; i < data.length; i += 7) {
 result.push({

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,8 @@ function loadavg() {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`functioncpus(){`
`92`		`-constdata=getCPUs();`
	`92`	`+// [] is a bugfix for a regression introduced in 51cea61`
	`93`	`+constdata=getCPUs()\|\|[];`
`93`	`94`	`constresult=[];`
`94`	`95`	`for(vari=0;i<data.length;i+=7){`
`95`	`96`	`result.push({`