net: check if option is undefined

watilde · nodejs-github-bot · commit f57010909435 · 2021-10-13T01:45:04.000Z
PR-URL: #40344 Fixes: #40336 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
diff --git a/lib/net.js b/lib/net.js
@@ -282,13 +282,13 @@ const kSetNoDelay = Symbol('kSetNoDelay');
 
 function Socket(options) {
 if (!(this instanceof Socket)) return new Socket(options);
- if (options.objectMode) {
+ if (options?.objectMode) {
 throw new ERR_INVALID_ARG_VALUE(
 'options.objectMode',
 options.objectMode,
 'is not supported'
 );
- } else if (options.readableObjectMode || options.writableObjectMode) {
+ } else if (options?.readableObjectMode || options?.writableObjectMode) {
 throw new ERR_INVALID_ARG_VALUE(
 `options.${
 options.readableObjectMode ? 'readableObjectMode' : 'writableObjectMode'

-Original file line number
+Diff line change
 functionSocket(options){
 if(!(thisinstanceofSocket))returnnewSocket(options);
 -if(options.objectMode){
 +if(options?.objectMode){
 thrownewERR_INVALID_ARG_VALUE(
 'options.objectMode',
 options.objectMode,
 'is not supported'
 );
 -}elseif(options.readableObjectMode||options.writableObjectMode){
 +}elseif(options?.readableObjectMode||options?.writableObjectMode){
 thrownewERR_INVALID_ARG_VALUE(
 `options.${
 options.readableObjectMode ? 'readableObjectMode' : 'writableObjectMode'