test: use callback arguments in getconnections test

Trott · targos · commit f6356fe50b43 · 2020-01-13T16:35:54.000+01:00
Use previously-unused callback arguments in test-child-process-fork-getconnections. PR-URL: #30775 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/parallel/test-child-process-fork-getconnections.js b/test/parallel/test-child-process-fork-getconnections.js
@@ -58,8 +58,10 @@ if (process.argv[2] === 'child') {
 const child = fork(process.argv[1], ['child']);
 
 child.on('exit', function(code, signal) {
- if (!subprocessKilled)
- throw new Error('subprocess died unexpectedly!');
+ if (!subprocessKilled) {
+ assert.fail('subprocess died unexpectedly! ' +
+ `code: ${code} signal: ${signal}`);
+ }
 });
 
 const server = net.createServer();
@@ -98,6 +100,8 @@ if (process.argv[2] === 'child') {
 child.once('message', function(m) {
 assert.strictEqual(m.status, 'closed');
 server.getConnections(function(err, num) {
+ assert.ifError(err);
+ assert.strictEqual(num, count - (i + 1));
 closeSockets(i + 1);
 });
 });

-Original file line number
+Diff line change
 constchild=fork(process.argv[1],['child']);
 child.on('exit',function(code,signal){
 -if(!subprocessKilled)
 -thrownewError('subprocess died unexpectedly!');
 +if(!subprocessKilled){
 +assert.fail('subprocess died unexpectedly! '+
 +`code: ${code} signal: ${signal}`);
 +}
 });
 constserver=net.createServer();
 child.once('message',function(m){
 assert.strictEqual(m.status,'closed');
 server.getConnections(function(err,num){
 +assert.ifError(err);
 +assert.strictEqual(num,count-(i+1));
 closeSockets(i+1);
 });
 });