test: change misleading variable name

tniessen · danielleadams · commit f6a70197427a · 2022-08-10T21:08:28.000-04:00
The return value of getPrime() is not a private key in any way. Refs: nodejs/node-v0.x-archive#2638 PR-URL: #43990 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/pummel/test-crypto-dh-hash.js b/test/pummel/test-crypto-dh-hash.js
@@ -50,10 +50,10 @@ const hashes = {
 
 for (const name in hashes) {
 const group = crypto.getDiffieHellman(name);
- const private_key = group.getPrime('hex');
+ const prime = group.getPrime('hex');
 const hash1 = hashes[name];
 const hash2 = crypto.createHash('sha1')
- .update(private_key.toUpperCase()).digest('hex');
+ .update(prime.toUpperCase()).digest('hex');
 assert.strictEqual(hash1, hash2);
 assert.strictEqual(group.getGenerator('hex'), '02');
 }

-Original file line number
+Diff line change
 for(constnameinhashes){
 constgroup=crypto.getDiffieHellman(name);
 -constprivate_key=group.getPrime('hex');
 +constprime=group.getPrime('hex');
 consthash1=hashes[name];
 consthash2=crypto.createHash('sha1')
 -.update(private_key.toUpperCase()).digest('hex');
 +.update(prime.toUpperCase()).digest('hex');
 assert.strictEqual(hash1,hash2);
 assert.strictEqual(group.getGenerator('hex'),'02');
+}