lib: remove deprecated string methods

MrJithil · UlisesGascon · commit fa220cac87ce · 2023-12-11T17:50:30.000Z
PR-URL: #50592 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/_http_agent.js b/lib/_http_agent.js
@@ -38,7 +38,7 @@ const {
 StringPrototypeIndexOf,
 StringPrototypeSplit,
 StringPrototypeStartsWith,
- StringPrototypeSubstr,
+ StringPrototypeSubstring,
 Symbol,
 } = primordials;
 
@@ -363,7 +363,7 @@ function calculateServerName(options, req) {
 // Leading '[', but no ']'. Need to do something...
 servername = hostHeader;
 } else {
- servername = StringPrototypeSubstr(hostHeader, 1, index - 1);
+ servername = StringPrototypeSubstring(hostHeader, 1, index);
 }
 } else {
 servername = StringPrototypeSplit(hostHeader, ':', 1)[0];
diff --git a/lib/internal/main/print_help.js b/lib/internal/main/print_help.js
@@ -11,7 +11,7 @@ const {
 RegExpPrototypeSymbolReplace,
 StringPrototypeLocaleCompare,
 StringPrototypeSlice,
- StringPrototypeTrimLeft,
+ StringPrototypeTrimStart,
 StringPrototypeRepeat,
 SafeMap,
 } = primordials;
@@ -180,7 +180,7 @@ function format(
 else
 text += StringPrototypeRepeat(' ', firstColumn - displayName.length);
 
- text += StringPrototypeTrimLeft(
+ text += StringPrototypeTrimStart(
 indent(fold(displayHelpText, secondColumn), firstColumn)) + '\n';
 }
 
diff --git a/lib/repl.js b/lib/repl.js
@@ -90,7 +90,7 @@ const {
 StringPrototypeSplit,
 StringPrototypeStartsWith,
 StringPrototypeTrim,
- StringPrototypeTrimLeft,
+ StringPrototypeTrimStart,
 StringPrototypeToLocaleLowerCase,
 Symbol,
 SyntaxError,
@@ -1326,7 +1326,7 @@ function complete(line, callback) {
 let completeOn, group;
 
 // Ignore right whitespace. It could change the outcome.
- line = StringPrototypeTrimLeft(line);
+ line = StringPrototypeTrimStart(line);
 
 let filter = '';
 

-Original file line number
+Diff line change
  StringPrototypeIndexOf,
  StringPrototypeSplit,
  StringPrototypeStartsWith,
 -StringPrototypeSubstr,
 +StringPrototypeSubstring,
  Symbol,
 }=primordials;
 // Leading '[', but no ']'. Need to do something...
 servername=hostHeader;
 }else{
 -servername=StringPrototypeSubstr(hostHeader,1,index-1);
 +servername=StringPrototypeSubstring(hostHeader,1,index);
+}
 }else{
 servername=StringPrototypeSplit(hostHeader,':',1)[0];