fs: remove ability to call truncate with fd

PR-URL: #57567
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: anonrig

doc/api/deprecations.md

@@ -1832,12 +1832,15 @@ and replaced with an identical, public `path.toNamespacedPath()` method.
 
 <!-- YAML
 changes:
+ - version: REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/57567
+ description: End-of-Life.
  - version: v9.0.0
  pr-url: https://github.com/nodejs/node/pull/15990
  description: Runtime deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
 `fs.truncate()``fs.truncateSync()` usage with a file descriptor is
 deprecated. Please use `fs.ftruncate()` or `fs.ftruncateSync()` to work with

lib/fs.js

@@ -153,7 +153,6 @@ const {
 
 constpermission=require('internal/process/permission');
 
-lettruncateWarn=true;
 letfs;
 
 // Lazy loaded
@@ -171,16 +170,6 @@ let ReadFileContext;
 letFileReadStream;
 letFileWriteStream;
 
-functionshowTruncateDeprecation(){
-if(truncateWarn){
-process.emitWarning(
-'Using fs.truncate with a file descriptor is deprecated. Please use '+
-'fs.ftruncate with a file descriptor instead.',
-'DeprecationWarning','DEP0081');
-truncateWarn=false;
-}
-}
-
 // Ensure that callbacks run in the global context. Only use this function
 // for callbacks that are passed to the binding layer, callbacks that are
 // invoked from JS already run in the proper scope.
@@ -1035,10 +1024,6 @@ function renameSync(oldPath, newPath) {
  * @returns {void}
  */
 functiontruncate(path,len,callback){
-if(typeofpath==='number'){
-showTruncateDeprecation();
-returnfs.ftruncate(path,len,callback);
-}
 if(typeoflen==='function'){
 callback=len;
 len=0;
@@ -1068,11 +1053,6 @@ function truncate(path, len, callback) {
  * @returns {void}
  */
 functiontruncateSync(path,len){
-if(typeofpath==='number'){
-// legacy
-showTruncateDeprecation();
-returnfs.ftruncateSync(path,len);
-}
 if(len===undefined){
 len=0;
 }

test/parallel/test-fs-truncate-fd.js

@@ -12,10 +12,7 @@ const filename = path.resolve(tmp, 'truncate-sync-file.txt');
 
 fs.writeFileSync(filename,'hello world','utf8');
 
-constfd=fs.openSync(filename,'r+');
+fs.truncateSync(filename,5);
+assert(fs.readFileSync(filename).equals(Buffer.from('hello')));
 
-fs.truncateSync(fd,5);
-assert(fs.readFileSync(fd).equals(Buffer.from('hello')));
-
-fs.closeSync(fd);
 fs.unlinkSync(filename);

test/parallel/test-fs-truncate-sync.js

@@ -33,9 +33,6 @@ tmpdir.refresh();
 
 letstat;
 
-constmsg='Using fs.truncate with a file descriptor is deprecated.'+
-' Please use fs.ftruncate with a file descriptor instead.';
-
 // Check truncateSync
 fs.writeFileSync(filename,data);
 stat=fs.statSync(filename);
@@ -64,10 +61,6 @@ fs.ftruncateSync(fd);
 stat=fs.statSync(filename);
 assert.strictEqual(stat.size,0);
 
-// truncateSync
-common.expectWarning('DeprecationWarning',msg,'DEP0081');
-fs.truncateSync(fd);
-
 fs.closeSync(fd);
 
 // Async tests