test: specify 'dir' for directory symlinks

Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.
PR-URL: #19049
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: kfarnung

test/addons/symlinked-module/test.js

@@ -19,7 +19,7 @@ const addonPath = path.join(__dirname, 'build', common.buildType);
 constaddonLink=path.join(tmpdir.path,'addon');
 
 try{
-fs.symlinkSync(addonPath,addonLink);
+fs.symlinkSync(addonPath,addonLink,'dir');
 }catch(err){
 if(err.code!=='EPERM')throwerr;
 common.skip('module identity test (no privs for symlinks)');

test/es-module/test-esm-symlink.js

@@ -37,7 +37,7 @@ try {
 fs.symlinkSync(real,link_absolute_path);
 fs.symlinkSync(path.basename(real),link_relative_path);
 fs.symlinkSync(real,link_ignore_extension);
-fs.symlinkSync(path.dirname(real),link_directory);
+fs.symlinkSync(path.dirname(real),link_directory,'dir');
 }catch(err){
 if(err.code!=='EPERM')throwerr;
 common.skip('insufficient privileges for symlinks');

test/parallel/test-module-symlinked-peer-modules.js

@@ -43,7 +43,7 @@ fs.mkdirSync(moduleB);
 // Attempt to make the symlink. If this fails due to lack of sufficient
 // permissions, the test will bail out and be skipped.
 try{
-fs.symlinkSync(moduleA,moduleA_link);
+fs.symlinkSync(moduleA,moduleA_link,'dir');
 }catch(err){
 if(err.code!=='EPERM')throwerr;
 common.skip('insufficient privileges for symlinks');