Skip to content

Commit fdfcf68

Browse files
artmaksMylesBorins
authored andcommitted
http: destructure primordials in lib/_http_server.js
PR-URL: #30315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent a621ab8 commit fdfcf68

1 file changed

Lines changed: 12 additions & 7 deletions

File tree

‎lib/_http_server.js‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,12 @@
2121

2222
'use strict';
2323

24-
const{ Object }=primordials;
24+
const{
25+
Object: {
26+
setPrototypeOf: ObjectSetPrototypeOf,
27+
keys: ObjectKeys,
28+
}
29+
}=primordials;
2530

2631
constnet=require('net');
2732
constassert=require('internal/assert');
@@ -165,8 +170,8 @@ function ServerResponse(req) {
165170
};
166171
}
167172
}
168-
Object.setPrototypeOf(ServerResponse.prototype,OutgoingMessage.prototype);
169-
Object.setPrototypeOf(ServerResponse,OutgoingMessage);
173+
ObjectSetPrototypeOf(ServerResponse.prototype,OutgoingMessage.prototype);
174+
ObjectSetPrototypeOf(ServerResponse,OutgoingMessage);
170175

171176
ServerResponse.prototype._finish=function_finish(){
172177
DTRACE_HTTP_SERVER_RESPONSE(this.connection);
@@ -258,8 +263,8 @@ function writeHead(statusCode, reason, obj) {
258263
// Slow-case: when progressive API and header fields are passed.
259264
letk;
260265
if(obj){
261-
constkeys=Object.keys(obj);
262-
for(leti=0;i<keys.length;i++){
266+
constkeys=ObjectKeys(obj);
267+
for(vari=0;i<keys.length;i++){
263268
k=keys[i];
264269
if(k)this.setHeader(k,obj[k]);
265270
}
@@ -341,8 +346,8 @@ function Server(options, requestListener) {
341346
this.maxHeadersCount=null;
342347
this.headersTimeout=40*1000;// 40 seconds
343348
}
344-
Object.setPrototypeOf(Server.prototype,net.Server.prototype);
345-
Object.setPrototypeOf(Server,net.Server);
349+
ObjectSetPrototypeOf(Server.prototype,net.Server.prototype);
350+
ObjectSetPrototypeOf(Server,net.Server);
346351

347352

348353
Server.prototype.setTimeout=functionsetTimeout(msecs,callback){

0 commit comments

Comments
 (0)