url: preserve null char in WHATWG URL errors

A null character in the middle of an invalid URL was resulting in an
error message that truncated the input string. This preserves the entire
input string in the error message.
Refs: #39592
PR-URL: #42263
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: Trott

lib/internal/url.js

@@ -559,7 +559,7 @@ function onParseComplete(flags, protocol, username, password,
 initSearchParams(this[searchParams],query);
 }
 
-functiononParseError(flags,input){
+functiononParseError(input,flags){
 thrownewERR_INVALID_URL(input);
 }
 
@@ -641,7 +641,8 @@ class URL {
 }
 this[context]=newURLContext();
 parse(input,-1,base_context,undefined,
-FunctionPrototypeBind(onParseComplete,this),onParseError);
+FunctionPrototypeBind(onParseComplete,this),
+FunctionPrototypeBind(onParseError,this,input));
 }
 
 get[special](){
@@ -760,7 +761,8 @@ class URL {
 // toUSVString is not needed.
 input=`${input}`;
 parse(input,-1,undefined,undefined,
-FunctionPrototypeBind(onParseComplete,this),onParseError);
+FunctionPrototypeBind(onParseComplete,this),
+FunctionPrototypeBind(onParseError,this,input));
 }
 
 // readonly

src/node_url.cc

@@ -142,22 +142,12 @@ URLHost::~URLHost() {
 XX(ARG_FRAGMENT) \
 XX(ARG_COUNT) // This one has to be last.
 
-#defineERR_ARGS(XX) \
-XX(ERR_ARG_FLAGS) \
-XX(ERR_ARG_INPUT) \
-
 enum url_cb_args {
 #defineXX(name) name,
 ARGS(XX)
 #undef XX
 };
 
-enum url_error_cb_args {
-#defineXX(name) name,
-ERR_ARGS(XX)
-#undef XX
-};
-
 #defineTWO_CHAR_STRING_TEST(bits, name, expr) \
 template <typename T> \
 boolname(const T ch1, const T ch2) { \
@@ -1679,12 +1669,8 @@ void Parse(Environment* env,
 SetArgs(env, argv, url);
  cb->Call(context, recv, arraysize(argv), argv).FromMaybe(Local<Value>());
  } elseif (error_cb->IsFunction()) {
- Local<Value> argv[2] = { undef, undef };
- argv[ERR_ARG_FLAGS] = Integer::NewFromUnsigned(isolate, url.flags);
- argv[ERR_ARG_INPUT] =
-String::NewFromUtf8(env->isolate(), input).ToLocalChecked();
- error_cb.As<Function>()->Call(context, recv, arraysize(argv), argv)
- .FromMaybe(Local<Value>());
+ Local<Value> flags = Integer::NewFromUnsigned(isolate, url.flags);
+USE(error_cb.As<Function>()->Call(context, recv, 1, &flags));
  }
 }
 

test/parallel/test-url-null-char.js

@@ -0,0 +1,8 @@
+'use strict';
+require('../common');
+constassert=require('assert');
+
+assert.throws(
+()=>{newURL('a\0b');},
+{input: 'a\0b'}
+);