stream: fix uncatchable error closing half-open Duplex.toWeb() writable

Signed-off-by: Mohamed Sayed <k@3zrv.com>
PR-URL: #64161Fixes: #64120
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

Author: 3zrv

lib/internal/webstreams/adapters.js

@@ -216,7 +216,7 @@ function newWritableStreamFromStreamWritable(streamWritable, options = kEmptyObj
 closed.reject(error);
 closed=undefined;
 }
-controller.error(error);
+controller?.error(error);
 controller=undefined;
 return;
 }
@@ -226,7 +226,7 @@ function newWritableStreamFromStreamWritable(streamWritable, options = kEmptyObj
 closed=undefined;
 return;
 }
-controller.error(newAbortError());
+controller?.error(newAbortError());
 controller=undefined;
 });
 

test/parallel/test-whatwg-webstreams-adapters-to-readablewritablepair.js

@@ -10,6 +10,7 @@ const {
 }=require('internal/webstreams/adapters');
 
 const{
+ Duplex,
  PassThrough,
 }=require('stream');
 
@@ -254,3 +255,27 @@ const {
 code: 'ERR_INVALID_ARG_TYPE'
 });
 }
+
+{
+constduplex=newDuplex({
+allowHalfOpen: false,
+read(){},
+write(chunk,enc,cb){cb();},
+final(cb){setImmediate(cb);},
+});
+
+const{
+ readable,
+ writable,
+}=newReadableWritablePairFromDuplex(duplex);
+
+constreader=readable.getReader();
+constwriter=writable.getWriter();
+
+duplex.push(null);
+
+reader.read().then(common.mustCall(({ done })=>{
+assert.strictEqual(done,true);
+writer.close().then(common.mustCall());
+}));
+}