lib: migrate process.binding to internalBinding

Migrate various modules from using process.binding to internalBinding.
PR-URL: #24952
Refs: #22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Author: BeniCheni

test/async-hooks/test-zlib.zlib-binding.deflate.js

@@ -11,7 +11,7 @@ const hooks = initHooks();
 hooks.enable();
 const{ internalBinding }=require('internal/test/binding');
 const{ Zlib }=internalBinding('zlib');
-constconstants=process.binding('constants').zlib;
+constconstants=internalBinding('constants').zlib;
 
 consthandle=newZlib(constants.DEFLATE);
 

test/parallel/test-accessor-properties.js

@@ -57,7 +57,7 @@ const UDP = internalBinding('udp_wrap').UDP;
 
 if(common.hasCrypto){// eslint-disable-line node-core/crypto-check
 // There are accessor properties in crypto too
-constcrypto=process.binding('crypto');
+constcrypto=internalBinding('crypto');
 
 assert.throws(()=>{
 crypto.SecureContext.prototype._external;

test/parallel/test-binding-constants.js

@@ -1,7 +1,9 @@
+// Flags: --expose-internals
 'use strict';
 
 require('../common');
-constconstants=process.binding('constants');
+const{ internalBinding }=require('internal/test/binding');
+constconstants=internalBinding('constants');
 constassert=require('assert');
 
 assert.deepStrictEqual(

test/parallel/test-child-process-spawnsync-kill-signal.js

@@ -9,7 +9,7 @@ if (process.argv[2] === 'child') {
 }else{
 constinternalCp=require('internal/child_process');
 constoldSpawnSync=internalCp.spawnSync;
-const{SIGKILL}=process.binding('constants').os.signals;
+const{SIGKILL}=require('os').constants.signals;
 
 functionspawn(killSignal,beforeSpawn){
 if(beforeSpawn){

test/parallel/test-child-process-spawnsync-validation-errors.js

@@ -2,7 +2,7 @@
 constcommon=require('../common');
 constassert=require('assert');
 constspawnSync=require('child_process').spawnSync;
-constsignals=process.binding('constants').os.signals;
+constsignals=require('os').constants.signals;
 constrootUser=common.isWindows ? false : process.getuid()===0;
 
 constinvalidArgTypeError=common.expectsError(

test/parallel/test-constants.js

@@ -1,7 +1,9 @@
+// Flags: --expose_internals
 'use strict';
 
 require('../common');
-constbinding=process.binding('constants');
+const{ internalBinding }=require('internal/test/binding');
+constbinding=internalBinding('constants');
 constconstants=require('constants');
 constassert=require('assert');
 

test/parallel/test-dgram-bind-fd.js

@@ -8,7 +8,7 @@ const assert = require('assert');
 constdgram=require('dgram');
 const{ internalBinding }=require('internal/test/binding');
 const{UDP}=internalBinding('udp_wrap');
-const{UV_UDP_REUSEADDR}=process.binding('constants').os;
+const{UV_UDP_REUSEADDR}=require('os').constants;
 
 constBUFFER_SIZE=4096;
 

test/parallel/test-fs-readdir-types.js

@@ -1,3 +1,4 @@
+// Flags: --expose-internals
 'use strict';
 
 constcommon=require('../common');
@@ -6,11 +7,12 @@ const fs = require('fs');
 
 consttmpdir=require('../common/tmpdir');
 
-constbinding=process.binding('fs');
+const{ internalBinding }=require('internal/test/binding');
+constbinding=internalBinding('fs');
 
 constreaddirDir=tmpdir.path;
 constfiles=['empty','files','for','just','testing'];
-constconstants=process.binding('constants').fs;
+constconstants=require('fs').constants;
 consttypes={
 isDirectory: constants.UV_DIRENT_DIR,
 isFile: constants.UV_DIRENT_FILE,

test/parallel/test-loaders-hidden-from-users.js

@@ -16,7 +16,8 @@ common.expectsError(
 common.expectsError(
 ()=>{
 constsource='module.exports = require("internal/bootstrap/loaders")';
-process.binding('natives').owo=source;
+const{ internalBinding }=require('internal/test/binding');
+internalBinding('natives').owo=source;
 require('owo');
 },{
 code: 'MODULE_NOT_FOUND',

test/parallel/test-process-binding-internalbinding-whitelist.js

@@ -1,21 +1,41 @@
 // Flags: --no-warnings
 'use strict';
 
-require('../common');
+constcommon=require('../common');
 constassert=require('assert');
 
 // Assert that whitelisted internalBinding modules are accessible via
 // process.binding().
-assert(process.binding('uv'));
-assert(process.binding('http_parser'));
-assert(process.binding('v8'));
-assert(process.binding('stream_wrap'));
-assert(process.binding('signal_wrap'));
-assert(process.binding('contextify'));
-assert(process.binding('url'));
-assert(process.binding('spawn_sync'));
-assert(process.binding('js_stream'));
+assert(process.binding('async_wrap'));
 assert(process.binding('buffer'));
+assert(process.binding('cares_wrap'));
+assert(process.binding('constants'));
+assert(process.binding('contextify'));
+if(common.hasCrypto){// eslint-disable-line node-core/crypto-check
+assert(process.binding('crypto'));
+}
 assert(process.binding('fs'));
+assert(process.binding('fs_event_wrap'));
+assert(process.binding('http_parser'));
+if(common.hasIntl){
+assert(process.binding('icu'));
+}
 assert(process.binding('inspector'));
+assert(process.binding('js_stream'));
+assert(process.binding('natives'));
 assert(process.binding('os'));
+assert(process.binding('pipe_wrap'));
+assert(process.binding('signal_wrap'));
+assert(process.binding('spawn_sync'));
+assert(process.binding('stream_wrap'));
+assert(process.binding('tcp_wrap'));
+if(common.hasCrypto){// eslint-disable-line node-core/crypto-check
+assert(process.binding('tls_wrap'));
+}
+assert(process.binding('tty_wrap'));
+assert(process.binding('udp_wrap'));
+assert(process.binding('url'));
+assert(process.binding('util'));
+assert(process.binding('uv'));
+assert(process.binding('v8'));
+assert(process.binding('zlib'));