test: add test for fs.promises.lchmod

Masashi Hirano · addaleax · commit ff5f20fc7ba6 · 2018-05-31T11:34:49.000+02:00
To increase test coverage for fs.promises by adding a test for lchmod. PR-URL: #20584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
diff --git a/test/parallel/test-fs-promises.js b/test/parallel/test-fs-promises.js
@@ -18,6 +18,7 @@ const {
 ftruncate,
 futimes,
 link,
+ lchmod,
 lstat,
 mkdir,
 mkdtemp,
@@ -160,14 +161,21 @@ function verifyStatObject(stat) {
 if (common.canCreateSymLink()) {
 const newLink = path.resolve(tmpDir, 'baz3.js');
 await symlink(newPath, newLink);
-
 stats = await lstat(newLink);
 verifyStatObject(stats);
 
 assert.strictEqual(newPath.toLowerCase(),
 (await realpath(newLink)).toLowerCase());
 assert.strictEqual(newPath.toLowerCase(),
 (await readlink(newLink)).toLowerCase());
+ if (common.isOSX) {
+ // lchmod is only available on macOS
+ const newMode = 0o666;
+ await lchmod(newLink, newMode);
+ stats = await lstat(newLink);
+ assert.strictEqual(stats.mode & 0o777, newMode);
+ }
+
 
 await unlink(newLink);
 }

-Original file line number
+Diff line change
  ftruncate,
  futimes,
  link,
 + lchmod,
  lstat,
  mkdir,
  mkdtemp,
 if(common.canCreateSymLink()){
 constnewLink=path.resolve(tmpDir,'baz3.js');
 awaitsymlink(newPath,newLink);
+-
 stats=awaitlstat(newLink);
 verifyStatObject(stats);
 assert.strictEqual(newPath.toLowerCase(),
 (awaitrealpath(newLink)).toLowerCase());
 assert.strictEqual(newPath.toLowerCase(),
 (awaitreadlink(newLink)).toLowerCase());
 +if(common.isOSX){
 +// lchmod is only available on macOS
 +constnewMode=0o666;
 +awaitlchmod(newLink,newMode);
 +stats=awaitlstat(newLink);
 +assert.strictEqual(stats.mode&0o777,newMode);
 +}
++
 awaitunlink(newLink);
+}