errors: use ErrorPrototypeToString from primordials object

ExE-Boss · richardlau · commit fffba3a270c8 · 2020-09-01T11:15:37.000-04:00
PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -13,6 +13,7 @@
 const {
 ArrayIsArray,
 Error,
+ ErrorPrototypeToString,
 JSONStringify,
 Map,
 MathAbs,
@@ -47,7 +48,6 @@ const kTypes = [
 ];
 
 const MainContextError = Error;
-const ErrorToString = Error.prototype.toString;
 const overrideStackTrace = new WeakMap();
 const kNoOverride = Symbol('kNoOverride');
 const prepareStackTrace = (globalThis, error, trace) => {
@@ -68,7 +68,7 @@ const prepareStackTrace = (globalThis, error, trace) => {
 // Error: Message
 // at function (file)
 // at file
- const errorString = ErrorToString.call(error);
+ const errorString = ErrorPrototypeToString(error);
 if (trace.length === 0) {
 return errorString;
 }

-Original file line number
+Diff line change
 const{
  ArrayIsArray,
  Error,
 + ErrorPrototypeToString,
  JSONStringify,
  Map,
  MathAbs,
 ];
 constMainContextError=Error;
 -constErrorToString=Error.prototype.toString;
 constoverrideStackTrace=newWeakMap();
 constkNoOverride=Symbol('kNoOverride');
 constprepareStackTrace=(globalThis,error,trace)=>{
 // Error: Message
 // at function (file)
 // at file
 -consterrorString=ErrorToString.call(error);
 +consterrorString=ErrorPrototypeToString(error);
 if(trace.length===0){
 returnerrorString;
+}