Skip to content

Commit c80341a

Browse files
justfalterjustfalter
committed
Fix encoding/decoding of base-256 numbers
- Encoding/decoding of base-256 numbers failed to failed to handle last byte in buffer. Handling was previously broken. - Take javascript's MAX_SAFE_INTEGER / MIN_SAFE_INTEGER into account when encoding/decoding. Namely, if the numbers cannot accurately be represented in javascript with integer-precision, a TypeError will be thrown. - Throw a TypeError if the parser is passed an buffer that does not appear to be base-256 encoded. (must start with 0x80 or 0xff)
1 parent b863448 commit c80341a

2 files changed

Lines changed: 89 additions & 42 deletions

File tree

‎lib/large-numbers.js‎

Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
'use strict'
22
// Tar can encode large and negative numbers using a leading byte of
3-
// 0xff for negative, and 0x80 for positive. The trailing byte in the
4-
// section will always be 0x20, or in some implementations 0x00.
5-
// this module encodes and decodes these things.
3+
// 0xff for negative, and 0x80 for positive.
64

75
constencode=exports.encode=(num,buf)=>{
8-
buf[buf.length-1]=0x20
9-
if(num<0)
6+
if(!Number.isSafeInteger(num))
7+
// The number is so large that javascript cannot represent it with integer
8+
// precision.
9+
throwTypeError('cannot encode number outside of javascript safe integer range')
10+
elseif(num<0)
1011
encodeNegative(num,buf)
1112
else
1213
encodePositive(num,buf)
@@ -15,44 +16,48 @@ const encode = exports.encode = (num, buf) => {
1516

1617
constencodePositive=(num,buf)=>{
1718
buf[0]=0x80
18-
for(vari=buf.length-2;i>0;i--){
19-
if(num===0)
20-
buf[i]=0
21-
else{
22-
buf[i]=num%0x100
23-
num=Math.floor(num/0x100)
24-
}
19+
20+
for(vari=buf.length;i>1;i--){
21+
buf[i-1]=num&0xff
22+
num=Math.floor(num/0x100)
2523
}
2624
}
2725

2826
constencodeNegative=(num,buf)=>{
2927
buf[0]=0xff
3028
varflipped=false
3129
num=num*-1
32-
for(vari=buf.length-2;i>0;i--){
33-
varbyte
34-
if(num===0)
35-
byte=0
36-
else{
37-
byte=num%0x100
38-
num=Math.floor(num/0x100)
39-
}
30+
for(vari=buf.length;i>1;i--){
31+
varbyte=num&0xff
32+
num=Math.floor(num/0x100)
4033
if(flipped)
41-
buf[i]=onesComp(byte)
34+
buf[i-1]=onesComp(byte)
4235
elseif(byte===0)
43-
buf[i]=0
36+
buf[i-1]=0
4437
else{
4538
flipped=true
46-
buf[i]=twosComp(byte)
39+
buf[i-1]=twosComp(byte)
4740
}
4841
}
4942
}
5043

5144
constparse=exports.parse=(buf)=>{
5245
varpost=buf[buf.length-1]
5346
varpre=buf[0]
54-
returnpre===0x80 ? pos(buf.slice(1,buf.length-1))
55-
: twos(buf.slice(1,buf.length-1))
47+
varvalue;
48+
if(pre===0x80)
49+
value=pos(buf.slice(1,buf.length))
50+
elseif(pre===0xff)
51+
value=twos(buf)
52+
else
53+
throwTypeError('invalid base256 encoding')
54+
55+
if(!Number.isSafeInteger(value))
56+
// The number is so large that javascript cannot represent it with integer
57+
// precision.
58+
throwTypeError('parsed number outside of javascript javascript safe integer range')
59+
60+
returnvalue
5661
}
5762

5863
consttwos=(buf)=>{
@@ -71,9 +76,9 @@ const twos = (buf) => {
7176
f=twosComp(byte)
7277
}
7378
if(f!==0)
74-
sum+=f*Math.pow(256,len-i-1)
79+
sum-=f*Math.pow(256,len-i-1)
7580
}
76-
returnsum*-1
81+
returnsum
7782
}
7883

7984
constpos=(buf)=>{

‎test/large-numbers.js‎

Lines changed: 57 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,56 @@ const t = require('tap')
77

88
t.test('parse',t=>{
99
constcases=newMap([
10-
['ffffffffffffffffffffff20',-1],
11-
['800000000000100000000020',68719476736],
12-
['fffffffffffffffe1ecc8020',-31536000],
13-
['fffffffffffffff000000020',-268435456],
14-
['800000010203040506070020',72623859790382850],
15-
['ffffffffffffffffffffff00',-1],
16-
['800000000000100000000000',68719476736],
17-
['fffffffffffffffe1ecc8000',-31536000],
18-
['fffffffffffffff000000000',-268435456],
19-
['800000010203040506070000',72623859790382850]
10+
['ffffffffffffffffffffffff',-1],
11+
['800000000000100000000020',17592186044448],
12+
['fffffffffffffffe1ecc8020',-8073215968],
13+
['fffffffffffffff000000020',-68719476704],
14+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
15+
['ffffffffffe0000000000001',-9007199254740991],// MIN_SAFE_INTEGER
16+
['800000000000100000000000',17592186044416],
17+
['fffffffffffffffe1ecc8000',-8073216000],
18+
['fffffffffffffff000000000',-68719476736],
19+
['800000000000000353b66200',14289363456]
2020
])
2121
t.plan(cases.size)
2222
cases.forEach((value,hex)=>
2323
t.equal(parse(Buffer.from(hex,'hex')),value))
2424
})
2525

26+
t.test('parse out of range',t=>{
27+
constcases=[
28+
'800000030000000000000000',
29+
'800000000020000000000000',// MAX_SAFE_INTEGER + 1
30+
'ffffffffffe0000000000000',// MIN_SAFE_INTEGER - 1
31+
'fffffffffdd0000000000000',
32+
]
33+
t.plan(cases.length)
34+
cases.forEach((hex)=>
35+
t.throws(_=>parse(Buffer.from(hex,'hex')),
36+
TypeError('parsed number outside of javascript javascript safe integer range')))
37+
})
38+
39+
t.test('parse invalid base256 encoding',t=>{
40+
constcases=[
41+
'313233343536373131',// octal encoded
42+
'700000030000000000000000',// does not start with 0x80 or 0xff
43+
]
44+
t.plan(cases.length)
45+
cases.forEach((hex)=>
46+
t.throws(_=>parse(Buffer.from(hex,'hex')),
47+
TypeError('invalid base256 encoding')))
48+
})
49+
2650
t.test('encode',t=>{
2751
constcases=newMap([
28-
['ffffffffffffffffffffff20',-1],
29-
['800000000000100000000020',68719476736],
30-
['fffffffffffffffe1ecc8020',-31536000],
31-
['fffffffffffffff000000020',-268435456],
32-
['800000010203040506070020',72623859790382850]
52+
['ffffffffffffffffffffffff',-1],
53+
['800000000000100000000020',17592186044448],
54+
['800000000000100000000000',17592186044416],
55+
['fffffffffffffffe1ecc8020',-8073215968],
56+
['fffffffffffffff000000020',-68719476704],
57+
['fffffffffffffff000000000',-68719476736],// Allows us to test the case where there's a trailing 00
58+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
59+
['ffffffffffe0000000000001',-9007199254740991]// MIN_SAFE_INTEGER
3360
])
3461
t.plan(2)
3562
t.test('alloc',t=>{
@@ -43,3 +70,18 @@ t.test('encode', t => {
4370
t.equal(encode(value,Buffer.allocUnsafe(12)).toString('hex'),hex))
4471
})
4572
})
73+
74+
t.test('encode unsafe numbers',t=>{
75+
constcases=[
76+
Number.MAX_VALUE,
77+
Number.MAX_SAFE_INTEGER+1,
78+
Number.MIN_SAFE_INTEGER-1,
79+
Number.MIN_VALUE,
80+
]
81+
82+
t.plan(cases.length)
83+
cases.forEach((value)=>
84+
t.throws(_=>encode(value),
85+
TypeError('cannot encode number outside of javascript safe integer range')))
86+
})
87+

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix encoding/decoding of base-256 numbers · isaacs/node-tar@c80341a · GitHub
Skip to content
Commit c80341a
Browse files
justfalterjustfalter
committed
Fix encoding/decoding of base-256 numbers
- Encoding/decoding of base-256 numbers failed to failed to handle last
byte in buffer. Handling was previously broken.
- Take javascript's MAX_SAFE_INTEGER / MIN_SAFE_INTEGER into account
when encoding/decoding. Namely, if the numbers cannot accurately be
represented in javascript with integer-precision, a TypeError will be
thrown.
- Throw a TypeError if the parser is passed an buffer that does not
appear to be base-256 encoded. (must start with 0x80 or 0xff)
1 parent b863448 commit c80341a
2 files changed
Lines changed: 89 additions & 42 deletions
File tree
‎lib/large-numbers.js‎
Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
'use strict'
22
// Tar can encode large and negative numbers using a leading byte of
3-
// 0xff for negative, and 0x80 for positive. The trailing byte in the
4-
// section will always be 0x20, or in some implementations 0x00.
5-
// this module encodes and decodes these things.
3+
// 0xff for negative, and 0x80 for positive.
64

75
constencode=exports.encode=(num,buf)=>{
8-
buf[buf.length-1]=0x20
9-
if(num<0)
6+
if(!Number.isSafeInteger(num))
7+
// The number is so large that javascript cannot represent it with integer
8+
// precision.
9+
throwTypeError('cannot encode number outside of javascript safe integer range')
10+
elseif(num<0)
1011
encodeNegative(num,buf)
1112
else
1213
encodePositive(num,buf)
@@ -15,44 +16,48 @@ const encode = exports.encode = (num, buf) => {
1516

1617
constencodePositive=(num,buf)=>{
1718
buf[0]=0x80
18-
for(vari=buf.length-2;i>0;i--){
19-
if(num===0)
20-
buf[i]=0
21-
else{
22-
buf[i]=num%0x100
23-
num=Math.floor(num/0x100)
24-
}
19+
20+
for(vari=buf.length;i>1;i--){
21+
buf[i-1]=num&0xff
22+
num=Math.floor(num/0x100)
2523
}
2624
}
2725

2826
constencodeNegative=(num,buf)=>{
2927
buf[0]=0xff
3028
varflipped=false
3129
num=num*-1
32-
for(vari=buf.length-2;i>0;i--){
33-
varbyte
34-
if(num===0)
35-
byte=0
36-
else{
37-
byte=num%0x100
38-
num=Math.floor(num/0x100)
39-
}
30+
for(vari=buf.length;i>1;i--){
31+
varbyte=num&0xff
32+
num=Math.floor(num/0x100)
4033
if(flipped)
41-
buf[i]=onesComp(byte)
34+
buf[i-1]=onesComp(byte)
4235
elseif(byte===0)
43-
buf[i]=0
36+
buf[i-1]=0
4437
else{
4538
flipped=true
46-
buf[i]=twosComp(byte)
39+
buf[i-1]=twosComp(byte)
4740
}
4841
}
4942
}
5043

5144
constparse=exports.parse=(buf)=>{
5245
varpost=buf[buf.length-1]
5346
varpre=buf[0]
54-
returnpre===0x80 ? pos(buf.slice(1,buf.length-1))
55-
 : twos(buf.slice(1,buf.length-1))
47+
varvalue;
48+
if(pre===0x80)
49+
value=pos(buf.slice(1,buf.length))
50+
elseif(pre===0xff)
51+
value=twos(buf)
52+
else
53+
throwTypeError('invalid base256 encoding')
54+
55+
if(!Number.isSafeInteger(value))
56+
// The number is so large that javascript cannot represent it with integer
57+
// precision.
58+
throwTypeError('parsed number outside of javascript javascript safe integer range')
59+
60+
returnvalue
5661
}
5762

5863
consttwos=(buf)=>{
@@ -71,9 +76,9 @@ const twos = (buf) => {
7176
f=twosComp(byte)
7277
}
7378
if(f!==0)
74-
sum+=f*Math.pow(256,len-i-1)
79+
sum-=f*Math.pow(256,len-i-1)
7580
}
76-
returnsum*-1
81+
returnsum
7782
}
7883

7984
constpos=(buf)=>{
‎test/large-numbers.js‎
Lines changed: 57 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,56 @@ const t = require('tap')
77

88
t.test('parse',t=>{
99
constcases=newMap([
10-
['ffffffffffffffffffffff20',-1],
11-
['800000000000100000000020',68719476736],
12-
['fffffffffffffffe1ecc8020',-31536000],
13-
['fffffffffffffff000000020',-268435456],
14-
['800000010203040506070020',72623859790382850],
15-
['ffffffffffffffffffffff00',-1],
16-
['800000000000100000000000',68719476736],
17-
['fffffffffffffffe1ecc8000',-31536000],
18-
['fffffffffffffff000000000',-268435456],
19-
['800000010203040506070000',72623859790382850]
10+
['ffffffffffffffffffffffff',-1],
11+
['800000000000100000000020',17592186044448],
12+
['fffffffffffffffe1ecc8020',-8073215968],
13+
['fffffffffffffff000000020',-68719476704],
14+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
15+
['ffffffffffe0000000000001',-9007199254740991],// MIN_SAFE_INTEGER
16+
['800000000000100000000000',17592186044416],
17+
['fffffffffffffffe1ecc8000',-8073216000],
18+
['fffffffffffffff000000000',-68719476736],
19+
['800000000000000353b66200',14289363456]
2020
])
2121
t.plan(cases.size)
2222
cases.forEach((value,hex)=>
2323
t.equal(parse(Buffer.from(hex,'hex')),value))
2424
})
2525

26+
t.test('parse out of range',t=>{
27+
constcases=[
28+
'800000030000000000000000',
29+
'800000000020000000000000',// MAX_SAFE_INTEGER + 1
30+
'ffffffffffe0000000000000',// MIN_SAFE_INTEGER - 1
31+
'fffffffffdd0000000000000',
32+
]
33+
t.plan(cases.length)
34+
cases.forEach((hex)=>
35+
t.throws(_=>parse(Buffer.from(hex,'hex')),
36+
TypeError('parsed number outside of javascript javascript safe integer range')))
37+
})
38+
39+
t.test('parse invalid base256 encoding',t=>{
40+
constcases=[
41+
'313233343536373131',// octal encoded
42+
'700000030000000000000000',// does not start with 0x80 or 0xff
43+
]
44+
t.plan(cases.length)
45+
cases.forEach((hex)=>
46+
t.throws(_=>parse(Buffer.from(hex,'hex')),
47+
TypeError('invalid base256 encoding')))
48+
})
49+
2650
t.test('encode',t=>{
2751
constcases=newMap([
28-
['ffffffffffffffffffffff20',-1],
29-
['800000000000100000000020',68719476736],
30-
['fffffffffffffffe1ecc8020',-31536000],
31-
['fffffffffffffff000000020',-268435456],
32-
['800000010203040506070020',72623859790382850]
52+
['ffffffffffffffffffffffff',-1],
53+
['800000000000100000000020',17592186044448],
54+
['800000000000100000000000',17592186044416],
55+
['fffffffffffffffe1ecc8020',-8073215968],
56+
['fffffffffffffff000000020',-68719476704],
57+
['fffffffffffffff000000000',-68719476736],// Allows us to test the case where there's a trailing 00
58+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
59+
['ffffffffffe0000000000001',-9007199254740991]// MIN_SAFE_INTEGER
3360
])
3461
t.plan(2)
3562
t.test('alloc',t=>{
@@ -43,3 +70,18 @@ t.test('encode', t => {
4370
t.equal(encode(value,Buffer.allocUnsafe(12)).toString('hex'),hex))
4471
})
4572
})
73+
74+
t.test('encode unsafe numbers',t=>{
75+
constcases=[
76+
Number.MAX_VALUE,
77+
Number.MAX_SAFE_INTEGER+1,
78+
Number.MIN_SAFE_INTEGER-1,
79+
Number.MIN_VALUE,
80+
]
81+
82+
t.plan(cases.length)
83+
cases.forEach((value)=>
84+
t.throws(_=>encode(value),
85+
TypeError('cannot encode number outside of javascript safe integer range')))
86+
})
87+
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix encoding/decoding of base-256 numbers · isaacs/node-tar@c80341a · GitHub
Skip to content
Commit c80341a
Browse files
justfalterjustfalter
committed
Fix encoding/decoding of base-256 numbers
- Encoding/decoding of base-256 numbers failed to failed to handle last
byte in buffer. Handling was previously broken.
- Take javascript's MAX_SAFE_INTEGER / MIN_SAFE_INTEGER into account
when encoding/decoding. Namely, if the numbers cannot accurately be
represented in javascript with integer-precision, a TypeError will be
thrown.
- Throw a TypeError if the parser is passed an buffer that does not
appear to be base-256 encoded. (must start with 0x80 or 0xff)
1 parent b863448 commit c80341a
2 files changed
Lines changed: 89 additions & 42 deletions
File tree
‎lib/large-numbers.js‎
Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
'use strict'
22
// Tar can encode large and negative numbers using a leading byte of
3-
// 0xff for negative, and 0x80 for positive. The trailing byte in the
4-
// section will always be 0x20, or in some implementations 0x00.
5-
// this module encodes and decodes these things.
3+
// 0xff for negative, and 0x80 for positive.
64

75
constencode=exports.encode=(num,buf)=>{
8-
buf[buf.length-1]=0x20
9-
if(num<0)
6+
if(!Number.isSafeInteger(num))
7+
// The number is so large that javascript cannot represent it with integer
8+
// precision.
9+
throwTypeError('cannot encode number outside of javascript safe integer range')
10+
elseif(num<0)
1011
encodeNegative(num,buf)
1112
else
1213
encodePositive(num,buf)
@@ -15,44 +16,48 @@ const encode = exports.encode = (num, buf) => {
1516

1617
constencodePositive=(num,buf)=>{
1718
buf[0]=0x80
18-
for(vari=buf.length-2;i>0;i--){
19-
if(num===0)
20-
buf[i]=0
21-
else{
22-
buf[i]=num%0x100
23-
num=Math.floor(num/0x100)
24-
}
19+
20+
for(vari=buf.length;i>1;i--){
21+
buf[i-1]=num&0xff
22+
num=Math.floor(num/0x100)
2523
}
2624
}
2725

2826
constencodeNegative=(num,buf)=>{
2927
buf[0]=0xff
3028
varflipped=false
3129
num=num*-1
32-
for(vari=buf.length-2;i>0;i--){
33-
varbyte
34-
if(num===0)
35-
byte=0
36-
else{
37-
byte=num%0x100
38-
num=Math.floor(num/0x100)
39-
}
30+
for(vari=buf.length;i>1;i--){
31+
varbyte=num&0xff
32+
num=Math.floor(num/0x100)
4033
if(flipped)
41-
buf[i]=onesComp(byte)
34+
buf[i-1]=onesComp(byte)
4235
elseif(byte===0)
43-
buf[i]=0
36+
buf[i-1]=0
4437
else{
4538
flipped=true
46-
buf[i]=twosComp(byte)
39+
buf[i-1]=twosComp(byte)
4740
}
4841
}
4942
}
5043

5144
constparse=exports.parse=(buf)=>{
5245
varpost=buf[buf.length-1]
5346
varpre=buf[0]
54-
returnpre===0x80 ? pos(buf.slice(1,buf.length-1))
55-
 : twos(buf.slice(1,buf.length-1))
47+
varvalue;
48+
if(pre===0x80)
49+
value=pos(buf.slice(1,buf.length))
50+
elseif(pre===0xff)
51+
value=twos(buf)
52+
else
53+
throwTypeError('invalid base256 encoding')
54+
55+
if(!Number.isSafeInteger(value))
56+
// The number is so large that javascript cannot represent it with integer
57+
// precision.
58+
throwTypeError('parsed number outside of javascript javascript safe integer range')
59+
60+
returnvalue
5661
}
5762

5863
consttwos=(buf)=>{
@@ -71,9 +76,9 @@ const twos = (buf) => {
7176
f=twosComp(byte)
7277
}
7378
if(f!==0)
74-
sum+=f*Math.pow(256,len-i-1)
79+
sum-=f*Math.pow(256,len-i-1)
7580
}
76-
returnsum*-1
81+
returnsum
7782
}
7883

7984
constpos=(buf)=>{
‎test/large-numbers.js‎
Lines changed: 57 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,56 @@ const t = require('tap')
77

88
t.test('parse',t=>{
99
constcases=newMap([
10-
['ffffffffffffffffffffff20',-1],
11-
['800000000000100000000020',68719476736],
12-
['fffffffffffffffe1ecc8020',-31536000],
13-
['fffffffffffffff000000020',-268435456],
14-
['800000010203040506070020',72623859790382850],
15-
['ffffffffffffffffffffff00',-1],
16-
['800000000000100000000000',68719476736],
17-
['fffffffffffffffe1ecc8000',-31536000],
18-
['fffffffffffffff000000000',-268435456],
19-
['800000010203040506070000',72623859790382850]
10+
['ffffffffffffffffffffffff',-1],
11+
['800000000000100000000020',17592186044448],
12+
['fffffffffffffffe1ecc8020',-8073215968],
13+
['fffffffffffffff000000020',-68719476704],
14+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
15+
['ffffffffffe0000000000001',-9007199254740991],// MIN_SAFE_INTEGER
16+
['800000000000100000000000',17592186044416],
17+
['fffffffffffffffe1ecc8000',-8073216000],
18+
['fffffffffffffff000000000',-68719476736],
19+
['800000000000000353b66200',14289363456]
2020
])
2121
t.plan(cases.size)
2222
cases.forEach((value,hex)=>
2323
t.equal(parse(Buffer.from(hex,'hex')),value))
2424
})
2525

26+
t.test('parse out of range',t=>{
27+
constcases=[
28+
'800000030000000000000000',
29+
'800000000020000000000000',// MAX_SAFE_INTEGER + 1
30+
'ffffffffffe0000000000000',// MIN_SAFE_INTEGER - 1
31+
'fffffffffdd0000000000000',
32+
]
33+
t.plan(cases.length)
34+
cases.forEach((hex)=>
35+
t.throws(_=>parse(Buffer.from(hex,'hex')),
36+
TypeError('parsed number outside of javascript javascript safe integer range')))
37+
})
38+
39+
t.test('parse invalid base256 encoding',t=>{
40+
constcases=[
41+
'313233343536373131',// octal encoded
42+
'700000030000000000000000',// does not start with 0x80 or 0xff
43+
]
44+
t.plan(cases.length)
45+
cases.forEach((hex)=>
46+
t.throws(_=>parse(Buffer.from(hex,'hex')),
47+
TypeError('invalid base256 encoding')))
48+
})
49+
2650
t.test('encode',t=>{
2751
constcases=newMap([
28-
['ffffffffffffffffffffff20',-1],
29-
['800000000000100000000020',68719476736],
30-
['fffffffffffffffe1ecc8020',-31536000],
31-
['fffffffffffffff000000020',-268435456],
32-
['800000010203040506070020',72623859790382850]
52+
['ffffffffffffffffffffffff',-1],
53+
['800000000000100000000020',17592186044448],
54+
['800000000000100000000000',17592186044416],
55+
['fffffffffffffffe1ecc8020',-8073215968],
56+
['fffffffffffffff000000020',-68719476704],
57+
['fffffffffffffff000000000',-68719476736],// Allows us to test the case where there's a trailing 00
58+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
59+
['ffffffffffe0000000000001',-9007199254740991]// MIN_SAFE_INTEGER
3360
])
3461
t.plan(2)
3562
t.test('alloc',t=>{
@@ -43,3 +70,18 @@ t.test('encode', t => {
4370
t.equal(encode(value,Buffer.allocUnsafe(12)).toString('hex'),hex))
4471
})
4572
})
73+
74+
t.test('encode unsafe numbers',t=>{
75+
constcases=[
76+
Number.MAX_VALUE,
77+
Number.MAX_SAFE_INTEGER+1,
78+
Number.MIN_SAFE_INTEGER-1,
79+
Number.MIN_VALUE,
80+
]
81+
82+
t.plan(cases.length)
83+
cases.forEach((value)=>
84+
t.throws(_=>encode(value),
85+
TypeError('cannot encode number outside of javascript safe integer range')))
86+
})
87+
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix encoding/decoding of base-256 numbers · isaacs/node-tar@c80341a · GitHub
Skip to content
Commit c80341a
Browse files
justfalterjustfalter
committed
Fix encoding/decoding of base-256 numbers
- Encoding/decoding of base-256 numbers failed to failed to handle last
byte in buffer. Handling was previously broken.
- Take javascript's MAX_SAFE_INTEGER / MIN_SAFE_INTEGER into account
when encoding/decoding. Namely, if the numbers cannot accurately be
represented in javascript with integer-precision, a TypeError will be
thrown.
- Throw a TypeError if the parser is passed an buffer that does not
appear to be base-256 encoded. (must start with 0x80 or 0xff)
1 parent b863448 commit c80341a
2 files changed
Lines changed: 89 additions & 42 deletions
File tree
‎lib/large-numbers.js‎
Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
'use strict'
22
// Tar can encode large and negative numbers using a leading byte of
3-
// 0xff for negative, and 0x80 for positive. The trailing byte in the
4-
// section will always be 0x20, or in some implementations 0x00.
5-
// this module encodes and decodes these things.
3+
// 0xff for negative, and 0x80 for positive.
64

75
constencode=exports.encode=(num,buf)=>{
8-
buf[buf.length-1]=0x20
9-
if(num<0)
6+
if(!Number.isSafeInteger(num))
7+
// The number is so large that javascript cannot represent it with integer
8+
// precision.
9+
throwTypeError('cannot encode number outside of javascript safe integer range')
10+
elseif(num<0)
1011
encodeNegative(num,buf)
1112
else
1213
encodePositive(num,buf)
@@ -15,44 +16,48 @@ const encode = exports.encode = (num, buf) => {
1516

1617
constencodePositive=(num,buf)=>{
1718
buf[0]=0x80
18-
for(vari=buf.length-2;i>0;i--){
19-
if(num===0)
20-
buf[i]=0
21-
else{
22-
buf[i]=num%0x100
23-
num=Math.floor(num/0x100)
24-
}
19+
20+
for(vari=buf.length;i>1;i--){
21+
buf[i-1]=num&0xff
22+
num=Math.floor(num/0x100)
2523
}
2624
}
2725

2826
constencodeNegative=(num,buf)=>{
2927
buf[0]=0xff
3028
varflipped=false
3129
num=num*-1
32-
for(vari=buf.length-2;i>0;i--){
33-
varbyte
34-
if(num===0)
35-
byte=0
36-
else{
37-
byte=num%0x100
38-
num=Math.floor(num/0x100)
39-
}
30+
for(vari=buf.length;i>1;i--){
31+
varbyte=num&0xff
32+
num=Math.floor(num/0x100)
4033
if(flipped)
41-
buf[i]=onesComp(byte)
34+
buf[i-1]=onesComp(byte)
4235
elseif(byte===0)
43-
buf[i]=0
36+
buf[i-1]=0
4437
else{
4538
flipped=true
46-
buf[i]=twosComp(byte)
39+
buf[i-1]=twosComp(byte)
4740
}
4841
}
4942
}
5043

5144
constparse=exports.parse=(buf)=>{
5245
varpost=buf[buf.length-1]
5346
varpre=buf[0]
54-
returnpre===0x80 ? pos(buf.slice(1,buf.length-1))
55-
 : twos(buf.slice(1,buf.length-1))
47+
varvalue;
48+
if(pre===0x80)
49+
value=pos(buf.slice(1,buf.length))
50+
elseif(pre===0xff)
51+
value=twos(buf)
52+
else
53+
throwTypeError('invalid base256 encoding')
54+
55+
if(!Number.isSafeInteger(value))
56+
// The number is so large that javascript cannot represent it with integer
57+
// precision.
58+
throwTypeError('parsed number outside of javascript javascript safe integer range')
59+
60+
returnvalue
5661
}
5762

5863
consttwos=(buf)=>{
@@ -71,9 +76,9 @@ const twos = (buf) => {
7176
f=twosComp(byte)
7277
}
7378
if(f!==0)
74-
sum+=f*Math.pow(256,len-i-1)
79+
sum-=f*Math.pow(256,len-i-1)
7580
}
76-
returnsum*-1
81+
returnsum
7782
}
7883

7984
constpos=(buf)=>{
‎test/large-numbers.js‎
Lines changed: 57 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,56 @@ const t = require('tap')
77

88
t.test('parse',t=>{
99
constcases=newMap([
10-
['ffffffffffffffffffffff20',-1],
11-
['800000000000100000000020',68719476736],
12-
['fffffffffffffffe1ecc8020',-31536000],
13-
['fffffffffffffff000000020',-268435456],
14-
['800000010203040506070020',72623859790382850],
15-
['ffffffffffffffffffffff00',-1],
16-
['800000000000100000000000',68719476736],
17-
['fffffffffffffffe1ecc8000',-31536000],
18-
['fffffffffffffff000000000',-268435456],
19-
['800000010203040506070000',72623859790382850]
10+
['ffffffffffffffffffffffff',-1],
11+
['800000000000100000000020',17592186044448],
12+
['fffffffffffffffe1ecc8020',-8073215968],
13+
['fffffffffffffff000000020',-68719476704],
14+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
15+
['ffffffffffe0000000000001',-9007199254740991],// MIN_SAFE_INTEGER
16+
['800000000000100000000000',17592186044416],
17+
['fffffffffffffffe1ecc8000',-8073216000],
18+
['fffffffffffffff000000000',-68719476736],
19+
['800000000000000353b66200',14289363456]
2020
])
2121
t.plan(cases.size)
2222
cases.forEach((value,hex)=>
2323
t.equal(parse(Buffer.from(hex,'hex')),value))
2424
})
2525

26+
t.test('parse out of range',t=>{
27+
constcases=[
28+
'800000030000000000000000',
29+
'800000000020000000000000',// MAX_SAFE_INTEGER + 1
30+
'ffffffffffe0000000000000',// MIN_SAFE_INTEGER - 1
31+
'fffffffffdd0000000000000',
32+
]
33+
t.plan(cases.length)
34+
cases.forEach((hex)=>
35+
t.throws(_=>parse(Buffer.from(hex,'hex')),
36+
TypeError('parsed number outside of javascript javascript safe integer range')))
37+
})
38+
39+
t.test('parse invalid base256 encoding',t=>{
40+
constcases=[
41+
'313233343536373131',// octal encoded
42+
'700000030000000000000000',// does not start with 0x80 or 0xff
43+
]
44+
t.plan(cases.length)
45+
cases.forEach((hex)=>
46+
t.throws(_=>parse(Buffer.from(hex,'hex')),
47+
TypeError('invalid base256 encoding')))
48+
})
49+
2650
t.test('encode',t=>{
2751
constcases=newMap([
28-
['ffffffffffffffffffffff20',-1],
29-
['800000000000100000000020',68719476736],
30-
['fffffffffffffffe1ecc8020',-31536000],
31-
['fffffffffffffff000000020',-268435456],
32-
['800000010203040506070020',72623859790382850]
52+
['ffffffffffffffffffffffff',-1],
53+
['800000000000100000000020',17592186044448],
54+
['800000000000100000000000',17592186044416],
55+
['fffffffffffffffe1ecc8020',-8073215968],
56+
['fffffffffffffff000000020',-68719476704],
57+
['fffffffffffffff000000000',-68719476736],// Allows us to test the case where there's a trailing 00
58+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
59+
['ffffffffffe0000000000001',-9007199254740991]// MIN_SAFE_INTEGER
3360
])
3461
t.plan(2)
3562
t.test('alloc',t=>{
@@ -43,3 +70,18 @@ t.test('encode', t => {
4370
t.equal(encode(value,Buffer.allocUnsafe(12)).toString('hex'),hex))
4471
})
4572
})
73+
74+
t.test('encode unsafe numbers',t=>{
75+
constcases=[
76+
Number.MAX_VALUE,
77+
Number.MAX_SAFE_INTEGER+1,
78+
Number.MIN_SAFE_INTEGER-1,
79+
Number.MIN_VALUE,
80+
]
81+
82+
t.plan(cases.length)
83+
cases.forEach((value)=>
84+
t.throws(_=>encode(value),
85+
TypeError('cannot encode number outside of javascript safe integer range')))
86+
})
87+
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix encoding/decoding of base-256 numbers · isaacs/node-tar@c80341a · GitHub
Skip to content
Commit c80341a
Browse files
justfalterjustfalter
committed
Fix encoding/decoding of base-256 numbers
- Encoding/decoding of base-256 numbers failed to failed to handle last
byte in buffer. Handling was previously broken.
- Take javascript's MAX_SAFE_INTEGER / MIN_SAFE_INTEGER into account
when encoding/decoding. Namely, if the numbers cannot accurately be
represented in javascript with integer-precision, a TypeError will be
thrown.
- Throw a TypeError if the parser is passed an buffer that does not
appear to be base-256 encoded. (must start with 0x80 or 0xff)
1 parent b863448 commit c80341a
2 files changed
Lines changed: 89 additions & 42 deletions
File tree
‎lib/large-numbers.js‎
Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
'use strict'
22
// Tar can encode large and negative numbers using a leading byte of
3-
// 0xff for negative, and 0x80 for positive. The trailing byte in the
4-
// section will always be 0x20, or in some implementations 0x00.
5-
// this module encodes and decodes these things.
3+
// 0xff for negative, and 0x80 for positive.
64

75
constencode=exports.encode=(num,buf)=>{
8-
buf[buf.length-1]=0x20
9-
if(num<0)
6+
if(!Number.isSafeInteger(num))
7+
// The number is so large that javascript cannot represent it with integer
8+
// precision.
9+
throwTypeError('cannot encode number outside of javascript safe integer range')
10+
elseif(num<0)
1011
encodeNegative(num,buf)
1112
else
1213
encodePositive(num,buf)
@@ -15,44 +16,48 @@ const encode = exports.encode = (num, buf) => {
1516

1617
constencodePositive=(num,buf)=>{
1718
buf[0]=0x80
18-
for(vari=buf.length-2;i>0;i--){
19-
if(num===0)
20-
buf[i]=0
21-
else{
22-
buf[i]=num%0x100
23-
num=Math.floor(num/0x100)
24-
}
19+
20+
for(vari=buf.length;i>1;i--){
21+
buf[i-1]=num&0xff
22+
num=Math.floor(num/0x100)
2523
}
2624
}
2725

2826
constencodeNegative=(num,buf)=>{
2927
buf[0]=0xff
3028
varflipped=false
3129
num=num*-1
32-
for(vari=buf.length-2;i>0;i--){
33-
varbyte
34-
if(num===0)
35-
byte=0
36-
else{
37-
byte=num%0x100
38-
num=Math.floor(num/0x100)
39-
}
30+
for(vari=buf.length;i>1;i--){
31+
varbyte=num&0xff
32+
num=Math.floor(num/0x100)
4033
if(flipped)
41-
buf[i]=onesComp(byte)
34+
buf[i-1]=onesComp(byte)
4235
elseif(byte===0)
43-
buf[i]=0
36+
buf[i-1]=0
4437
else{
4538
flipped=true
46-
buf[i]=twosComp(byte)
39+
buf[i-1]=twosComp(byte)
4740
}
4841
}
4942
}
5043

5144
constparse=exports.parse=(buf)=>{
5245
varpost=buf[buf.length-1]
5346
varpre=buf[0]
54-
returnpre===0x80 ? pos(buf.slice(1,buf.length-1))
55-
 : twos(buf.slice(1,buf.length-1))
47+
varvalue;
48+
if(pre===0x80)
49+
value=pos(buf.slice(1,buf.length))
50+
elseif(pre===0xff)
51+
value=twos(buf)
52+
else
53+
throwTypeError('invalid base256 encoding')
54+
55+
if(!Number.isSafeInteger(value))
56+
// The number is so large that javascript cannot represent it with integer
57+
// precision.
58+
throwTypeError('parsed number outside of javascript javascript safe integer range')
59+
60+
returnvalue
5661
}
5762

5863
consttwos=(buf)=>{
@@ -71,9 +76,9 @@ const twos = (buf) => {
7176
f=twosComp(byte)
7277
}
7378
if(f!==0)
74-
sum+=f*Math.pow(256,len-i-1)
79+
sum-=f*Math.pow(256,len-i-1)
7580
}
76-
returnsum*-1
81+
returnsum
7782
}
7883

7984
constpos=(buf)=>{
‎test/large-numbers.js‎
Lines changed: 57 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,56 @@ const t = require('tap')
77

88
t.test('parse',t=>{
99
constcases=newMap([
10-
['ffffffffffffffffffffff20',-1],
11-
['800000000000100000000020',68719476736],
12-
['fffffffffffffffe1ecc8020',-31536000],
13-
['fffffffffffffff000000020',-268435456],
14-
['800000010203040506070020',72623859790382850],
15-
['ffffffffffffffffffffff00',-1],
16-
['800000000000100000000000',68719476736],
17-
['fffffffffffffffe1ecc8000',-31536000],
18-
['fffffffffffffff000000000',-268435456],
19-
['800000010203040506070000',72623859790382850]
10+
['ffffffffffffffffffffffff',-1],
11+
['800000000000100000000020',17592186044448],
12+
['fffffffffffffffe1ecc8020',-8073215968],
13+
['fffffffffffffff000000020',-68719476704],
14+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
15+
['ffffffffffe0000000000001',-9007199254740991],// MIN_SAFE_INTEGER
16+
['800000000000100000000000',17592186044416],
17+
['fffffffffffffffe1ecc8000',-8073216000],
18+
['fffffffffffffff000000000',-68719476736],
19+
['800000000000000353b66200',14289363456]
2020
])
2121
t.plan(cases.size)
2222
cases.forEach((value,hex)=>
2323
t.equal(parse(Buffer.from(hex,'hex')),value))
2424
})
2525

26+
t.test('parse out of range',t=>{
27+
constcases=[
28+
'800000030000000000000000',
29+
'800000000020000000000000',// MAX_SAFE_INTEGER + 1
30+
'ffffffffffe0000000000000',// MIN_SAFE_INTEGER - 1
31+
'fffffffffdd0000000000000',
32+
]
33+
t.plan(cases.length)
34+
cases.forEach((hex)=>
35+
t.throws(_=>parse(Buffer.from(hex,'hex')),
36+
TypeError('parsed number outside of javascript javascript safe integer range')))
37+
})
38+
39+
t.test('parse invalid base256 encoding',t=>{
40+
constcases=[
41+
'313233343536373131',// octal encoded
42+
'700000030000000000000000',// does not start with 0x80 or 0xff
43+
]
44+
t.plan(cases.length)
45+
cases.forEach((hex)=>
46+
t.throws(_=>parse(Buffer.from(hex,'hex')),
47+
TypeError('invalid base256 encoding')))
48+
})
49+
2650
t.test('encode',t=>{
2751
constcases=newMap([
28-
['ffffffffffffffffffffff20',-1],
29-
['800000000000100000000020',68719476736],
30-
['fffffffffffffffe1ecc8020',-31536000],
31-
['fffffffffffffff000000020',-268435456],
32-
['800000010203040506070020',72623859790382850]
52+
['ffffffffffffffffffffffff',-1],
53+
['800000000000100000000020',17592186044448],
54+
['800000000000100000000000',17592186044416],
55+
['fffffffffffffffe1ecc8020',-8073215968],
56+
['fffffffffffffff000000020',-68719476704],
57+
['fffffffffffffff000000000',-68719476736],// Allows us to test the case where there's a trailing 00
58+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
59+
['ffffffffffe0000000000001',-9007199254740991]// MIN_SAFE_INTEGER
3360
])
3461
t.plan(2)
3562
t.test('alloc',t=>{
@@ -43,3 +70,18 @@ t.test('encode', t => {
4370
t.equal(encode(value,Buffer.allocUnsafe(12)).toString('hex'),hex))
4471
})
4572
})
73+
74+
t.test('encode unsafe numbers',t=>{
75+
constcases=[
76+
Number.MAX_VALUE,
77+
Number.MAX_SAFE_INTEGER+1,
78+
Number.MIN_SAFE_INTEGER-1,
79+
Number.MIN_VALUE,
80+
]
81+
82+
t.plan(cases.length)
83+
cases.forEach((value)=>
84+
t.throws(_=>encode(value),
85+
TypeError('cannot encode number outside of javascript safe integer range')))
86+
})
87+
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix encoding/decoding of base-256 numbers · isaacs/node-tar@c80341a · GitHub
Skip to content
Commit c80341a
Browse files
justfalterjustfalter
committed
Fix encoding/decoding of base-256 numbers
- Encoding/decoding of base-256 numbers failed to failed to handle last
byte in buffer. Handling was previously broken.
- Take javascript's MAX_SAFE_INTEGER / MIN_SAFE_INTEGER into account
when encoding/decoding. Namely, if the numbers cannot accurately be
represented in javascript with integer-precision, a TypeError will be
thrown.
- Throw a TypeError if the parser is passed an buffer that does not
appear to be base-256 encoded. (must start with 0x80 or 0xff)
1 parent b863448 commit c80341a
2 files changed
Lines changed: 89 additions & 42 deletions
File tree
‎lib/large-numbers.js‎
Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
'use strict'
22
// Tar can encode large and negative numbers using a leading byte of
3-
// 0xff for negative, and 0x80 for positive. The trailing byte in the
4-
// section will always be 0x20, or in some implementations 0x00.
5-
// this module encodes and decodes these things.
3+
// 0xff for negative, and 0x80 for positive.
64

75
constencode=exports.encode=(num,buf)=>{
8-
buf[buf.length-1]=0x20
9-
if(num<0)
6+
if(!Number.isSafeInteger(num))
7+
// The number is so large that javascript cannot represent it with integer
8+
// precision.
9+
throwTypeError('cannot encode number outside of javascript safe integer range')
10+
elseif(num<0)
1011
encodeNegative(num,buf)
1112
else
1213
encodePositive(num,buf)
@@ -15,44 +16,48 @@ const encode = exports.encode = (num, buf) => {
1516

1617
constencodePositive=(num,buf)=>{
1718
buf[0]=0x80
18-
for(vari=buf.length-2;i>0;i--){
19-
if(num===0)
20-
buf[i]=0
21-
else{
22-
buf[i]=num%0x100
23-
num=Math.floor(num/0x100)
24-
}
19+
20+
for(vari=buf.length;i>1;i--){
21+
buf[i-1]=num&0xff
22+
num=Math.floor(num/0x100)
2523
}
2624
}
2725

2826
constencodeNegative=(num,buf)=>{
2927
buf[0]=0xff
3028
varflipped=false
3129
num=num*-1
32-
for(vari=buf.length-2;i>0;i--){
33-
varbyte
34-
if(num===0)
35-
byte=0
36-
else{
37-
byte=num%0x100
38-
num=Math.floor(num/0x100)
39-
}
30+
for(vari=buf.length;i>1;i--){
31+
varbyte=num&0xff
32+
num=Math.floor(num/0x100)
4033
if(flipped)
41-
buf[i]=onesComp(byte)
34+
buf[i-1]=onesComp(byte)
4235
elseif(byte===0)
43-
buf[i]=0
36+
buf[i-1]=0
4437
else{
4538
flipped=true
46-
buf[i]=twosComp(byte)
39+
buf[i-1]=twosComp(byte)
4740
}
4841
}
4942
}
5043

5144
constparse=exports.parse=(buf)=>{
5245
varpost=buf[buf.length-1]
5346
varpre=buf[0]
54-
returnpre===0x80 ? pos(buf.slice(1,buf.length-1))
55-
 : twos(buf.slice(1,buf.length-1))
47+
varvalue;
48+
if(pre===0x80)
49+
value=pos(buf.slice(1,buf.length))
50+
elseif(pre===0xff)
51+
value=twos(buf)
52+
else
53+
throwTypeError('invalid base256 encoding')
54+
55+
if(!Number.isSafeInteger(value))
56+
// The number is so large that javascript cannot represent it with integer
57+
// precision.
58+
throwTypeError('parsed number outside of javascript javascript safe integer range')
59+
60+
returnvalue
5661
}
5762

5863
consttwos=(buf)=>{
@@ -71,9 +76,9 @@ const twos = (buf) => {
7176
f=twosComp(byte)
7277
}
7378
if(f!==0)
74-
sum+=f*Math.pow(256,len-i-1)
79+
sum-=f*Math.pow(256,len-i-1)
7580
}
76-
returnsum*-1
81+
returnsum
7782
}
7883

7984
constpos=(buf)=>{
‎test/large-numbers.js‎
Lines changed: 57 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,56 @@ const t = require('tap')
77

88
t.test('parse',t=>{
99
constcases=newMap([
10-
['ffffffffffffffffffffff20',-1],
11-
['800000000000100000000020',68719476736],
12-
['fffffffffffffffe1ecc8020',-31536000],
13-
['fffffffffffffff000000020',-268435456],
14-
['800000010203040506070020',72623859790382850],
15-
['ffffffffffffffffffffff00',-1],
16-
['800000000000100000000000',68719476736],
17-
['fffffffffffffffe1ecc8000',-31536000],
18-
['fffffffffffffff000000000',-268435456],
19-
['800000010203040506070000',72623859790382850]
10+
['ffffffffffffffffffffffff',-1],
11+
['800000000000100000000020',17592186044448],
12+
['fffffffffffffffe1ecc8020',-8073215968],
13+
['fffffffffffffff000000020',-68719476704],
14+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
15+
['ffffffffffe0000000000001',-9007199254740991],// MIN_SAFE_INTEGER
16+
['800000000000100000000000',17592186044416],
17+
['fffffffffffffffe1ecc8000',-8073216000],
18+
['fffffffffffffff000000000',-68719476736],
19+
['800000000000000353b66200',14289363456]
2020
])
2121
t.plan(cases.size)
2222
cases.forEach((value,hex)=>
2323
t.equal(parse(Buffer.from(hex,'hex')),value))
2424
})
2525

26+
t.test('parse out of range',t=>{
27+
constcases=[
28+
'800000030000000000000000',
29+
'800000000020000000000000',// MAX_SAFE_INTEGER + 1
30+
'ffffffffffe0000000000000',// MIN_SAFE_INTEGER - 1
31+
'fffffffffdd0000000000000',
32+
]
33+
t.plan(cases.length)
34+
cases.forEach((hex)=>
35+
t.throws(_=>parse(Buffer.from(hex,'hex')),
36+
TypeError('parsed number outside of javascript javascript safe integer range')))
37+
})
38+
39+
t.test('parse invalid base256 encoding',t=>{
40+
constcases=[
41+
'313233343536373131',// octal encoded
42+
'700000030000000000000000',// does not start with 0x80 or 0xff
43+
]
44+
t.plan(cases.length)
45+
cases.forEach((hex)=>
46+
t.throws(_=>parse(Buffer.from(hex,'hex')),
47+
TypeError('invalid base256 encoding')))
48+
})
49+
2650
t.test('encode',t=>{
2751
constcases=newMap([
28-
['ffffffffffffffffffffff20',-1],
29-
['800000000000100000000020',68719476736],
30-
['fffffffffffffffe1ecc8020',-31536000],
31-
['fffffffffffffff000000020',-268435456],
32-
['800000010203040506070020',72623859790382850]
52+
['ffffffffffffffffffffffff',-1],
53+
['800000000000100000000020',17592186044448],
54+
['800000000000100000000000',17592186044416],
55+
['fffffffffffffffe1ecc8020',-8073215968],
56+
['fffffffffffffff000000020',-68719476704],
57+
['fffffffffffffff000000000',-68719476736],// Allows us to test the case where there's a trailing 00
58+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
59+
['ffffffffffe0000000000001',-9007199254740991]// MIN_SAFE_INTEGER
3360
])
3461
t.plan(2)
3562
t.test('alloc',t=>{
@@ -43,3 +70,18 @@ t.test('encode', t => {
4370
t.equal(encode(value,Buffer.allocUnsafe(12)).toString('hex'),hex))
4471
})
4572
})
73+
74+
t.test('encode unsafe numbers',t=>{
75+
constcases=[
76+
Number.MAX_VALUE,
77+
Number.MAX_SAFE_INTEGER+1,
78+
Number.MIN_SAFE_INTEGER-1,
79+
Number.MIN_VALUE,
80+
]
81+
82+
t.plan(cases.length)
83+
cases.forEach((value)=>
84+
t.throws(_=>encode(value),
85+
TypeError('cannot encode number outside of javascript safe integer range')))
86+
})
87+
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix encoding/decoding of base-256 numbers · isaacs/node-tar@c80341a · GitHub
Skip to content
Commit c80341a
Browse files
justfalterjustfalter
committed
Fix encoding/decoding of base-256 numbers
- Encoding/decoding of base-256 numbers failed to failed to handle last
byte in buffer. Handling was previously broken.
- Take javascript's MAX_SAFE_INTEGER / MIN_SAFE_INTEGER into account
when encoding/decoding. Namely, if the numbers cannot accurately be
represented in javascript with integer-precision, a TypeError will be
thrown.
- Throw a TypeError if the parser is passed an buffer that does not
appear to be base-256 encoded. (must start with 0x80 or 0xff)
1 parent b863448 commit c80341a
2 files changed
Lines changed: 89 additions & 42 deletions
File tree
‎lib/large-numbers.js‎
Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
'use strict'
22
// Tar can encode large and negative numbers using a leading byte of
3-
// 0xff for negative, and 0x80 for positive. The trailing byte in the
4-
// section will always be 0x20, or in some implementations 0x00.
5-
// this module encodes and decodes these things.
3+
// 0xff for negative, and 0x80 for positive.
64

75
constencode=exports.encode=(num,buf)=>{
8-
buf[buf.length-1]=0x20
9-
if(num<0)
6+
if(!Number.isSafeInteger(num))
7+
// The number is so large that javascript cannot represent it with integer
8+
// precision.
9+
throwTypeError('cannot encode number outside of javascript safe integer range')
10+
elseif(num<0)
1011
encodeNegative(num,buf)
1112
else
1213
encodePositive(num,buf)
@@ -15,44 +16,48 @@ const encode = exports.encode = (num, buf) => {
1516

1617
constencodePositive=(num,buf)=>{
1718
buf[0]=0x80
18-
for(vari=buf.length-2;i>0;i--){
19-
if(num===0)
20-
buf[i]=0
21-
else{
22-
buf[i]=num%0x100
23-
num=Math.floor(num/0x100)
24-
}
19+
20+
for(vari=buf.length;i>1;i--){
21+
buf[i-1]=num&0xff
22+
num=Math.floor(num/0x100)
2523
}
2624
}
2725

2826
constencodeNegative=(num,buf)=>{
2927
buf[0]=0xff
3028
varflipped=false
3129
num=num*-1
32-
for(vari=buf.length-2;i>0;i--){
33-
varbyte
34-
if(num===0)
35-
byte=0
36-
else{
37-
byte=num%0x100
38-
num=Math.floor(num/0x100)
39-
}
30+
for(vari=buf.length;i>1;i--){
31+
varbyte=num&0xff
32+
num=Math.floor(num/0x100)
4033
if(flipped)
41-
buf[i]=onesComp(byte)
34+
buf[i-1]=onesComp(byte)
4235
elseif(byte===0)
43-
buf[i]=0
36+
buf[i-1]=0
4437
else{
4538
flipped=true
46-
buf[i]=twosComp(byte)
39+
buf[i-1]=twosComp(byte)
4740
}
4841
}
4942
}
5043

5144
constparse=exports.parse=(buf)=>{
5245
varpost=buf[buf.length-1]
5346
varpre=buf[0]
54-
returnpre===0x80 ? pos(buf.slice(1,buf.length-1))
55-
 : twos(buf.slice(1,buf.length-1))
47+
varvalue;
48+
if(pre===0x80)
49+
value=pos(buf.slice(1,buf.length))
50+
elseif(pre===0xff)
51+
value=twos(buf)
52+
else
53+
throwTypeError('invalid base256 encoding')
54+
55+
if(!Number.isSafeInteger(value))
56+
// The number is so large that javascript cannot represent it with integer
57+
// precision.
58+
throwTypeError('parsed number outside of javascript javascript safe integer range')
59+
60+
returnvalue
5661
}
5762

5863
consttwos=(buf)=>{
@@ -71,9 +76,9 @@ const twos = (buf) => {
7176
f=twosComp(byte)
7277
}
7378
if(f!==0)
74-
sum+=f*Math.pow(256,len-i-1)
79+
sum-=f*Math.pow(256,len-i-1)
7580
}
76-
returnsum*-1
81+
returnsum
7782
}
7883

7984
constpos=(buf)=>{
‎test/large-numbers.js‎
Lines changed: 57 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,56 @@ const t = require('tap')
77

88
t.test('parse',t=>{
99
constcases=newMap([
10-
['ffffffffffffffffffffff20',-1],
11-
['800000000000100000000020',68719476736],
12-
['fffffffffffffffe1ecc8020',-31536000],
13-
['fffffffffffffff000000020',-268435456],
14-
['800000010203040506070020',72623859790382850],
15-
['ffffffffffffffffffffff00',-1],
16-
['800000000000100000000000',68719476736],
17-
['fffffffffffffffe1ecc8000',-31536000],
18-
['fffffffffffffff000000000',-268435456],
19-
['800000010203040506070000',72623859790382850]
10+
['ffffffffffffffffffffffff',-1],
11+
['800000000000100000000020',17592186044448],
12+
['fffffffffffffffe1ecc8020',-8073215968],
13+
['fffffffffffffff000000020',-68719476704],
14+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
15+
['ffffffffffe0000000000001',-9007199254740991],// MIN_SAFE_INTEGER
16+
['800000000000100000000000',17592186044416],
17+
['fffffffffffffffe1ecc8000',-8073216000],
18+
['fffffffffffffff000000000',-68719476736],
19+
['800000000000000353b66200',14289363456]
2020
])
2121
t.plan(cases.size)
2222
cases.forEach((value,hex)=>
2323
t.equal(parse(Buffer.from(hex,'hex')),value))
2424
})
2525

26+
t.test('parse out of range',t=>{
27+
constcases=[
28+
'800000030000000000000000',
29+
'800000000020000000000000',// MAX_SAFE_INTEGER + 1
30+
'ffffffffffe0000000000000',// MIN_SAFE_INTEGER - 1
31+
'fffffffffdd0000000000000',
32+
]
33+
t.plan(cases.length)
34+
cases.forEach((hex)=>
35+
t.throws(_=>parse(Buffer.from(hex,'hex')),
36+
TypeError('parsed number outside of javascript javascript safe integer range')))
37+
})
38+
39+
t.test('parse invalid base256 encoding',t=>{
40+
constcases=[
41+
'313233343536373131',// octal encoded
42+
'700000030000000000000000',// does not start with 0x80 or 0xff
43+
]
44+
t.plan(cases.length)
45+
cases.forEach((hex)=>
46+
t.throws(_=>parse(Buffer.from(hex,'hex')),
47+
TypeError('invalid base256 encoding')))
48+
})
49+
2650
t.test('encode',t=>{
2751
constcases=newMap([
28-
['ffffffffffffffffffffff20',-1],
29-
['800000000000100000000020',68719476736],
30-
['fffffffffffffffe1ecc8020',-31536000],
31-
['fffffffffffffff000000020',-268435456],
32-
['800000010203040506070020',72623859790382850]
52+
['ffffffffffffffffffffffff',-1],
53+
['800000000000100000000020',17592186044448],
54+
['800000000000100000000000',17592186044416],
55+
['fffffffffffffffe1ecc8020',-8073215968],
56+
['fffffffffffffff000000020',-68719476704],
57+
['fffffffffffffff000000000',-68719476736],// Allows us to test the case where there's a trailing 00
58+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
59+
['ffffffffffe0000000000001',-9007199254740991]// MIN_SAFE_INTEGER
3360
])
3461
t.plan(2)
3562
t.test('alloc',t=>{
@@ -43,3 +70,18 @@ t.test('encode', t => {
4370
t.equal(encode(value,Buffer.allocUnsafe(12)).toString('hex'),hex))
4471
})
4572
})
73+
74+
t.test('encode unsafe numbers',t=>{
75+
constcases=[
76+
Number.MAX_VALUE,
77+
Number.MAX_SAFE_INTEGER+1,
78+
Number.MIN_SAFE_INTEGER-1,
79+
Number.MIN_VALUE,
80+
]
81+
82+
t.plan(cases.length)
83+
cases.forEach((value)=>
84+
t.throws(_=>encode(value),
85+
TypeError('cannot encode number outside of javascript safe integer range')))
86+
})
87+
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Fix encoding/decoding of base-256 numbers · isaacs/node-tar@c80341a · GitHub
Skip to content
Commit c80341a
Browse files
justfalterjustfalter
committed
Fix encoding/decoding of base-256 numbers
- Encoding/decoding of base-256 numbers failed to failed to handle last
byte in buffer. Handling was previously broken.
- Take javascript's MAX_SAFE_INTEGER / MIN_SAFE_INTEGER into account
when encoding/decoding. Namely, if the numbers cannot accurately be
represented in javascript with integer-precision, a TypeError will be
thrown.
- Throw a TypeError if the parser is passed an buffer that does not
appear to be base-256 encoded. (must start with 0x80 or 0xff)
1 parent b863448 commit c80341a
2 files changed
Lines changed: 89 additions & 42 deletions
File tree
‎lib/large-numbers.js‎
Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
'use strict'
22
// Tar can encode large and negative numbers using a leading byte of
3-
// 0xff for negative, and 0x80 for positive. The trailing byte in the
4-
// section will always be 0x20, or in some implementations 0x00.
5-
// this module encodes and decodes these things.
3+
// 0xff for negative, and 0x80 for positive.
64

75
constencode=exports.encode=(num,buf)=>{
8-
buf[buf.length-1]=0x20
9-
if(num<0)
6+
if(!Number.isSafeInteger(num))
7+
// The number is so large that javascript cannot represent it with integer
8+
// precision.
9+
throwTypeError('cannot encode number outside of javascript safe integer range')
10+
elseif(num<0)
1011
encodeNegative(num,buf)
1112
else
1213
encodePositive(num,buf)
@@ -15,44 +16,48 @@ const encode = exports.encode = (num, buf) => {
1516

1617
constencodePositive=(num,buf)=>{
1718
buf[0]=0x80
18-
for(vari=buf.length-2;i>0;i--){
19-
if(num===0)
20-
buf[i]=0
21-
else{
22-
buf[i]=num%0x100
23-
num=Math.floor(num/0x100)
24-
}
19+
20+
for(vari=buf.length;i>1;i--){
21+
buf[i-1]=num&0xff
22+
num=Math.floor(num/0x100)
2523
}
2624
}
2725

2826
constencodeNegative=(num,buf)=>{
2927
buf[0]=0xff
3028
varflipped=false
3129
num=num*-1
32-
for(vari=buf.length-2;i>0;i--){
33-
varbyte
34-
if(num===0)
35-
byte=0
36-
else{
37-
byte=num%0x100
38-
num=Math.floor(num/0x100)
39-
}
30+
for(vari=buf.length;i>1;i--){
31+
varbyte=num&0xff
32+
num=Math.floor(num/0x100)
4033
if(flipped)
41-
buf[i]=onesComp(byte)
34+
buf[i-1]=onesComp(byte)
4235
elseif(byte===0)
43-
buf[i]=0
36+
buf[i-1]=0
4437
else{
4538
flipped=true
46-
buf[i]=twosComp(byte)
39+
buf[i-1]=twosComp(byte)
4740
}
4841
}
4942
}
5043

5144
constparse=exports.parse=(buf)=>{
5245
varpost=buf[buf.length-1]
5346
varpre=buf[0]
54-
returnpre===0x80 ? pos(buf.slice(1,buf.length-1))
55-
 : twos(buf.slice(1,buf.length-1))
47+
varvalue;
48+
if(pre===0x80)
49+
value=pos(buf.slice(1,buf.length))
50+
elseif(pre===0xff)
51+
value=twos(buf)
52+
else
53+
throwTypeError('invalid base256 encoding')
54+
55+
if(!Number.isSafeInteger(value))
56+
// The number is so large that javascript cannot represent it with integer
57+
// precision.
58+
throwTypeError('parsed number outside of javascript javascript safe integer range')
59+
60+
returnvalue
5661
}
5762

5863
consttwos=(buf)=>{
@@ -71,9 +76,9 @@ const twos = (buf) => {
7176
f=twosComp(byte)
7277
}
7378
if(f!==0)
74-
sum+=f*Math.pow(256,len-i-1)
79+
sum-=f*Math.pow(256,len-i-1)
7580
}
76-
returnsum*-1
81+
returnsum
7782
}
7883

7984
constpos=(buf)=>{
‎test/large-numbers.js‎
Lines changed: 57 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,56 @@ const t = require('tap')
77

88
t.test('parse',t=>{
99
constcases=newMap([
10-
['ffffffffffffffffffffff20',-1],
11-
['800000000000100000000020',68719476736],
12-
['fffffffffffffffe1ecc8020',-31536000],
13-
['fffffffffffffff000000020',-268435456],
14-
['800000010203040506070020',72623859790382850],
15-
['ffffffffffffffffffffff00',-1],
16-
['800000000000100000000000',68719476736],
17-
['fffffffffffffffe1ecc8000',-31536000],
18-
['fffffffffffffff000000000',-268435456],
19-
['800000010203040506070000',72623859790382850]
10+
['ffffffffffffffffffffffff',-1],
11+
['800000000000100000000020',17592186044448],
12+
['fffffffffffffffe1ecc8020',-8073215968],
13+
['fffffffffffffff000000020',-68719476704],
14+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
15+
['ffffffffffe0000000000001',-9007199254740991],// MIN_SAFE_INTEGER
16+
['800000000000100000000000',17592186044416],
17+
['fffffffffffffffe1ecc8000',-8073216000],
18+
['fffffffffffffff000000000',-68719476736],
19+
['800000000000000353b66200',14289363456]
2020
])
2121
t.plan(cases.size)
2222
cases.forEach((value,hex)=>
2323
t.equal(parse(Buffer.from(hex,'hex')),value))
2424
})
2525

26+
t.test('parse out of range',t=>{
27+
constcases=[
28+
'800000030000000000000000',
29+
'800000000020000000000000',// MAX_SAFE_INTEGER + 1
30+
'ffffffffffe0000000000000',// MIN_SAFE_INTEGER - 1
31+
'fffffffffdd0000000000000',
32+
]
33+
t.plan(cases.length)
34+
cases.forEach((hex)=>
35+
t.throws(_=>parse(Buffer.from(hex,'hex')),
36+
TypeError('parsed number outside of javascript javascript safe integer range')))
37+
})
38+
39+
t.test('parse invalid base256 encoding',t=>{
40+
constcases=[
41+
'313233343536373131',// octal encoded
42+
'700000030000000000000000',// does not start with 0x80 or 0xff
43+
]
44+
t.plan(cases.length)
45+
cases.forEach((hex)=>
46+
t.throws(_=>parse(Buffer.from(hex,'hex')),
47+
TypeError('invalid base256 encoding')))
48+
})
49+
2650
t.test('encode',t=>{
2751
constcases=newMap([
28-
['ffffffffffffffffffffff20',-1],
29-
['800000000000100000000020',68719476736],
30-
['fffffffffffffffe1ecc8020',-31536000],
31-
['fffffffffffffff000000020',-268435456],
32-
['800000010203040506070020',72623859790382850]
52+
['ffffffffffffffffffffffff',-1],
53+
['800000000000100000000020',17592186044448],
54+
['800000000000100000000000',17592186044416],
55+
['fffffffffffffffe1ecc8020',-8073215968],
56+
['fffffffffffffff000000020',-68719476704],
57+
['fffffffffffffff000000000',-68719476736],// Allows us to test the case where there's a trailing 00
58+
['80000000001fffffffffffff',9007199254740991],// MAX_SAFE_INTEGER
59+
['ffffffffffe0000000000001',-9007199254740991]// MIN_SAFE_INTEGER
3360
])
3461
t.plan(2)
3562
t.test('alloc',t=>{
@@ -43,3 +70,18 @@ t.test('encode', t => {
4370
t.equal(encode(value,Buffer.allocUnsafe(12)).toString('hex'),hex))
4471
})
4572
})
73+
74+
t.test('encode unsafe numbers',t=>{
75+
constcases=[
76+
Number.MAX_VALUE,
77+
Number.MAX_SAFE_INTEGER+1,
78+
Number.MIN_SAFE_INTEGER-1,
79+
Number.MIN_VALUE,
80+
]
81+
82+
t.plan(cases.length)
83+
cases.forEach((value)=>
84+
t.throws(_=>encode(value),
85+
TypeError('cannot encode number outside of javascript safe integer range')))
86+
})
87+
0 commit comments
Comments
 (0)