perf: keep engine and update checks off the version path

Author: danielroe

packages/nuxt-cli/src/main.ts

@@ -14,11 +14,9 @@ import { cwdArgs } from './commands/_shared'
 import{runCommand,setCurrentCommand}from'./run'
 import{normaliseCwdArg}from'./utils/args'
 import{setupGlobalConsole}from'./utils/console'
-import{checkEngines}from'./utils/engines'
 import{debug,logger}from'./utils/logger'
 import{setupProxySupport}from'./utils/network'
 import{findInPath,withLocalBinPath}from'./utils/path-env'
-import{resolveProjectDir}from'./utils/paths'
 import{templateNames}from'./utils/templates/names'
 import{findUnknownFlags,suggestFlags}from'./utils/unknown-args'
 import{scheduleUpdateNudge}from'./utils/update-lazy'
@@ -49,13 +47,14 @@ const _main = defineCommand({
 setCurrentCommand(command)
 setupGlobalConsole({dev: command==='dev'})
 
-if(command!=='_dev'&&provider!=='stackblitz'){
+if(command&&command!=='_dev'&&provider!=='stackblitz'){
 // The engine check is awaited so its warning cannot land in the middle of
 // a prompt, but the update checks are left running: they reach the user
 // through a `process.exit` handler, and a slow or unreachable registry
 // must never hold up the command.
-awaitcheckEngines().catch(err=>logger.error(String(err)))
-voidscheduleUpdateNudge(resolveProjectDir(ctx.args),command)
+awaitimport('./utils/engines').then(({ checkEngines })=>checkEngines()).catch(err=>logger.error(String(err)))
+voidimport('./utils/paths')
+.then(({ resolveProjectDir })=>scheduleUpdateNudge(resolveProjectDir(ctx.args),command))
 .catch(err=>debug('Failed to check for updates:',err))
 }
 

packages/nuxt-cli/test/unit/startup-checks.spec.ts

@@ -0,0 +1,48 @@
+importtype{CommandContext}from'citty'
+importtype{main}from'../../src/main'
+
+import{beforeEach,describe,expect,it,vi}from'vitest'
+
+constcheckEngines=vi.hoisted(()=>vi.fn(async()=>{}))
+constscheduleUpdateNudge=vi.hoisted(()=>vi.fn(async()=>{}))
+
+asyncfunctionsetup(argv: string[]): Promise<void>{
+vi.doMock('../../src/utils/engines',()=>({ checkEngines }))
+vi.doMock('../../src/utils/update-lazy',()=>({ scheduleUpdateNudge }))
+vi.doMock('../../src/commands',()=>({
+commands: {info: ()=>({meta: {name: 'info'},args: {},run: ()=>{}})},
+}))
+vi.resetModules()
+
+const{main: freshMain}=awaitimport('../../src/main')as{main: typeofmain}
+constcommand=argv.find(arg=>!arg.startsWith('-'))
+awaitfreshMain.setup!({
+rawArgs: argv,
+args: {_: command ? [command] : [],cwd: '.'},
+cmd: freshMain,
+data: {},
+}asunknownasCommandContext)
+
+awaitnewPromise(resolve=>setImmediate(resolve))
+}
+
+describe('startup checks',()=>{
+beforeEach(()=>{
+checkEngines.mockClear()
+scheduleUpdateNudge.mockClear()
+})
+
+it('should run for a command',async()=>{
+awaitsetup(['info'])
+
+expect(checkEngines).toHaveBeenCalled()
+awaitvi.waitFor(()=>expect(scheduleUpdateNudge).toHaveBeenCalled())
+})
+
+it('should be skipped when no command is given',async()=>{
+awaitsetup(['--version'])
+
+expect(checkEngines).not.toHaveBeenCalled()
+expect(scheduleUpdateNudge).not.toHaveBeenCalled()
+})
+})