test: give servers under test a realistic startup budget

Author: danielroe

packages/nuxt-cli/test/e2e/commands.spec.ts

@@ -97,7 +97,7 @@ describe('commands', () => {
 })
 
 // Test that server responds
-constresponse=awaitfetchWithPolling(`http://127.0.0.1:${port}`,{},30,300)
+constresponse=awaitfetchWithPolling(`http://127.0.0.1:${port}`)
 expect.soft(response?.status).toBe(200)
 
 controller.abort()
@@ -190,7 +190,7 @@ describe('extends support', () => {
 })
 
 // Test that server responds
-constresponse=awaitfetchWithPolling(`http://127.0.0.1:${port}/extended`,{},30,300)
+constresponse=awaitfetchWithPolling(`http://127.0.0.1:${port}/extended`)
 expect.soft(response?.status).toBe(200)
 expect(awaitresponse?.text()).toContain('This is an extended page from a layer.')
 

packages/nuxt-cli/test/utils/index.ts

@@ -3,10 +3,16 @@ import { join, sep } from 'node:path'
 import{fileURLToPath}from'node:url'
 import{isCI}from'std-env'
 
-exportasyncfunctionfetchWithPolling(url: string,options: RequestInit={},maxAttempts=10,interval=100): Promise<Response|null>{
+/**
+ * Poll `url` until it answers, allowing for a server that is still booting.
+ *
+ * The deadline is a wall-clock budget rather than an attempt count, so a slow
+ * machine gets the same number of seconds as a fast one.
+ */
+exportasyncfunctionfetchWithPolling(url: string,options: RequestInit={},timeout=isCI ? 120_000 : 30_000,interval=100): Promise<Response|null>{
+constdeadline=Date.now()+timeout
 letresponse: Response|null=null
-letattempts=0
-while(attempts<maxAttempts){
+do{
 try{
 response=awaitfetch(url,options)
 if(response.ok){
@@ -16,9 +22,8 @@ export async function fetchWithPolling(url: string, options: RequestInit = {}, m
 catch{
 // Ignore errors and retry
 }
-attempts++
-awaitnewPromise(resolve=>setTimeout(resolve,isCI ? interval*10 : interval))
-}
+awaitnewPromise(resolve=>setTimeout(resolve,interval))
+}while(Date.now()<deadline)
 returnresponse
 }