Part-of Closing-Keyword Guard

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it #4417

Sign in to view logs

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it #4417

Workflow file for this run

.github/workflows/partof-closing-keyword-guard.yml at 374de16
# A PR that declares itself only `Part of #N` must not also tell GitHub to
# close `#N`. GitHub's closing-keyword parser matches the keyword plus the
# number and ignores the surrounding prose entirely — negations and modals
# included — so the sentence an author writes to PREVENT an auto-close is
# exactly what performs it on merge. That happened: a half-delivered card was
# closed `completed` two seconds after its PR merged, by its own warning
# sentence, and a closed card reads as finished, so it was found only by a
# post-merge inventory re-pull. The author wrote the warning correctly and
# still lost the card, which is why this is mechanical and not advice.
#
# The rule, the wording of the failure, and the code-stripping this depends on
# all live in `scripts/check-partof-closing-keyword.mjs` and the predicate it
# reuses; that header is authoritative, this file is the invocation.
#
# Sibling shape, deliberately copied rather than reinvented: the Duplicate Fix
# Guard is this repo's other PR-body-scoped blocking check, and it takes the
# same trigger set for the same measured reason.
name: Part-of Closing-Keyword Guard
# `edited` is load-bearing, not decoration. The body is this check's whole
# input, and GitHub does not re-deliver a `pull_request` event when a body
# changes under any other activity type — while `rerun_failed_jobs` replays the
# frozen payload, so a re-run of a fixed body stays red forever. With `edited`
# subscribed, rewording the sentence fires a fresh event carrying the fresh
# body and the check goes green with no push and no re-run.
#
# No `merge_group:` trigger, and that is not an oversight: a merge-queue event
# carries no pull request and therefore no body, so this check has nothing to
# judge there. That also keeps it out of the required-context registry, whose
# entries must report on queue builds; see the script header on where branch
# protection fits.
on:
pull_request:
types: [opened, edited, reopened, synchronize]
permissions:
contents: read
concurrency:
group: partof-closing-keyword-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
partof-closing-keyword:
name: Part-of PR must not also close its card
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v7
# Pinned to the same major and spelling as every other setup-node in this
# repo, and for a measured reason rather than tidiness. The first draft of
# this file used `actions/setup-node@v5` with `node-version-file`, and the
# job died IN THIS STEP, before the script ever ran:
#
# ##[error]Unable to locate executable file: pnpm.
#
# v5 defaults `package-manager-cache: true` (the run log echoes it as an
# input), which reads `packageManager: pnpm@...` out of package.json and
# shells out to pnpm to locate the store to cache. This job installs no
# package manager on purpose — the script is dependency-free and imports
# one sibling module — so pnpm is not on PATH and the action hard-errors.
# The failure is worth naming because nothing in the step that failed
# mentions pnpm: it is an implicit default of the action, invisible in the
# workflow source, and the misleading first read is that the `run:` line
# below invoked a package manager. It does not, and never did.
#
# The check-links workflow's ADR-links job is the known-good shape this
# now matches exactly: checkout, setup-node, one `node scripts/check-*.mjs`
# call, no install and no corepack. It is green on this repo today.
- name: Setup Node.js
uses: actions/setup-node@v7
with:
node-version: '22'
# The body reaches the script through `env:`, never through `${{ }}`
# inside the `run:` script. An expression interpolated into a shell line
# is substituted before bash ever sees it, so a PR body is arbitrary
# attacker-controlled text landing in a command; through `env:` it is
# inert data. The script's self-test pins this spelling.
#
# `PR_NUMBER` is not only for the message: GitHub renders a null body as
# an EMPTY value, so it is the witness that separates "this PR has an
# empty body" (a real, clean verdict) from "this step was handed nothing"
# (a wiring failure, which exits 2 and says so).
#
# No install step: the script imports one sibling module and reads no
# workspace package, so `node` on the pinned runtime is the whole
# toolchain it needs.
- name: A Part-of PR body may not carry a closing keyword for the same card
env:
PR_BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: node scripts/check-partof-closing-keyword.mjs
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
 Part-of Closing-Keyword Guard

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it
#4417
Sign in to view logs

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it


fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it #4417
Workflow file for this run

.github/workflows/partof-closing-keyword-guard.yml
 at
374de16
# A PR that declares itself only `Part of #N` must not also tell GitHub to
# close `#N`. GitHub's closing-keyword parser matches the keyword plus the
# number and ignores the surrounding prose entirely — negations and modals
# included — so the sentence an author writes to PREVENT an auto-close is
# exactly what performs it on merge. That happened: a half-delivered card was
# closed `completed` two seconds after its PR merged, by its own warning
# sentence, and a closed card reads as finished, so it was found only by a
# post-merge inventory re-pull. The author wrote the warning correctly and
# still lost the card, which is why this is mechanical and not advice.
#
# The rule, the wording of the failure, and the code-stripping this depends on
# all live in `scripts/check-partof-closing-keyword.mjs` and the predicate it
# reuses; that header is authoritative, this file is the invocation.
#
# Sibling shape, deliberately copied rather than reinvented: the Duplicate Fix
# Guard is this repo's other PR-body-scoped blocking check, and it takes the
# same trigger set for the same measured reason.
name: Part-of Closing-Keyword Guard
# `edited` is load-bearing, not decoration. The body is this check's whole
# input, and GitHub does not re-deliver a `pull_request` event when a body
# changes under any other activity type — while `rerun_failed_jobs` replays the
# frozen payload, so a re-run of a fixed body stays red forever. With `edited`
# subscribed, rewording the sentence fires a fresh event carrying the fresh
# body and the check goes green with no push and no re-run.
#
# No `merge_group:` trigger, and that is not an oversight: a merge-queue event
# carries no pull request and therefore no body, so this check has nothing to
# judge there. That also keeps it out of the required-context registry, whose
# entries must report on queue builds; see the script header on where branch
# protection fits.
on:
pull_request:
types: [opened, edited, reopened, synchronize]
permissions:
contents: read
concurrency:
group: partof-closing-keyword-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
partof-closing-keyword:
name: Part-of PR must not also close its card
runs-on: ubuntu-latest
steps:
 - name: Checkout repository
uses: actions/checkout@v7
# Pinned to the same major and spelling as every other setup-node in this
# repo, and for a measured reason rather than tidiness. The first draft of
# this file used `actions/setup-node@v5` with `node-version-file`, and the
# job died IN THIS STEP, before the script ever ran:
#
# ##[error]Unable to locate executable file: pnpm.
#
# v5 defaults `package-manager-cache: true` (the run log echoes it as an
# input), which reads `packageManager: pnpm@...` out of package.json and
# shells out to pnpm to locate the store to cache. This job installs no
# package manager on purpose — the script is dependency-free and imports
# one sibling module — so pnpm is not on PATH and the action hard-errors.
# The failure is worth naming because nothing in the step that failed
# mentions pnpm: it is an implicit default of the action, invisible in the
# workflow source, and the misleading first read is that the `run:` line
# below invoked a package manager. It does not, and never did.
#
# The check-links workflow's ADR-links job is the known-good shape this
# now matches exactly: checkout, setup-node, one `node scripts/check-*.mjs`
# call, no install and no corepack. It is green on this repo today.
 - name: Setup Node.js
uses: actions/setup-node@v7
with:
node-version: '22'
# The body reaches the script through `env:`, never through `${{ }}`
# inside the `run:` script. An expression interpolated into a shell line
# is substituted before bash ever sees it, so a PR body is arbitrary
# attacker-controlled text landing in a command; through `env:` it is
# inert data. The script's self-test pins this spelling.
#
# `PR_NUMBER` is not only for the message: GitHub renders a null body as
# an EMPTY value, so it is the witness that separates "this PR has an
# empty body" (a real, clean verdict) from "this step was handed nothing"
# (a wiring failure, which exits 2 and says so).
#
# No install step: the script imports one sibling module and reads no
# workspace package, so `node` on the pinned runtime is the whole
# toolchain it needs.
 - name: A Part-of PR body may not carry a closing keyword for the same card
env:
PR_BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: node scripts/check-partof-closing-keyword.mjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
 Part-of Closing-Keyword Guard

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it
#4417
Sign in to view logs

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it


fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it #4417
Workflow file for this run

.github/workflows/partof-closing-keyword-guard.yml
 at
374de16
# A PR that declares itself only `Part of #N` must not also tell GitHub to
# close `#N`. GitHub's closing-keyword parser matches the keyword plus the
# number and ignores the surrounding prose entirely — negations and modals
# included — so the sentence an author writes to PREVENT an auto-close is
# exactly what performs it on merge. That happened: a half-delivered card was
# closed `completed` two seconds after its PR merged, by its own warning
# sentence, and a closed card reads as finished, so it was found only by a
# post-merge inventory re-pull. The author wrote the warning correctly and
# still lost the card, which is why this is mechanical and not advice.
#
# The rule, the wording of the failure, and the code-stripping this depends on
# all live in `scripts/check-partof-closing-keyword.mjs` and the predicate it
# reuses; that header is authoritative, this file is the invocation.
#
# Sibling shape, deliberately copied rather than reinvented: the Duplicate Fix
# Guard is this repo's other PR-body-scoped blocking check, and it takes the
# same trigger set for the same measured reason.
name: Part-of Closing-Keyword Guard
# `edited` is load-bearing, not decoration. The body is this check's whole
# input, and GitHub does not re-deliver a `pull_request` event when a body
# changes under any other activity type — while `rerun_failed_jobs` replays the
# frozen payload, so a re-run of a fixed body stays red forever. With `edited`
# subscribed, rewording the sentence fires a fresh event carrying the fresh
# body and the check goes green with no push and no re-run.
#
# No `merge_group:` trigger, and that is not an oversight: a merge-queue event
# carries no pull request and therefore no body, so this check has nothing to
# judge there. That also keeps it out of the required-context registry, whose
# entries must report on queue builds; see the script header on where branch
# protection fits.
on:
pull_request:
types: [opened, edited, reopened, synchronize]
permissions:
contents: read
concurrency:
group: partof-closing-keyword-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
partof-closing-keyword:
name: Part-of PR must not also close its card
runs-on: ubuntu-latest
steps:
 - name: Checkout repository
uses: actions/checkout@v7
# Pinned to the same major and spelling as every other setup-node in this
# repo, and for a measured reason rather than tidiness. The first draft of
# this file used `actions/setup-node@v5` with `node-version-file`, and the
# job died IN THIS STEP, before the script ever ran:
#
# ##[error]Unable to locate executable file: pnpm.
#
# v5 defaults `package-manager-cache: true` (the run log echoes it as an
# input), which reads `packageManager: pnpm@...` out of package.json and
# shells out to pnpm to locate the store to cache. This job installs no
# package manager on purpose — the script is dependency-free and imports
# one sibling module — so pnpm is not on PATH and the action hard-errors.
# The failure is worth naming because nothing in the step that failed
# mentions pnpm: it is an implicit default of the action, invisible in the
# workflow source, and the misleading first read is that the `run:` line
# below invoked a package manager. It does not, and never did.
#
# The check-links workflow's ADR-links job is the known-good shape this
# now matches exactly: checkout, setup-node, one `node scripts/check-*.mjs`
# call, no install and no corepack. It is green on this repo today.
 - name: Setup Node.js
uses: actions/setup-node@v7
with:
node-version: '22'
# The body reaches the script through `env:`, never through `${{ }}`
# inside the `run:` script. An expression interpolated into a shell line
# is substituted before bash ever sees it, so a PR body is arbitrary
# attacker-controlled text landing in a command; through `env:` it is
# inert data. The script's self-test pins this spelling.
#
# `PR_NUMBER` is not only for the message: GitHub renders a null body as
# an EMPTY value, so it is the witness that separates "this PR has an
# empty body" (a real, clean verdict) from "this step was handed nothing"
# (a wiring failure, which exits 2 and says so).
#
# No install step: the script imports one sibling module and reads no
# workspace package, so `node` on the pinned runtime is the whole
# toolchain it needs.
 - name: A Part-of PR body may not carry a closing keyword for the same card
env:
PR_BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: node scripts/check-partof-closing-keyword.mjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
 Part-of Closing-Keyword Guard

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it
#4417
Sign in to view logs

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it


fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it #4417
Workflow file for this run

.github/workflows/partof-closing-keyword-guard.yml
 at
374de16
# A PR that declares itself only `Part of #N` must not also tell GitHub to
# close `#N`. GitHub's closing-keyword parser matches the keyword plus the
# number and ignores the surrounding prose entirely — negations and modals
# included — so the sentence an author writes to PREVENT an auto-close is
# exactly what performs it on merge. That happened: a half-delivered card was
# closed `completed` two seconds after its PR merged, by its own warning
# sentence, and a closed card reads as finished, so it was found only by a
# post-merge inventory re-pull. The author wrote the warning correctly and
# still lost the card, which is why this is mechanical and not advice.
#
# The rule, the wording of the failure, and the code-stripping this depends on
# all live in `scripts/check-partof-closing-keyword.mjs` and the predicate it
# reuses; that header is authoritative, this file is the invocation.
#
# Sibling shape, deliberately copied rather than reinvented: the Duplicate Fix
# Guard is this repo's other PR-body-scoped blocking check, and it takes the
# same trigger set for the same measured reason.
name: Part-of Closing-Keyword Guard
# `edited` is load-bearing, not decoration. The body is this check's whole
# input, and GitHub does not re-deliver a `pull_request` event when a body
# changes under any other activity type — while `rerun_failed_jobs` replays the
# frozen payload, so a re-run of a fixed body stays red forever. With `edited`
# subscribed, rewording the sentence fires a fresh event carrying the fresh
# body and the check goes green with no push and no re-run.
#
# No `merge_group:` trigger, and that is not an oversight: a merge-queue event
# carries no pull request and therefore no body, so this check has nothing to
# judge there. That also keeps it out of the required-context registry, whose
# entries must report on queue builds; see the script header on where branch
# protection fits.
on:
pull_request:
types: [opened, edited, reopened, synchronize]
permissions:
contents: read
concurrency:
group: partof-closing-keyword-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
partof-closing-keyword:
name: Part-of PR must not also close its card
runs-on: ubuntu-latest
steps:
 - name: Checkout repository
uses: actions/checkout@v7
# Pinned to the same major and spelling as every other setup-node in this
# repo, and for a measured reason rather than tidiness. The first draft of
# this file used `actions/setup-node@v5` with `node-version-file`, and the
# job died IN THIS STEP, before the script ever ran:
#
# ##[error]Unable to locate executable file: pnpm.
#
# v5 defaults `package-manager-cache: true` (the run log echoes it as an
# input), which reads `packageManager: pnpm@...` out of package.json and
# shells out to pnpm to locate the store to cache. This job installs no
# package manager on purpose — the script is dependency-free and imports
# one sibling module — so pnpm is not on PATH and the action hard-errors.
# The failure is worth naming because nothing in the step that failed
# mentions pnpm: it is an implicit default of the action, invisible in the
# workflow source, and the misleading first read is that the `run:` line
# below invoked a package manager. It does not, and never did.
#
# The check-links workflow's ADR-links job is the known-good shape this
# now matches exactly: checkout, setup-node, one `node scripts/check-*.mjs`
# call, no install and no corepack. It is green on this repo today.
 - name: Setup Node.js
uses: actions/setup-node@v7
with:
node-version: '22'
# The body reaches the script through `env:`, never through `${{ }}`
# inside the `run:` script. An expression interpolated into a shell line
# is substituted before bash ever sees it, so a PR body is arbitrary
# attacker-controlled text landing in a command; through `env:` it is
# inert data. The script's self-test pins this spelling.
#
# `PR_NUMBER` is not only for the message: GitHub renders a null body as
# an EMPTY value, so it is the witness that separates "this PR has an
# empty body" (a real, clean verdict) from "this step was handed nothing"
# (a wiring failure, which exits 2 and says so).
#
# No install step: the script imports one sibling module and reads no
# workspace package, so `node` on the pinned runtime is the whole
# toolchain it needs.
 - name: A Part-of PR body may not carry a closing keyword for the same card
env:
PR_BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: node scripts/check-partof-closing-keyword.mjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
 Part-of Closing-Keyword Guard

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it
#4417
Sign in to view logs

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it


fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it #4417
Workflow file for this run

.github/workflows/partof-closing-keyword-guard.yml
 at
374de16
# A PR that declares itself only `Part of #N` must not also tell GitHub to
# close `#N`. GitHub's closing-keyword parser matches the keyword plus the
# number and ignores the surrounding prose entirely — negations and modals
# included — so the sentence an author writes to PREVENT an auto-close is
# exactly what performs it on merge. That happened: a half-delivered card was
# closed `completed` two seconds after its PR merged, by its own warning
# sentence, and a closed card reads as finished, so it was found only by a
# post-merge inventory re-pull. The author wrote the warning correctly and
# still lost the card, which is why this is mechanical and not advice.
#
# The rule, the wording of the failure, and the code-stripping this depends on
# all live in `scripts/check-partof-closing-keyword.mjs` and the predicate it
# reuses; that header is authoritative, this file is the invocation.
#
# Sibling shape, deliberately copied rather than reinvented: the Duplicate Fix
# Guard is this repo's other PR-body-scoped blocking check, and it takes the
# same trigger set for the same measured reason.
name: Part-of Closing-Keyword Guard
# `edited` is load-bearing, not decoration. The body is this check's whole
# input, and GitHub does not re-deliver a `pull_request` event when a body
# changes under any other activity type — while `rerun_failed_jobs` replays the
# frozen payload, so a re-run of a fixed body stays red forever. With `edited`
# subscribed, rewording the sentence fires a fresh event carrying the fresh
# body and the check goes green with no push and no re-run.
#
# No `merge_group:` trigger, and that is not an oversight: a merge-queue event
# carries no pull request and therefore no body, so this check has nothing to
# judge there. That also keeps it out of the required-context registry, whose
# entries must report on queue builds; see the script header on where branch
# protection fits.
on:
pull_request:
types: [opened, edited, reopened, synchronize]
permissions:
contents: read
concurrency:
group: partof-closing-keyword-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
partof-closing-keyword:
name: Part-of PR must not also close its card
runs-on: ubuntu-latest
steps:
 - name: Checkout repository
uses: actions/checkout@v7
# Pinned to the same major and spelling as every other setup-node in this
# repo, and for a measured reason rather than tidiness. The first draft of
# this file used `actions/setup-node@v5` with `node-version-file`, and the
# job died IN THIS STEP, before the script ever ran:
#
# ##[error]Unable to locate executable file: pnpm.
#
# v5 defaults `package-manager-cache: true` (the run log echoes it as an
# input), which reads `packageManager: pnpm@...` out of package.json and
# shells out to pnpm to locate the store to cache. This job installs no
# package manager on purpose — the script is dependency-free and imports
# one sibling module — so pnpm is not on PATH and the action hard-errors.
# The failure is worth naming because nothing in the step that failed
# mentions pnpm: it is an implicit default of the action, invisible in the
# workflow source, and the misleading first read is that the `run:` line
# below invoked a package manager. It does not, and never did.
#
# The check-links workflow's ADR-links job is the known-good shape this
# now matches exactly: checkout, setup-node, one `node scripts/check-*.mjs`
# call, no install and no corepack. It is green on this repo today.
 - name: Setup Node.js
uses: actions/setup-node@v7
with:
node-version: '22'
# The body reaches the script through `env:`, never through `${{ }}`
# inside the `run:` script. An expression interpolated into a shell line
# is substituted before bash ever sees it, so a PR body is arbitrary
# attacker-controlled text landing in a command; through `env:` it is
# inert data. The script's self-test pins this spelling.
#
# `PR_NUMBER` is not only for the message: GitHub renders a null body as
# an EMPTY value, so it is the witness that separates "this PR has an
# empty body" (a real, clean verdict) from "this step was handed nothing"
# (a wiring failure, which exits 2 and says so).
#
# No install step: the script imports one sibling module and reads no
# workspace package, so `node` on the pinned runtime is the whole
# toolchain it needs.
 - name: A Part-of PR body may not carry a closing keyword for the same card
env:
PR_BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: node scripts/check-partof-closing-keyword.mjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
 Part-of Closing-Keyword Guard

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it
#4417
Sign in to view logs

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it


fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it #4417
Workflow file for this run

.github/workflows/partof-closing-keyword-guard.yml
 at
374de16
# A PR that declares itself only `Part of #N` must not also tell GitHub to
# close `#N`. GitHub's closing-keyword parser matches the keyword plus the
# number and ignores the surrounding prose entirely — negations and modals
# included — so the sentence an author writes to PREVENT an auto-close is
# exactly what performs it on merge. That happened: a half-delivered card was
# closed `completed` two seconds after its PR merged, by its own warning
# sentence, and a closed card reads as finished, so it was found only by a
# post-merge inventory re-pull. The author wrote the warning correctly and
# still lost the card, which is why this is mechanical and not advice.
#
# The rule, the wording of the failure, and the code-stripping this depends on
# all live in `scripts/check-partof-closing-keyword.mjs` and the predicate it
# reuses; that header is authoritative, this file is the invocation.
#
# Sibling shape, deliberately copied rather than reinvented: the Duplicate Fix
# Guard is this repo's other PR-body-scoped blocking check, and it takes the
# same trigger set for the same measured reason.
name: Part-of Closing-Keyword Guard
# `edited` is load-bearing, not decoration. The body is this check's whole
# input, and GitHub does not re-deliver a `pull_request` event when a body
# changes under any other activity type — while `rerun_failed_jobs` replays the
# frozen payload, so a re-run of a fixed body stays red forever. With `edited`
# subscribed, rewording the sentence fires a fresh event carrying the fresh
# body and the check goes green with no push and no re-run.
#
# No `merge_group:` trigger, and that is not an oversight: a merge-queue event
# carries no pull request and therefore no body, so this check has nothing to
# judge there. That also keeps it out of the required-context registry, whose
# entries must report on queue builds; see the script header on where branch
# protection fits.
on:
pull_request:
types: [opened, edited, reopened, synchronize]
permissions:
contents: read
concurrency:
group: partof-closing-keyword-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
partof-closing-keyword:
name: Part-of PR must not also close its card
runs-on: ubuntu-latest
steps:
 - name: Checkout repository
uses: actions/checkout@v7
# Pinned to the same major and spelling as every other setup-node in this
# repo, and for a measured reason rather than tidiness. The first draft of
# this file used `actions/setup-node@v5` with `node-version-file`, and the
# job died IN THIS STEP, before the script ever ran:
#
# ##[error]Unable to locate executable file: pnpm.
#
# v5 defaults `package-manager-cache: true` (the run log echoes it as an
# input), which reads `packageManager: pnpm@...` out of package.json and
# shells out to pnpm to locate the store to cache. This job installs no
# package manager on purpose — the script is dependency-free and imports
# one sibling module — so pnpm is not on PATH and the action hard-errors.
# The failure is worth naming because nothing in the step that failed
# mentions pnpm: it is an implicit default of the action, invisible in the
# workflow source, and the misleading first read is that the `run:` line
# below invoked a package manager. It does not, and never did.
#
# The check-links workflow's ADR-links job is the known-good shape this
# now matches exactly: checkout, setup-node, one `node scripts/check-*.mjs`
# call, no install and no corepack. It is green on this repo today.
 - name: Setup Node.js
uses: actions/setup-node@v7
with:
node-version: '22'
# The body reaches the script through `env:`, never through `${{ }}`
# inside the `run:` script. An expression interpolated into a shell line
# is substituted before bash ever sees it, so a PR body is arbitrary
# attacker-controlled text landing in a command; through `env:` it is
# inert data. The script's self-test pins this spelling.
#
# `PR_NUMBER` is not only for the message: GitHub renders a null body as
# an EMPTY value, so it is the witness that separates "this PR has an
# empty body" (a real, clean verdict) from "this step was handed nothing"
# (a wiring failure, which exits 2 and says so).
#
# No install step: the script imports one sibling module and reads no
# workspace package, so `node` on the pinned runtime is the whole
# toolchain it needs.
 - name: A Part-of PR body may not carry a closing keyword for the same card
env:
PR_BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: node scripts/check-partof-closing-keyword.mjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
 Part-of Closing-Keyword Guard

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it
#4417
Sign in to view logs

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it


fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it #4417
Workflow file for this run

.github/workflows/partof-closing-keyword-guard.yml
 at
374de16
# A PR that declares itself only `Part of #N` must not also tell GitHub to
# close `#N`. GitHub's closing-keyword parser matches the keyword plus the
# number and ignores the surrounding prose entirely — negations and modals
# included — so the sentence an author writes to PREVENT an auto-close is
# exactly what performs it on merge. That happened: a half-delivered card was
# closed `completed` two seconds after its PR merged, by its own warning
# sentence, and a closed card reads as finished, so it was found only by a
# post-merge inventory re-pull. The author wrote the warning correctly and
# still lost the card, which is why this is mechanical and not advice.
#
# The rule, the wording of the failure, and the code-stripping this depends on
# all live in `scripts/check-partof-closing-keyword.mjs` and the predicate it
# reuses; that header is authoritative, this file is the invocation.
#
# Sibling shape, deliberately copied rather than reinvented: the Duplicate Fix
# Guard is this repo's other PR-body-scoped blocking check, and it takes the
# same trigger set for the same measured reason.
name: Part-of Closing-Keyword Guard
# `edited` is load-bearing, not decoration. The body is this check's whole
# input, and GitHub does not re-deliver a `pull_request` event when a body
# changes under any other activity type — while `rerun_failed_jobs` replays the
# frozen payload, so a re-run of a fixed body stays red forever. With `edited`
# subscribed, rewording the sentence fires a fresh event carrying the fresh
# body and the check goes green with no push and no re-run.
#
# No `merge_group:` trigger, and that is not an oversight: a merge-queue event
# carries no pull request and therefore no body, so this check has nothing to
# judge there. That also keeps it out of the required-context registry, whose
# entries must report on queue builds; see the script header on where branch
# protection fits.
on:
pull_request:
types: [opened, edited, reopened, synchronize]
permissions:
contents: read
concurrency:
group: partof-closing-keyword-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
partof-closing-keyword:
name: Part-of PR must not also close its card
runs-on: ubuntu-latest
steps:
 - name: Checkout repository
uses: actions/checkout@v7
# Pinned to the same major and spelling as every other setup-node in this
# repo, and for a measured reason rather than tidiness. The first draft of
# this file used `actions/setup-node@v5` with `node-version-file`, and the
# job died IN THIS STEP, before the script ever ran:
#
# ##[error]Unable to locate executable file: pnpm.
#
# v5 defaults `package-manager-cache: true` (the run log echoes it as an
# input), which reads `packageManager: pnpm@...` out of package.json and
# shells out to pnpm to locate the store to cache. This job installs no
# package manager on purpose — the script is dependency-free and imports
# one sibling module — so pnpm is not on PATH and the action hard-errors.
# The failure is worth naming because nothing in the step that failed
# mentions pnpm: it is an implicit default of the action, invisible in the
# workflow source, and the misleading first read is that the `run:` line
# below invoked a package manager. It does not, and never did.
#
# The check-links workflow's ADR-links job is the known-good shape this
# now matches exactly: checkout, setup-node, one `node scripts/check-*.mjs`
# call, no install and no corepack. It is green on this repo today.
 - name: Setup Node.js
uses: actions/setup-node@v7
with:
node-version: '22'
# The body reaches the script through `env:`, never through `${{ }}`
# inside the `run:` script. An expression interpolated into a shell line
# is substituted before bash ever sees it, so a PR body is arbitrary
# attacker-controlled text landing in a command; through `env:` it is
# inert data. The script's self-test pins this spelling.
#
# `PR_NUMBER` is not only for the message: GitHub renders a null body as
# an EMPTY value, so it is the witness that separates "this PR has an
# empty body" (a real, clean verdict) from "this step was handed nothing"
# (a wiring failure, which exits 2 and says so).
#
# No install step: the script imports one sibling module and reads no
# workspace package, so `node` on the pinned runtime is the whole
# toolchain it needs.
 - name: A Part-of PR body may not carry a closing keyword for the same card
env:
PR_BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: node scripts/check-partof-closing-keyword.mjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
 Part-of Closing-Keyword Guard

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it
#4417
Sign in to view logs

fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it


fix(plugin-sharing): guard the record-share $in against a nullish record_id before String() coerces it #4417
Workflow file for this run

.github/workflows/partof-closing-keyword-guard.yml
 at
374de16
# A PR that declares itself only `Part of #N` must not also tell GitHub to
# close `#N`. GitHub's closing-keyword parser matches the keyword plus the
# number and ignores the surrounding prose entirely — negations and modals
# included — so the sentence an author writes to PREVENT an auto-close is
# exactly what performs it on merge. That happened: a half-delivered card was
# closed `completed` two seconds after its PR merged, by its own warning
# sentence, and a closed card reads as finished, so it was found only by a
# post-merge inventory re-pull. The author wrote the warning correctly and
# still lost the card, which is why this is mechanical and not advice.
#
# The rule, the wording of the failure, and the code-stripping this depends on
# all live in `scripts/check-partof-closing-keyword.mjs` and the predicate it
# reuses; that header is authoritative, this file is the invocation.
#
# Sibling shape, deliberately copied rather than reinvented: the Duplicate Fix
# Guard is this repo's other PR-body-scoped blocking check, and it takes the
# same trigger set for the same measured reason.
name: Part-of Closing-Keyword Guard
# `edited` is load-bearing, not decoration. The body is this check's whole
# input, and GitHub does not re-deliver a `pull_request` event when a body
# changes under any other activity type — while `rerun_failed_jobs` replays the
# frozen payload, so a re-run of a fixed body stays red forever. With `edited`
# subscribed, rewording the sentence fires a fresh event carrying the fresh
# body and the check goes green with no push and no re-run.
#
# No `merge_group:` trigger, and that is not an oversight: a merge-queue event
# carries no pull request and therefore no body, so this check has nothing to
# judge there. That also keeps it out of the required-context registry, whose
# entries must report on queue builds; see the script header on where branch
# protection fits.
on:
pull_request:
types: [opened, edited, reopened, synchronize]
permissions:
contents: read
concurrency:
group: partof-closing-keyword-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
partof-closing-keyword:
name: Part-of PR must not also close its card
runs-on: ubuntu-latest
steps:
 - name: Checkout repository
uses: actions/checkout@v7
# Pinned to the same major and spelling as every other setup-node in this
# repo, and for a measured reason rather than tidiness. The first draft of
# this file used `actions/setup-node@v5` with `node-version-file`, and the
# job died IN THIS STEP, before the script ever ran:
#
# ##[error]Unable to locate executable file: pnpm.
#
# v5 defaults `package-manager-cache: true` (the run log echoes it as an
# input), which reads `packageManager: pnpm@...` out of package.json and
# shells out to pnpm to locate the store to cache. This job installs no
# package manager on purpose — the script is dependency-free and imports
# one sibling module — so pnpm is not on PATH and the action hard-errors.
# The failure is worth naming because nothing in the step that failed
# mentions pnpm: it is an implicit default of the action, invisible in the
# workflow source, and the misleading first read is that the `run:` line
# below invoked a package manager. It does not, and never did.
#
# The check-links workflow's ADR-links job is the known-good shape this
# now matches exactly: checkout, setup-node, one `node scripts/check-*.mjs`
# call, no install and no corepack. It is green on this repo today.
 - name: Setup Node.js
uses: actions/setup-node@v7
with:
node-version: '22'
# The body reaches the script through `env:`, never through `${{ }}`
# inside the `run:` script. An expression interpolated into a shell line
# is substituted before bash ever sees it, so a PR body is arbitrary
# attacker-controlled text landing in a command; through `env:` it is
# inert data. The script's self-test pins this spelling.
#
# `PR_NUMBER` is not only for the message: GitHub renders a null body as
# an EMPTY value, so it is the witness that separates "this PR has an
# empty body" (a real, clean verdict) from "this step was handed nothing"
# (a wiring failure, which exits 2 and says so).
#
# No install step: the script imports one sibling module and reads no
# workspace package, so `node` on the pinned runtime is the whole
# toolchain it needs.
 - name: A Part-of PR body may not carry a closing keyword for the same card
env:
PR_BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: node scripts/check-partof-closing-keyword.mjs