From db4d84abb18dc8a9da9a9cbdfbc560b9893b46df Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 2 Sep 2026 10:29:21 +0000 Subject: [PATCH] docs(ci): stop hard-coding hook self-test deps in a comment The step comment claimed a fixed dependency set (jq + git only) for the whole "Claude hook guard self-tests" step, but the step discovers its matrices by glob (`find .claude/hooks -type f -name '*.selftest.sh'`), so a new matrix can legitimately need more than the two original ones did -- and one already does (guard-governed-enqueue.selftest.sh needs `node` for real, to run its two predicates). The comment never noticed; nothing catches that this prose fell out of date, since check:step-collectors cannot see this block (already admitted a few lines up). Rewrite the dependency sentence to say what is true of the STEP itself (jq + git, both already relied on bare elsewhere in this repo) plus whatever each discovered matrix declares in its own header -- because discovery is by glob, a matrix needing more must say so there, not here. Drop the stale "~2 s measured" figure along with it. No other line moves: step name, run: script, find discovery, and the rest of the "Hermetic by construction" paragraph are untouched. --- .github/workflows/lint.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 0ab076bdba..86e62ec2c9 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1343,9 +1343,12 @@ jobs: # own git repo and linked worktree under $TMPDIR, and both were re-run # from a primary checkout, a detached HEAD and a non-repo cwd with # identical results, so neither this checkout's depth nor its branch is an - # input. Needs `jq` and `git` and nothing else โ€” no pnpm, no node, no - # build, no network (`jq` is in the runner image and is already relied on - # bare by cut-rc.yml and release.yml). ~2 s measured. + # input. This step itself needs only `jq` and `git` (both in the runner + # image; `jq` is already relied on bare by cut-rc.yml and release.yml), + # plus whatever each discovered matrix declares in its own header โ€” + # discovery above is by glob, so a matrix needing more (node, pnpm, a + # built tree, a generator) must say so there; this comment is not the + # place to enumerate it. - name: Claude hook guard self-tests (worktree-first ยท stash ban) run: | # Tolerate-and-collect (#10814) โ€” see the note above this step. Each