From c55539c050f7b85ca64a97b8a7f92b1197148677 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 15 Aug 2026 09:18:43 +0000 Subject: [PATCH] docs(types): correct thrown-http-error.ts doc comment for #8634's re-point The TSDoc for ThrownHttpError.declaredStatus said the fallback-probe workaround (`resolveThrownHttpError(e, 0).status !== 0`) was "still spelled by hand in packages/rest's publish-classification suite". PR #8814 (closing #8634) re-pointed both call sites in that suite at `declaredStatus` directly, so the clause is now false. Corrected it to name the current call-site spelling instead. Fixes #8810 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01NaS1PAHJcPfAA2acnV53Tn --- packages/types/src/thrown-http-error.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/types/src/thrown-http-error.ts b/packages/types/src/thrown-http-error.ts index c0fd376785..e2c75518b8 100644 --- a/packages/types/src/thrown-http-error.ts +++ b/packages/types/src/thrown-http-error.ts @@ -85,10 +85,12 @@ export interface ThrownHttpError { * to `status: 500`, so a caller that must tell "the producer said so" from * "I supplied the default" cannot read it off the value. The workaround in * the repo was to probe this function with a fallback no producer declares - * — `resolveThrownHttpError(e, 0).status !== 0`, still spelled by hand in - * `packages/rest`'s publish-classification suite. That is a magic number + * — `resolveThrownHttpError(e, 0).status !== 0`. That is a magic number * standing in for a fact this function already computed, and it fails - * silently the day a producer declares the sentinel. So the fact is stated. + * silently the day a producer declares the sentinel. So the fact is stated; + * `packages/rest`'s publish-classification suite now reads + * `resolveThrownHttpError(error).declaredStatus !== undefined` instead of + * hand-spelling the workaround. * * ## Who needs the distinction *