From fe920978a2ce1cb1bf245c3e3ca73ca5f439105f Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 15 Aug 2026 11:41:35 +0000 Subject: [PATCH] docs(platform-objects): refresh stale pages.* exclusion comment app-nav-translation-parity.test.ts's block comment above the default-locale describe still said pages.* had "no source comparison in ANY locale" and tracked the gap as #8764. PR #8826 closed that: check:app-nav-i18n (packages/cli/scripts/check-app-nav-i18n.mjs) now asserts the `en` copy of pages.* against the composed page metadata verbatim. Keep the structural explanation (the sources live in packages platform-objects must not depend on), replace the stale sentence with a pointer to the gate that now covers it, retire the closed-issue forward reference, and state plainly what still isn't covered: per-locale (zh-CN / ja-JP / es-ES) coverage of those pages.* keys remains unasserted anywhere in the repo. Comment-only change; no behaviour, gate, or test-count change. Fixes #8828 --- .../app-nav-translation-parity.test.ts | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/packages/platform-objects/src/apps/translations/app-nav-translation-parity.test.ts b/packages/platform-objects/src/apps/translations/app-nav-translation-parity.test.ts index a218480c05..e03a88d953 100644 --- a/packages/platform-objects/src/apps/translations/app-nav-translation-parity.test.ts +++ b/packages/platform-objects/src/apps/translations/app-nav-translation-parity.test.ts @@ -182,11 +182,15 @@ describe('dashboard widgets are translated in every locale', () => { // `pages.*` is out of the walk on purpose: those entries mirror page metadata // authored in OTHER packages (@objectstack/cloud-connection, @objectstack/mcp), // which this package does not import and must not depend on to run its tests. -// That leaves the third of this bundle with no source comparison in ANY locale, -// `en` included — the same shape as the defect above, one section over, and a -// static walk in this package cannot close it. Tracked as #8764; the gate that -// can see those pages is `check:app-nav-i18n`, which already boots the real -// composition. All three were in parity when this block was written. +// A static walk in this package cannot close that gap; where it IS covered +// is `pnpm check:app-nav-i18n` (`packages/cli/scripts/check-app-nav-i18n.mjs`), +// which boots the real composition and asserts the `en` copy of `pages.*` — +// label, description, and every `page:header` title/subtitle — against the +// composed page metadata, verbatim: the same default-locale content claim +// this block makes for `apps.*` and `dashboards.*`, one section over. +// Default locale only: per-locale coverage of those `pages.*` keys in +// `zh-CN` / `ja-JP` / `es-ES` remains unasserted anywhere in this repo. All +// three were in parity when this block was written. describe('the default locale bundle serves the declared source string verbatim', () => { type Drift = { path: string; source: string; en: string | undefined };