Uh oh!
There was an error while loading. Please reload this page.
feat: Base data structures fot hook implementation. - #112
Conversation
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds the ChangesNew Type Definitions
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
There was a problem hiding this comment.
Pull request overview
Adds foundational public types to support a future Hooks implementation in the OpenFeature C++ SDK, aligning with Issue #111’s “Hook hints” portion and preparing for later HookData/EvaluationOptions work.
Changes:
- Introduces
HookHintsas astd::unordered_map<std::string, std::any>type alias. - Introduces
FlagValueTypeenum to represent supported flag value categories.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| openfeature/hook_hints.h | Adds the HookHints type alias for passing arbitrary hook hint data. |
| openfeature/flag_type_value.h | Adds the FlagValueType enum for flag value categorization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Uh oh!
There was an error while loading. Please reload this page.
🤖 I have created a release *beep* *boop* --- ## [0.1.2](v0.1.1...v0.1.2) (2026-07-14) ### Features * Add HookContext class ([#115](#115)) ([ec5a971](ec5a971)) * Add HookData class. ([#114](#114)) ([fdac1e0](fdac1e0)) * Base data structures fot hook implementation. ([#112](#112)) ([91d1b13](91d1b13)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
This PR
Introduces HookHints and FlagTypeValus that will allow later implementation of Hooks.
Related Issues
Fixes#111
Follow-up Tasks
Implementing the EvaluationOptions and HookData.