Uh oh!
There was an error while loading. Please reload this page.
feat: Overload client functions - #129
Conversation
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthrough
ChangesEvaluationOptions evaluation support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Features
participant ClientAPI
participant EvaluateFlag
participant ProviderCallback
Features->>ClientAPI: request flag value with EvaluationOptions
ClientAPI->>EvaluateFlag: pass context and options
EvaluateFlag->>ProviderCallback: dispatch typed evaluation with options
ProviderCallback-->>ClientAPI: return evaluation result
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
…verload_client_functions
Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openfeature/client_api.h`:
- Around line 102-109: Remove one duplicate declaration set for AddHooks,
AddHook, and GetHooks in ClientAPI, retaining exactly one declaration of each
method with its existing signatures and override specifiers.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 72258ec3-7646-44db-9ace-43f58c46c062
📒 Files selected for processing (5)
openfeature/BUILDopenfeature/client_api.cppopenfeature/client_api.hopenfeature/features.htest/client_api_test.cpp
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Uh oh!
There was an error while loading. Please reload this page.
This PR
EvaluationOptionsoverloads for all typed flag evaluation methods (GetBooleanValue,GetStringValue,GetIntegerValue,GetDoubleValue,GetObjectValue) in theFeaturesinterface andClientAPIimplementation per OpenFeature Specification Requirements 1.3.1.1 and 1.5.1.(flag_key, default_value, options)and(flag_key, default_value, context, options)call signatures.ClientAPI::EvaluateFlagand private typed evaluation helpers to accept and propagatestd::optional<EvaluationOptions>.:evaluation_optionsdependency to the:featureslibrary target inopenfeature/BUILD.test/client_api_test.cppverifying each typed evaluation method withEvaluationOptionsand combinedEvaluationContext+EvaluationOptions.Related Issues
Fixes#128
Notes
options.hooks) and metadata hints (options.hook_hints) to individual evaluation calls.Follow-up Tasks
ClientAPI::EvaluateFlagto execute invocation-level hooks and propagateHookHints.Get*Details) returning `Flag