Skip to content

feat: Add basic env var provider - #276

Merged
aepfli merged 17 commits into
open-feature:mainfrom
chrfwow:add-env-var-provider
Jul 16, 2025
Merged

feat: Add basic env var provider#276
aepfli merged 17 commits into
open-feature:mainfrom
chrfwow:add-env-var-provider

Conversation

@chrfwow

Copy link
Copy Markdown

This PR

Adds a very basic implementation of an env var provider

Please make sure that the repo setup is correct.

Follow-up Tasks

If we want more advanced behaviour as in the java env var provider (env var name transformation, alternative env var access logic, ...) or more tests, this can be done in a follow up PR

Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow
chrfwow requested review from a team as code ownersJuly 4, 2025 09:09
@chrfwowchrfwow changed the title Add basic env var providerfeat: Add basic env var providerJul 4, 2025
christian.lutnik added 3 commits July 4, 2025 11:16
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@codecov

codecovBot commented Jul 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (144c725) to head (ce3fee1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #276 +/- ##
==========================================
+ Coverage 94.00% 94.21% +0.21% 
==========================================
Files 18 20 +2 Lines 984 1020 +36 ==========================================
+ Hits 925 961 +36 
Misses 59 59 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

christian.lutnik added 7 commits July 4, 2025 11:40
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Comment threadproviders/openfeature-provider-env-var/README.md Outdated
christian.lutnik added 2 commits July 7, 2025 12:50
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>

@toddbaerttoddbaert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm preemptively approving, but please consider this.

@gruebelgruebel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, just found some minor stuff.

@beeme1mr can you setup the release on pypi side?

Comment threadproviders/openfeature-provider-env-var/.python-version Outdated
Comment threadproviders/openfeature-provider-env-var/pyproject.toml Outdated
Comment threadproviders/openfeature-provider-env-var/pyproject.toml Outdated
christian.lutnik added 2 commits July 9, 2025 08:40
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>

@gruebelgruebel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I think everything looks good for an initial version 🍻

@alexandraoberaigneralexandraoberaigner left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! 🎉

@aepfli
aepfli merged commit 72e6bd3 into open-feature:mainJul 16, 2025
27 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@chrfwow@aepfli@toddbaert@gruebel@alexandraoberaigner