Skip to content

chore: use existing submodule version for e2e tests - #444

Merged
gruebel merged 2 commits into
mainfrom
use-submodule
Feb 12, 2025
Merged

chore: use existing submodule version for e2e tests#444
gruebel merged 2 commits into
mainfrom
use-submodule

Conversation

@beeme1mr

Copy link
Copy Markdown
Member

This PR

  • modifies the submodule set in the E2E tests to use the existing .gitmodule configuration.

Notes

The E2E tests will now use the submodule sha instead of pulling the latest. As a added benefit, Renovate should automagically open PRs when the spec repo is updated.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (2951eb2) to head (e2a95f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #444 +/- ##
=======================================
Coverage 97.71% 97.71% =======================================
Files 32 32 Lines 1621 1621 =======================================
Hits 1584 1584 Misses 37 37 
FlagCoverage Δ
unittests97.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment threadpyproject.toml

@gruebelgruebel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@gruebel
gruebel merged commit 5ae8571 into mainFeb 12, 2025
@gruebel
gruebel deleted the use-submodule branch December 6, 2025 22:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@beeme1mr@chrfwow@gruebel