Skip to content

chore: use keyword arguments, validate test - #446

Merged
beeme1mr merged 2 commits into
open-feature:mainfrom
leohoare:feature/position_to_keyword_arguments
Feb 13, 2025
Merged

chore: use keyword arguments, validate test#446
beeme1mr merged 2 commits into
open-feature:mainfrom
leohoare:feature/position_to_keyword_arguments

Conversation

@leohoare

Copy link
Copy Markdown
Contributor

This PR

Cleaning up some tech debt associated mentioned in this comment

  • Dynamically resolve based on keyword arguments
  • I wasn't able to find a configuration that worked on python 3.8/3.9 with mypy. I opted for ignoring the call-arg.
  • If we'd prefer not ignore the error and keep positional arguments, feel free to close the PR.

How to test

Standard testing (test, e2e, pre-commit)

Signed-off-by: leohoare <leo@insight.co>
@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (f907855) to head (82195f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #446 +/- ##
=======================================
Coverage 97.71% 97.72% =======================================
Files 32 32 Lines 1621 1623 +2 =======================================
+ Hits 1584 1586 +2 
Misses 37 37 
FlagCoverage Δ
unittests97.72% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beeme1mrbeeme1mr changed the title use keyword arguments, validate testchore: use keyword arguments, validate testFeb 12, 2025

@lukas-reininglukas-reining left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one question.

Comment threadopenfeature/client.py
@beeme1mr
beeme1mr merged commit f29c450 into open-feature:mainFeb 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@leohoare@beeme1mr@aepfli@chrfwow@gruebel@lukas-reining