From a3bf48d029d4e191a3cbdc1ce0c3b5456b9acb90 Mon Sep 17 00:00:00 2001
From: Oblivion <ehsan.sadroid@gmail.com>
Date: Thu, 17 Mar 2022 21:59:37 +0000
Subject: [PATCH] MetricStorage dtors

---
 .gitignore                                                   | 1 +
 sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/.gitignore b/.gitignore
index 8a55a4ca4a..87d2de3921 100644
--- a/.gitignore
+++ b/.gitignore
@@ -50,3 +50,4 @@
 /build
 
 tags
+.cache/clangd/*
diff --git a/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h b/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h
index fbff04c47f..a2fcb87679 100644
--- a/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h
+++ b/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h
@@ -24,6 +24,8 @@ class MetricStorage
       opentelemetry::sdk::instrumentationlibrary::InstrumentationLibrary *instrumentation_library,
       opentelemetry::sdk::resource::Resource *resource,
       nostd::function_ref<bool(MetricData &)> callback) noexcept = 0;
+
+  virtual ~MetricStorage() = default;
 };
 
 class WritableMetricStorage
@@ -38,6 +40,7 @@ class WritableMetricStorage
 
   virtual void RecordDouble(double value,
                             const opentelemetry::common::KeyValueIterable &attributes) noexcept = 0;
+  virtual ~WritableMetricStorage() = default;
 };
 
 class NoopMetricStorage : public MetricStorage