Skip to content

feat(api): add safety case retrieval - #3911

Merged
jbeckwith-oai merged 1 commit into
mainfrom
codex/safety-cases-5d985802-python
Sep 19, 2026
Merged

feat(api): add safety case retrieval#3911
jbeckwith-oai merged 1 commit into
mainfrom
codex/safety-cases-5d985802-python

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds support for retrieving safety case details by ID.

Changes

  • Add client.safety.cases.retrieve for retrieving a safety case by ID
  • Expose the case identifier, creation time, entity identifier, nullable reason, and warning or deactivation notice

@jbeckwith-oai
feat(api): add safety case retrieval
59f5755 
Adds support for retrieving safety case details by ID.

- Add client.safety.cases.retrieve for retrieving a safety case by ID
- Expose the case identifier, creation time, entity identifier, nullable reason, and warning or deactivation notice
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner September 19, 2026 16:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-19T16:12:32.044988Z 59f5755 PR opened
🔒 Security Review ✅ Completed 2026-09-19T16:12:33.520207Z 59f5755 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 10.985s for Python SDK PR #3911.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 175ms
tests/chat-completions-create.test.ts ✅ Passed 293ms
tests/chat-completions-stream.test.ts ✅ Passed 278ms
tests/files-content-binary.test.ts ✅ Passed 204ms
tests/files-create-multipart.test.ts ✅ Passed 237ms
tests/files-list-pagination.test.ts ✅ Passed 149ms
tests/initialize-config.test.ts ✅ Passed 146ms
tests/instance-isolation.test.ts ✅ Passed 197ms
tests/models-list.test.ts ✅ Passed 276ms
tests/responses-background-lifecycle.test.ts ✅ Passed 241ms
tests/responses-body-method-errors.test.ts ✅ Passed 327ms
tests/responses-cancel-timeout.test.ts ✅ Passed 210ms
tests/responses-cancel.test.ts ✅ Passed 202ms
tests/responses-compact-retries.test.ts ✅ Passed 477ms
tests/responses-compact.test.ts ✅ Passed 340ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 131ms
tests/responses-create-advanced.test.ts ✅ Passed 297ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.248s
tests/responses-create-errors.test.ts ✅ Passed 175ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 486ms
tests/responses-create-retries.test.ts ✅ Passed 241ms
tests/responses-create-stream-failures.test.ts ✅ Passed 221ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 243ms
tests/responses-create-stream-wire.test.ts ✅ Passed 3.178s
tests/responses-create-stream.test.ts ✅ Passed 239ms
tests/responses-create-terminal-states.test.ts ✅ Passed 248ms
tests/responses-create-timeout.test.ts ✅ Passed 232ms
tests/responses-create.test.ts ✅ Passed 258ms
tests/responses-delete.test.ts ✅ Passed 232ms
tests/responses-input-items-errors.test.ts ✅ Passed 488ms
tests/responses-input-items-list.test.ts ✅ Passed 298ms
tests/responses-input-items-options.test.ts ✅ Passed 286ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 239ms
tests/responses-input-tokens-count.test.ts ✅ Passed 266ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.247s
tests/responses-not-found-errors.test.ts ✅ Passed 268ms
tests/responses-parse.test.ts ✅ Passed 272ms
tests/responses-retrieve-retries.test.ts ✅ Passed 229ms
tests/responses-retrieve.test.ts ✅ Passed 293ms
tests/responses-stored-method-errors.test.ts ✅ Passed 607ms
tests/retry-behavior.test.ts ✅ Passed 3.072s
tests/sdk-error-shape.test.ts ✅ Passed 278ms

View OkTest run #35454113896

SDK merge (2845626bf009) · head (59f5755a8bdb) · base (6332577d3fb5) · OkTest (a0be4375e02d)

@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

47 mixed files remain; 0 existing customizations changed; 1 generated baselines changed.

Compared 6332577d3fb5 → 59f5755a8bdb. Generated baselines verified.

File Result Current custom patch
api.md Generated baseline changed +119 / −0
46 existing customizations unchanged
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/beta/agent_session_message.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response.py
  • src/openai/types/responses/response_function_web_search.py
  • src/openai/types/responses/response_function_web_search_param.py
  • src/openai/types/responses/responses_client_event.py
  • src/openai/types/responses/responses_client_event_param.py
  • src/openai/types/responses/tool.py

6 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35454130155 --repo openai/openai-python \
  --name castiron-custom-code-35454130155-1 --dir /tmp/castiron-custom-code-35454130155-1
git apply --stat /tmp/castiron-custom-code-35454130155-1/custom-code.patch
cat /tmp/castiron-custom-code-35454130155-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 6332577d3fb5f83f7f381a431460262f7192402d 59f5755a8bdbc0cbbab63be716620dfef1ced92c
python3 scripts/castiron/custom_code_report.py report \
  --base 6332577d3fb5f83f7f381a431460262f7192402d \
  --head 59f5755a8bdbc0cbbab63be716620dfef1ced92c --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-59f5755a8bdb
cat /tmp/castiron-custom-code-59f5755a8bdb/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

markstuart-oai
markstuart-oai approved these changes Sep 19, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 59f5755a8bdbc0cbbab63be716620dfef1ced92c. Reviewed the pinned change and shared SDK path, authentication, response and export handling. The new sync/async endpoint follows the existing safety resource patterns, with focused coverage for encoded IDs, ordinary-key auth, nullable responses and forward compatibility. No actionable findings.

Static review only; I did not run tests locally.

Hosted check runs at this head have passed or been skipped, and both commit-status checks pass. Some integrations have queued check suites without runs; I am not treating those as completed checks.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Sep 19, 2026
Merged via the queue into main with commit a87b938 Sep 19, 2026
26 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/safety-cases-5d985802-python branch September 19, 2026 16:42
@openai-sdks openai-sdks Bot mentioned this pull request Sep 19, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai