From 090e27c96745e9b38b1b98d7eae870ff3ba72670 Mon Sep 17 00:00:00 2001 From: curfew-marathon Date: Sun, 2 Aug 2026 11:28:59 -0400 Subject: [PATCH 1/2] fix: migrate transaction docs and examples to transactions() API Move the write mode-selection Javadoc in OpenFgaClient and the example projects off the double-negative disableTransactions(boolean) to the affirmative transactions()/isTransactionsEnabled() API. Also switch the internal write mode branch to !isTransactionsEnabled() so the SDK no longer calls its own soon-to-be-deprecated method. Behavior is unchanged. Test call sites that still use disableTransactions are intentionally left for the deprecation issue, which will migrate them and keep one back-compat test under @SuppressWarnings. Refs #368 --- .../main/java/dev/openfga/sdk/example/Example1.java | 2 +- .../kotlin/dev/openfga/sdk/example/KotlinExample1.kt | 2 +- .../java/dev/openfga/sdk/api/client/OpenFgaClient.java | 10 +++++----- .../java/dev/openfga/sdk/example/Example1.java | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/basic-examples/src/main/java/dev/openfga/sdk/example/Example1.java b/examples/basic-examples/src/main/java/dev/openfga/sdk/example/Example1.java index 97d0cfe0..8a2e27f6 100644 --- a/examples/basic-examples/src/main/java/dev/openfga/sdk/example/Example1.java +++ b/examples/basic-examples/src/main/java/dev/openfga/sdk/example/Example1.java @@ -117,7 +117,7 @@ public void run(String apiUrl) throws Exception { // relation )), new ClientWriteOptions() - .disableTransactions(true) + .transactions(false) .authorizationModelId(authorizationModel.getAuthorizationModelId())) .get(); System.out.println("Done Writing Tuples"); diff --git a/examples/basic-examples/src/main/kotlin/dev/openfga/sdk/example/KotlinExample1.kt b/examples/basic-examples/src/main/kotlin/dev/openfga/sdk/example/KotlinExample1.kt index 3e11bb3d..aeedb6bc 100644 --- a/examples/basic-examples/src/main/kotlin/dev/openfga/sdk/example/KotlinExample1.kt +++ b/examples/basic-examples/src/main/kotlin/dev/openfga/sdk/example/KotlinExample1.kt @@ -117,7 +117,7 @@ internal class KotlinExample1 { ) ), ClientWriteOptions() - .disableTransactions(true) + .transactions(false) .authorizationModelId(authorizationModel.authorizationModelId) ) .get() diff --git a/src/main/java/dev/openfga/sdk/api/client/OpenFgaClient.java b/src/main/java/dev/openfga/sdk/api/client/OpenFgaClient.java index 5d931ac7..6a6ba170 100644 --- a/src/main/java/dev/openfga/sdk/api/client/OpenFgaClient.java +++ b/src/main/java/dev/openfga/sdk/api/client/OpenFgaClient.java @@ -412,7 +412,7 @@ public CompletableFuture read(ClientReadRequest request, Cli *

This method can operate in two modes depending on the options provided:

* *

Transactional Mode (default)

- *

When {@code options.disableTransactions()} is false or not set:

+ *

When {@code options.isTransactionsEnabled()} is true (the default):

* * *

Non-Transactional Mode

- *

When {@code options.disableTransactions()} is true:

+ *

When {@code options.isTransactionsEnabled()} is false:

*