From b4c3242bf3f775fa299a15fa51b21e91e7ac4652 Mon Sep 17 00:00:00 2001
From: Bilal <39002942+byhlel@users.noreply.github.com>
Date: Mon, 23 Sep 2024 07:55:16 +0000
Subject: [PATCH 1/2] refactor: fixed ESLint warnings

Resolves #44
---
 src/miningRulesCore/preProcessing.js | 30 +++++++++++++++++-----------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/src/miningRulesCore/preProcessing.js b/src/miningRulesCore/preProcessing.js
index e57a219..0e782b0 100644
--- a/src/miningRulesCore/preProcessing.js
+++ b/src/miningRulesCore/preProcessing.js
@@ -21,6 +21,10 @@ export const createGroupingMetaData = () => {
     const groupMapping = {};
     const fileMapping = {};
     for (const key in groupingCategories) {
+        if (groupingCategories.hasOwnProperty(key)) {
+            groupMapping[key] = {};
+        }
+    }
         groupMapping[key] = {};
     }
     return {groupMapping, fileMapping};
@@ -80,20 +84,22 @@ const cleanGroupings = (xmlFile, groupingMetaData) => {
 const addToGroupings = (xmlFile, groupingMetaData) => {
     const fileID = xmlFile.filePath;
     for (const groupingCategoryID in groupingCategories) {
-        const values = getValuesForGrouping(xmlFile.xml, groupingCategories[groupingCategoryID]);
-        for (const valueID of values) {
-            if (!groupingMetaData.groupMapping[groupingCategoryID][valueID]) {
-                groupingMetaData.groupMapping[groupingCategoryID][valueID] = [];
-            }
-            groupingMetaData.groupMapping[groupingCategoryID][valueID].push(fileID);
+        if (groupingCategories.hasOwnProperty(groupingCategoryID)) {
+            const values = getValuesForGrouping(xmlFile.xml, groupingCategories[groupingCategoryID]);
+            for (const valueID of values) {
+                if (!groupingMetaData.groupMapping[groupingCategoryID][valueID]) {
+                    groupingMetaData.groupMapping[groupingCategoryID][valueID] = [];
+                }
+                groupingMetaData.groupMapping[groupingCategoryID][valueID].push(fileID);
 
-            if (!groupingMetaData.fileMapping[fileID]) {
-                groupingMetaData.fileMapping[fileID] = {};
-            }
-            if (!groupingMetaData.fileMapping[fileID][groupingCategoryID]) {
-                groupingMetaData.fileMapping[fileID][groupingCategoryID] = [];
+                if (!groupingMetaData.fileMapping[fileID]) {
+                    groupingMetaData.fileMapping[fileID] = {};
+                }
+                if (!groupingMetaData.fileMapping[fileID][groupingCategoryID]) {
+                    groupingMetaData.fileMapping[fileID][groupingCategoryID] = [];
+                }
+                groupingMetaData.fileMapping[fileID][groupingCategoryID].push(valueID);
             }
-            groupingMetaData.fileMapping[fileID][groupingCategoryID].push(valueID);
         }
     }
 };

From 23f6db1bc9fecd8cfac2fcbd60f2b8a804855057 Mon Sep 17 00:00:00 2001
From: Bilal <39002942+byhlel@users.noreply.github.com>
Date: Tue, 24 Sep 2024 04:27:04 +0000
Subject: [PATCH 2/2] refactor: applied suggested fix for ESLINT errors
 Resolves [ESLint] Fix the warnings. #44

---
 src/miningRulesCore/preProcessing.js | 32 ++++++++++++----------------
 1 file changed, 14 insertions(+), 18 deletions(-)

diff --git a/src/miningRulesCore/preProcessing.js b/src/miningRulesCore/preProcessing.js
index 0e782b0..c60d8c8 100644
--- a/src/miningRulesCore/preProcessing.js
+++ b/src/miningRulesCore/preProcessing.js
@@ -21,10 +21,7 @@ export const createGroupingMetaData = () => {
     const groupMapping = {};
     const fileMapping = {};
     for (const key in groupingCategories) {
-        if (groupingCategories.hasOwnProperty(key)) {
-            groupMapping[key] = {};
-        }
-    }
+        if (!groupingCategories.hasOwnProperty(key)) continue;
         groupMapping[key] = {};
     }
     return {groupMapping, fileMapping};
@@ -84,22 +81,21 @@ const cleanGroupings = (xmlFile, groupingMetaData) => {
 const addToGroupings = (xmlFile, groupingMetaData) => {
     const fileID = xmlFile.filePath;
     for (const groupingCategoryID in groupingCategories) {
-        if (groupingCategories.hasOwnProperty(groupingCategoryID)) {
-            const values = getValuesForGrouping(xmlFile.xml, groupingCategories[groupingCategoryID]);
-            for (const valueID of values) {
-                if (!groupingMetaData.groupMapping[groupingCategoryID][valueID]) {
-                    groupingMetaData.groupMapping[groupingCategoryID][valueID] = [];
-                }
-                groupingMetaData.groupMapping[groupingCategoryID][valueID].push(fileID);
+        if (!groupingCategories.hasOwnProperty(groupingCategoryID)) continue;
+        const values = getValuesForGrouping(xmlFile.xml, groupingCategories[groupingCategoryID]);
+        for (const valueID of values) {
+            if (!groupingMetaData.groupMapping[groupingCategoryID][valueID]) {
+                groupingMetaData.groupMapping[groupingCategoryID][valueID] = [];
+            }
+            groupingMetaData.groupMapping[groupingCategoryID][valueID].push(fileID);
 
-                if (!groupingMetaData.fileMapping[fileID]) {
-                    groupingMetaData.fileMapping[fileID] = {};
-                }
-                if (!groupingMetaData.fileMapping[fileID][groupingCategoryID]) {
-                    groupingMetaData.fileMapping[fileID][groupingCategoryID] = [];
-                }
-                groupingMetaData.fileMapping[fileID][groupingCategoryID].push(valueID);
+            if (!groupingMetaData.fileMapping[fileID]) {
+                groupingMetaData.fileMapping[fileID] = {};
+            }
+            if (!groupingMetaData.fileMapping[fileID][groupingCategoryID]) {
+                groupingMetaData.fileMapping[fileID][groupingCategoryID] = [];
             }
+            groupingMetaData.fileMapping[fileID][groupingCategoryID].push(valueID);
         }
     }
 };