Skip to content

Add open-in-editor feature with Cmd+O shortcut#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3dotgg merged 5 commits into from
Feb 9, 2026
Merged

Add open-in-editor feature with Cmd+O shortcut #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3303d9a
Add open-in-editor feature with Cmd+O shortcut
juliusmarminge Feb 9, 2026
6204eaf
Move editor definitions to contracts for strict IPC typing
juliusmarminge Feb 9, 2026
c8f33b8
Fix biome formatting issues
juliusmarminge Feb 9, 2026
84b71e0
fix: add error handling and address review feedback
cursoragent Feb 9, 2026
36314bb
Merge origin/main and resolve conflicts
juliusmarminge Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion apps/desktop/src/main.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,10 @@ fixPath();

import { spawn } from "node:child_process";
import path from "node:path";
import { BrowserWindow, app, dialog, ipcMain, session } from "electron";
import { BrowserWindow, app, dialog, ipcMain, session, shell } from "electron";

import {
EDITORS,
IPC_CHANNELS,
type TerminalCommandInput,
type TerminalCommandResult,
Expand DownExpand Up@@ -125,6 +126,29 @@ function registerIpcHandlers(): void {
}),
);

// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async (_event, cwd: string, editor: string) => {
if (!cwd) throw new Error("cwd is required");
const editorDef = EDITORS.find((e) => e.id === editor);
if (!editorDef) throw new Error(`Unknown editor: ${editor}`);
if (!editorDef.command) {
const error = await shell.openPath(cwd);
if (error) throw new Error(error);
return;
}
const child = spawn(editorDef.command, [cwd], {
detached: true,
stdio: "ignore",
});
child.on("error", () => {
/* ignore spawn failures for detached editors */
});
child.unref();
Comment thread
macroscopeapp[bot] marked this conversation as resolved.
},
Comment on lines +129 to +149

@coderabbitaicoderabbitaiBotFeb 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n apps/desktop/src/main.ts | sed -n '135,153p'

Repository: pingdotgg/codething-mvp

Length of output: 848

🌐 Web query:

Electron shell.openPath() return value error handling

💡 Result:

shell.openPath(path) returns a Promise<string> that resolves (not rejects) to:

  • "" (empty string) on success
  • a non-empty error message string on failure (electronjs.org)

So error handling is typically:

import{shell}from"electron";asyncfunctionopenFile(p: string){try{consterr=awaitshell.openPath(p);if(err){// open failed; Electron returns an error message stringconsole.error("openPath failed:",err);// show UI / log / fallback here}}catch(e){// for unexpected exceptions (e.g., bad argument types, other runtime issues)console.error("openPath threw:",e);}}

Key point: check the resolved string—don’t rely only on catch. (electronjs.org)

Citations:

🌐 Web query:

Node.js child_process spawn error event handling

💡 Result:

In Node.js, child_process.spawn() can fail asynchronously, so you should always attach an 'error' handler to the returned ChildProcess:

  • 'error' event is emitted when the process could not be spawned (e.g., ENOENT, EACCES), could not be killed, or IPC send failed. The 'exit' event may or may not fire after an 'error', so don’t rely on 'exit' alone. [1]
  • 'close' event fires after the process ends and all stdio streams are closed; it will emit after 'exit', or after 'error' if the child failed to spawn. [2]

A common safe pattern is to funnel both 'error' and 'close' into a single “done once” handler:

import{spawn}from'node:child_process';functionspawnChecked(cmd,args,opts){constchild=spawn(cmd,args,opts);letsettled=false;constdone=(err,result)=>{if(settled)return;settled=true;if(err)throwerr;// or reject a Promise / call cb(err)returnresult;};child.once('error',(err)=>done(err));// spawn/kill/IPC failurechild.once('close',(code,signal)=>{// stdio fully closedif(code===0)returndone(null,{ code, signal });done(Object.assign(newError(`exit ${code??'null'} (${signal??'no-signal'})`),{ code, signal }));});returnchild;}

Sources: Node.js ChildProcess event docs for 'error' and 'close'. [1] [2]

References
[1] Node.js docs — ChildProcess event: 'error' (nodejs.org)
[2] Node.js v22 docs — ChildProcess event: 'close' (nodejs.org)

Citations:

Add error handling for shell.openPath() and spawn() to prevent crashes and silent failures.
shell.openPath() returns a Promise that resolves to an error string (not thrown), and spawn() emits an 'error' event asynchronously when the process cannot be spawned (e.g., missing CLI). Without handling these, the IPC handler silently fails or crashes. Also guard against empty cwd.

🛠️ Suggested fix
- async (_event, cwd: string, editor: string) => {- if (editor === "file-manager") {- await shell.openPath(cwd);- return;- }+ async (_event, cwd: string, editor: string) => {+ if (!cwd) {+ throw new Error("cwd is required");+ }+ if (editor === "file-manager") {+ const error = await shell.openPath(cwd);+ if (error) {+ throw new Error(error);+ }+ return;+ }
const EDITOR_COMMANDS: Record<string, { command: string; args: (cwd: string) => string[] }> = {
cursor: { command: "cursor", args: (p) => [p] },
};
const entry = EDITOR_COMMANDS[editor];
if (!entry) throw new Error(`Unknown editor: ${editor}`);
- const child = spawn(entry.command, entry.args(cwd), {- detached: true,- stdio: "ignore",- });- child.unref();+ await new Promise<void>((resolve, reject) => {+ const child = spawn(entry.command, entry.args(cwd), {+ detached: true,+ stdio: "ignore",+ });+ child.once("error", reject);+ child.once("spawn", () => {+ child.unref();+ resolve();+ });+ });
},
);
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(editor==="file-manager"){
awaitshell.openPath(cwd);
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.unref();
},
// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(!cwd){
thrownewError("cwd is required");
}
if(editor==="file-manager"){
consterror=awaitshell.openPath(cwd);
if(error){
thrownewError(error);
}
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
awaitnewPromise<void>((resolve,reject)=>{
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.once("error",reject);
child.once("spawn",()=>{
child.unref();
resolve();
});
});
},
);
🤖 Prompt for AI Agents
In `@apps/desktop/src/main.ts` around lines 135 - 153, The IPC handler for
ipcMain.handle should validate cwd is non-empty, await shell.openPath(cwd) and
check its returned string for an error (log/throw when non-empty) instead of
assuming success, and protect the spawn path by wrapping the spawn call in
try/catch and attaching an 'error' listener to the returned child (e.g.,
child.on('error', ...) to log/throw when the CLI cannot be spawned); reference
EDITOR_COMMANDS and entry (from editor) to locate the spawn logic, and ensure
you handle and surface errors for both shell.openPath and spawn so the handler
doesn't crash or fail silently.

);

// Agent handlers
ipcMain.handle(
IPC_CHANNELS.agentSpawn,
Expand Down
4 changes: 4 additions & 0 deletions apps/desktop/src/preload.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,10 @@ const nativeApi: NativeApi = {
ipcRenderer.removeListener(IPC_CHANNELS.providerEvent, listener);
},
},
shell: {
openInEditor: (cwd: string, editor: string) =>
ipcRenderer.invoke(IPC_CHANNELS.shellOpenInEditor, cwd, editor),
},
};

contextBridge.exposeInMainWorld("nativeApi", nativeApi);
95 changes: 95 additions & 0 deletions apps/renderer/src/components/ChatView.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ import {
useState,
} from "react";

import { EDITORS, type EditorId } from "@acme/contracts";
import {
DEFAULT_MODEL,
DEFAULT_REASONING,
Expand All@@ -32,6 +33,18 @@ function formatMessageMeta(createdAt: string, duration: string | null): string {
return `${formatTimestamp(createdAt)} • ${duration}`;
}

const FILE_MANAGER_LABEL = navigator.platform.includes("Mac")
? "Finder"
: navigator.platform.includes("Win")
? "Explorer"
: "Files";

function editorLabel(editor: (typeof EDITORS)[number]): string {
return editor.command ? editor.label : FILE_MANAGER_LABEL;
}

const LAST_EDITOR_KEY = "codething:last-editor";

function workToneClass(tone: "thinking" | "tool" | "info" | "error"): string {
if (tone === "error") return "text-rose-300/50";
if (tone === "tool") return "text-[#8a8a8a]";
Expand All@@ -46,12 +59,20 @@ export default function ChatView() {
const [isSending, setIsSending] = useState(false);
const [isConnecting, setIsConnecting] = useState(false);
const [isModelMenuOpen, setIsModelMenuOpen] = useState(false);
const [isEditorMenuOpen, setIsEditorMenuOpen] = useState(false);
const [lastEditor, setLastEditor] = useState<EditorId>(() => {
const stored = localStorage.getItem(LAST_EDITOR_KEY);
return EDITORS.some((e) => e.id === stored)
? (stored as EditorId)
: EDITORS[0].id;
});
const [selectedEffort, setSelectedEffort] =
useState<string>(DEFAULT_REASONING);
const [nowTick, setNowTick] = useState(() => Date.now());
const messagesEndRef = useRef<HTMLDivElement>(null);
const textareaRef = useRef<HTMLTextAreaElement>(null);
const modelMenuRef = useRef<HTMLDivElement>(null);
const editorMenuRef = useRef<HTMLDivElement>(null);

const activeThread = state.threads.find((t) => t.id === state.activeThreadId);
const activeProject = state.projects.find(
Expand DownExpand Up@@ -179,6 +200,47 @@ export default function ChatView() {
};
}, [isModelMenuOpen]);

useEffect(() => {
if (!isEditorMenuOpen) return;

const handleClickOutside = (event: MouseEvent) => {
if (!editorMenuRef.current) return;
if (
event.target instanceof Node &&
!editorMenuRef.current.contains(event.target)
) {
setIsEditorMenuOpen(false);
}
};

window.addEventListener("mousedown", handleClickOutside);
return () => {
window.removeEventListener("mousedown", handleClickOutside);
};
}, [isEditorMenuOpen]);

// Cmd+O / Ctrl+O to open in last-used editor
useEffect(() => {
const handler = (e: globalThis.KeyboardEvent) => {
if (e.key === "o" && (e.metaKey || e.ctrlKey) && !e.shiftKey) {
if (api && activeProject) {
e.preventDefault();
void api.shell.openInEditor(activeProject.cwd, lastEditor);
}
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
};
window.addEventListener("keydown", handler);
return () => window.removeEventListener("keydown", handler);
}, [api, activeProject, lastEditor]);

const openInEditor = (editorId: EditorId) => {
if (!api || !activeProject) return;
void api.shell.openInEditor(activeProject.cwd, editorId);
setLastEditor(editorId);
localStorage.setItem(LAST_EDITOR_KEY, editorId);
setIsEditorMenuOpen(false);
};

const ensureSession = async (): Promise<string | null> => {
if (!api || !activeThread || !activeProject) return null;
if (activeThread.session && activeThread.session.status !== "closed") {
Expand DownExpand Up@@ -313,6 +375,39 @@ export default function ChatView() {
</h2>
</div>
<div className="flex items-center gap-3">
{/* Open in editor */}
{activeProject && (
<div className="relative" ref={editorMenuRef}>
<button
type="button"
className="rounded-md px-2 py-1 text-[10px] text-[#a0a0a0]/40 transition-colors duration-150 hover:text-[#a0a0a0]/60"
onClick={() => setIsEditorMenuOpen((v) => !v)}
>
Open in&hellip;
</button>
{isEditorMenuOpen && (
<div className="absolute right-0 top-full z-50 mt-1 min-w-[120px] rounded-md border border-white/[0.08] bg-[#1b1b1d] py-1 shadow-xl">
{EDITORS.map((editor) => (
<button
key={editor.id}
type="button"
className="flex w-full items-center gap-2 px-3 py-1.5 text-left text-[11px] text-[#e0e0e0] hover:bg-white/[0.06]"
onClick={() => openInEditor(editor.id)}
>
{editorLabel(editor)}
{editor.id === lastEditor && (
<kbd className="ml-auto text-[9px] text-[#a0a0a0]/40">
{navigator.platform.includes("Mac")
? "\u2318O"
: "Ctrl+O"}
</kbd>
)}
</button>
))}
</div>
)}
</div>
)}
{/* Diff toggle */}
<button
type="button"
Expand Down
11 changes: 11 additions & 0 deletions packages/contracts/src/ipc.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,13 @@ import type {
import type { TerminalCommandInput, TerminalCommandResult } from "./terminal";
import type { NewTodoInput, Todo } from "./todo";

export const EDITORS = [
{ id: "cursor", label: "Cursor", command: "cursor" },
{ id: "file-manager", label: "File Manager", command: null },
] as const;

export type EditorId = (typeof EDITORS)[number]["id"];

export const IPC_CHANNELS = {
todosList: "todos:list",
todosAdd: "todos:add",
Expand All@@ -29,6 +36,7 @@ export const IPC_CHANNELS = {
providerSessionStop: "provider:session:stop",
providerSessionList: "provider:session:list",
providerEvent: "provider:event",
shellOpenInEditor: "shell:open-in-editor",
} as const;

export interface NativeApi {
Expand DownExpand Up@@ -63,4 +71,7 @@ export interface NativeApi {
listSessions: () => Promise<ProviderSession[]>;
onEvent: (callback: (event: ProviderEvent) => void) => () => void;
};
shell: {
openInEditor: (cwd: string, editor: EditorId) => Promise<void>;
};
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add open-in-editor feature with Cmd+O shortcut by juliusmarminge · Pull Request #2 · pingdotgg/t3code · GitHub
Skip to content
Add open-in-editor feature with Cmd+O shortcut#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

t3dotgg
merged 5 commits into

from

Feb 9, 2026
 Merged


Add open-in-editor feature with Cmd+O shortcut
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
3303d9a

Add open-in-editor feature with Cmd+O shortcut


juliusmarminge Feb 9, 2026
6204eaf

Move editor definitions to contracts for strict IPC typing


juliusmarminge Feb 9, 2026
c8f33b8

Fix biome formatting issues


juliusmarminge Feb 9, 2026
84b71e0

fix: add error handling and address review feedback


cursoragent Feb 9, 2026
36314bb

Merge origin/main and resolve conflicts


juliusmarminge Feb 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 25 additions & 1 deletion
apps/desktop/src/main.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,10 @@ fixPath();

import { spawn } from "node:child_process";
import path from "node:path";
import { BrowserWindow, app, dialog, ipcMain, session } from "electron";
import { BrowserWindow, app, dialog, ipcMain, session, shell } from "electron";

import {
 EDITORS,
 IPC_CHANNELS,
 type TerminalCommandInput,
 type TerminalCommandResult,
Expand DownExpand Up@@ -125,6 +126,29 @@ function registerIpcHandlers(): void {
 }),
 );

 // Shell handlers
 ipcMain.handle(
 IPC_CHANNELS.shellOpenInEditor,
 async (_event, cwd: string, editor: string) => {
 if (!cwd) throw new Error("cwd is required");
 const editorDef = EDITORS.find((e) => e.id === editor);
 if (!editorDef) throw new Error(`Unknown editor: ${editor}`);
 if (!editorDef.command) {
 const error = await shell.openPath(cwd);
 if (error) throw new Error(error);
 return;
 }
 const child = spawn(editorDef.command, [cwd], {
 detached: true,
 stdio: "ignore",
 });
 child.on("error", () => {
 /* ignore spawn failures for detached editors */
 });
 child.unref();
Comment thread
macroscopeapp[bot] marked this conversation as resolved.

 },

Comment on lines

+129
 to 
+149

@coderabbitaicoderabbitaiBotFeb 9, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
cat -n apps/desktop/src/main.ts | sed -n '135,153p'
Repository: pingdotgg/codething-mvp
Length of output: 848
🌐 Web query:
Electron shell.openPath() return value error handling
💡 Result:
shell.openPath(path) returns a Promise<string> that resolves (not rejects) to:
  • "" (empty string) on success
  • a non-empty error message string on failure (electronjs.org)
So error handling is typically:
import{shell}from"electron";asyncfunctionopenFile(p: string){try{consterr=awaitshell.openPath(p);if(err){// open failed; Electron returns an error message stringconsole.error("openPath failed:",err);// show UI / log / fallback here}}catch(e){// for unexpected exceptions (e.g., bad argument types, other runtime issues)console.error("openPath threw:",e);}}
Key point: check the resolved string—don’t rely only on catch. (electronjs.org)
Citations:
🌐 Web query:
Node.js child_process spawn error event handling
💡 Result:
In Node.js, child_process.spawn() can fail asynchronously, so you should always attach an 'error' handler to the returned ChildProcess:
  • 'error' event is emitted when the process could not be spawned (e.g., ENOENT, EACCES), could not be killed, or IPC send failed. The 'exit' event may or may not fire after an 'error', so don’t rely on 'exit' alone. [1]
  • 'close' event fires after the process ends and all stdio streams are closed; it will emit after 'exit', or after 'error' if the child failed to spawn. [2]
A common safe pattern is to funnel both 'error' and 'close' into a single “done once” handler:
import{spawn}from'node:child_process';functionspawnChecked(cmd,args,opts){constchild=spawn(cmd,args,opts);letsettled=false;constdone=(err,result)=>{if(settled)return;settled=true;if(err)throwerr;// or reject a Promise / call cb(err)returnresult;};child.once('error',(err)=>done(err));// spawn/kill/IPC failurechild.once('close',(code,signal)=>{// stdio fully closedif(code===0)returndone(null,{ code, signal });done(Object.assign(newError(`exit ${code??'null'} (${signal??'no-signal'})`),{ code, signal }));});returnchild;}
Sources: Node.js ChildProcess event docs for 'error' and 'close'. [1] [2]
References

[1] Node.js docs — ChildProcess event: 'error' (nodejs.org)

[2] Node.js v22 docs — ChildProcess event: 'close' (nodejs.org)
Citations:
Add error handling for shell.openPath() and spawn() to prevent crashes and silent failures.
shell.openPath() returns a Promise that resolves to an error string (not thrown), and spawn() emits an 'error' event asynchronously when the process cannot be spawned (e.g., missing CLI). Without handling these, the IPC handler silently fails or crashes. Also guard against empty cwd.
🛠️ Suggested fix
- async (_event, cwd: string, editor: string) => {- if (editor === "file-manager") {- await shell.openPath(cwd);- return;- }+ async (_event, cwd: string, editor: string) => {+ if (!cwd) {+ throw new Error("cwd is required");+ }+ if (editor === "file-manager") {+ const error = await shell.openPath(cwd);+ if (error) {+ throw new Error(error);+ }+ return;+ }
const EDITOR_COMMANDS: Record<string, { command: string; args: (cwd: string) => string[] }> = {
cursor: { command: "cursor", args: (p) => [p] },
};
const entry = EDITOR_COMMANDS[editor];
if (!entry) throw new Error(`Unknown editor: ${editor}`);
- const child = spawn(entry.command, entry.args(cwd), {- detached: true,- stdio: "ignore",- });- child.unref();+ await new Promise<void>((resolve, reject) => {+ const child = spawn(entry.command, entry.args(cwd), {+ detached: true,+ stdio: "ignore",+ });+ child.once("error", reject);+ child.once("spawn", () => {+ child.unref();+ resolve();+ });+ });
},
);
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(editor==="file-manager"){
awaitshell.openPath(cwd);
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.unref();
},
// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(!cwd){
thrownewError("cwd is required");
}
if(editor==="file-manager"){
consterror=awaitshell.openPath(cwd);
if(error){
thrownewError(error);
}
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
awaitnewPromise<void>((resolve,reject)=>{
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.once("error",reject);
child.once("spawn",()=>{
child.unref();
resolve();
});
});
},
);
🤖 Prompt for AI Agents
In `@apps/desktop/src/main.ts` around lines 135 - 153, The IPC handler for
ipcMain.handle should validate cwd is non-empty, await shell.openPath(cwd) and
check its returned string for an error (log/throw when non-empty) instead of
assuming success, and protect the spawn path by wrapping the spawn call in
try/catch and attaching an 'error' listener to the returned child (e.g.,
child.on('error', ...) to log/throw when the CLI cannot be spawned); reference
EDITOR_COMMANDS and entry (from editor) to locate the spawn logic, and ensure
you handle and surface errors for both shell.openPath and spawn so the handler
doesn't crash or fail silently.

 );

 // Agent handlers
 ipcMain.handle(
 IPC_CHANNELS.agentSpawn,
Expand Down

4 changes: 4 additions & 0 deletions
apps/desktop/src/preload.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,10 @@ const nativeApi: NativeApi = {
 ipcRenderer.removeListener(IPC_CHANNELS.providerEvent, listener);
 },
 },
 shell: {
 openInEditor: (cwd: string, editor: string) =>
 ipcRenderer.invoke(IPC_CHANNELS.shellOpenInEditor, cwd, editor),
 },
};

contextBridge.exposeInMainWorld("nativeApi", nativeApi);

95 changes: 95 additions & 0 deletions
apps/renderer/src/components/ChatView.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ import {
 useState,
} from "react";

import { EDITORS, type EditorId } from "@acme/contracts";
import {
 DEFAULT_MODEL,
 DEFAULT_REASONING,
Expand All@@ -32,6 +33,18 @@ function formatMessageMeta(createdAt: string, duration: string | null): string {
 return `${formatTimestamp(createdAt)} • ${duration}`;
}

const FILE_MANAGER_LABEL = navigator.platform.includes("Mac")
 ? "Finder"
 : navigator.platform.includes("Win")
 ? "Explorer"
 : "Files";

function editorLabel(editor: (typeof EDITORS)[number]): string {
 return editor.command ? editor.label : FILE_MANAGER_LABEL;
}

const LAST_EDITOR_KEY = "codething:last-editor";

function workToneClass(tone: "thinking" | "tool" | "info" | "error"): string {
 if (tone === "error") return "text-rose-300/50";
 if (tone === "tool") return "text-[#8a8a8a]";
Expand All@@ -46,12 +59,20 @@ export default function ChatView() {
 const [isSending, setIsSending] = useState(false);
 const [isConnecting, setIsConnecting] = useState(false);
 const [isModelMenuOpen, setIsModelMenuOpen] = useState(false);
 const [isEditorMenuOpen, setIsEditorMenuOpen] = useState(false);
 const [lastEditor, setLastEditor] = useState<EditorId>(() => {
 const stored = localStorage.getItem(LAST_EDITOR_KEY);
 return EDITORS.some((e) => e.id === stored)
 ? (stored as EditorId)
 : EDITORS[0].id;
 });
 const [selectedEffort, setSelectedEffort] =
 useState<string>(DEFAULT_REASONING);
 const [nowTick, setNowTick] = useState(() => Date.now());
 const messagesEndRef = useRef<HTMLDivElement>(null);
 const textareaRef = useRef<HTMLTextAreaElement>(null);
 const modelMenuRef = useRef<HTMLDivElement>(null);
 const editorMenuRef = useRef<HTMLDivElement>(null);

 const activeThread = state.threads.find((t) => t.id === state.activeThreadId);
 const activeProject = state.projects.find(
Expand DownExpand Up@@ -179,6 +200,47 @@ export default function ChatView() {
 };
 }, [isModelMenuOpen]);

 useEffect(() => {
 if (!isEditorMenuOpen) return;

 const handleClickOutside = (event: MouseEvent) => {
 if (!editorMenuRef.current) return;
 if (
 event.target instanceof Node &&
 !editorMenuRef.current.contains(event.target)
 ) {
 setIsEditorMenuOpen(false);
 }
 };

 window.addEventListener("mousedown", handleClickOutside);
 return () => {
 window.removeEventListener("mousedown", handleClickOutside);
 };
 }, [isEditorMenuOpen]);

 // Cmd+O / Ctrl+O to open in last-used editor
 useEffect(() => {
 const handler = (e: globalThis.KeyboardEvent) => {
 if (e.key === "o" && (e.metaKey || e.ctrlKey) && !e.shiftKey) {
 if (api && activeProject) {
 e.preventDefault();
 void api.shell.openInEditor(activeProject.cwd, lastEditor);
 }
 }
Comment thread
coderabbitai[bot] marked this conversation as resolved.

 };
 window.addEventListener("keydown", handler);
 return () => window.removeEventListener("keydown", handler);
 }, [api, activeProject, lastEditor]);

 const openInEditor = (editorId: EditorId) => {
 if (!api || !activeProject) return;
 void api.shell.openInEditor(activeProject.cwd, editorId);
 setLastEditor(editorId);
 localStorage.setItem(LAST_EDITOR_KEY, editorId);
 setIsEditorMenuOpen(false);
 };

 const ensureSession = async (): Promise<string | null> => {
 if (!api || !activeThread || !activeProject) return null;
 if (activeThread.session && activeThread.session.status !== "closed") {
Expand DownExpand Up@@ -313,6 +375,39 @@ export default function ChatView() {
 </h2>
 </div>
 <div className="flex items-center gap-3">
 {/* Open in editor */}
 {activeProject && (
 <div className="relative" ref={editorMenuRef}>
 <button
 type="button"
 className="rounded-md px-2 py-1 text-[10px] text-[#a0a0a0]/40 transition-colors duration-150 hover:text-[#a0a0a0]/60"
 onClick={() => setIsEditorMenuOpen((v) => !v)}
 >
 Open in&hellip;
 </button>
 {isEditorMenuOpen && (
 <div className="absolute right-0 top-full z-50 mt-1 min-w-[120px] rounded-md border border-white/[0.08] bg-[#1b1b1d] py-1 shadow-xl">
 {EDITORS.map((editor) => (
 <button
 key={editor.id}
 type="button"
 className="flex w-full items-center gap-2 px-3 py-1.5 text-left text-[11px] text-[#e0e0e0] hover:bg-white/[0.06]"
 onClick={() => openInEditor(editor.id)}
 >
 {editorLabel(editor)}
 {editor.id === lastEditor && (
 <kbd className="ml-auto text-[9px] text-[#a0a0a0]/40">
 {navigator.platform.includes("Mac")
 ? "\u2318O"
 : "Ctrl+O"}
 </kbd>
 )}
 </button>
 ))}
 </div>
 )}
 </div>
 )}
 {/* Diff toggle */}
 <button
 type="button"
Expand Down

11 changes: 11 additions & 0 deletions
packages/contracts/src/ipc.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,13 @@ import type {
import type { TerminalCommandInput, TerminalCommandResult } from "./terminal";
import type { NewTodoInput, Todo } from "./todo";

export const EDITORS = [
 { id: "cursor", label: "Cursor", command: "cursor" },
 { id: "file-manager", label: "File Manager", command: null },
] as const;

export type EditorId = (typeof EDITORS)[number]["id"];

export const IPC_CHANNELS = {
 todosList: "todos:list",
 todosAdd: "todos:add",
Expand All@@ -29,6 +36,7 @@ export const IPC_CHANNELS = {
 providerSessionStop: "provider:session:stop",
 providerSessionList: "provider:session:list",
 providerEvent: "provider:event",
 shellOpenInEditor: "shell:open-in-editor",
} as const;

export interface NativeApi {
Expand DownExpand Up@@ -63,4 +71,7 @@ export interface NativeApi {
 listSessions: () => Promise<ProviderSession[]>;
 onEvent: (callback: (event: ProviderEvent) => void) => () => void;
 };
 shell: {
 openInEditor: (cwd: string, editor: EditorId) => Promise<void>;
 };
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add open-in-editor feature with Cmd+O shortcut by juliusmarminge · Pull Request #2 · pingdotgg/t3code · GitHub
Skip to content
Add open-in-editor feature with Cmd+O shortcut#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

t3dotgg
merged 5 commits into

from

Feb 9, 2026
 Merged


Add open-in-editor feature with Cmd+O shortcut
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
3303d9a

Add open-in-editor feature with Cmd+O shortcut


juliusmarminge Feb 9, 2026
6204eaf

Move editor definitions to contracts for strict IPC typing


juliusmarminge Feb 9, 2026
c8f33b8

Fix biome formatting issues


juliusmarminge Feb 9, 2026
84b71e0

fix: add error handling and address review feedback


cursoragent Feb 9, 2026
36314bb

Merge origin/main and resolve conflicts


juliusmarminge Feb 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 25 additions & 1 deletion
apps/desktop/src/main.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,10 @@ fixPath();

import { spawn } from "node:child_process";
import path from "node:path";
import { BrowserWindow, app, dialog, ipcMain, session } from "electron";
import { BrowserWindow, app, dialog, ipcMain, session, shell } from "electron";

import {
 EDITORS,
 IPC_CHANNELS,
 type TerminalCommandInput,
 type TerminalCommandResult,
Expand DownExpand Up@@ -125,6 +126,29 @@ function registerIpcHandlers(): void {
 }),
 );

 // Shell handlers
 ipcMain.handle(
 IPC_CHANNELS.shellOpenInEditor,
 async (_event, cwd: string, editor: string) => {
 if (!cwd) throw new Error("cwd is required");
 const editorDef = EDITORS.find((e) => e.id === editor);
 if (!editorDef) throw new Error(`Unknown editor: ${editor}`);
 if (!editorDef.command) {
 const error = await shell.openPath(cwd);
 if (error) throw new Error(error);
 return;
 }
 const child = spawn(editorDef.command, [cwd], {
 detached: true,
 stdio: "ignore",
 });
 child.on("error", () => {
 /* ignore spawn failures for detached editors */
 });
 child.unref();
Comment thread
macroscopeapp[bot] marked this conversation as resolved.

 },

Comment on lines

+129
 to 
+149

@coderabbitaicoderabbitaiBotFeb 9, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
cat -n apps/desktop/src/main.ts | sed -n '135,153p'
Repository: pingdotgg/codething-mvp
Length of output: 848
🌐 Web query:
Electron shell.openPath() return value error handling
💡 Result:
shell.openPath(path) returns a Promise<string> that resolves (not rejects) to:
  • "" (empty string) on success
  • a non-empty error message string on failure (electronjs.org)
So error handling is typically:
import{shell}from"electron";asyncfunctionopenFile(p: string){try{consterr=awaitshell.openPath(p);if(err){// open failed; Electron returns an error message stringconsole.error("openPath failed:",err);// show UI / log / fallback here}}catch(e){// for unexpected exceptions (e.g., bad argument types, other runtime issues)console.error("openPath threw:",e);}}
Key point: check the resolved string—don’t rely only on catch. (electronjs.org)
Citations:
🌐 Web query:
Node.js child_process spawn error event handling
💡 Result:
In Node.js, child_process.spawn() can fail asynchronously, so you should always attach an 'error' handler to the returned ChildProcess:
  • 'error' event is emitted when the process could not be spawned (e.g., ENOENT, EACCES), could not be killed, or IPC send failed. The 'exit' event may or may not fire after an 'error', so don’t rely on 'exit' alone. [1]
  • 'close' event fires after the process ends and all stdio streams are closed; it will emit after 'exit', or after 'error' if the child failed to spawn. [2]
A common safe pattern is to funnel both 'error' and 'close' into a single “done once” handler:
import{spawn}from'node:child_process';functionspawnChecked(cmd,args,opts){constchild=spawn(cmd,args,opts);letsettled=false;constdone=(err,result)=>{if(settled)return;settled=true;if(err)throwerr;// or reject a Promise / call cb(err)returnresult;};child.once('error',(err)=>done(err));// spawn/kill/IPC failurechild.once('close',(code,signal)=>{// stdio fully closedif(code===0)returndone(null,{ code, signal });done(Object.assign(newError(`exit ${code??'null'} (${signal??'no-signal'})`),{ code, signal }));});returnchild;}
Sources: Node.js ChildProcess event docs for 'error' and 'close'. [1] [2]
References

[1] Node.js docs — ChildProcess event: 'error' (nodejs.org)

[2] Node.js v22 docs — ChildProcess event: 'close' (nodejs.org)
Citations:
Add error handling for shell.openPath() and spawn() to prevent crashes and silent failures.
shell.openPath() returns a Promise that resolves to an error string (not thrown), and spawn() emits an 'error' event asynchronously when the process cannot be spawned (e.g., missing CLI). Without handling these, the IPC handler silently fails or crashes. Also guard against empty cwd.
🛠️ Suggested fix
- async (_event, cwd: string, editor: string) => {- if (editor === "file-manager") {- await shell.openPath(cwd);- return;- }+ async (_event, cwd: string, editor: string) => {+ if (!cwd) {+ throw new Error("cwd is required");+ }+ if (editor === "file-manager") {+ const error = await shell.openPath(cwd);+ if (error) {+ throw new Error(error);+ }+ return;+ }
const EDITOR_COMMANDS: Record<string, { command: string; args: (cwd: string) => string[] }> = {
cursor: { command: "cursor", args: (p) => [p] },
};
const entry = EDITOR_COMMANDS[editor];
if (!entry) throw new Error(`Unknown editor: ${editor}`);
- const child = spawn(entry.command, entry.args(cwd), {- detached: true,- stdio: "ignore",- });- child.unref();+ await new Promise<void>((resolve, reject) => {+ const child = spawn(entry.command, entry.args(cwd), {+ detached: true,+ stdio: "ignore",+ });+ child.once("error", reject);+ child.once("spawn", () => {+ child.unref();+ resolve();+ });+ });
},
);
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(editor==="file-manager"){
awaitshell.openPath(cwd);
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.unref();
},
// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(!cwd){
thrownewError("cwd is required");
}
if(editor==="file-manager"){
consterror=awaitshell.openPath(cwd);
if(error){
thrownewError(error);
}
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
awaitnewPromise<void>((resolve,reject)=>{
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.once("error",reject);
child.once("spawn",()=>{
child.unref();
resolve();
});
});
},
);
🤖 Prompt for AI Agents
In `@apps/desktop/src/main.ts` around lines 135 - 153, The IPC handler for
ipcMain.handle should validate cwd is non-empty, await shell.openPath(cwd) and
check its returned string for an error (log/throw when non-empty) instead of
assuming success, and protect the spawn path by wrapping the spawn call in
try/catch and attaching an 'error' listener to the returned child (e.g.,
child.on('error', ...) to log/throw when the CLI cannot be spawned); reference
EDITOR_COMMANDS and entry (from editor) to locate the spawn logic, and ensure
you handle and surface errors for both shell.openPath and spawn so the handler
doesn't crash or fail silently.

 );

 // Agent handlers
 ipcMain.handle(
 IPC_CHANNELS.agentSpawn,
Expand Down

4 changes: 4 additions & 0 deletions
apps/desktop/src/preload.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,10 @@ const nativeApi: NativeApi = {
 ipcRenderer.removeListener(IPC_CHANNELS.providerEvent, listener);
 },
 },
 shell: {
 openInEditor: (cwd: string, editor: string) =>
 ipcRenderer.invoke(IPC_CHANNELS.shellOpenInEditor, cwd, editor),
 },
};

contextBridge.exposeInMainWorld("nativeApi", nativeApi);

95 changes: 95 additions & 0 deletions
apps/renderer/src/components/ChatView.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ import {
 useState,
} from "react";

import { EDITORS, type EditorId } from "@acme/contracts";
import {
 DEFAULT_MODEL,
 DEFAULT_REASONING,
Expand All@@ -32,6 +33,18 @@ function formatMessageMeta(createdAt: string, duration: string | null): string {
 return `${formatTimestamp(createdAt)} • ${duration}`;
}

const FILE_MANAGER_LABEL = navigator.platform.includes("Mac")
 ? "Finder"
 : navigator.platform.includes("Win")
 ? "Explorer"
 : "Files";

function editorLabel(editor: (typeof EDITORS)[number]): string {
 return editor.command ? editor.label : FILE_MANAGER_LABEL;
}

const LAST_EDITOR_KEY = "codething:last-editor";

function workToneClass(tone: "thinking" | "tool" | "info" | "error"): string {
 if (tone === "error") return "text-rose-300/50";
 if (tone === "tool") return "text-[#8a8a8a]";
Expand All@@ -46,12 +59,20 @@ export default function ChatView() {
 const [isSending, setIsSending] = useState(false);
 const [isConnecting, setIsConnecting] = useState(false);
 const [isModelMenuOpen, setIsModelMenuOpen] = useState(false);
 const [isEditorMenuOpen, setIsEditorMenuOpen] = useState(false);
 const [lastEditor, setLastEditor] = useState<EditorId>(() => {
 const stored = localStorage.getItem(LAST_EDITOR_KEY);
 return EDITORS.some((e) => e.id === stored)
 ? (stored as EditorId)
 : EDITORS[0].id;
 });
 const [selectedEffort, setSelectedEffort] =
 useState<string>(DEFAULT_REASONING);
 const [nowTick, setNowTick] = useState(() => Date.now());
 const messagesEndRef = useRef<HTMLDivElement>(null);
 const textareaRef = useRef<HTMLTextAreaElement>(null);
 const modelMenuRef = useRef<HTMLDivElement>(null);
 const editorMenuRef = useRef<HTMLDivElement>(null);

 const activeThread = state.threads.find((t) => t.id === state.activeThreadId);
 const activeProject = state.projects.find(
Expand DownExpand Up@@ -179,6 +200,47 @@ export default function ChatView() {
 };
 }, [isModelMenuOpen]);

 useEffect(() => {
 if (!isEditorMenuOpen) return;

 const handleClickOutside = (event: MouseEvent) => {
 if (!editorMenuRef.current) return;
 if (
 event.target instanceof Node &&
 !editorMenuRef.current.contains(event.target)
 ) {
 setIsEditorMenuOpen(false);
 }
 };

 window.addEventListener("mousedown", handleClickOutside);
 return () => {
 window.removeEventListener("mousedown", handleClickOutside);
 };
 }, [isEditorMenuOpen]);

 // Cmd+O / Ctrl+O to open in last-used editor
 useEffect(() => {
 const handler = (e: globalThis.KeyboardEvent) => {
 if (e.key === "o" && (e.metaKey || e.ctrlKey) && !e.shiftKey) {
 if (api && activeProject) {
 e.preventDefault();
 void api.shell.openInEditor(activeProject.cwd, lastEditor);
 }
 }
Comment thread
coderabbitai[bot] marked this conversation as resolved.

 };
 window.addEventListener("keydown", handler);
 return () => window.removeEventListener("keydown", handler);
 }, [api, activeProject, lastEditor]);

 const openInEditor = (editorId: EditorId) => {
 if (!api || !activeProject) return;
 void api.shell.openInEditor(activeProject.cwd, editorId);
 setLastEditor(editorId);
 localStorage.setItem(LAST_EDITOR_KEY, editorId);
 setIsEditorMenuOpen(false);
 };

 const ensureSession = async (): Promise<string | null> => {
 if (!api || !activeThread || !activeProject) return null;
 if (activeThread.session && activeThread.session.status !== "closed") {
Expand DownExpand Up@@ -313,6 +375,39 @@ export default function ChatView() {
 </h2>
 </div>
 <div className="flex items-center gap-3">
 {/* Open in editor */}
 {activeProject && (
 <div className="relative" ref={editorMenuRef}>
 <button
 type="button"
 className="rounded-md px-2 py-1 text-[10px] text-[#a0a0a0]/40 transition-colors duration-150 hover:text-[#a0a0a0]/60"
 onClick={() => setIsEditorMenuOpen((v) => !v)}
 >
 Open in&hellip;
 </button>
 {isEditorMenuOpen && (
 <div className="absolute right-0 top-full z-50 mt-1 min-w-[120px] rounded-md border border-white/[0.08] bg-[#1b1b1d] py-1 shadow-xl">
 {EDITORS.map((editor) => (
 <button
 key={editor.id}
 type="button"
 className="flex w-full items-center gap-2 px-3 py-1.5 text-left text-[11px] text-[#e0e0e0] hover:bg-white/[0.06]"
 onClick={() => openInEditor(editor.id)}
 >
 {editorLabel(editor)}
 {editor.id === lastEditor && (
 <kbd className="ml-auto text-[9px] text-[#a0a0a0]/40">
 {navigator.platform.includes("Mac")
 ? "\u2318O"
 : "Ctrl+O"}
 </kbd>
 )}
 </button>
 ))}
 </div>
 )}
 </div>
 )}
 {/* Diff toggle */}
 <button
 type="button"
Expand Down

11 changes: 11 additions & 0 deletions
packages/contracts/src/ipc.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,13 @@ import type {
import type { TerminalCommandInput, TerminalCommandResult } from "./terminal";
import type { NewTodoInput, Todo } from "./todo";

export const EDITORS = [
 { id: "cursor", label: "Cursor", command: "cursor" },
 { id: "file-manager", label: "File Manager", command: null },
] as const;

export type EditorId = (typeof EDITORS)[number]["id"];

export const IPC_CHANNELS = {
 todosList: "todos:list",
 todosAdd: "todos:add",
Expand All@@ -29,6 +36,7 @@ export const IPC_CHANNELS = {
 providerSessionStop: "provider:session:stop",
 providerSessionList: "provider:session:list",
 providerEvent: "provider:event",
 shellOpenInEditor: "shell:open-in-editor",
} as const;

export interface NativeApi {
Expand DownExpand Up@@ -63,4 +71,7 @@ export interface NativeApi {
 listSessions: () => Promise<ProviderSession[]>;
 onEvent: (callback: (event: ProviderEvent) => void) => () => void;
 };
 shell: {
 openInEditor: (cwd: string, editor: EditorId) => Promise<void>;
 };
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add open-in-editor feature with Cmd+O shortcut by juliusmarminge · Pull Request #2 · pingdotgg/t3code · GitHub
Skip to content
Add open-in-editor feature with Cmd+O shortcut#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

t3dotgg
merged 5 commits into

from

Feb 9, 2026
 Merged


Add open-in-editor feature with Cmd+O shortcut
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
3303d9a

Add open-in-editor feature with Cmd+O shortcut


juliusmarminge Feb 9, 2026
6204eaf

Move editor definitions to contracts for strict IPC typing


juliusmarminge Feb 9, 2026
c8f33b8

Fix biome formatting issues


juliusmarminge Feb 9, 2026
84b71e0

fix: add error handling and address review feedback


cursoragent Feb 9, 2026
36314bb

Merge origin/main and resolve conflicts


juliusmarminge Feb 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 25 additions & 1 deletion
apps/desktop/src/main.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,10 @@ fixPath();

import { spawn } from "node:child_process";
import path from "node:path";
import { BrowserWindow, app, dialog, ipcMain, session } from "electron";
import { BrowserWindow, app, dialog, ipcMain, session, shell } from "electron";

import {
 EDITORS,
 IPC_CHANNELS,
 type TerminalCommandInput,
 type TerminalCommandResult,
Expand DownExpand Up@@ -125,6 +126,29 @@ function registerIpcHandlers(): void {
 }),
 );

 // Shell handlers
 ipcMain.handle(
 IPC_CHANNELS.shellOpenInEditor,
 async (_event, cwd: string, editor: string) => {
 if (!cwd) throw new Error("cwd is required");
 const editorDef = EDITORS.find((e) => e.id === editor);
 if (!editorDef) throw new Error(`Unknown editor: ${editor}`);
 if (!editorDef.command) {
 const error = await shell.openPath(cwd);
 if (error) throw new Error(error);
 return;
 }
 const child = spawn(editorDef.command, [cwd], {
 detached: true,
 stdio: "ignore",
 });
 child.on("error", () => {
 /* ignore spawn failures for detached editors */
 });
 child.unref();
Comment thread
macroscopeapp[bot] marked this conversation as resolved.

 },

Comment on lines

+129
 to 
+149

@coderabbitaicoderabbitaiBotFeb 9, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
cat -n apps/desktop/src/main.ts | sed -n '135,153p'
Repository: pingdotgg/codething-mvp
Length of output: 848
🌐 Web query:
Electron shell.openPath() return value error handling
💡 Result:
shell.openPath(path) returns a Promise<string> that resolves (not rejects) to:
  • "" (empty string) on success
  • a non-empty error message string on failure (electronjs.org)
So error handling is typically:
import{shell}from"electron";asyncfunctionopenFile(p: string){try{consterr=awaitshell.openPath(p);if(err){// open failed; Electron returns an error message stringconsole.error("openPath failed:",err);// show UI / log / fallback here}}catch(e){// for unexpected exceptions (e.g., bad argument types, other runtime issues)console.error("openPath threw:",e);}}
Key point: check the resolved string—don’t rely only on catch. (electronjs.org)
Citations:
🌐 Web query:
Node.js child_process spawn error event handling
💡 Result:
In Node.js, child_process.spawn() can fail asynchronously, so you should always attach an 'error' handler to the returned ChildProcess:
  • 'error' event is emitted when the process could not be spawned (e.g., ENOENT, EACCES), could not be killed, or IPC send failed. The 'exit' event may or may not fire after an 'error', so don’t rely on 'exit' alone. [1]
  • 'close' event fires after the process ends and all stdio streams are closed; it will emit after 'exit', or after 'error' if the child failed to spawn. [2]
A common safe pattern is to funnel both 'error' and 'close' into a single “done once” handler:
import{spawn}from'node:child_process';functionspawnChecked(cmd,args,opts){constchild=spawn(cmd,args,opts);letsettled=false;constdone=(err,result)=>{if(settled)return;settled=true;if(err)throwerr;// or reject a Promise / call cb(err)returnresult;};child.once('error',(err)=>done(err));// spawn/kill/IPC failurechild.once('close',(code,signal)=>{// stdio fully closedif(code===0)returndone(null,{ code, signal });done(Object.assign(newError(`exit ${code??'null'} (${signal??'no-signal'})`),{ code, signal }));});returnchild;}
Sources: Node.js ChildProcess event docs for 'error' and 'close'. [1] [2]
References

[1] Node.js docs — ChildProcess event: 'error' (nodejs.org)

[2] Node.js v22 docs — ChildProcess event: 'close' (nodejs.org)
Citations:
Add error handling for shell.openPath() and spawn() to prevent crashes and silent failures.
shell.openPath() returns a Promise that resolves to an error string (not thrown), and spawn() emits an 'error' event asynchronously when the process cannot be spawned (e.g., missing CLI). Without handling these, the IPC handler silently fails or crashes. Also guard against empty cwd.
🛠️ Suggested fix
- async (_event, cwd: string, editor: string) => {- if (editor === "file-manager") {- await shell.openPath(cwd);- return;- }+ async (_event, cwd: string, editor: string) => {+ if (!cwd) {+ throw new Error("cwd is required");+ }+ if (editor === "file-manager") {+ const error = await shell.openPath(cwd);+ if (error) {+ throw new Error(error);+ }+ return;+ }
const EDITOR_COMMANDS: Record<string, { command: string; args: (cwd: string) => string[] }> = {
cursor: { command: "cursor", args: (p) => [p] },
};
const entry = EDITOR_COMMANDS[editor];
if (!entry) throw new Error(`Unknown editor: ${editor}`);
- const child = spawn(entry.command, entry.args(cwd), {- detached: true,- stdio: "ignore",- });- child.unref();+ await new Promise<void>((resolve, reject) => {+ const child = spawn(entry.command, entry.args(cwd), {+ detached: true,+ stdio: "ignore",+ });+ child.once("error", reject);+ child.once("spawn", () => {+ child.unref();+ resolve();+ });+ });
},
);
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(editor==="file-manager"){
awaitshell.openPath(cwd);
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.unref();
},
// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(!cwd){
thrownewError("cwd is required");
}
if(editor==="file-manager"){
consterror=awaitshell.openPath(cwd);
if(error){
thrownewError(error);
}
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
awaitnewPromise<void>((resolve,reject)=>{
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.once("error",reject);
child.once("spawn",()=>{
child.unref();
resolve();
});
});
},
);
🤖 Prompt for AI Agents
In `@apps/desktop/src/main.ts` around lines 135 - 153, The IPC handler for
ipcMain.handle should validate cwd is non-empty, await shell.openPath(cwd) and
check its returned string for an error (log/throw when non-empty) instead of
assuming success, and protect the spawn path by wrapping the spawn call in
try/catch and attaching an 'error' listener to the returned child (e.g.,
child.on('error', ...) to log/throw when the CLI cannot be spawned); reference
EDITOR_COMMANDS and entry (from editor) to locate the spawn logic, and ensure
you handle and surface errors for both shell.openPath and spawn so the handler
doesn't crash or fail silently.

 );

 // Agent handlers
 ipcMain.handle(
 IPC_CHANNELS.agentSpawn,
Expand Down

4 changes: 4 additions & 0 deletions
apps/desktop/src/preload.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,10 @@ const nativeApi: NativeApi = {
 ipcRenderer.removeListener(IPC_CHANNELS.providerEvent, listener);
 },
 },
 shell: {
 openInEditor: (cwd: string, editor: string) =>
 ipcRenderer.invoke(IPC_CHANNELS.shellOpenInEditor, cwd, editor),
 },
};

contextBridge.exposeInMainWorld("nativeApi", nativeApi);

95 changes: 95 additions & 0 deletions
apps/renderer/src/components/ChatView.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ import {
 useState,
} from "react";

import { EDITORS, type EditorId } from "@acme/contracts";
import {
 DEFAULT_MODEL,
 DEFAULT_REASONING,
Expand All@@ -32,6 +33,18 @@ function formatMessageMeta(createdAt: string, duration: string | null): string {
 return `${formatTimestamp(createdAt)} • ${duration}`;
}

const FILE_MANAGER_LABEL = navigator.platform.includes("Mac")
 ? "Finder"
 : navigator.platform.includes("Win")
 ? "Explorer"
 : "Files";

function editorLabel(editor: (typeof EDITORS)[number]): string {
 return editor.command ? editor.label : FILE_MANAGER_LABEL;
}

const LAST_EDITOR_KEY = "codething:last-editor";

function workToneClass(tone: "thinking" | "tool" | "info" | "error"): string {
 if (tone === "error") return "text-rose-300/50";
 if (tone === "tool") return "text-[#8a8a8a]";
Expand All@@ -46,12 +59,20 @@ export default function ChatView() {
 const [isSending, setIsSending] = useState(false);
 const [isConnecting, setIsConnecting] = useState(false);
 const [isModelMenuOpen, setIsModelMenuOpen] = useState(false);
 const [isEditorMenuOpen, setIsEditorMenuOpen] = useState(false);
 const [lastEditor, setLastEditor] = useState<EditorId>(() => {
 const stored = localStorage.getItem(LAST_EDITOR_KEY);
 return EDITORS.some((e) => e.id === stored)
 ? (stored as EditorId)
 : EDITORS[0].id;
 });
 const [selectedEffort, setSelectedEffort] =
 useState<string>(DEFAULT_REASONING);
 const [nowTick, setNowTick] = useState(() => Date.now());
 const messagesEndRef = useRef<HTMLDivElement>(null);
 const textareaRef = useRef<HTMLTextAreaElement>(null);
 const modelMenuRef = useRef<HTMLDivElement>(null);
 const editorMenuRef = useRef<HTMLDivElement>(null);

 const activeThread = state.threads.find((t) => t.id === state.activeThreadId);
 const activeProject = state.projects.find(
Expand DownExpand Up@@ -179,6 +200,47 @@ export default function ChatView() {
 };
 }, [isModelMenuOpen]);

 useEffect(() => {
 if (!isEditorMenuOpen) return;

 const handleClickOutside = (event: MouseEvent) => {
 if (!editorMenuRef.current) return;
 if (
 event.target instanceof Node &&
 !editorMenuRef.current.contains(event.target)
 ) {
 setIsEditorMenuOpen(false);
 }
 };

 window.addEventListener("mousedown", handleClickOutside);
 return () => {
 window.removeEventListener("mousedown", handleClickOutside);
 };
 }, [isEditorMenuOpen]);

 // Cmd+O / Ctrl+O to open in last-used editor
 useEffect(() => {
 const handler = (e: globalThis.KeyboardEvent) => {
 if (e.key === "o" && (e.metaKey || e.ctrlKey) && !e.shiftKey) {
 if (api && activeProject) {
 e.preventDefault();
 void api.shell.openInEditor(activeProject.cwd, lastEditor);
 }
 }
Comment thread
coderabbitai[bot] marked this conversation as resolved.

 };
 window.addEventListener("keydown", handler);
 return () => window.removeEventListener("keydown", handler);
 }, [api, activeProject, lastEditor]);

 const openInEditor = (editorId: EditorId) => {
 if (!api || !activeProject) return;
 void api.shell.openInEditor(activeProject.cwd, editorId);
 setLastEditor(editorId);
 localStorage.setItem(LAST_EDITOR_KEY, editorId);
 setIsEditorMenuOpen(false);
 };

 const ensureSession = async (): Promise<string | null> => {
 if (!api || !activeThread || !activeProject) return null;
 if (activeThread.session && activeThread.session.status !== "closed") {
Expand DownExpand Up@@ -313,6 +375,39 @@ export default function ChatView() {
 </h2>
 </div>
 <div className="flex items-center gap-3">
 {/* Open in editor */}
 {activeProject && (
 <div className="relative" ref={editorMenuRef}>
 <button
 type="button"
 className="rounded-md px-2 py-1 text-[10px] text-[#a0a0a0]/40 transition-colors duration-150 hover:text-[#a0a0a0]/60"
 onClick={() => setIsEditorMenuOpen((v) => !v)}
 >
 Open in&hellip;
 </button>
 {isEditorMenuOpen && (
 <div className="absolute right-0 top-full z-50 mt-1 min-w-[120px] rounded-md border border-white/[0.08] bg-[#1b1b1d] py-1 shadow-xl">
 {EDITORS.map((editor) => (
 <button
 key={editor.id}
 type="button"
 className="flex w-full items-center gap-2 px-3 py-1.5 text-left text-[11px] text-[#e0e0e0] hover:bg-white/[0.06]"
 onClick={() => openInEditor(editor.id)}
 >
 {editorLabel(editor)}
 {editor.id === lastEditor && (
 <kbd className="ml-auto text-[9px] text-[#a0a0a0]/40">
 {navigator.platform.includes("Mac")
 ? "\u2318O"
 : "Ctrl+O"}
 </kbd>
 )}
 </button>
 ))}
 </div>
 )}
 </div>
 )}
 {/* Diff toggle */}
 <button
 type="button"
Expand Down

11 changes: 11 additions & 0 deletions
packages/contracts/src/ipc.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,13 @@ import type {
import type { TerminalCommandInput, TerminalCommandResult } from "./terminal";
import type { NewTodoInput, Todo } from "./todo";

export const EDITORS = [
 { id: "cursor", label: "Cursor", command: "cursor" },
 { id: "file-manager", label: "File Manager", command: null },
] as const;

export type EditorId = (typeof EDITORS)[number]["id"];

export const IPC_CHANNELS = {
 todosList: "todos:list",
 todosAdd: "todos:add",
Expand All@@ -29,6 +36,7 @@ export const IPC_CHANNELS = {
 providerSessionStop: "provider:session:stop",
 providerSessionList: "provider:session:list",
 providerEvent: "provider:event",
 shellOpenInEditor: "shell:open-in-editor",
} as const;

export interface NativeApi {
Expand DownExpand Up@@ -63,4 +71,7 @@ export interface NativeApi {
 listSessions: () => Promise<ProviderSession[]>;
 onEvent: (callback: (event: ProviderEvent) => void) => () => void;
 };
 shell: {
 openInEditor: (cwd: string, editor: EditorId) => Promise<void>;
 };
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add open-in-editor feature with Cmd+O shortcut by juliusmarminge · Pull Request #2 · pingdotgg/t3code · GitHub
Skip to content
Add open-in-editor feature with Cmd+O shortcut#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

t3dotgg
merged 5 commits into

from

Feb 9, 2026
 Merged


Add open-in-editor feature with Cmd+O shortcut
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
3303d9a

Add open-in-editor feature with Cmd+O shortcut


juliusmarminge Feb 9, 2026
6204eaf

Move editor definitions to contracts for strict IPC typing


juliusmarminge Feb 9, 2026
c8f33b8

Fix biome formatting issues


juliusmarminge Feb 9, 2026
84b71e0

fix: add error handling and address review feedback


cursoragent Feb 9, 2026
36314bb

Merge origin/main and resolve conflicts


juliusmarminge Feb 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 25 additions & 1 deletion
apps/desktop/src/main.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,10 @@ fixPath();

import { spawn } from "node:child_process";
import path from "node:path";
import { BrowserWindow, app, dialog, ipcMain, session } from "electron";
import { BrowserWindow, app, dialog, ipcMain, session, shell } from "electron";

import {
 EDITORS,
 IPC_CHANNELS,
 type TerminalCommandInput,
 type TerminalCommandResult,
Expand DownExpand Up@@ -125,6 +126,29 @@ function registerIpcHandlers(): void {
 }),
 );

 // Shell handlers
 ipcMain.handle(
 IPC_CHANNELS.shellOpenInEditor,
 async (_event, cwd: string, editor: string) => {
 if (!cwd) throw new Error("cwd is required");
 const editorDef = EDITORS.find((e) => e.id === editor);
 if (!editorDef) throw new Error(`Unknown editor: ${editor}`);
 if (!editorDef.command) {
 const error = await shell.openPath(cwd);
 if (error) throw new Error(error);
 return;
 }
 const child = spawn(editorDef.command, [cwd], {
 detached: true,
 stdio: "ignore",
 });
 child.on("error", () => {
 /* ignore spawn failures for detached editors */
 });
 child.unref();
Comment thread
macroscopeapp[bot] marked this conversation as resolved.

 },

Comment on lines

+129
 to 
+149

@coderabbitaicoderabbitaiBotFeb 9, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
cat -n apps/desktop/src/main.ts | sed -n '135,153p'
Repository: pingdotgg/codething-mvp
Length of output: 848
🌐 Web query:
Electron shell.openPath() return value error handling
💡 Result:
shell.openPath(path) returns a Promise<string> that resolves (not rejects) to:
  • "" (empty string) on success
  • a non-empty error message string on failure (electronjs.org)
So error handling is typically:
import{shell}from"electron";asyncfunctionopenFile(p: string){try{consterr=awaitshell.openPath(p);if(err){// open failed; Electron returns an error message stringconsole.error("openPath failed:",err);// show UI / log / fallback here}}catch(e){// for unexpected exceptions (e.g., bad argument types, other runtime issues)console.error("openPath threw:",e);}}
Key point: check the resolved string—don’t rely only on catch. (electronjs.org)
Citations:
🌐 Web query:
Node.js child_process spawn error event handling
💡 Result:
In Node.js, child_process.spawn() can fail asynchronously, so you should always attach an 'error' handler to the returned ChildProcess:
  • 'error' event is emitted when the process could not be spawned (e.g., ENOENT, EACCES), could not be killed, or IPC send failed. The 'exit' event may or may not fire after an 'error', so don’t rely on 'exit' alone. [1]
  • 'close' event fires after the process ends and all stdio streams are closed; it will emit after 'exit', or after 'error' if the child failed to spawn. [2]
A common safe pattern is to funnel both 'error' and 'close' into a single “done once” handler:
import{spawn}from'node:child_process';functionspawnChecked(cmd,args,opts){constchild=spawn(cmd,args,opts);letsettled=false;constdone=(err,result)=>{if(settled)return;settled=true;if(err)throwerr;// or reject a Promise / call cb(err)returnresult;};child.once('error',(err)=>done(err));// spawn/kill/IPC failurechild.once('close',(code,signal)=>{// stdio fully closedif(code===0)returndone(null,{ code, signal });done(Object.assign(newError(`exit ${code??'null'} (${signal??'no-signal'})`),{ code, signal }));});returnchild;}
Sources: Node.js ChildProcess event docs for 'error' and 'close'. [1] [2]
References

[1] Node.js docs — ChildProcess event: 'error' (nodejs.org)

[2] Node.js v22 docs — ChildProcess event: 'close' (nodejs.org)
Citations:
Add error handling for shell.openPath() and spawn() to prevent crashes and silent failures.
shell.openPath() returns a Promise that resolves to an error string (not thrown), and spawn() emits an 'error' event asynchronously when the process cannot be spawned (e.g., missing CLI). Without handling these, the IPC handler silently fails or crashes. Also guard against empty cwd.
🛠️ Suggested fix
- async (_event, cwd: string, editor: string) => {- if (editor === "file-manager") {- await shell.openPath(cwd);- return;- }+ async (_event, cwd: string, editor: string) => {+ if (!cwd) {+ throw new Error("cwd is required");+ }+ if (editor === "file-manager") {+ const error = await shell.openPath(cwd);+ if (error) {+ throw new Error(error);+ }+ return;+ }
const EDITOR_COMMANDS: Record<string, { command: string; args: (cwd: string) => string[] }> = {
cursor: { command: "cursor", args: (p) => [p] },
};
const entry = EDITOR_COMMANDS[editor];
if (!entry) throw new Error(`Unknown editor: ${editor}`);
- const child = spawn(entry.command, entry.args(cwd), {- detached: true,- stdio: "ignore",- });- child.unref();+ await new Promise<void>((resolve, reject) => {+ const child = spawn(entry.command, entry.args(cwd), {+ detached: true,+ stdio: "ignore",+ });+ child.once("error", reject);+ child.once("spawn", () => {+ child.unref();+ resolve();+ });+ });
},
);
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(editor==="file-manager"){
awaitshell.openPath(cwd);
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.unref();
},
// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(!cwd){
thrownewError("cwd is required");
}
if(editor==="file-manager"){
consterror=awaitshell.openPath(cwd);
if(error){
thrownewError(error);
}
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
awaitnewPromise<void>((resolve,reject)=>{
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.once("error",reject);
child.once("spawn",()=>{
child.unref();
resolve();
});
});
},
);
🤖 Prompt for AI Agents
In `@apps/desktop/src/main.ts` around lines 135 - 153, The IPC handler for
ipcMain.handle should validate cwd is non-empty, await shell.openPath(cwd) and
check its returned string for an error (log/throw when non-empty) instead of
assuming success, and protect the spawn path by wrapping the spawn call in
try/catch and attaching an 'error' listener to the returned child (e.g.,
child.on('error', ...) to log/throw when the CLI cannot be spawned); reference
EDITOR_COMMANDS and entry (from editor) to locate the spawn logic, and ensure
you handle and surface errors for both shell.openPath and spawn so the handler
doesn't crash or fail silently.

 );

 // Agent handlers
 ipcMain.handle(
 IPC_CHANNELS.agentSpawn,
Expand Down

4 changes: 4 additions & 0 deletions
apps/desktop/src/preload.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,10 @@ const nativeApi: NativeApi = {
 ipcRenderer.removeListener(IPC_CHANNELS.providerEvent, listener);
 },
 },
 shell: {
 openInEditor: (cwd: string, editor: string) =>
 ipcRenderer.invoke(IPC_CHANNELS.shellOpenInEditor, cwd, editor),
 },
};

contextBridge.exposeInMainWorld("nativeApi", nativeApi);

95 changes: 95 additions & 0 deletions
apps/renderer/src/components/ChatView.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ import {
 useState,
} from "react";

import { EDITORS, type EditorId } from "@acme/contracts";
import {
 DEFAULT_MODEL,
 DEFAULT_REASONING,
Expand All@@ -32,6 +33,18 @@ function formatMessageMeta(createdAt: string, duration: string | null): string {
 return `${formatTimestamp(createdAt)} • ${duration}`;
}

const FILE_MANAGER_LABEL = navigator.platform.includes("Mac")
 ? "Finder"
 : navigator.platform.includes("Win")
 ? "Explorer"
 : "Files";

function editorLabel(editor: (typeof EDITORS)[number]): string {
 return editor.command ? editor.label : FILE_MANAGER_LABEL;
}

const LAST_EDITOR_KEY = "codething:last-editor";

function workToneClass(tone: "thinking" | "tool" | "info" | "error"): string {
 if (tone === "error") return "text-rose-300/50";
 if (tone === "tool") return "text-[#8a8a8a]";
Expand All@@ -46,12 +59,20 @@ export default function ChatView() {
 const [isSending, setIsSending] = useState(false);
 const [isConnecting, setIsConnecting] = useState(false);
 const [isModelMenuOpen, setIsModelMenuOpen] = useState(false);
 const [isEditorMenuOpen, setIsEditorMenuOpen] = useState(false);
 const [lastEditor, setLastEditor] = useState<EditorId>(() => {
 const stored = localStorage.getItem(LAST_EDITOR_KEY);
 return EDITORS.some((e) => e.id === stored)
 ? (stored as EditorId)
 : EDITORS[0].id;
 });
 const [selectedEffort, setSelectedEffort] =
 useState<string>(DEFAULT_REASONING);
 const [nowTick, setNowTick] = useState(() => Date.now());
 const messagesEndRef = useRef<HTMLDivElement>(null);
 const textareaRef = useRef<HTMLTextAreaElement>(null);
 const modelMenuRef = useRef<HTMLDivElement>(null);
 const editorMenuRef = useRef<HTMLDivElement>(null);

 const activeThread = state.threads.find((t) => t.id === state.activeThreadId);
 const activeProject = state.projects.find(
Expand DownExpand Up@@ -179,6 +200,47 @@ export default function ChatView() {
 };
 }, [isModelMenuOpen]);

 useEffect(() => {
 if (!isEditorMenuOpen) return;

 const handleClickOutside = (event: MouseEvent) => {
 if (!editorMenuRef.current) return;
 if (
 event.target instanceof Node &&
 !editorMenuRef.current.contains(event.target)
 ) {
 setIsEditorMenuOpen(false);
 }
 };

 window.addEventListener("mousedown", handleClickOutside);
 return () => {
 window.removeEventListener("mousedown", handleClickOutside);
 };
 }, [isEditorMenuOpen]);

 // Cmd+O / Ctrl+O to open in last-used editor
 useEffect(() => {
 const handler = (e: globalThis.KeyboardEvent) => {
 if (e.key === "o" && (e.metaKey || e.ctrlKey) && !e.shiftKey) {
 if (api && activeProject) {
 e.preventDefault();
 void api.shell.openInEditor(activeProject.cwd, lastEditor);
 }
 }
Comment thread
coderabbitai[bot] marked this conversation as resolved.

 };
 window.addEventListener("keydown", handler);
 return () => window.removeEventListener("keydown", handler);
 }, [api, activeProject, lastEditor]);

 const openInEditor = (editorId: EditorId) => {
 if (!api || !activeProject) return;
 void api.shell.openInEditor(activeProject.cwd, editorId);
 setLastEditor(editorId);
 localStorage.setItem(LAST_EDITOR_KEY, editorId);
 setIsEditorMenuOpen(false);
 };

 const ensureSession = async (): Promise<string | null> => {
 if (!api || !activeThread || !activeProject) return null;
 if (activeThread.session && activeThread.session.status !== "closed") {
Expand DownExpand Up@@ -313,6 +375,39 @@ export default function ChatView() {
 </h2>
 </div>
 <div className="flex items-center gap-3">
 {/* Open in editor */}
 {activeProject && (
 <div className="relative" ref={editorMenuRef}>
 <button
 type="button"
 className="rounded-md px-2 py-1 text-[10px] text-[#a0a0a0]/40 transition-colors duration-150 hover:text-[#a0a0a0]/60"
 onClick={() => setIsEditorMenuOpen((v) => !v)}
 >
 Open in&hellip;
 </button>
 {isEditorMenuOpen && (
 <div className="absolute right-0 top-full z-50 mt-1 min-w-[120px] rounded-md border border-white/[0.08] bg-[#1b1b1d] py-1 shadow-xl">
 {EDITORS.map((editor) => (
 <button
 key={editor.id}
 type="button"
 className="flex w-full items-center gap-2 px-3 py-1.5 text-left text-[11px] text-[#e0e0e0] hover:bg-white/[0.06]"
 onClick={() => openInEditor(editor.id)}
 >
 {editorLabel(editor)}
 {editor.id === lastEditor && (
 <kbd className="ml-auto text-[9px] text-[#a0a0a0]/40">
 {navigator.platform.includes("Mac")
 ? "\u2318O"
 : "Ctrl+O"}
 </kbd>
 )}
 </button>
 ))}
 </div>
 )}
 </div>
 )}
 {/* Diff toggle */}
 <button
 type="button"
Expand Down

11 changes: 11 additions & 0 deletions
packages/contracts/src/ipc.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,13 @@ import type {
import type { TerminalCommandInput, TerminalCommandResult } from "./terminal";
import type { NewTodoInput, Todo } from "./todo";

export const EDITORS = [
 { id: "cursor", label: "Cursor", command: "cursor" },
 { id: "file-manager", label: "File Manager", command: null },
] as const;

export type EditorId = (typeof EDITORS)[number]["id"];

export const IPC_CHANNELS = {
 todosList: "todos:list",
 todosAdd: "todos:add",
Expand All@@ -29,6 +36,7 @@ export const IPC_CHANNELS = {
 providerSessionStop: "provider:session:stop",
 providerSessionList: "provider:session:list",
 providerEvent: "provider:event",
 shellOpenInEditor: "shell:open-in-editor",
} as const;

export interface NativeApi {
Expand DownExpand Up@@ -63,4 +71,7 @@ export interface NativeApi {
 listSessions: () => Promise<ProviderSession[]>;
 onEvent: (callback: (event: ProviderEvent) => void) => () => void;
 };
 shell: {
 openInEditor: (cwd: string, editor: EditorId) => Promise<void>;
 };
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add open-in-editor feature with Cmd+O shortcut by juliusmarminge · Pull Request #2 · pingdotgg/t3code · GitHub
Skip to content
Add open-in-editor feature with Cmd+O shortcut#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

t3dotgg
merged 5 commits into

from

Feb 9, 2026
 Merged


Add open-in-editor feature with Cmd+O shortcut
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
3303d9a

Add open-in-editor feature with Cmd+O shortcut


juliusmarminge Feb 9, 2026
6204eaf

Move editor definitions to contracts for strict IPC typing


juliusmarminge Feb 9, 2026
c8f33b8

Fix biome formatting issues


juliusmarminge Feb 9, 2026
84b71e0

fix: add error handling and address review feedback


cursoragent Feb 9, 2026
36314bb

Merge origin/main and resolve conflicts


juliusmarminge Feb 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 25 additions & 1 deletion
apps/desktop/src/main.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,10 @@ fixPath();

import { spawn } from "node:child_process";
import path from "node:path";
import { BrowserWindow, app, dialog, ipcMain, session } from "electron";
import { BrowserWindow, app, dialog, ipcMain, session, shell } from "electron";

import {
 EDITORS,
 IPC_CHANNELS,
 type TerminalCommandInput,
 type TerminalCommandResult,
Expand DownExpand Up@@ -125,6 +126,29 @@ function registerIpcHandlers(): void {
 }),
 );

 // Shell handlers
 ipcMain.handle(
 IPC_CHANNELS.shellOpenInEditor,
 async (_event, cwd: string, editor: string) => {
 if (!cwd) throw new Error("cwd is required");
 const editorDef = EDITORS.find((e) => e.id === editor);
 if (!editorDef) throw new Error(`Unknown editor: ${editor}`);
 if (!editorDef.command) {
 const error = await shell.openPath(cwd);
 if (error) throw new Error(error);
 return;
 }
 const child = spawn(editorDef.command, [cwd], {
 detached: true,
 stdio: "ignore",
 });
 child.on("error", () => {
 /* ignore spawn failures for detached editors */
 });
 child.unref();
Comment thread
macroscopeapp[bot] marked this conversation as resolved.

 },

Comment on lines

+129
 to 
+149

@coderabbitaicoderabbitaiBotFeb 9, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
cat -n apps/desktop/src/main.ts | sed -n '135,153p'
Repository: pingdotgg/codething-mvp
Length of output: 848
🌐 Web query:
Electron shell.openPath() return value error handling
💡 Result:
shell.openPath(path) returns a Promise<string> that resolves (not rejects) to:
  • "" (empty string) on success
  • a non-empty error message string on failure (electronjs.org)
So error handling is typically:
import{shell}from"electron";asyncfunctionopenFile(p: string){try{consterr=awaitshell.openPath(p);if(err){// open failed; Electron returns an error message stringconsole.error("openPath failed:",err);// show UI / log / fallback here}}catch(e){// for unexpected exceptions (e.g., bad argument types, other runtime issues)console.error("openPath threw:",e);}}
Key point: check the resolved string—don’t rely only on catch. (electronjs.org)
Citations:
🌐 Web query:
Node.js child_process spawn error event handling
💡 Result:
In Node.js, child_process.spawn() can fail asynchronously, so you should always attach an 'error' handler to the returned ChildProcess:
  • 'error' event is emitted when the process could not be spawned (e.g., ENOENT, EACCES), could not be killed, or IPC send failed. The 'exit' event may or may not fire after an 'error', so don’t rely on 'exit' alone. [1]
  • 'close' event fires after the process ends and all stdio streams are closed; it will emit after 'exit', or after 'error' if the child failed to spawn. [2]
A common safe pattern is to funnel both 'error' and 'close' into a single “done once” handler:
import{spawn}from'node:child_process';functionspawnChecked(cmd,args,opts){constchild=spawn(cmd,args,opts);letsettled=false;constdone=(err,result)=>{if(settled)return;settled=true;if(err)throwerr;// or reject a Promise / call cb(err)returnresult;};child.once('error',(err)=>done(err));// spawn/kill/IPC failurechild.once('close',(code,signal)=>{// stdio fully closedif(code===0)returndone(null,{ code, signal });done(Object.assign(newError(`exit ${code??'null'} (${signal??'no-signal'})`),{ code, signal }));});returnchild;}
Sources: Node.js ChildProcess event docs for 'error' and 'close'. [1] [2]
References

[1] Node.js docs — ChildProcess event: 'error' (nodejs.org)

[2] Node.js v22 docs — ChildProcess event: 'close' (nodejs.org)
Citations:
Add error handling for shell.openPath() and spawn() to prevent crashes and silent failures.
shell.openPath() returns a Promise that resolves to an error string (not thrown), and spawn() emits an 'error' event asynchronously when the process cannot be spawned (e.g., missing CLI). Without handling these, the IPC handler silently fails or crashes. Also guard against empty cwd.
🛠️ Suggested fix
- async (_event, cwd: string, editor: string) => {- if (editor === "file-manager") {- await shell.openPath(cwd);- return;- }+ async (_event, cwd: string, editor: string) => {+ if (!cwd) {+ throw new Error("cwd is required");+ }+ if (editor === "file-manager") {+ const error = await shell.openPath(cwd);+ if (error) {+ throw new Error(error);+ }+ return;+ }
const EDITOR_COMMANDS: Record<string, { command: string; args: (cwd: string) => string[] }> = {
cursor: { command: "cursor", args: (p) => [p] },
};
const entry = EDITOR_COMMANDS[editor];
if (!entry) throw new Error(`Unknown editor: ${editor}`);
- const child = spawn(entry.command, entry.args(cwd), {- detached: true,- stdio: "ignore",- });- child.unref();+ await new Promise<void>((resolve, reject) => {+ const child = spawn(entry.command, entry.args(cwd), {+ detached: true,+ stdio: "ignore",+ });+ child.once("error", reject);+ child.once("spawn", () => {+ child.unref();+ resolve();+ });+ });
},
);
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(editor==="file-manager"){
awaitshell.openPath(cwd);
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.unref();
},
// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(!cwd){
thrownewError("cwd is required");
}
if(editor==="file-manager"){
consterror=awaitshell.openPath(cwd);
if(error){
thrownewError(error);
}
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
awaitnewPromise<void>((resolve,reject)=>{
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.once("error",reject);
child.once("spawn",()=>{
child.unref();
resolve();
});
});
},
);
🤖 Prompt for AI Agents
In `@apps/desktop/src/main.ts` around lines 135 - 153, The IPC handler for
ipcMain.handle should validate cwd is non-empty, await shell.openPath(cwd) and
check its returned string for an error (log/throw when non-empty) instead of
assuming success, and protect the spawn path by wrapping the spawn call in
try/catch and attaching an 'error' listener to the returned child (e.g.,
child.on('error', ...) to log/throw when the CLI cannot be spawned); reference
EDITOR_COMMANDS and entry (from editor) to locate the spawn logic, and ensure
you handle and surface errors for both shell.openPath and spawn so the handler
doesn't crash or fail silently.

 );

 // Agent handlers
 ipcMain.handle(
 IPC_CHANNELS.agentSpawn,
Expand Down

4 changes: 4 additions & 0 deletions
apps/desktop/src/preload.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,10 @@ const nativeApi: NativeApi = {
 ipcRenderer.removeListener(IPC_CHANNELS.providerEvent, listener);
 },
 },
 shell: {
 openInEditor: (cwd: string, editor: string) =>
 ipcRenderer.invoke(IPC_CHANNELS.shellOpenInEditor, cwd, editor),
 },
};

contextBridge.exposeInMainWorld("nativeApi", nativeApi);

95 changes: 95 additions & 0 deletions
apps/renderer/src/components/ChatView.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ import {
 useState,
} from "react";

import { EDITORS, type EditorId } from "@acme/contracts";
import {
 DEFAULT_MODEL,
 DEFAULT_REASONING,
Expand All@@ -32,6 +33,18 @@ function formatMessageMeta(createdAt: string, duration: string | null): string {
 return `${formatTimestamp(createdAt)} • ${duration}`;
}

const FILE_MANAGER_LABEL = navigator.platform.includes("Mac")
 ? "Finder"
 : navigator.platform.includes("Win")
 ? "Explorer"
 : "Files";

function editorLabel(editor: (typeof EDITORS)[number]): string {
 return editor.command ? editor.label : FILE_MANAGER_LABEL;
}

const LAST_EDITOR_KEY = "codething:last-editor";

function workToneClass(tone: "thinking" | "tool" | "info" | "error"): string {
 if (tone === "error") return "text-rose-300/50";
 if (tone === "tool") return "text-[#8a8a8a]";
Expand All@@ -46,12 +59,20 @@ export default function ChatView() {
 const [isSending, setIsSending] = useState(false);
 const [isConnecting, setIsConnecting] = useState(false);
 const [isModelMenuOpen, setIsModelMenuOpen] = useState(false);
 const [isEditorMenuOpen, setIsEditorMenuOpen] = useState(false);
 const [lastEditor, setLastEditor] = useState<EditorId>(() => {
 const stored = localStorage.getItem(LAST_EDITOR_KEY);
 return EDITORS.some((e) => e.id === stored)
 ? (stored as EditorId)
 : EDITORS[0].id;
 });
 const [selectedEffort, setSelectedEffort] =
 useState<string>(DEFAULT_REASONING);
 const [nowTick, setNowTick] = useState(() => Date.now());
 const messagesEndRef = useRef<HTMLDivElement>(null);
 const textareaRef = useRef<HTMLTextAreaElement>(null);
 const modelMenuRef = useRef<HTMLDivElement>(null);
 const editorMenuRef = useRef<HTMLDivElement>(null);

 const activeThread = state.threads.find((t) => t.id === state.activeThreadId);
 const activeProject = state.projects.find(
Expand DownExpand Up@@ -179,6 +200,47 @@ export default function ChatView() {
 };
 }, [isModelMenuOpen]);

 useEffect(() => {
 if (!isEditorMenuOpen) return;

 const handleClickOutside = (event: MouseEvent) => {
 if (!editorMenuRef.current) return;
 if (
 event.target instanceof Node &&
 !editorMenuRef.current.contains(event.target)
 ) {
 setIsEditorMenuOpen(false);
 }
 };

 window.addEventListener("mousedown", handleClickOutside);
 return () => {
 window.removeEventListener("mousedown", handleClickOutside);
 };
 }, [isEditorMenuOpen]);

 // Cmd+O / Ctrl+O to open in last-used editor
 useEffect(() => {
 const handler = (e: globalThis.KeyboardEvent) => {
 if (e.key === "o" && (e.metaKey || e.ctrlKey) && !e.shiftKey) {
 if (api && activeProject) {
 e.preventDefault();
 void api.shell.openInEditor(activeProject.cwd, lastEditor);
 }
 }
Comment thread
coderabbitai[bot] marked this conversation as resolved.

 };
 window.addEventListener("keydown", handler);
 return () => window.removeEventListener("keydown", handler);
 }, [api, activeProject, lastEditor]);

 const openInEditor = (editorId: EditorId) => {
 if (!api || !activeProject) return;
 void api.shell.openInEditor(activeProject.cwd, editorId);
 setLastEditor(editorId);
 localStorage.setItem(LAST_EDITOR_KEY, editorId);
 setIsEditorMenuOpen(false);
 };

 const ensureSession = async (): Promise<string | null> => {
 if (!api || !activeThread || !activeProject) return null;
 if (activeThread.session && activeThread.session.status !== "closed") {
Expand DownExpand Up@@ -313,6 +375,39 @@ export default function ChatView() {
 </h2>
 </div>
 <div className="flex items-center gap-3">
 {/* Open in editor */}
 {activeProject && (
 <div className="relative" ref={editorMenuRef}>
 <button
 type="button"
 className="rounded-md px-2 py-1 text-[10px] text-[#a0a0a0]/40 transition-colors duration-150 hover:text-[#a0a0a0]/60"
 onClick={() => setIsEditorMenuOpen((v) => !v)}
 >
 Open in&hellip;
 </button>
 {isEditorMenuOpen && (
 <div className="absolute right-0 top-full z-50 mt-1 min-w-[120px] rounded-md border border-white/[0.08] bg-[#1b1b1d] py-1 shadow-xl">
 {EDITORS.map((editor) => (
 <button
 key={editor.id}
 type="button"
 className="flex w-full items-center gap-2 px-3 py-1.5 text-left text-[11px] text-[#e0e0e0] hover:bg-white/[0.06]"
 onClick={() => openInEditor(editor.id)}
 >
 {editorLabel(editor)}
 {editor.id === lastEditor && (
 <kbd className="ml-auto text-[9px] text-[#a0a0a0]/40">
 {navigator.platform.includes("Mac")
 ? "\u2318O"
 : "Ctrl+O"}
 </kbd>
 )}
 </button>
 ))}
 </div>
 )}
 </div>
 )}
 {/* Diff toggle */}
 <button
 type="button"
Expand Down

11 changes: 11 additions & 0 deletions
packages/contracts/src/ipc.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,13 @@ import type {
import type { TerminalCommandInput, TerminalCommandResult } from "./terminal";
import type { NewTodoInput, Todo } from "./todo";

export const EDITORS = [
 { id: "cursor", label: "Cursor", command: "cursor" },
 { id: "file-manager", label: "File Manager", command: null },
] as const;

export type EditorId = (typeof EDITORS)[number]["id"];

export const IPC_CHANNELS = {
 todosList: "todos:list",
 todosAdd: "todos:add",
Expand All@@ -29,6 +36,7 @@ export const IPC_CHANNELS = {
 providerSessionStop: "provider:session:stop",
 providerSessionList: "provider:session:list",
 providerEvent: "provider:event",
 shellOpenInEditor: "shell:open-in-editor",
} as const;

export interface NativeApi {
Expand DownExpand Up@@ -63,4 +71,7 @@ export interface NativeApi {
 listSessions: () => Promise<ProviderSession[]>;
 onEvent: (callback: (event: ProviderEvent) => void) => () => void;
 };
 shell: {
 openInEditor: (cwd: string, editor: EditorId) => Promise<void>;
 };
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add open-in-editor feature with Cmd+O shortcut by juliusmarminge · Pull Request #2 · pingdotgg/t3code · GitHub
Skip to content
Add open-in-editor feature with Cmd+O shortcut#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

t3dotgg
merged 5 commits into

from

Feb 9, 2026
 Merged


Add open-in-editor feature with Cmd+O shortcut
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
3303d9a

Add open-in-editor feature with Cmd+O shortcut


juliusmarminge Feb 9, 2026
6204eaf

Move editor definitions to contracts for strict IPC typing


juliusmarminge Feb 9, 2026
c8f33b8

Fix biome formatting issues


juliusmarminge Feb 9, 2026
84b71e0

fix: add error handling and address review feedback


cursoragent Feb 9, 2026
36314bb

Merge origin/main and resolve conflicts


juliusmarminge Feb 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 25 additions & 1 deletion
apps/desktop/src/main.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,10 @@ fixPath();

import { spawn } from "node:child_process";
import path from "node:path";
import { BrowserWindow, app, dialog, ipcMain, session } from "electron";
import { BrowserWindow, app, dialog, ipcMain, session, shell } from "electron";

import {
 EDITORS,
 IPC_CHANNELS,
 type TerminalCommandInput,
 type TerminalCommandResult,
Expand DownExpand Up@@ -125,6 +126,29 @@ function registerIpcHandlers(): void {
 }),
 );

 // Shell handlers
 ipcMain.handle(
 IPC_CHANNELS.shellOpenInEditor,
 async (_event, cwd: string, editor: string) => {
 if (!cwd) throw new Error("cwd is required");
 const editorDef = EDITORS.find((e) => e.id === editor);
 if (!editorDef) throw new Error(`Unknown editor: ${editor}`);
 if (!editorDef.command) {
 const error = await shell.openPath(cwd);
 if (error) throw new Error(error);
 return;
 }
 const child = spawn(editorDef.command, [cwd], {
 detached: true,
 stdio: "ignore",
 });
 child.on("error", () => {
 /* ignore spawn failures for detached editors */
 });
 child.unref();
Comment thread
macroscopeapp[bot] marked this conversation as resolved.

 },

Comment on lines

+129
 to 
+149

@coderabbitaicoderabbitaiBotFeb 9, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
cat -n apps/desktop/src/main.ts | sed -n '135,153p'
Repository: pingdotgg/codething-mvp
Length of output: 848
🌐 Web query:
Electron shell.openPath() return value error handling
💡 Result:
shell.openPath(path) returns a Promise<string> that resolves (not rejects) to:
  • "" (empty string) on success
  • a non-empty error message string on failure (electronjs.org)
So error handling is typically:
import{shell}from"electron";asyncfunctionopenFile(p: string){try{consterr=awaitshell.openPath(p);if(err){// open failed; Electron returns an error message stringconsole.error("openPath failed:",err);// show UI / log / fallback here}}catch(e){// for unexpected exceptions (e.g., bad argument types, other runtime issues)console.error("openPath threw:",e);}}
Key point: check the resolved string—don’t rely only on catch. (electronjs.org)
Citations:
🌐 Web query:
Node.js child_process spawn error event handling
💡 Result:
In Node.js, child_process.spawn() can fail asynchronously, so you should always attach an 'error' handler to the returned ChildProcess:
  • 'error' event is emitted when the process could not be spawned (e.g., ENOENT, EACCES), could not be killed, or IPC send failed. The 'exit' event may or may not fire after an 'error', so don’t rely on 'exit' alone. [1]
  • 'close' event fires after the process ends and all stdio streams are closed; it will emit after 'exit', or after 'error' if the child failed to spawn. [2]
A common safe pattern is to funnel both 'error' and 'close' into a single “done once” handler:
import{spawn}from'node:child_process';functionspawnChecked(cmd,args,opts){constchild=spawn(cmd,args,opts);letsettled=false;constdone=(err,result)=>{if(settled)return;settled=true;if(err)throwerr;// or reject a Promise / call cb(err)returnresult;};child.once('error',(err)=>done(err));// spawn/kill/IPC failurechild.once('close',(code,signal)=>{// stdio fully closedif(code===0)returndone(null,{ code, signal });done(Object.assign(newError(`exit ${code??'null'} (${signal??'no-signal'})`),{ code, signal }));});returnchild;}
Sources: Node.js ChildProcess event docs for 'error' and 'close'. [1] [2]
References

[1] Node.js docs — ChildProcess event: 'error' (nodejs.org)

[2] Node.js v22 docs — ChildProcess event: 'close' (nodejs.org)
Citations:
Add error handling for shell.openPath() and spawn() to prevent crashes and silent failures.
shell.openPath() returns a Promise that resolves to an error string (not thrown), and spawn() emits an 'error' event asynchronously when the process cannot be spawned (e.g., missing CLI). Without handling these, the IPC handler silently fails or crashes. Also guard against empty cwd.
🛠️ Suggested fix
- async (_event, cwd: string, editor: string) => {- if (editor === "file-manager") {- await shell.openPath(cwd);- return;- }+ async (_event, cwd: string, editor: string) => {+ if (!cwd) {+ throw new Error("cwd is required");+ }+ if (editor === "file-manager") {+ const error = await shell.openPath(cwd);+ if (error) {+ throw new Error(error);+ }+ return;+ }
const EDITOR_COMMANDS: Record<string, { command: string; args: (cwd: string) => string[] }> = {
cursor: { command: "cursor", args: (p) => [p] },
};
const entry = EDITOR_COMMANDS[editor];
if (!entry) throw new Error(`Unknown editor: ${editor}`);
- const child = spawn(entry.command, entry.args(cwd), {- detached: true,- stdio: "ignore",- });- child.unref();+ await new Promise<void>((resolve, reject) => {+ const child = spawn(entry.command, entry.args(cwd), {+ detached: true,+ stdio: "ignore",+ });+ child.once("error", reject);+ child.once("spawn", () => {+ child.unref();+ resolve();+ });+ });
},
);
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(editor==="file-manager"){
awaitshell.openPath(cwd);
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.unref();
},
// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(!cwd){
thrownewError("cwd is required");
}
if(editor==="file-manager"){
consterror=awaitshell.openPath(cwd);
if(error){
thrownewError(error);
}
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
awaitnewPromise<void>((resolve,reject)=>{
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.once("error",reject);
child.once("spawn",()=>{
child.unref();
resolve();
});
});
},
);
🤖 Prompt for AI Agents
In `@apps/desktop/src/main.ts` around lines 135 - 153, The IPC handler for
ipcMain.handle should validate cwd is non-empty, await shell.openPath(cwd) and
check its returned string for an error (log/throw when non-empty) instead of
assuming success, and protect the spawn path by wrapping the spawn call in
try/catch and attaching an 'error' listener to the returned child (e.g.,
child.on('error', ...) to log/throw when the CLI cannot be spawned); reference
EDITOR_COMMANDS and entry (from editor) to locate the spawn logic, and ensure
you handle and surface errors for both shell.openPath and spawn so the handler
doesn't crash or fail silently.

 );

 // Agent handlers
 ipcMain.handle(
 IPC_CHANNELS.agentSpawn,
Expand Down

4 changes: 4 additions & 0 deletions
apps/desktop/src/preload.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,10 @@ const nativeApi: NativeApi = {
 ipcRenderer.removeListener(IPC_CHANNELS.providerEvent, listener);
 },
 },
 shell: {
 openInEditor: (cwd: string, editor: string) =>
 ipcRenderer.invoke(IPC_CHANNELS.shellOpenInEditor, cwd, editor),
 },
};

contextBridge.exposeInMainWorld("nativeApi", nativeApi);

95 changes: 95 additions & 0 deletions
apps/renderer/src/components/ChatView.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ import {
 useState,
} from "react";

import { EDITORS, type EditorId } from "@acme/contracts";
import {
 DEFAULT_MODEL,
 DEFAULT_REASONING,
Expand All@@ -32,6 +33,18 @@ function formatMessageMeta(createdAt: string, duration: string | null): string {
 return `${formatTimestamp(createdAt)} • ${duration}`;
}

const FILE_MANAGER_LABEL = navigator.platform.includes("Mac")
 ? "Finder"
 : navigator.platform.includes("Win")
 ? "Explorer"
 : "Files";

function editorLabel(editor: (typeof EDITORS)[number]): string {
 return editor.command ? editor.label : FILE_MANAGER_LABEL;
}

const LAST_EDITOR_KEY = "codething:last-editor";

function workToneClass(tone: "thinking" | "tool" | "info" | "error"): string {
 if (tone === "error") return "text-rose-300/50";
 if (tone === "tool") return "text-[#8a8a8a]";
Expand All@@ -46,12 +59,20 @@ export default function ChatView() {
 const [isSending, setIsSending] = useState(false);
 const [isConnecting, setIsConnecting] = useState(false);
 const [isModelMenuOpen, setIsModelMenuOpen] = useState(false);
 const [isEditorMenuOpen, setIsEditorMenuOpen] = useState(false);
 const [lastEditor, setLastEditor] = useState<EditorId>(() => {
 const stored = localStorage.getItem(LAST_EDITOR_KEY);
 return EDITORS.some((e) => e.id === stored)
 ? (stored as EditorId)
 : EDITORS[0].id;
 });
 const [selectedEffort, setSelectedEffort] =
 useState<string>(DEFAULT_REASONING);
 const [nowTick, setNowTick] = useState(() => Date.now());
 const messagesEndRef = useRef<HTMLDivElement>(null);
 const textareaRef = useRef<HTMLTextAreaElement>(null);
 const modelMenuRef = useRef<HTMLDivElement>(null);
 const editorMenuRef = useRef<HTMLDivElement>(null);

 const activeThread = state.threads.find((t) => t.id === state.activeThreadId);
 const activeProject = state.projects.find(
Expand DownExpand Up@@ -179,6 +200,47 @@ export default function ChatView() {
 };
 }, [isModelMenuOpen]);

 useEffect(() => {
 if (!isEditorMenuOpen) return;

 const handleClickOutside = (event: MouseEvent) => {
 if (!editorMenuRef.current) return;
 if (
 event.target instanceof Node &&
 !editorMenuRef.current.contains(event.target)
 ) {
 setIsEditorMenuOpen(false);
 }
 };

 window.addEventListener("mousedown", handleClickOutside);
 return () => {
 window.removeEventListener("mousedown", handleClickOutside);
 };
 }, [isEditorMenuOpen]);

 // Cmd+O / Ctrl+O to open in last-used editor
 useEffect(() => {
 const handler = (e: globalThis.KeyboardEvent) => {
 if (e.key === "o" && (e.metaKey || e.ctrlKey) && !e.shiftKey) {
 if (api && activeProject) {
 e.preventDefault();
 void api.shell.openInEditor(activeProject.cwd, lastEditor);
 }
 }
Comment thread
coderabbitai[bot] marked this conversation as resolved.

 };
 window.addEventListener("keydown", handler);
 return () => window.removeEventListener("keydown", handler);
 }, [api, activeProject, lastEditor]);

 const openInEditor = (editorId: EditorId) => {
 if (!api || !activeProject) return;
 void api.shell.openInEditor(activeProject.cwd, editorId);
 setLastEditor(editorId);
 localStorage.setItem(LAST_EDITOR_KEY, editorId);
 setIsEditorMenuOpen(false);
 };

 const ensureSession = async (): Promise<string | null> => {
 if (!api || !activeThread || !activeProject) return null;
 if (activeThread.session && activeThread.session.status !== "closed") {
Expand DownExpand Up@@ -313,6 +375,39 @@ export default function ChatView() {
 </h2>
 </div>
 <div className="flex items-center gap-3">
 {/* Open in editor */}
 {activeProject && (
 <div className="relative" ref={editorMenuRef}>
 <button
 type="button"
 className="rounded-md px-2 py-1 text-[10px] text-[#a0a0a0]/40 transition-colors duration-150 hover:text-[#a0a0a0]/60"
 onClick={() => setIsEditorMenuOpen((v) => !v)}
 >
 Open in&hellip;
 </button>
 {isEditorMenuOpen && (
 <div className="absolute right-0 top-full z-50 mt-1 min-w-[120px] rounded-md border border-white/[0.08] bg-[#1b1b1d] py-1 shadow-xl">
 {EDITORS.map((editor) => (
 <button
 key={editor.id}
 type="button"
 className="flex w-full items-center gap-2 px-3 py-1.5 text-left text-[11px] text-[#e0e0e0] hover:bg-white/[0.06]"
 onClick={() => openInEditor(editor.id)}
 >
 {editorLabel(editor)}
 {editor.id === lastEditor && (
 <kbd className="ml-auto text-[9px] text-[#a0a0a0]/40">
 {navigator.platform.includes("Mac")
 ? "\u2318O"
 : "Ctrl+O"}
 </kbd>
 )}
 </button>
 ))}
 </div>
 )}
 </div>
 )}
 {/* Diff toggle */}
 <button
 type="button"
Expand Down

11 changes: 11 additions & 0 deletions
packages/contracts/src/ipc.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,13 @@ import type {
import type { TerminalCommandInput, TerminalCommandResult } from "./terminal";
import type { NewTodoInput, Todo } from "./todo";

export const EDITORS = [
 { id: "cursor", label: "Cursor", command: "cursor" },
 { id: "file-manager", label: "File Manager", command: null },
] as const;

export type EditorId = (typeof EDITORS)[number]["id"];

export const IPC_CHANNELS = {
 todosList: "todos:list",
 todosAdd: "todos:add",
Expand All@@ -29,6 +36,7 @@ export const IPC_CHANNELS = {
 providerSessionStop: "provider:session:stop",
 providerSessionList: "provider:session:list",
 providerEvent: "provider:event",
 shellOpenInEditor: "shell:open-in-editor",
} as const;

export interface NativeApi {
Expand DownExpand Up@@ -63,4 +71,7 @@ export interface NativeApi {
 listSessions: () => Promise<ProviderSession[]>;
 onEvent: (callback: (event: ProviderEvent) => void) => () => void;
 };
 shell: {
 openInEditor: (cwd: string, editor: EditorId) => Promise<void>;
 };
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add open-in-editor feature with Cmd+O shortcut by juliusmarminge · Pull Request #2 · pingdotgg/t3code · GitHub
Skip to content
Add open-in-editor feature with Cmd+O shortcut#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

t3dotgg
merged 5 commits into

from

Feb 9, 2026
 Merged


Add open-in-editor feature with Cmd+O shortcut
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
3303d9a

Add open-in-editor feature with Cmd+O shortcut


juliusmarminge Feb 9, 2026
6204eaf

Move editor definitions to contracts for strict IPC typing


juliusmarminge Feb 9, 2026
c8f33b8

Fix biome formatting issues


juliusmarminge Feb 9, 2026
84b71e0

fix: add error handling and address review feedback


cursoragent Feb 9, 2026
36314bb

Merge origin/main and resolve conflicts


juliusmarminge Feb 9, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 25 additions & 1 deletion
apps/desktop/src/main.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,9 +3,10 @@ fixPath();

import { spawn } from "node:child_process";
import path from "node:path";
import { BrowserWindow, app, dialog, ipcMain, session } from "electron";
import { BrowserWindow, app, dialog, ipcMain, session, shell } from "electron";

import {
 EDITORS,
 IPC_CHANNELS,
 type TerminalCommandInput,
 type TerminalCommandResult,
Expand DownExpand Up@@ -125,6 +126,29 @@ function registerIpcHandlers(): void {
 }),
 );

 // Shell handlers
 ipcMain.handle(
 IPC_CHANNELS.shellOpenInEditor,
 async (_event, cwd: string, editor: string) => {
 if (!cwd) throw new Error("cwd is required");
 const editorDef = EDITORS.find((e) => e.id === editor);
 if (!editorDef) throw new Error(`Unknown editor: ${editor}`);
 if (!editorDef.command) {
 const error = await shell.openPath(cwd);
 if (error) throw new Error(error);
 return;
 }
 const child = spawn(editorDef.command, [cwd], {
 detached: true,
 stdio: "ignore",
 });
 child.on("error", () => {
 /* ignore spawn failures for detached editors */
 });
 child.unref();
Comment thread
macroscopeapp[bot] marked this conversation as resolved.

 },

Comment on lines

+129
 to 
+149

@coderabbitaicoderabbitaiBotFeb 9, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
cat -n apps/desktop/src/main.ts | sed -n '135,153p'
Repository: pingdotgg/codething-mvp
Length of output: 848
🌐 Web query:
Electron shell.openPath() return value error handling
💡 Result:
shell.openPath(path) returns a Promise<string> that resolves (not rejects) to:
  • "" (empty string) on success
  • a non-empty error message string on failure (electronjs.org)
So error handling is typically:
import{shell}from"electron";asyncfunctionopenFile(p: string){try{consterr=awaitshell.openPath(p);if(err){// open failed; Electron returns an error message stringconsole.error("openPath failed:",err);// show UI / log / fallback here}}catch(e){// for unexpected exceptions (e.g., bad argument types, other runtime issues)console.error("openPath threw:",e);}}
Key point: check the resolved string—don’t rely only on catch. (electronjs.org)
Citations:
🌐 Web query:
Node.js child_process spawn error event handling
💡 Result:
In Node.js, child_process.spawn() can fail asynchronously, so you should always attach an 'error' handler to the returned ChildProcess:
  • 'error' event is emitted when the process could not be spawned (e.g., ENOENT, EACCES), could not be killed, or IPC send failed. The 'exit' event may or may not fire after an 'error', so don’t rely on 'exit' alone. [1]
  • 'close' event fires after the process ends and all stdio streams are closed; it will emit after 'exit', or after 'error' if the child failed to spawn. [2]
A common safe pattern is to funnel both 'error' and 'close' into a single “done once” handler:
import{spawn}from'node:child_process';functionspawnChecked(cmd,args,opts){constchild=spawn(cmd,args,opts);letsettled=false;constdone=(err,result)=>{if(settled)return;settled=true;if(err)throwerr;// or reject a Promise / call cb(err)returnresult;};child.once('error',(err)=>done(err));// spawn/kill/IPC failurechild.once('close',(code,signal)=>{// stdio fully closedif(code===0)returndone(null,{ code, signal });done(Object.assign(newError(`exit ${code??'null'} (${signal??'no-signal'})`),{ code, signal }));});returnchild;}
Sources: Node.js ChildProcess event docs for 'error' and 'close'. [1] [2]
References

[1] Node.js docs — ChildProcess event: 'error' (nodejs.org)

[2] Node.js v22 docs — ChildProcess event: 'close' (nodejs.org)
Citations:
Add error handling for shell.openPath() and spawn() to prevent crashes and silent failures.
shell.openPath() returns a Promise that resolves to an error string (not thrown), and spawn() emits an 'error' event asynchronously when the process cannot be spawned (e.g., missing CLI). Without handling these, the IPC handler silently fails or crashes. Also guard against empty cwd.
🛠️ Suggested fix
- async (_event, cwd: string, editor: string) => {- if (editor === "file-manager") {- await shell.openPath(cwd);- return;- }+ async (_event, cwd: string, editor: string) => {+ if (!cwd) {+ throw new Error("cwd is required");+ }+ if (editor === "file-manager") {+ const error = await shell.openPath(cwd);+ if (error) {+ throw new Error(error);+ }+ return;+ }
const EDITOR_COMMANDS: Record<string, { command: string; args: (cwd: string) => string[] }> = {
cursor: { command: "cursor", args: (p) => [p] },
};
const entry = EDITOR_COMMANDS[editor];
if (!entry) throw new Error(`Unknown editor: ${editor}`);
- const child = spawn(entry.command, entry.args(cwd), {- detached: true,- stdio: "ignore",- });- child.unref();+ await new Promise<void>((resolve, reject) => {+ const child = spawn(entry.command, entry.args(cwd), {+ detached: true,+ stdio: "ignore",+ });+ child.once("error", reject);+ child.once("spawn", () => {+ child.unref();+ resolve();+ });+ });
},
);
📝 Committable suggestion
‼️IMPORTANT

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(editor==="file-manager"){
awaitshell.openPath(cwd);
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.unref();
},
// Shell handlers
ipcMain.handle(
IPC_CHANNELS.shellOpenInEditor,
async(_event,cwd: string,editor: string)=>{
if(!cwd){
thrownewError("cwd is required");
}
if(editor==="file-manager"){
consterror=awaitshell.openPath(cwd);
if(error){
thrownewError(error);
}
return;
}
constEDITOR_COMMANDS: Record<string,{command: string;args: (cwd: string)=>string[]}>={
cursor: {command: "cursor",args: (p)=>[p]},
};
constentry=EDITOR_COMMANDS[editor];
if(!entry)thrownewError(`Unknown editor: ${editor}`);
awaitnewPromise<void>((resolve,reject)=>{
constchild=spawn(entry.command,entry.args(cwd),{
detached: true,
stdio: "ignore",
});
child.once("error",reject);
child.once("spawn",()=>{
child.unref();
resolve();
});
});
},
);
🤖 Prompt for AI Agents
In `@apps/desktop/src/main.ts` around lines 135 - 153, The IPC handler for
ipcMain.handle should validate cwd is non-empty, await shell.openPath(cwd) and
check its returned string for an error (log/throw when non-empty) instead of
assuming success, and protect the spawn path by wrapping the spawn call in
try/catch and attaching an 'error' listener to the returned child (e.g.,
child.on('error', ...) to log/throw when the CLI cannot be spawned); reference
EDITOR_COMMANDS and entry (from editor) to locate the spawn logic, and ensure
you handle and surface errors for both shell.openPath and spawn so the handler
doesn't crash or fail silently.

 );

 // Agent handlers
 ipcMain.handle(
 IPC_CHANNELS.agentSpawn,
Expand Down

4 changes: 4 additions & 0 deletions
apps/desktop/src/preload.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,10 @@ const nativeApi: NativeApi = {
 ipcRenderer.removeListener(IPC_CHANNELS.providerEvent, listener);
 },
 },
 shell: {
 openInEditor: (cwd: string, editor: string) =>
 ipcRenderer.invoke(IPC_CHANNELS.shellOpenInEditor, cwd, editor),
 },
};

contextBridge.exposeInMainWorld("nativeApi", nativeApi);

95 changes: 95 additions & 0 deletions
apps/renderer/src/components/ChatView.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ import {
 useState,
} from "react";

import { EDITORS, type EditorId } from "@acme/contracts";
import {
 DEFAULT_MODEL,
 DEFAULT_REASONING,
Expand All@@ -32,6 +33,18 @@ function formatMessageMeta(createdAt: string, duration: string | null): string {
 return `${formatTimestamp(createdAt)} • ${duration}`;
}

const FILE_MANAGER_LABEL = navigator.platform.includes("Mac")
 ? "Finder"
 : navigator.platform.includes("Win")
 ? "Explorer"
 : "Files";

function editorLabel(editor: (typeof EDITORS)[number]): string {
 return editor.command ? editor.label : FILE_MANAGER_LABEL;
}

const LAST_EDITOR_KEY = "codething:last-editor";

function workToneClass(tone: "thinking" | "tool" | "info" | "error"): string {
 if (tone === "error") return "text-rose-300/50";
 if (tone === "tool") return "text-[#8a8a8a]";
Expand All@@ -46,12 +59,20 @@ export default function ChatView() {
 const [isSending, setIsSending] = useState(false);
 const [isConnecting, setIsConnecting] = useState(false);
 const [isModelMenuOpen, setIsModelMenuOpen] = useState(false);
 const [isEditorMenuOpen, setIsEditorMenuOpen] = useState(false);
 const [lastEditor, setLastEditor] = useState<EditorId>(() => {
 const stored = localStorage.getItem(LAST_EDITOR_KEY);
 return EDITORS.some((e) => e.id === stored)
 ? (stored as EditorId)
 : EDITORS[0].id;
 });
 const [selectedEffort, setSelectedEffort] =
 useState<string>(DEFAULT_REASONING);
 const [nowTick, setNowTick] = useState(() => Date.now());
 const messagesEndRef = useRef<HTMLDivElement>(null);
 const textareaRef = useRef<HTMLTextAreaElement>(null);
 const modelMenuRef = useRef<HTMLDivElement>(null);
 const editorMenuRef = useRef<HTMLDivElement>(null);

 const activeThread = state.threads.find((t) => t.id === state.activeThreadId);
 const activeProject = state.projects.find(
Expand DownExpand Up@@ -179,6 +200,47 @@ export default function ChatView() {
 };
 }, [isModelMenuOpen]);

 useEffect(() => {
 if (!isEditorMenuOpen) return;

 const handleClickOutside = (event: MouseEvent) => {
 if (!editorMenuRef.current) return;
 if (
 event.target instanceof Node &&
 !editorMenuRef.current.contains(event.target)
 ) {
 setIsEditorMenuOpen(false);
 }
 };

 window.addEventListener("mousedown", handleClickOutside);
 return () => {
 window.removeEventListener("mousedown", handleClickOutside);
 };
 }, [isEditorMenuOpen]);

 // Cmd+O / Ctrl+O to open in last-used editor
 useEffect(() => {
 const handler = (e: globalThis.KeyboardEvent) => {
 if (e.key === "o" && (e.metaKey || e.ctrlKey) && !e.shiftKey) {
 if (api && activeProject) {
 e.preventDefault();
 void api.shell.openInEditor(activeProject.cwd, lastEditor);
 }
 }
Comment thread
coderabbitai[bot] marked this conversation as resolved.

 };
 window.addEventListener("keydown", handler);
 return () => window.removeEventListener("keydown", handler);
 }, [api, activeProject, lastEditor]);

 const openInEditor = (editorId: EditorId) => {
 if (!api || !activeProject) return;
 void api.shell.openInEditor(activeProject.cwd, editorId);
 setLastEditor(editorId);
 localStorage.setItem(LAST_EDITOR_KEY, editorId);
 setIsEditorMenuOpen(false);
 };

 const ensureSession = async (): Promise<string | null> => {
 if (!api || !activeThread || !activeProject) return null;
 if (activeThread.session && activeThread.session.status !== "closed") {
Expand DownExpand Up@@ -313,6 +375,39 @@ export default function ChatView() {
 </h2>
 </div>
 <div className="flex items-center gap-3">
 {/* Open in editor */}
 {activeProject && (
 <div className="relative" ref={editorMenuRef}>
 <button
 type="button"
 className="rounded-md px-2 py-1 text-[10px] text-[#a0a0a0]/40 transition-colors duration-150 hover:text-[#a0a0a0]/60"
 onClick={() => setIsEditorMenuOpen((v) => !v)}
 >
 Open in&hellip;
 </button>
 {isEditorMenuOpen && (
 <div className="absolute right-0 top-full z-50 mt-1 min-w-[120px] rounded-md border border-white/[0.08] bg-[#1b1b1d] py-1 shadow-xl">
 {EDITORS.map((editor) => (
 <button
 key={editor.id}
 type="button"
 className="flex w-full items-center gap-2 px-3 py-1.5 text-left text-[11px] text-[#e0e0e0] hover:bg-white/[0.06]"
 onClick={() => openInEditor(editor.id)}
 >
 {editorLabel(editor)}
 {editor.id === lastEditor && (
 <kbd className="ml-auto text-[9px] text-[#a0a0a0]/40">
 {navigator.platform.includes("Mac")
 ? "\u2318O"
 : "Ctrl+O"}
 </kbd>
 )}
 </button>
 ))}
 </div>
 )}
 </div>
 )}
 {/* Diff toggle */}
 <button
 type="button"
Expand Down

11 changes: 11 additions & 0 deletions
packages/contracts/src/ipc.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,13 @@ import type {
import type { TerminalCommandInput, TerminalCommandResult } from "./terminal";
import type { NewTodoInput, Todo } from "./todo";

export const EDITORS = [
 { id: "cursor", label: "Cursor", command: "cursor" },
 { id: "file-manager", label: "File Manager", command: null },
] as const;

export type EditorId = (typeof EDITORS)[number]["id"];

export const IPC_CHANNELS = {
 todosList: "todos:list",
 todosAdd: "todos:add",
Expand All@@ -29,6 +36,7 @@ export const IPC_CHANNELS = {
 providerSessionStop: "provider:session:stop",
 providerSessionList: "provider:session:list",
 providerEvent: "provider:event",
 shellOpenInEditor: "shell:open-in-editor",
} as const;

export interface NativeApi {
Expand DownExpand Up@@ -63,4 +71,7 @@ export interface NativeApi {
 listSessions: () => Promise<ProviderSession[]>;
 onEvent: (callback: (event: ProviderEvent) => void) => () => void;
 };
 shell: {
 openInEditor: (cwd: string, editor: EditorId) => Promise<void>;
 };
}