Commit 04e28a8

Browse files
committed
fix: add --root flag to resolve-nightly-release.ts and fix smoke test
The smoke test invoked resolve-nightly-release.ts with --root, but that script had no such flag (causing Effect CLI to reject the invocation) and used a static import for the desktop package.json (always reading the repo's real version instead of the temp fixture). Changes: - Add --root optional flag to resolve-nightly-release.ts that, when provided, reads apps/desktop/package.json from the specified root directory instead of using the static import. - Change smoke test fixture version from 9.9.9-smoke.0 to 9.9.9 so the nightly version derivation produces the expected 9.9.9-nightly.* format without a double prerelease suffix.
1 parent 79c032a commit 04e28a8

2 files changed

Lines changed: 45 additions & 29 deletions

File tree

‎scripts/release-smoke.ts‎

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,31 @@ function writeMacManifestFixtures(targetRoot: string): { arm64Path: string; x64P
3737

3838
writeFileSync(
3939
arm64Path,
40-
`version: 9.9.9-smoke.0
40+
`version: 9.9.9
4141
files:
42-
- url: T3-Code-9.9.9-smoke.0-arm64.zip
42+
- url: T3-Code-9.9.9-arm64.zip
4343
sha512: arm64zip
4444
size: 125621344
45-
- url: T3-Code-9.9.9-smoke.0-arm64.dmg
45+
- url: T3-Code-9.9.9-arm64.dmg
4646
sha512: arm64dmg
4747
size: 131754935
48-
path: T3-Code-9.9.9-smoke.0-arm64.zip
48+
path: T3-Code-9.9.9-arm64.zip
4949
sha512: arm64zip
5050
releaseDate: '2026-03-08T10:32:14.587Z'
5151
`,
5252
);
5353

5454
writeFileSync(
5555
x64Path,
56-
`version: 9.9.9-smoke.0
56+
`version: 9.9.9
5757
files:
58-
- url: T3-Code-9.9.9-smoke.0-x64.zip
58+
- url: T3-Code-9.9.9-x64.zip
5959
sha512: x64zip
6060
size: 132000112
61-
- url: T3-Code-9.9.9-smoke.0-x64.dmg
61+
- url: T3-Code-9.9.9-x64.dmg
6262
sha512: x64dmg
6363
size: 138148807
64-
path: T3-Code-9.9.9-smoke.0-x64.zip
64+
path: T3-Code-9.9.9-x64.zip
6565
sha512: x64zip
6666
releaseDate: '2026-03-08T10:36:07.540Z'
6767
`,
@@ -83,12 +83,7 @@ try {
8383

8484
execFileSync(
8585
process.execPath,
86-
[
87-
resolve(repoRoot,"scripts/update-release-package-versions.ts"),
88-
"9.9.9-smoke.0",
89-
"--root",
90-
tempRoot,
91-
],
86+
[resolve(repoRoot,"scripts/update-release-package-versions.ts"),"9.9.9","--root",tempRoot],
9287
{
9388
cwd: repoRoot,
9489
stdio: "inherit",
@@ -101,11 +96,7 @@ try {
10196
});
10297

10398
constlockfile=readFileSync(resolve(tempRoot,"bun.lock"),"utf8");
104-
assertContains(
105-
lockfile,
106-
`"version": "9.9.9-smoke.0"`,
107-
"Expected bun.lock to contain the smoke version.",
108-
);
99+
assertContains(lockfile,`"version": "9.9.9"`,"Expected bun.lock to contain the smoke version.");
109100

110101
constnightlyReleaseMetadata=execFileSync(
111102
process.execPath,
@@ -149,12 +140,12 @@ try {
149140
constmergedManifest=readFileSync(arm64Path,"utf8");
150141
assertContains(
151142
mergedManifest,
152-
"T3-Code-9.9.9-smoke.0-arm64.zip",
143+
"T3-Code-9.9.9-arm64.zip",
153144
"Merged manifest is missing the arm64 asset.",
154145
);
155146
assertContains(
156147
mergedManifest,
157-
"T3-Code-9.9.9-smoke.0-x64.zip",
148+
"T3-Code-9.9.9-x64.zip",
158149
"Merged manifest is missing the x64 asset.",
159150
);
160151

‎scripts/resolve-nightly-release.ts‎

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import*asNodeRuntimefrom"@effect/platform-node/NodeRuntime";
44
import*asNodeServicesfrom"@effect/platform-node/NodeServices";
5-
import{Config,Effect,FileSystem,Schema}from"effect";
5+
import{resolve}from"node:path";
6+
import{Config,Effect,FileSystem,Option,Schema}from"effect";
67
import{Command,Flag}from"effect/unstable/cli";
78
importdesktopPackageJsonfrom"../apps/desktop/package.json"with{type: "json"};
89

@@ -18,11 +19,25 @@ const DateSchema = Schema.String.check(Schema.isPattern(/^\d{8}$/));
1819
constRunNumberSchema=Schema.FiniteFromString.check(Schema.isGreaterThanOrEqualTo(1));
1920
constShaSchema=Schema.String.check(Schema.isPattern(/^[0-9a-f]{7,40}$/i));
2021

21-
constresolveNightlyReleaseMetadata=(date: string,runNumber: number,sha: string)=>({
22-
baseVersion: desktopPackageJson.version,
23-
version: `${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
24-
tag: `nightly-v${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
25-
name: `T3 Code Nightly ${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
22+
constresolveBaseVersion=(root: string|undefined)=>
23+
Effect.gen(function*(){
24+
if(root===undefined)returndesktopPackageJson.version;
25+
constfs=yield*FileSystem.FileSystem;
26+
constraw=yield*fs.readFileString(resolve(root,"apps/desktop/package.json"));
27+
constparsed=JSON.parse(raw)as{version: string};
28+
returnparsed.version;
29+
});
30+
31+
constresolveNightlyReleaseMetadata=(
32+
baseVersion: string,
33+
date: string,
34+
runNumber: number,
35+
sha: string,
36+
)=>({
37+
baseVersion,
38+
version: `${baseVersion}-nightly.${date}.${runNumber}`,
39+
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
40+
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber}`,
2641
shortSha: sha.slice(0,12),
2742
});
2843

@@ -70,9 +85,19 @@ const command = Command.make(
7085
Flag.withDescription("Write values to GITHUB_OUTPUT instead of stdout."),
7186
Flag.withDefault(false),
7287
),
88+
root: Flag.string("root").pipe(
89+
Flag.withDescription("Override workspace root directory for reading package versions."),
90+
Flag.optional,
91+
),
7392
},
74-
({ date, runNumber, sha, githubOutput })=>
75-
writeOutput(resolveNightlyReleaseMetadata(date,runNumber,sha),githubOutput),
93+
({ date, runNumber, sha, githubOutput, root })=>
94+
Effect.gen(function*(){
95+
constbaseVersion=yield*resolveBaseVersion(Option.getOrUndefined(root));
96+
yield*writeOutput(
97+
resolveNightlyReleaseMetadata(baseVersion,date,runNumber,sha),
98+
githubOutput,
99+
);
100+
}),
76101
).pipe(Command.withDescription("Resolve nightly release version metadata."));
77102

78103
Command.run(command,{version: "0.0.0"}).pipe(

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 04e28a8

Browse files
committed
fix: add --root flag to resolve-nightly-release.ts and fix smoke test
The smoke test invoked resolve-nightly-release.ts with --root, but that script had no such flag (causing Effect CLI to reject the invocation) and used a static import for the desktop package.json (always reading the repo's real version instead of the temp fixture). Changes: - Add --root optional flag to resolve-nightly-release.ts that, when provided, reads apps/desktop/package.json from the specified root directory instead of using the static import. - Change smoke test fixture version from 9.9.9-smoke.0 to 9.9.9 so the nightly version derivation produces the expected 9.9.9-nightly.* format without a double prerelease suffix.
1 parent 79c032a commit 04e28a8

2 files changed

Lines changed: 45 additions & 29 deletions

File tree

‎scripts/release-smoke.ts‎

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,31 @@ function writeMacManifestFixtures(targetRoot: string): { arm64Path: string; x64P
3737

3838
writeFileSync(
3939
arm64Path,
40-
`version: 9.9.9-smoke.0
40+
`version: 9.9.9
4141
files:
42-
- url: T3-Code-9.9.9-smoke.0-arm64.zip
42+
- url: T3-Code-9.9.9-arm64.zip
4343
sha512: arm64zip
4444
size: 125621344
45-
- url: T3-Code-9.9.9-smoke.0-arm64.dmg
45+
- url: T3-Code-9.9.9-arm64.dmg
4646
sha512: arm64dmg
4747
size: 131754935
48-
path: T3-Code-9.9.9-smoke.0-arm64.zip
48+
path: T3-Code-9.9.9-arm64.zip
4949
sha512: arm64zip
5050
releaseDate: '2026-03-08T10:32:14.587Z'
5151
`,
5252
);
5353

5454
writeFileSync(
5555
x64Path,
56-
`version: 9.9.9-smoke.0
56+
`version: 9.9.9
5757
files:
58-
- url: T3-Code-9.9.9-smoke.0-x64.zip
58+
- url: T3-Code-9.9.9-x64.zip
5959
sha512: x64zip
6060
size: 132000112
61-
- url: T3-Code-9.9.9-smoke.0-x64.dmg
61+
- url: T3-Code-9.9.9-x64.dmg
6262
sha512: x64dmg
6363
size: 138148807
64-
path: T3-Code-9.9.9-smoke.0-x64.zip
64+
path: T3-Code-9.9.9-x64.zip
6565
sha512: x64zip
6666
releaseDate: '2026-03-08T10:36:07.540Z'
6767
`,
@@ -83,12 +83,7 @@ try {
8383

8484
execFileSync(
8585
process.execPath,
86-
[
87-
resolve(repoRoot,"scripts/update-release-package-versions.ts"),
88-
"9.9.9-smoke.0",
89-
"--root",
90-
tempRoot,
91-
],
86+
[resolve(repoRoot,"scripts/update-release-package-versions.ts"),"9.9.9","--root",tempRoot],
9287
{
9388
cwd: repoRoot,
9489
stdio: "inherit",
@@ -101,11 +96,7 @@ try {
10196
});
10297

10398
constlockfile=readFileSync(resolve(tempRoot,"bun.lock"),"utf8");
104-
assertContains(
105-
lockfile,
106-
`"version": "9.9.9-smoke.0"`,
107-
"Expected bun.lock to contain the smoke version.",
108-
);
99+
assertContains(lockfile,`"version": "9.9.9"`,"Expected bun.lock to contain the smoke version.");
109100

110101
constnightlyReleaseMetadata=execFileSync(
111102
process.execPath,
@@ -149,12 +140,12 @@ try {
149140
constmergedManifest=readFileSync(arm64Path,"utf8");
150141
assertContains(
151142
mergedManifest,
152-
"T3-Code-9.9.9-smoke.0-arm64.zip",
143+
"T3-Code-9.9.9-arm64.zip",
153144
"Merged manifest is missing the arm64 asset.",
154145
);
155146
assertContains(
156147
mergedManifest,
157-
"T3-Code-9.9.9-smoke.0-x64.zip",
148+
"T3-Code-9.9.9-x64.zip",
158149
"Merged manifest is missing the x64 asset.",
159150
);
160151

‎scripts/resolve-nightly-release.ts‎

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import*asNodeRuntimefrom"@effect/platform-node/NodeRuntime";
44
import*asNodeServicesfrom"@effect/platform-node/NodeServices";
5-
import{Config,Effect,FileSystem,Schema}from"effect";
5+
import{resolve}from"node:path";
6+
import{Config,Effect,FileSystem,Option,Schema}from"effect";
67
import{Command,Flag}from"effect/unstable/cli";
78
importdesktopPackageJsonfrom"../apps/desktop/package.json"with{type: "json"};
89

@@ -18,11 +19,25 @@ const DateSchema = Schema.String.check(Schema.isPattern(/^\d{8}$/));
1819
constRunNumberSchema=Schema.FiniteFromString.check(Schema.isGreaterThanOrEqualTo(1));
1920
constShaSchema=Schema.String.check(Schema.isPattern(/^[0-9a-f]{7,40}$/i));
2021

21-
constresolveNightlyReleaseMetadata=(date: string,runNumber: number,sha: string)=>({
22-
baseVersion: desktopPackageJson.version,
23-
version: `${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
24-
tag: `nightly-v${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
25-
name: `T3 Code Nightly ${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
22+
constresolveBaseVersion=(root: string|undefined)=>
23+
Effect.gen(function*(){
24+
if(root===undefined)returndesktopPackageJson.version;
25+
constfs=yield*FileSystem.FileSystem;
26+
constraw=yield*fs.readFileString(resolve(root,"apps/desktop/package.json"));
27+
constparsed=JSON.parse(raw)as{version: string};
28+
returnparsed.version;
29+
});
30+
31+
constresolveNightlyReleaseMetadata=(
32+
baseVersion: string,
33+
date: string,
34+
runNumber: number,
35+
sha: string,
36+
)=>({
37+
baseVersion,
38+
version: `${baseVersion}-nightly.${date}.${runNumber}`,
39+
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
40+
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber}`,
2641
shortSha: sha.slice(0,12),
2742
});
2843

@@ -70,9 +85,19 @@ const command = Command.make(
7085
Flag.withDescription("Write values to GITHUB_OUTPUT instead of stdout."),
7186
Flag.withDefault(false),
7287
),
88+
root: Flag.string("root").pipe(
89+
Flag.withDescription("Override workspace root directory for reading package versions."),
90+
Flag.optional,
91+
),
7392
},
74-
({ date, runNumber, sha, githubOutput })=>
75-
writeOutput(resolveNightlyReleaseMetadata(date,runNumber,sha),githubOutput),
93+
({ date, runNumber, sha, githubOutput, root })=>
94+
Effect.gen(function*(){
95+
constbaseVersion=yield*resolveBaseVersion(Option.getOrUndefined(root));
96+
yield*writeOutput(
97+
resolveNightlyReleaseMetadata(baseVersion,date,runNumber,sha),
98+
githubOutput,
99+
);
100+
}),
76101
).pipe(Command.withDescription("Resolve nightly release version metadata."));
77102

78103
Command.run(command,{version: "0.0.0"}).pipe(

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 04e28a8

Browse files
committed
fix: add --root flag to resolve-nightly-release.ts and fix smoke test
The smoke test invoked resolve-nightly-release.ts with --root, but that script had no such flag (causing Effect CLI to reject the invocation) and used a static import for the desktop package.json (always reading the repo's real version instead of the temp fixture). Changes: - Add --root optional flag to resolve-nightly-release.ts that, when provided, reads apps/desktop/package.json from the specified root directory instead of using the static import. - Change smoke test fixture version from 9.9.9-smoke.0 to 9.9.9 so the nightly version derivation produces the expected 9.9.9-nightly.* format without a double prerelease suffix.
1 parent 79c032a commit 04e28a8

2 files changed

Lines changed: 45 additions & 29 deletions

File tree

‎scripts/release-smoke.ts‎

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,31 @@ function writeMacManifestFixtures(targetRoot: string): { arm64Path: string; x64P
3737

3838
writeFileSync(
3939
arm64Path,
40-
`version: 9.9.9-smoke.0
40+
`version: 9.9.9
4141
files:
42-
- url: T3-Code-9.9.9-smoke.0-arm64.zip
42+
- url: T3-Code-9.9.9-arm64.zip
4343
sha512: arm64zip
4444
size: 125621344
45-
- url: T3-Code-9.9.9-smoke.0-arm64.dmg
45+
- url: T3-Code-9.9.9-arm64.dmg
4646
sha512: arm64dmg
4747
size: 131754935
48-
path: T3-Code-9.9.9-smoke.0-arm64.zip
48+
path: T3-Code-9.9.9-arm64.zip
4949
sha512: arm64zip
5050
releaseDate: '2026-03-08T10:32:14.587Z'
5151
`,
5252
);
5353

5454
writeFileSync(
5555
x64Path,
56-
`version: 9.9.9-smoke.0
56+
`version: 9.9.9
5757
files:
58-
- url: T3-Code-9.9.9-smoke.0-x64.zip
58+
- url: T3-Code-9.9.9-x64.zip
5959
sha512: x64zip
6060
size: 132000112
61-
- url: T3-Code-9.9.9-smoke.0-x64.dmg
61+
- url: T3-Code-9.9.9-x64.dmg
6262
sha512: x64dmg
6363
size: 138148807
64-
path: T3-Code-9.9.9-smoke.0-x64.zip
64+
path: T3-Code-9.9.9-x64.zip
6565
sha512: x64zip
6666
releaseDate: '2026-03-08T10:36:07.540Z'
6767
`,
@@ -83,12 +83,7 @@ try {
8383

8484
execFileSync(
8585
process.execPath,
86-
[
87-
resolve(repoRoot,"scripts/update-release-package-versions.ts"),
88-
"9.9.9-smoke.0",
89-
"--root",
90-
tempRoot,
91-
],
86+
[resolve(repoRoot,"scripts/update-release-package-versions.ts"),"9.9.9","--root",tempRoot],
9287
{
9388
cwd: repoRoot,
9489
stdio: "inherit",
@@ -101,11 +96,7 @@ try {
10196
});
10297

10398
constlockfile=readFileSync(resolve(tempRoot,"bun.lock"),"utf8");
104-
assertContains(
105-
lockfile,
106-
`"version": "9.9.9-smoke.0"`,
107-
"Expected bun.lock to contain the smoke version.",
108-
);
99+
assertContains(lockfile,`"version": "9.9.9"`,"Expected bun.lock to contain the smoke version.");
109100

110101
constnightlyReleaseMetadata=execFileSync(
111102
process.execPath,
@@ -149,12 +140,12 @@ try {
149140
constmergedManifest=readFileSync(arm64Path,"utf8");
150141
assertContains(
151142
mergedManifest,
152-
"T3-Code-9.9.9-smoke.0-arm64.zip",
143+
"T3-Code-9.9.9-arm64.zip",
153144
"Merged manifest is missing the arm64 asset.",
154145
);
155146
assertContains(
156147
mergedManifest,
157-
"T3-Code-9.9.9-smoke.0-x64.zip",
148+
"T3-Code-9.9.9-x64.zip",
158149
"Merged manifest is missing the x64 asset.",
159150
);
160151

‎scripts/resolve-nightly-release.ts‎

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import*asNodeRuntimefrom"@effect/platform-node/NodeRuntime";
44
import*asNodeServicesfrom"@effect/platform-node/NodeServices";
5-
import{Config,Effect,FileSystem,Schema}from"effect";
5+
import{resolve}from"node:path";
6+
import{Config,Effect,FileSystem,Option,Schema}from"effect";
67
import{Command,Flag}from"effect/unstable/cli";
78
importdesktopPackageJsonfrom"../apps/desktop/package.json"with{type: "json"};
89

@@ -18,11 +19,25 @@ const DateSchema = Schema.String.check(Schema.isPattern(/^\d{8}$/));
1819
constRunNumberSchema=Schema.FiniteFromString.check(Schema.isGreaterThanOrEqualTo(1));
1920
constShaSchema=Schema.String.check(Schema.isPattern(/^[0-9a-f]{7,40}$/i));
2021

21-
constresolveNightlyReleaseMetadata=(date: string,runNumber: number,sha: string)=>({
22-
baseVersion: desktopPackageJson.version,
23-
version: `${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
24-
tag: `nightly-v${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
25-
name: `T3 Code Nightly ${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
22+
constresolveBaseVersion=(root: string|undefined)=>
23+
Effect.gen(function*(){
24+
if(root===undefined)returndesktopPackageJson.version;
25+
constfs=yield*FileSystem.FileSystem;
26+
constraw=yield*fs.readFileString(resolve(root,"apps/desktop/package.json"));
27+
constparsed=JSON.parse(raw)as{version: string};
28+
returnparsed.version;
29+
});
30+
31+
constresolveNightlyReleaseMetadata=(
32+
baseVersion: string,
33+
date: string,
34+
runNumber: number,
35+
sha: string,
36+
)=>({
37+
baseVersion,
38+
version: `${baseVersion}-nightly.${date}.${runNumber}`,
39+
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
40+
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber}`,
2641
shortSha: sha.slice(0,12),
2742
});
2843

@@ -70,9 +85,19 @@ const command = Command.make(
7085
Flag.withDescription("Write values to GITHUB_OUTPUT instead of stdout."),
7186
Flag.withDefault(false),
7287
),
88+
root: Flag.string("root").pipe(
89+
Flag.withDescription("Override workspace root directory for reading package versions."),
90+
Flag.optional,
91+
),
7392
},
74-
({ date, runNumber, sha, githubOutput })=>
75-
writeOutput(resolveNightlyReleaseMetadata(date,runNumber,sha),githubOutput),
93+
({ date, runNumber, sha, githubOutput, root })=>
94+
Effect.gen(function*(){
95+
constbaseVersion=yield*resolveBaseVersion(Option.getOrUndefined(root));
96+
yield*writeOutput(
97+
resolveNightlyReleaseMetadata(baseVersion,date,runNumber,sha),
98+
githubOutput,
99+
);
100+
}),
76101
).pipe(Command.withDescription("Resolve nightly release version metadata."));
77102

78103
Command.run(command,{version: "0.0.0"}).pipe(

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 04e28a8

Browse files
committed
fix: add --root flag to resolve-nightly-release.ts and fix smoke test
The smoke test invoked resolve-nightly-release.ts with --root, but that script had no such flag (causing Effect CLI to reject the invocation) and used a static import for the desktop package.json (always reading the repo's real version instead of the temp fixture). Changes: - Add --root optional flag to resolve-nightly-release.ts that, when provided, reads apps/desktop/package.json from the specified root directory instead of using the static import. - Change smoke test fixture version from 9.9.9-smoke.0 to 9.9.9 so the nightly version derivation produces the expected 9.9.9-nightly.* format without a double prerelease suffix.
1 parent 79c032a commit 04e28a8

2 files changed

Lines changed: 45 additions & 29 deletions

File tree

‎scripts/release-smoke.ts‎

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,31 @@ function writeMacManifestFixtures(targetRoot: string): { arm64Path: string; x64P
3737

3838
writeFileSync(
3939
arm64Path,
40-
`version: 9.9.9-smoke.0
40+
`version: 9.9.9
4141
files:
42-
- url: T3-Code-9.9.9-smoke.0-arm64.zip
42+
- url: T3-Code-9.9.9-arm64.zip
4343
sha512: arm64zip
4444
size: 125621344
45-
- url: T3-Code-9.9.9-smoke.0-arm64.dmg
45+
- url: T3-Code-9.9.9-arm64.dmg
4646
sha512: arm64dmg
4747
size: 131754935
48-
path: T3-Code-9.9.9-smoke.0-arm64.zip
48+
path: T3-Code-9.9.9-arm64.zip
4949
sha512: arm64zip
5050
releaseDate: '2026-03-08T10:32:14.587Z'
5151
`,
5252
);
5353

5454
writeFileSync(
5555
x64Path,
56-
`version: 9.9.9-smoke.0
56+
`version: 9.9.9
5757
files:
58-
- url: T3-Code-9.9.9-smoke.0-x64.zip
58+
- url: T3-Code-9.9.9-x64.zip
5959
sha512: x64zip
6060
size: 132000112
61-
- url: T3-Code-9.9.9-smoke.0-x64.dmg
61+
- url: T3-Code-9.9.9-x64.dmg
6262
sha512: x64dmg
6363
size: 138148807
64-
path: T3-Code-9.9.9-smoke.0-x64.zip
64+
path: T3-Code-9.9.9-x64.zip
6565
sha512: x64zip
6666
releaseDate: '2026-03-08T10:36:07.540Z'
6767
`,
@@ -83,12 +83,7 @@ try {
8383

8484
execFileSync(
8585
process.execPath,
86-
[
87-
resolve(repoRoot,"scripts/update-release-package-versions.ts"),
88-
"9.9.9-smoke.0",
89-
"--root",
90-
tempRoot,
91-
],
86+
[resolve(repoRoot,"scripts/update-release-package-versions.ts"),"9.9.9","--root",tempRoot],
9287
{
9388
cwd: repoRoot,
9489
stdio: "inherit",
@@ -101,11 +96,7 @@ try {
10196
});
10297

10398
constlockfile=readFileSync(resolve(tempRoot,"bun.lock"),"utf8");
104-
assertContains(
105-
lockfile,
106-
`"version": "9.9.9-smoke.0"`,
107-
"Expected bun.lock to contain the smoke version.",
108-
);
99+
assertContains(lockfile,`"version": "9.9.9"`,"Expected bun.lock to contain the smoke version.");
109100

110101
constnightlyReleaseMetadata=execFileSync(
111102
process.execPath,
@@ -149,12 +140,12 @@ try {
149140
constmergedManifest=readFileSync(arm64Path,"utf8");
150141
assertContains(
151142
mergedManifest,
152-
"T3-Code-9.9.9-smoke.0-arm64.zip",
143+
"T3-Code-9.9.9-arm64.zip",
153144
"Merged manifest is missing the arm64 asset.",
154145
);
155146
assertContains(
156147
mergedManifest,
157-
"T3-Code-9.9.9-smoke.0-x64.zip",
148+
"T3-Code-9.9.9-x64.zip",
158149
"Merged manifest is missing the x64 asset.",
159150
);
160151

‎scripts/resolve-nightly-release.ts‎

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import*asNodeRuntimefrom"@effect/platform-node/NodeRuntime";
44
import*asNodeServicesfrom"@effect/platform-node/NodeServices";
5-
import{Config,Effect,FileSystem,Schema}from"effect";
5+
import{resolve}from"node:path";
6+
import{Config,Effect,FileSystem,Option,Schema}from"effect";
67
import{Command,Flag}from"effect/unstable/cli";
78
importdesktopPackageJsonfrom"../apps/desktop/package.json"with{type: "json"};
89

@@ -18,11 +19,25 @@ const DateSchema = Schema.String.check(Schema.isPattern(/^\d{8}$/));
1819
constRunNumberSchema=Schema.FiniteFromString.check(Schema.isGreaterThanOrEqualTo(1));
1920
constShaSchema=Schema.String.check(Schema.isPattern(/^[0-9a-f]{7,40}$/i));
2021

21-
constresolveNightlyReleaseMetadata=(date: string,runNumber: number,sha: string)=>({
22-
baseVersion: desktopPackageJson.version,
23-
version: `${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
24-
tag: `nightly-v${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
25-
name: `T3 Code Nightly ${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
22+
constresolveBaseVersion=(root: string|undefined)=>
23+
Effect.gen(function*(){
24+
if(root===undefined)returndesktopPackageJson.version;
25+
constfs=yield*FileSystem.FileSystem;
26+
constraw=yield*fs.readFileString(resolve(root,"apps/desktop/package.json"));
27+
constparsed=JSON.parse(raw)as{version: string};
28+
returnparsed.version;
29+
});
30+
31+
constresolveNightlyReleaseMetadata=(
32+
baseVersion: string,
33+
date: string,
34+
runNumber: number,
35+
sha: string,
36+
)=>({
37+
baseVersion,
38+
version: `${baseVersion}-nightly.${date}.${runNumber}`,
39+
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
40+
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber}`,
2641
shortSha: sha.slice(0,12),
2742
});
2843

@@ -70,9 +85,19 @@ const command = Command.make(
7085
Flag.withDescription("Write values to GITHUB_OUTPUT instead of stdout."),
7186
Flag.withDefault(false),
7287
),
88+
root: Flag.string("root").pipe(
89+
Flag.withDescription("Override workspace root directory for reading package versions."),
90+
Flag.optional,
91+
),
7392
},
74-
({ date, runNumber, sha, githubOutput })=>
75-
writeOutput(resolveNightlyReleaseMetadata(date,runNumber,sha),githubOutput),
93+
({ date, runNumber, sha, githubOutput, root })=>
94+
Effect.gen(function*(){
95+
constbaseVersion=yield*resolveBaseVersion(Option.getOrUndefined(root));
96+
yield*writeOutput(
97+
resolveNightlyReleaseMetadata(baseVersion,date,runNumber,sha),
98+
githubOutput,
99+
);
100+
}),
76101
).pipe(Command.withDescription("Resolve nightly release version metadata."));
77102

78103
Command.run(command,{version: "0.0.0"}).pipe(

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 04e28a8

Browse files
committed
fix: add --root flag to resolve-nightly-release.ts and fix smoke test
The smoke test invoked resolve-nightly-release.ts with --root, but that script had no such flag (causing Effect CLI to reject the invocation) and used a static import for the desktop package.json (always reading the repo's real version instead of the temp fixture). Changes: - Add --root optional flag to resolve-nightly-release.ts that, when provided, reads apps/desktop/package.json from the specified root directory instead of using the static import. - Change smoke test fixture version from 9.9.9-smoke.0 to 9.9.9 so the nightly version derivation produces the expected 9.9.9-nightly.* format without a double prerelease suffix.
1 parent 79c032a commit 04e28a8

2 files changed

Lines changed: 45 additions & 29 deletions

File tree

‎scripts/release-smoke.ts‎

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,31 @@ function writeMacManifestFixtures(targetRoot: string): { arm64Path: string; x64P
3737

3838
writeFileSync(
3939
arm64Path,
40-
`version: 9.9.9-smoke.0
40+
`version: 9.9.9
4141
files:
42-
- url: T3-Code-9.9.9-smoke.0-arm64.zip
42+
- url: T3-Code-9.9.9-arm64.zip
4343
sha512: arm64zip
4444
size: 125621344
45-
- url: T3-Code-9.9.9-smoke.0-arm64.dmg
45+
- url: T3-Code-9.9.9-arm64.dmg
4646
sha512: arm64dmg
4747
size: 131754935
48-
path: T3-Code-9.9.9-smoke.0-arm64.zip
48+
path: T3-Code-9.9.9-arm64.zip
4949
sha512: arm64zip
5050
releaseDate: '2026-03-08T10:32:14.587Z'
5151
`,
5252
);
5353

5454
writeFileSync(
5555
x64Path,
56-
`version: 9.9.9-smoke.0
56+
`version: 9.9.9
5757
files:
58-
- url: T3-Code-9.9.9-smoke.0-x64.zip
58+
- url: T3-Code-9.9.9-x64.zip
5959
sha512: x64zip
6060
size: 132000112
61-
- url: T3-Code-9.9.9-smoke.0-x64.dmg
61+
- url: T3-Code-9.9.9-x64.dmg
6262
sha512: x64dmg
6363
size: 138148807
64-
path: T3-Code-9.9.9-smoke.0-x64.zip
64+
path: T3-Code-9.9.9-x64.zip
6565
sha512: x64zip
6666
releaseDate: '2026-03-08T10:36:07.540Z'
6767
`,
@@ -83,12 +83,7 @@ try {
8383

8484
execFileSync(
8585
process.execPath,
86-
[
87-
resolve(repoRoot,"scripts/update-release-package-versions.ts"),
88-
"9.9.9-smoke.0",
89-
"--root",
90-
tempRoot,
91-
],
86+
[resolve(repoRoot,"scripts/update-release-package-versions.ts"),"9.9.9","--root",tempRoot],
9287
{
9388
cwd: repoRoot,
9489
stdio: "inherit",
@@ -101,11 +96,7 @@ try {
10196
});
10297

10398
constlockfile=readFileSync(resolve(tempRoot,"bun.lock"),"utf8");
104-
assertContains(
105-
lockfile,
106-
`"version": "9.9.9-smoke.0"`,
107-
"Expected bun.lock to contain the smoke version.",
108-
);
99+
assertContains(lockfile,`"version": "9.9.9"`,"Expected bun.lock to contain the smoke version.");
109100

110101
constnightlyReleaseMetadata=execFileSync(
111102
process.execPath,
@@ -149,12 +140,12 @@ try {
149140
constmergedManifest=readFileSync(arm64Path,"utf8");
150141
assertContains(
151142
mergedManifest,
152-
"T3-Code-9.9.9-smoke.0-arm64.zip",
143+
"T3-Code-9.9.9-arm64.zip",
153144
"Merged manifest is missing the arm64 asset.",
154145
);
155146
assertContains(
156147
mergedManifest,
157-
"T3-Code-9.9.9-smoke.0-x64.zip",
148+
"T3-Code-9.9.9-x64.zip",
158149
"Merged manifest is missing the x64 asset.",
159150
);
160151

‎scripts/resolve-nightly-release.ts‎

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import*asNodeRuntimefrom"@effect/platform-node/NodeRuntime";
44
import*asNodeServicesfrom"@effect/platform-node/NodeServices";
5-
import{Config,Effect,FileSystem,Schema}from"effect";
5+
import{resolve}from"node:path";
6+
import{Config,Effect,FileSystem,Option,Schema}from"effect";
67
import{Command,Flag}from"effect/unstable/cli";
78
importdesktopPackageJsonfrom"../apps/desktop/package.json"with{type: "json"};
89

@@ -18,11 +19,25 @@ const DateSchema = Schema.String.check(Schema.isPattern(/^\d{8}$/));
1819
constRunNumberSchema=Schema.FiniteFromString.check(Schema.isGreaterThanOrEqualTo(1));
1920
constShaSchema=Schema.String.check(Schema.isPattern(/^[0-9a-f]{7,40}$/i));
2021

21-
constresolveNightlyReleaseMetadata=(date: string,runNumber: number,sha: string)=>({
22-
baseVersion: desktopPackageJson.version,
23-
version: `${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
24-
tag: `nightly-v${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
25-
name: `T3 Code Nightly ${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
22+
constresolveBaseVersion=(root: string|undefined)=>
23+
Effect.gen(function*(){
24+
if(root===undefined)returndesktopPackageJson.version;
25+
constfs=yield*FileSystem.FileSystem;
26+
constraw=yield*fs.readFileString(resolve(root,"apps/desktop/package.json"));
27+
constparsed=JSON.parse(raw)as{version: string};
28+
returnparsed.version;
29+
});
30+
31+
constresolveNightlyReleaseMetadata=(
32+
baseVersion: string,
33+
date: string,
34+
runNumber: number,
35+
sha: string,
36+
)=>({
37+
baseVersion,
38+
version: `${baseVersion}-nightly.${date}.${runNumber}`,
39+
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
40+
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber}`,
2641
shortSha: sha.slice(0,12),
2742
});
2843

@@ -70,9 +85,19 @@ const command = Command.make(
7085
Flag.withDescription("Write values to GITHUB_OUTPUT instead of stdout."),
7186
Flag.withDefault(false),
7287
),
88+
root: Flag.string("root").pipe(
89+
Flag.withDescription("Override workspace root directory for reading package versions."),
90+
Flag.optional,
91+
),
7392
},
74-
({ date, runNumber, sha, githubOutput })=>
75-
writeOutput(resolveNightlyReleaseMetadata(date,runNumber,sha),githubOutput),
93+
({ date, runNumber, sha, githubOutput, root })=>
94+
Effect.gen(function*(){
95+
constbaseVersion=yield*resolveBaseVersion(Option.getOrUndefined(root));
96+
yield*writeOutput(
97+
resolveNightlyReleaseMetadata(baseVersion,date,runNumber,sha),
98+
githubOutput,
99+
);
100+
}),
76101
).pipe(Command.withDescription("Resolve nightly release version metadata."));
77102

78103
Command.run(command,{version: "0.0.0"}).pipe(

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 04e28a8

Browse files
committed
fix: add --root flag to resolve-nightly-release.ts and fix smoke test
The smoke test invoked resolve-nightly-release.ts with --root, but that script had no such flag (causing Effect CLI to reject the invocation) and used a static import for the desktop package.json (always reading the repo's real version instead of the temp fixture). Changes: - Add --root optional flag to resolve-nightly-release.ts that, when provided, reads apps/desktop/package.json from the specified root directory instead of using the static import. - Change smoke test fixture version from 9.9.9-smoke.0 to 9.9.9 so the nightly version derivation produces the expected 9.9.9-nightly.* format without a double prerelease suffix.
1 parent 79c032a commit 04e28a8

2 files changed

Lines changed: 45 additions & 29 deletions

File tree

‎scripts/release-smoke.ts‎

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,31 @@ function writeMacManifestFixtures(targetRoot: string): { arm64Path: string; x64P
3737

3838
writeFileSync(
3939
arm64Path,
40-
`version: 9.9.9-smoke.0
40+
`version: 9.9.9
4141
files:
42-
- url: T3-Code-9.9.9-smoke.0-arm64.zip
42+
- url: T3-Code-9.9.9-arm64.zip
4343
sha512: arm64zip
4444
size: 125621344
45-
- url: T3-Code-9.9.9-smoke.0-arm64.dmg
45+
- url: T3-Code-9.9.9-arm64.dmg
4646
sha512: arm64dmg
4747
size: 131754935
48-
path: T3-Code-9.9.9-smoke.0-arm64.zip
48+
path: T3-Code-9.9.9-arm64.zip
4949
sha512: arm64zip
5050
releaseDate: '2026-03-08T10:32:14.587Z'
5151
`,
5252
);
5353

5454
writeFileSync(
5555
x64Path,
56-
`version: 9.9.9-smoke.0
56+
`version: 9.9.9
5757
files:
58-
- url: T3-Code-9.9.9-smoke.0-x64.zip
58+
- url: T3-Code-9.9.9-x64.zip
5959
sha512: x64zip
6060
size: 132000112
61-
- url: T3-Code-9.9.9-smoke.0-x64.dmg
61+
- url: T3-Code-9.9.9-x64.dmg
6262
sha512: x64dmg
6363
size: 138148807
64-
path: T3-Code-9.9.9-smoke.0-x64.zip
64+
path: T3-Code-9.9.9-x64.zip
6565
sha512: x64zip
6666
releaseDate: '2026-03-08T10:36:07.540Z'
6767
`,
@@ -83,12 +83,7 @@ try {
8383

8484
execFileSync(
8585
process.execPath,
86-
[
87-
resolve(repoRoot,"scripts/update-release-package-versions.ts"),
88-
"9.9.9-smoke.0",
89-
"--root",
90-
tempRoot,
91-
],
86+
[resolve(repoRoot,"scripts/update-release-package-versions.ts"),"9.9.9","--root",tempRoot],
9287
{
9388
cwd: repoRoot,
9489
stdio: "inherit",
@@ -101,11 +96,7 @@ try {
10196
});
10297

10398
constlockfile=readFileSync(resolve(tempRoot,"bun.lock"),"utf8");
104-
assertContains(
105-
lockfile,
106-
`"version": "9.9.9-smoke.0"`,
107-
"Expected bun.lock to contain the smoke version.",
108-
);
99+
assertContains(lockfile,`"version": "9.9.9"`,"Expected bun.lock to contain the smoke version.");
109100

110101
constnightlyReleaseMetadata=execFileSync(
111102
process.execPath,
@@ -149,12 +140,12 @@ try {
149140
constmergedManifest=readFileSync(arm64Path,"utf8");
150141
assertContains(
151142
mergedManifest,
152-
"T3-Code-9.9.9-smoke.0-arm64.zip",
143+
"T3-Code-9.9.9-arm64.zip",
153144
"Merged manifest is missing the arm64 asset.",
154145
);
155146
assertContains(
156147
mergedManifest,
157-
"T3-Code-9.9.9-smoke.0-x64.zip",
148+
"T3-Code-9.9.9-x64.zip",
158149
"Merged manifest is missing the x64 asset.",
159150
);
160151

‎scripts/resolve-nightly-release.ts‎

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import*asNodeRuntimefrom"@effect/platform-node/NodeRuntime";
44
import*asNodeServicesfrom"@effect/platform-node/NodeServices";
5-
import{Config,Effect,FileSystem,Schema}from"effect";
5+
import{resolve}from"node:path";
6+
import{Config,Effect,FileSystem,Option,Schema}from"effect";
67
import{Command,Flag}from"effect/unstable/cli";
78
importdesktopPackageJsonfrom"../apps/desktop/package.json"with{type: "json"};
89

@@ -18,11 +19,25 @@ const DateSchema = Schema.String.check(Schema.isPattern(/^\d{8}$/));
1819
constRunNumberSchema=Schema.FiniteFromString.check(Schema.isGreaterThanOrEqualTo(1));
1920
constShaSchema=Schema.String.check(Schema.isPattern(/^[0-9a-f]{7,40}$/i));
2021

21-
constresolveNightlyReleaseMetadata=(date: string,runNumber: number,sha: string)=>({
22-
baseVersion: desktopPackageJson.version,
23-
version: `${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
24-
tag: `nightly-v${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
25-
name: `T3 Code Nightly ${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
22+
constresolveBaseVersion=(root: string|undefined)=>
23+
Effect.gen(function*(){
24+
if(root===undefined)returndesktopPackageJson.version;
25+
constfs=yield*FileSystem.FileSystem;
26+
constraw=yield*fs.readFileString(resolve(root,"apps/desktop/package.json"));
27+
constparsed=JSON.parse(raw)as{version: string};
28+
returnparsed.version;
29+
});
30+
31+
constresolveNightlyReleaseMetadata=(
32+
baseVersion: string,
33+
date: string,
34+
runNumber: number,
35+
sha: string,
36+
)=>({
37+
baseVersion,
38+
version: `${baseVersion}-nightly.${date}.${runNumber}`,
39+
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
40+
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber}`,
2641
shortSha: sha.slice(0,12),
2742
});
2843

@@ -70,9 +85,19 @@ const command = Command.make(
7085
Flag.withDescription("Write values to GITHUB_OUTPUT instead of stdout."),
7186
Flag.withDefault(false),
7287
),
88+
root: Flag.string("root").pipe(
89+
Flag.withDescription("Override workspace root directory for reading package versions."),
90+
Flag.optional,
91+
),
7392
},
74-
({ date, runNumber, sha, githubOutput })=>
75-
writeOutput(resolveNightlyReleaseMetadata(date,runNumber,sha),githubOutput),
93+
({ date, runNumber, sha, githubOutput, root })=>
94+
Effect.gen(function*(){
95+
constbaseVersion=yield*resolveBaseVersion(Option.getOrUndefined(root));
96+
yield*writeOutput(
97+
resolveNightlyReleaseMetadata(baseVersion,date,runNumber,sha),
98+
githubOutput,
99+
);
100+
}),
76101
).pipe(Command.withDescription("Resolve nightly release version metadata."));
77102

78103
Command.run(command,{version: "0.0.0"}).pipe(

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 04e28a8

Browse files
committed
fix: add --root flag to resolve-nightly-release.ts and fix smoke test
The smoke test invoked resolve-nightly-release.ts with --root, but that script had no such flag (causing Effect CLI to reject the invocation) and used a static import for the desktop package.json (always reading the repo's real version instead of the temp fixture). Changes: - Add --root optional flag to resolve-nightly-release.ts that, when provided, reads apps/desktop/package.json from the specified root directory instead of using the static import. - Change smoke test fixture version from 9.9.9-smoke.0 to 9.9.9 so the nightly version derivation produces the expected 9.9.9-nightly.* format without a double prerelease suffix.
1 parent 79c032a commit 04e28a8

2 files changed

Lines changed: 45 additions & 29 deletions

File tree

‎scripts/release-smoke.ts‎

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,31 @@ function writeMacManifestFixtures(targetRoot: string): { arm64Path: string; x64P
3737

3838
writeFileSync(
3939
arm64Path,
40-
`version: 9.9.9-smoke.0
40+
`version: 9.9.9
4141
files:
42-
- url: T3-Code-9.9.9-smoke.0-arm64.zip
42+
- url: T3-Code-9.9.9-arm64.zip
4343
sha512: arm64zip
4444
size: 125621344
45-
- url: T3-Code-9.9.9-smoke.0-arm64.dmg
45+
- url: T3-Code-9.9.9-arm64.dmg
4646
sha512: arm64dmg
4747
size: 131754935
48-
path: T3-Code-9.9.9-smoke.0-arm64.zip
48+
path: T3-Code-9.9.9-arm64.zip
4949
sha512: arm64zip
5050
releaseDate: '2026-03-08T10:32:14.587Z'
5151
`,
5252
);
5353

5454
writeFileSync(
5555
x64Path,
56-
`version: 9.9.9-smoke.0
56+
`version: 9.9.9
5757
files:
58-
- url: T3-Code-9.9.9-smoke.0-x64.zip
58+
- url: T3-Code-9.9.9-x64.zip
5959
sha512: x64zip
6060
size: 132000112
61-
- url: T3-Code-9.9.9-smoke.0-x64.dmg
61+
- url: T3-Code-9.9.9-x64.dmg
6262
sha512: x64dmg
6363
size: 138148807
64-
path: T3-Code-9.9.9-smoke.0-x64.zip
64+
path: T3-Code-9.9.9-x64.zip
6565
sha512: x64zip
6666
releaseDate: '2026-03-08T10:36:07.540Z'
6767
`,
@@ -83,12 +83,7 @@ try {
8383

8484
execFileSync(
8585
process.execPath,
86-
[
87-
resolve(repoRoot,"scripts/update-release-package-versions.ts"),
88-
"9.9.9-smoke.0",
89-
"--root",
90-
tempRoot,
91-
],
86+
[resolve(repoRoot,"scripts/update-release-package-versions.ts"),"9.9.9","--root",tempRoot],
9287
{
9388
cwd: repoRoot,
9489
stdio: "inherit",
@@ -101,11 +96,7 @@ try {
10196
});
10297

10398
constlockfile=readFileSync(resolve(tempRoot,"bun.lock"),"utf8");
104-
assertContains(
105-
lockfile,
106-
`"version": "9.9.9-smoke.0"`,
107-
"Expected bun.lock to contain the smoke version.",
108-
);
99+
assertContains(lockfile,`"version": "9.9.9"`,"Expected bun.lock to contain the smoke version.");
109100

110101
constnightlyReleaseMetadata=execFileSync(
111102
process.execPath,
@@ -149,12 +140,12 @@ try {
149140
constmergedManifest=readFileSync(arm64Path,"utf8");
150141
assertContains(
151142
mergedManifest,
152-
"T3-Code-9.9.9-smoke.0-arm64.zip",
143+
"T3-Code-9.9.9-arm64.zip",
153144
"Merged manifest is missing the arm64 asset.",
154145
);
155146
assertContains(
156147
mergedManifest,
157-
"T3-Code-9.9.9-smoke.0-x64.zip",
148+
"T3-Code-9.9.9-x64.zip",
158149
"Merged manifest is missing the x64 asset.",
159150
);
160151

‎scripts/resolve-nightly-release.ts‎

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import*asNodeRuntimefrom"@effect/platform-node/NodeRuntime";
44
import*asNodeServicesfrom"@effect/platform-node/NodeServices";
5-
import{Config,Effect,FileSystem,Schema}from"effect";
5+
import{resolve}from"node:path";
6+
import{Config,Effect,FileSystem,Option,Schema}from"effect";
67
import{Command,Flag}from"effect/unstable/cli";
78
importdesktopPackageJsonfrom"../apps/desktop/package.json"with{type: "json"};
89

@@ -18,11 +19,25 @@ const DateSchema = Schema.String.check(Schema.isPattern(/^\d{8}$/));
1819
constRunNumberSchema=Schema.FiniteFromString.check(Schema.isGreaterThanOrEqualTo(1));
1920
constShaSchema=Schema.String.check(Schema.isPattern(/^[0-9a-f]{7,40}$/i));
2021

21-
constresolveNightlyReleaseMetadata=(date: string,runNumber: number,sha: string)=>({
22-
baseVersion: desktopPackageJson.version,
23-
version: `${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
24-
tag: `nightly-v${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
25-
name: `T3 Code Nightly ${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
22+
constresolveBaseVersion=(root: string|undefined)=>
23+
Effect.gen(function*(){
24+
if(root===undefined)returndesktopPackageJson.version;
25+
constfs=yield*FileSystem.FileSystem;
26+
constraw=yield*fs.readFileString(resolve(root,"apps/desktop/package.json"));
27+
constparsed=JSON.parse(raw)as{version: string};
28+
returnparsed.version;
29+
});
30+
31+
constresolveNightlyReleaseMetadata=(
32+
baseVersion: string,
33+
date: string,
34+
runNumber: number,
35+
sha: string,
36+
)=>({
37+
baseVersion,
38+
version: `${baseVersion}-nightly.${date}.${runNumber}`,
39+
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
40+
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber}`,
2641
shortSha: sha.slice(0,12),
2742
});
2843

@@ -70,9 +85,19 @@ const command = Command.make(
7085
Flag.withDescription("Write values to GITHUB_OUTPUT instead of stdout."),
7186
Flag.withDefault(false),
7287
),
88+
root: Flag.string("root").pipe(
89+
Flag.withDescription("Override workspace root directory for reading package versions."),
90+
Flag.optional,
91+
),
7392
},
74-
({ date, runNumber, sha, githubOutput })=>
75-
writeOutput(resolveNightlyReleaseMetadata(date,runNumber,sha),githubOutput),
93+
({ date, runNumber, sha, githubOutput, root })=>
94+
Effect.gen(function*(){
95+
constbaseVersion=yield*resolveBaseVersion(Option.getOrUndefined(root));
96+
yield*writeOutput(
97+
resolveNightlyReleaseMetadata(baseVersion,date,runNumber,sha),
98+
githubOutput,
99+
);
100+
}),
76101
).pipe(Command.withDescription("Resolve nightly release version metadata."));
77102

78103
Command.run(command,{version: "0.0.0"}).pipe(

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 04e28a8

Browse files
committed
fix: add --root flag to resolve-nightly-release.ts and fix smoke test
The smoke test invoked resolve-nightly-release.ts with --root, but that script had no such flag (causing Effect CLI to reject the invocation) and used a static import for the desktop package.json (always reading the repo's real version instead of the temp fixture). Changes: - Add --root optional flag to resolve-nightly-release.ts that, when provided, reads apps/desktop/package.json from the specified root directory instead of using the static import. - Change smoke test fixture version from 9.9.9-smoke.0 to 9.9.9 so the nightly version derivation produces the expected 9.9.9-nightly.* format without a double prerelease suffix.
1 parent 79c032a commit 04e28a8

2 files changed

Lines changed: 45 additions & 29 deletions

File tree

‎scripts/release-smoke.ts‎

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,31 @@ function writeMacManifestFixtures(targetRoot: string): { arm64Path: string; x64P
3737

3838
writeFileSync(
3939
arm64Path,
40-
`version: 9.9.9-smoke.0
40+
`version: 9.9.9
4141
files:
42-
- url: T3-Code-9.9.9-smoke.0-arm64.zip
42+
- url: T3-Code-9.9.9-arm64.zip
4343
sha512: arm64zip
4444
size: 125621344
45-
- url: T3-Code-9.9.9-smoke.0-arm64.dmg
45+
- url: T3-Code-9.9.9-arm64.dmg
4646
sha512: arm64dmg
4747
size: 131754935
48-
path: T3-Code-9.9.9-smoke.0-arm64.zip
48+
path: T3-Code-9.9.9-arm64.zip
4949
sha512: arm64zip
5050
releaseDate: '2026-03-08T10:32:14.587Z'
5151
`,
5252
);
5353

5454
writeFileSync(
5555
x64Path,
56-
`version: 9.9.9-smoke.0
56+
`version: 9.9.9
5757
files:
58-
- url: T3-Code-9.9.9-smoke.0-x64.zip
58+
- url: T3-Code-9.9.9-x64.zip
5959
sha512: x64zip
6060
size: 132000112
61-
- url: T3-Code-9.9.9-smoke.0-x64.dmg
61+
- url: T3-Code-9.9.9-x64.dmg
6262
sha512: x64dmg
6363
size: 138148807
64-
path: T3-Code-9.9.9-smoke.0-x64.zip
64+
path: T3-Code-9.9.9-x64.zip
6565
sha512: x64zip
6666
releaseDate: '2026-03-08T10:36:07.540Z'
6767
`,
@@ -83,12 +83,7 @@ try {
8383

8484
execFileSync(
8585
process.execPath,
86-
[
87-
resolve(repoRoot,"scripts/update-release-package-versions.ts"),
88-
"9.9.9-smoke.0",
89-
"--root",
90-
tempRoot,
91-
],
86+
[resolve(repoRoot,"scripts/update-release-package-versions.ts"),"9.9.9","--root",tempRoot],
9287
{
9388
cwd: repoRoot,
9489
stdio: "inherit",
@@ -101,11 +96,7 @@ try {
10196
});
10297

10398
constlockfile=readFileSync(resolve(tempRoot,"bun.lock"),"utf8");
104-
assertContains(
105-
lockfile,
106-
`"version": "9.9.9-smoke.0"`,
107-
"Expected bun.lock to contain the smoke version.",
108-
);
99+
assertContains(lockfile,`"version": "9.9.9"`,"Expected bun.lock to contain the smoke version.");
109100

110101
constnightlyReleaseMetadata=execFileSync(
111102
process.execPath,
@@ -149,12 +140,12 @@ try {
149140
constmergedManifest=readFileSync(arm64Path,"utf8");
150141
assertContains(
151142
mergedManifest,
152-
"T3-Code-9.9.9-smoke.0-arm64.zip",
143+
"T3-Code-9.9.9-arm64.zip",
153144
"Merged manifest is missing the arm64 asset.",
154145
);
155146
assertContains(
156147
mergedManifest,
157-
"T3-Code-9.9.9-smoke.0-x64.zip",
148+
"T3-Code-9.9.9-x64.zip",
158149
"Merged manifest is missing the x64 asset.",
159150
);
160151

‎scripts/resolve-nightly-release.ts‎

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import*asNodeRuntimefrom"@effect/platform-node/NodeRuntime";
44
import*asNodeServicesfrom"@effect/platform-node/NodeServices";
5-
import{Config,Effect,FileSystem,Schema}from"effect";
5+
import{resolve}from"node:path";
6+
import{Config,Effect,FileSystem,Option,Schema}from"effect";
67
import{Command,Flag}from"effect/unstable/cli";
78
importdesktopPackageJsonfrom"../apps/desktop/package.json"with{type: "json"};
89

@@ -18,11 +19,25 @@ const DateSchema = Schema.String.check(Schema.isPattern(/^\d{8}$/));
1819
constRunNumberSchema=Schema.FiniteFromString.check(Schema.isGreaterThanOrEqualTo(1));
1920
constShaSchema=Schema.String.check(Schema.isPattern(/^[0-9a-f]{7,40}$/i));
2021

21-
constresolveNightlyReleaseMetadata=(date: string,runNumber: number,sha: string)=>({
22-
baseVersion: desktopPackageJson.version,
23-
version: `${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
24-
tag: `nightly-v${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
25-
name: `T3 Code Nightly ${desktopPackageJson.version}-nightly.${date}.${runNumber}`,
22+
constresolveBaseVersion=(root: string|undefined)=>
23+
Effect.gen(function*(){
24+
if(root===undefined)returndesktopPackageJson.version;
25+
constfs=yield*FileSystem.FileSystem;
26+
constraw=yield*fs.readFileString(resolve(root,"apps/desktop/package.json"));
27+
constparsed=JSON.parse(raw)as{version: string};
28+
returnparsed.version;
29+
});
30+
31+
constresolveNightlyReleaseMetadata=(
32+
baseVersion: string,
33+
date: string,
34+
runNumber: number,
35+
sha: string,
36+
)=>({
37+
baseVersion,
38+
version: `${baseVersion}-nightly.${date}.${runNumber}`,
39+
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
40+
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber}`,
2641
shortSha: sha.slice(0,12),
2742
});
2843

@@ -70,9 +85,19 @@ const command = Command.make(
7085
Flag.withDescription("Write values to GITHUB_OUTPUT instead of stdout."),
7186
Flag.withDefault(false),
7287
),
88+
root: Flag.string("root").pipe(
89+
Flag.withDescription("Override workspace root directory for reading package versions."),
90+
Flag.optional,
91+
),
7392
},
74-
({ date, runNumber, sha, githubOutput })=>
75-
writeOutput(resolveNightlyReleaseMetadata(date,runNumber,sha),githubOutput),
93+
({ date, runNumber, sha, githubOutput, root })=>
94+
Effect.gen(function*(){
95+
constbaseVersion=yield*resolveBaseVersion(Option.getOrUndefined(root));
96+
yield*writeOutput(
97+
resolveNightlyReleaseMetadata(baseVersion,date,runNumber,sha),
98+
githubOutput,
99+
);
100+
}),
76101
).pipe(Command.withDescription("Resolve nightly release version metadata."));
77102

78103
Command.run(command,{version: "0.0.0"}).pipe(

0 commit comments

Comments
 (0)