Commit 184d8ef

Browse files
authored
fix(mobile): steer active turns by default (#6543)
1 parent 038560e commit 184d8ef

7 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎apps/mobile/src/features/threads/ThreadComposer.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export interface ThreadComposerProps {
105105
readonlyselectedThread: OrchestrationThreadShell;
106106
readonlyserverConfig: T3ServerConfig|null;
107107
readonlyqueueCount: number;
108-
readonlyactiveThreadBusy: boolean;
109108
readonlyenvironmentId: EnvironmentId;
110109
readonlyprojectCwd: string|null;
111110
readonlyeditorRef?: RefObject<ComposerEditorHandle|null>;
@@ -327,9 +326,7 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
327326
props.selectedThread.session?.status==="starting";
328327

329328
constsendLabel=
330-
props.connectionState!=="connected"||props.activeThreadBusy||props.queueCount>0
331-
? "Queue"
332-
: "Send";
329+
props.connectionState!=="connected"||props.queueCount>0 ? "Queue" : "Send";
333330
constcurrentModelSelection=props.selectedThread.modelSelection;
334331
constcurrentRuntimeMode=props.selectedThread.runtimeMode;
335332
constconnectionStatus=composerConnectionStatus({

‎apps/mobile/src/features/threads/ThreadDetailScreen.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export interface ThreadDetailScreenProps {
101101
readonlythreadSyncStatus?: EnvironmentThreadStatus;
102102
/** Non-null when older turns exist beyond the loaded window. */
103103
readonlyloadEarlier?: {readonlyloading: boolean;readonlyonLoadEarlier: ()=>void}|null;
104-
readonlyactiveThreadBusy: boolean;
105104
readonlyenvironmentId: EnvironmentId;
106105
readonlyprojectWorkspaceRoot: string|null;
107106
readonlythreadCwd: string|null;
@@ -727,7 +726,6 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
727726
selectedThread={props.selectedThread}
728727
serverConfig={props.serverConfig}
729728
queueCount={props.selectedThreadQueueCount}
730-
activeThreadBusy={props.activeThreadBusy}
731729
environmentId={props.environmentId}
732730
projectCwd={props.projectWorkspaceRoot}
733731
bottomInset={composerBottomInset}

‎apps/mobile/src/features/threads/ThreadRouteScreen.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,6 @@ function ThreadRouteContent(
785785
connectionStateLabel={routeConnectionState}
786786
threadSyncStatus={selectedThreadDetailState.status}
787787
loadEarlier={loadEarlierTurns}
788-
activeThreadBusy={composer.activeThreadBusy}
789788
environmentId={selectedThread.environmentId}
790789
projectWorkspaceRoot={selectedThreadProject?.workspaceRoot??null}
791790
threadCwd={selectedThreadCwd}

‎apps/mobile/src/state/thread-outbox-model.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export function resolveThreadOutboxDeliveryAction(input: {
169169
if(!input.threadExists){
170170
returninput.shellStatus==="live" ? "remove" : "wait";
171171
}
172-
returninput.environmentConnected&&!input.threadBusy? "send" : "wait";
172+
returninput.environmentConnected ? "send" : "wait";
173173
}
174174

175175
/**

‎apps/mobile/src/state/thread-outbox.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,27 @@ describe("thread outbox", () => {
487487
).toBe("send");
488488
});
489489

490+
it("sends existing-thread messages whenever connected so queued messages can steer",()=>{
491+
expect(
492+
resolveThreadOutboxDeliveryAction({
493+
isCreation: false,
494+
threadExists: true,
495+
shellStatus: "live",
496+
environmentConnected: true,
497+
threadBusy: true,
498+
}),
499+
).toBe("send");
500+
expect(
501+
resolveThreadOutboxDeliveryAction({
502+
isCreation: false,
503+
threadExists: true,
504+
shellStatus: "live",
505+
environmentConnected: false,
506+
threadBusy: true,
507+
}),
508+
).toBe("wait");
509+
});
510+
490511
it("sends queued creations once connected and live, removing already-created ones",()=>{
491512
expect(
492513
resolveThreadOutboxDeliveryAction({

‎apps/mobile/src/state/use-thread-composer-state.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,6 @@ export function useThreadComposerState() {
129129
);
130130
},[selectedThreadDetail,selectedThreadSessionActivity,selectedThreadShell]);
131131

132-
constactiveThreadBusy=
133-
!!selectedThread&&
134-
(selectedThread.session?.status==="running"||selectedThread.session?.status==="starting");
135-
136132
constonSendMessage=useCallback(async()=>{
137133
if(!selectedThreadShell){
138134
returnnull;
@@ -308,7 +304,6 @@ export function useThreadComposerState() {
308304
modelSelection,
309305
runtimeMode,
310306
interactionMode,
311-
activeThreadBusy,
312307
onChangeDraftMessage,
313308
onPickDraftImages,
314309
onPasteIntoDraft,

‎apps/mobile/src/state/use-thread-outbox-drain.ts‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
typeQueuedThreadMessage,
3838
typeThreadOutboxCommandStage,
3939
}from"./thread-outbox-model";
40-
import{environmentThreadShells,threadEnvironment}from"./threads";
40+
import{threadEnvironment}from"./threads";
4141
import{useAtomCommand}from"./use-atom-command";
4242
import{
4343
editingQueuedMessageIdsAtom,
@@ -362,22 +362,12 @@ export function useThreadOutboxDrain(): void {
362362
returntrue;
363363
}
364364
// The guards evaluated before the confirmation await are stale by now:
365-
// the thread may have gone busy, or the user may have opened this
366-
// message in the editor. Re-read both and defer to the next drain pass
367-
// (returning true skips the failure/backoff path) rather than sending
368-
// a payload the user is editing or racing an active turn.
365+
// the user may have opened this message in the editor. Re-read that
366+
// guard and defer to the next drain pass (returning true skips the
367+
// failure/backoff path) rather than sending a payload being edited.
369368
if(appAtomRegistry.get(editingQueuedMessageIdsAtom)[nextQueuedMessage.messageId]){
370369
returntrue;
371370
}
372-
constfreshThread=findThread(
373-
appAtomRegistry.get(environmentThreadShells.threadShellsAtom),
374-
nextQueuedMessage,
375-
);
376-
constfreshThreadBusy=
377-
freshThread?.session?.status==="running"||freshThread?.session?.status==="starting";
378-
if(deliveryAction==="send"&&creation===undefined&&freshThreadBusy){
379-
returntrue;
380-
}
381371
returndeliveryAction==="remove"
382372
? removeQueuedMessage("[thread-outbox] failed to remove message for a missing thread")
383373
: creation!==undefined

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 184d8ef

Browse files
authored
fix(mobile): steer active turns by default (#6543)
1 parent 038560e commit 184d8ef

7 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎apps/mobile/src/features/threads/ThreadComposer.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export interface ThreadComposerProps {
105105
readonlyselectedThread: OrchestrationThreadShell;
106106
readonlyserverConfig: T3ServerConfig|null;
107107
readonlyqueueCount: number;
108-
readonlyactiveThreadBusy: boolean;
109108
readonlyenvironmentId: EnvironmentId;
110109
readonlyprojectCwd: string|null;
111110
readonlyeditorRef?: RefObject<ComposerEditorHandle|null>;
@@ -327,9 +326,7 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
327326
props.selectedThread.session?.status==="starting";
328327

329328
constsendLabel=
330-
props.connectionState!=="connected"||props.activeThreadBusy||props.queueCount>0
331-
? "Queue"
332-
: "Send";
329+
props.connectionState!=="connected"||props.queueCount>0 ? "Queue" : "Send";
333330
constcurrentModelSelection=props.selectedThread.modelSelection;
334331
constcurrentRuntimeMode=props.selectedThread.runtimeMode;
335332
constconnectionStatus=composerConnectionStatus({

‎apps/mobile/src/features/threads/ThreadDetailScreen.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export interface ThreadDetailScreenProps {
101101
readonlythreadSyncStatus?: EnvironmentThreadStatus;
102102
/** Non-null when older turns exist beyond the loaded window. */
103103
readonlyloadEarlier?: {readonlyloading: boolean;readonlyonLoadEarlier: ()=>void}|null;
104-
readonlyactiveThreadBusy: boolean;
105104
readonlyenvironmentId: EnvironmentId;
106105
readonlyprojectWorkspaceRoot: string|null;
107106
readonlythreadCwd: string|null;
@@ -727,7 +726,6 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
727726
selectedThread={props.selectedThread}
728727
serverConfig={props.serverConfig}
729728
queueCount={props.selectedThreadQueueCount}
730-
activeThreadBusy={props.activeThreadBusy}
731729
environmentId={props.environmentId}
732730
projectCwd={props.projectWorkspaceRoot}
733731
bottomInset={composerBottomInset}

‎apps/mobile/src/features/threads/ThreadRouteScreen.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,6 @@ function ThreadRouteContent(
785785
connectionStateLabel={routeConnectionState}
786786
threadSyncStatus={selectedThreadDetailState.status}
787787
loadEarlier={loadEarlierTurns}
788-
activeThreadBusy={composer.activeThreadBusy}
789788
environmentId={selectedThread.environmentId}
790789
projectWorkspaceRoot={selectedThreadProject?.workspaceRoot??null}
791790
threadCwd={selectedThreadCwd}

‎apps/mobile/src/state/thread-outbox-model.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export function resolveThreadOutboxDeliveryAction(input: {
169169
if(!input.threadExists){
170170
returninput.shellStatus==="live" ? "remove" : "wait";
171171
}
172-
returninput.environmentConnected&&!input.threadBusy? "send" : "wait";
172+
returninput.environmentConnected ? "send" : "wait";
173173
}
174174

175175
/**

‎apps/mobile/src/state/thread-outbox.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,27 @@ describe("thread outbox", () => {
487487
).toBe("send");
488488
});
489489

490+
it("sends existing-thread messages whenever connected so queued messages can steer",()=>{
491+
expect(
492+
resolveThreadOutboxDeliveryAction({
493+
isCreation: false,
494+
threadExists: true,
495+
shellStatus: "live",
496+
environmentConnected: true,
497+
threadBusy: true,
498+
}),
499+
).toBe("send");
500+
expect(
501+
resolveThreadOutboxDeliveryAction({
502+
isCreation: false,
503+
threadExists: true,
504+
shellStatus: "live",
505+
environmentConnected: false,
506+
threadBusy: true,
507+
}),
508+
).toBe("wait");
509+
});
510+
490511
it("sends queued creations once connected and live, removing already-created ones",()=>{
491512
expect(
492513
resolveThreadOutboxDeliveryAction({

‎apps/mobile/src/state/use-thread-composer-state.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,6 @@ export function useThreadComposerState() {
129129
);
130130
},[selectedThreadDetail,selectedThreadSessionActivity,selectedThreadShell]);
131131

132-
constactiveThreadBusy=
133-
!!selectedThread&&
134-
(selectedThread.session?.status==="running"||selectedThread.session?.status==="starting");
135-
136132
constonSendMessage=useCallback(async()=>{
137133
if(!selectedThreadShell){
138134
returnnull;
@@ -308,7 +304,6 @@ export function useThreadComposerState() {
308304
modelSelection,
309305
runtimeMode,
310306
interactionMode,
311-
activeThreadBusy,
312307
onChangeDraftMessage,
313308
onPickDraftImages,
314309
onPasteIntoDraft,

‎apps/mobile/src/state/use-thread-outbox-drain.ts‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
typeQueuedThreadMessage,
3838
typeThreadOutboxCommandStage,
3939
}from"./thread-outbox-model";
40-
import{environmentThreadShells,threadEnvironment}from"./threads";
40+
import{threadEnvironment}from"./threads";
4141
import{useAtomCommand}from"./use-atom-command";
4242
import{
4343
editingQueuedMessageIdsAtom,
@@ -362,22 +362,12 @@ export function useThreadOutboxDrain(): void {
362362
returntrue;
363363
}
364364
// The guards evaluated before the confirmation await are stale by now:
365-
// the thread may have gone busy, or the user may have opened this
366-
// message in the editor. Re-read both and defer to the next drain pass
367-
// (returning true skips the failure/backoff path) rather than sending
368-
// a payload the user is editing or racing an active turn.
365+
// the user may have opened this message in the editor. Re-read that
366+
// guard and defer to the next drain pass (returning true skips the
367+
// failure/backoff path) rather than sending a payload being edited.
369368
if(appAtomRegistry.get(editingQueuedMessageIdsAtom)[nextQueuedMessage.messageId]){
370369
returntrue;
371370
}
372-
constfreshThread=findThread(
373-
appAtomRegistry.get(environmentThreadShells.threadShellsAtom),
374-
nextQueuedMessage,
375-
);
376-
constfreshThreadBusy=
377-
freshThread?.session?.status==="running"||freshThread?.session?.status==="starting";
378-
if(deliveryAction==="send"&&creation===undefined&&freshThreadBusy){
379-
returntrue;
380-
}
381371
returndeliveryAction==="remove"
382372
? removeQueuedMessage("[thread-outbox] failed to remove message for a missing thread")
383373
: creation!==undefined

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 184d8ef

Browse files
authored
fix(mobile): steer active turns by default (#6543)
1 parent 038560e commit 184d8ef

7 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎apps/mobile/src/features/threads/ThreadComposer.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export interface ThreadComposerProps {
105105
readonlyselectedThread: OrchestrationThreadShell;
106106
readonlyserverConfig: T3ServerConfig|null;
107107
readonlyqueueCount: number;
108-
readonlyactiveThreadBusy: boolean;
109108
readonlyenvironmentId: EnvironmentId;
110109
readonlyprojectCwd: string|null;
111110
readonlyeditorRef?: RefObject<ComposerEditorHandle|null>;
@@ -327,9 +326,7 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
327326
props.selectedThread.session?.status==="starting";
328327

329328
constsendLabel=
330-
props.connectionState!=="connected"||props.activeThreadBusy||props.queueCount>0
331-
? "Queue"
332-
: "Send";
329+
props.connectionState!=="connected"||props.queueCount>0 ? "Queue" : "Send";
333330
constcurrentModelSelection=props.selectedThread.modelSelection;
334331
constcurrentRuntimeMode=props.selectedThread.runtimeMode;
335332
constconnectionStatus=composerConnectionStatus({

‎apps/mobile/src/features/threads/ThreadDetailScreen.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export interface ThreadDetailScreenProps {
101101
readonlythreadSyncStatus?: EnvironmentThreadStatus;
102102
/** Non-null when older turns exist beyond the loaded window. */
103103
readonlyloadEarlier?: {readonlyloading: boolean;readonlyonLoadEarlier: ()=>void}|null;
104-
readonlyactiveThreadBusy: boolean;
105104
readonlyenvironmentId: EnvironmentId;
106105
readonlyprojectWorkspaceRoot: string|null;
107106
readonlythreadCwd: string|null;
@@ -727,7 +726,6 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
727726
selectedThread={props.selectedThread}
728727
serverConfig={props.serverConfig}
729728
queueCount={props.selectedThreadQueueCount}
730-
activeThreadBusy={props.activeThreadBusy}
731729
environmentId={props.environmentId}
732730
projectCwd={props.projectWorkspaceRoot}
733731
bottomInset={composerBottomInset}

‎apps/mobile/src/features/threads/ThreadRouteScreen.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,6 @@ function ThreadRouteContent(
785785
connectionStateLabel={routeConnectionState}
786786
threadSyncStatus={selectedThreadDetailState.status}
787787
loadEarlier={loadEarlierTurns}
788-
activeThreadBusy={composer.activeThreadBusy}
789788
environmentId={selectedThread.environmentId}
790789
projectWorkspaceRoot={selectedThreadProject?.workspaceRoot??null}
791790
threadCwd={selectedThreadCwd}

‎apps/mobile/src/state/thread-outbox-model.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export function resolveThreadOutboxDeliveryAction(input: {
169169
if(!input.threadExists){
170170
returninput.shellStatus==="live" ? "remove" : "wait";
171171
}
172-
returninput.environmentConnected&&!input.threadBusy? "send" : "wait";
172+
returninput.environmentConnected ? "send" : "wait";
173173
}
174174

175175
/**

‎apps/mobile/src/state/thread-outbox.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,27 @@ describe("thread outbox", () => {
487487
).toBe("send");
488488
});
489489

490+
it("sends existing-thread messages whenever connected so queued messages can steer",()=>{
491+
expect(
492+
resolveThreadOutboxDeliveryAction({
493+
isCreation: false,
494+
threadExists: true,
495+
shellStatus: "live",
496+
environmentConnected: true,
497+
threadBusy: true,
498+
}),
499+
).toBe("send");
500+
expect(
501+
resolveThreadOutboxDeliveryAction({
502+
isCreation: false,
503+
threadExists: true,
504+
shellStatus: "live",
505+
environmentConnected: false,
506+
threadBusy: true,
507+
}),
508+
).toBe("wait");
509+
});
510+
490511
it("sends queued creations once connected and live, removing already-created ones",()=>{
491512
expect(
492513
resolveThreadOutboxDeliveryAction({

‎apps/mobile/src/state/use-thread-composer-state.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,6 @@ export function useThreadComposerState() {
129129
);
130130
},[selectedThreadDetail,selectedThreadSessionActivity,selectedThreadShell]);
131131

132-
constactiveThreadBusy=
133-
!!selectedThread&&
134-
(selectedThread.session?.status==="running"||selectedThread.session?.status==="starting");
135-
136132
constonSendMessage=useCallback(async()=>{
137133
if(!selectedThreadShell){
138134
returnnull;
@@ -308,7 +304,6 @@ export function useThreadComposerState() {
308304
modelSelection,
309305
runtimeMode,
310306
interactionMode,
311-
activeThreadBusy,
312307
onChangeDraftMessage,
313308
onPickDraftImages,
314309
onPasteIntoDraft,

‎apps/mobile/src/state/use-thread-outbox-drain.ts‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
typeQueuedThreadMessage,
3838
typeThreadOutboxCommandStage,
3939
}from"./thread-outbox-model";
40-
import{environmentThreadShells,threadEnvironment}from"./threads";
40+
import{threadEnvironment}from"./threads";
4141
import{useAtomCommand}from"./use-atom-command";
4242
import{
4343
editingQueuedMessageIdsAtom,
@@ -362,22 +362,12 @@ export function useThreadOutboxDrain(): void {
362362
returntrue;
363363
}
364364
// The guards evaluated before the confirmation await are stale by now:
365-
// the thread may have gone busy, or the user may have opened this
366-
// message in the editor. Re-read both and defer to the next drain pass
367-
// (returning true skips the failure/backoff path) rather than sending
368-
// a payload the user is editing or racing an active turn.
365+
// the user may have opened this message in the editor. Re-read that
366+
// guard and defer to the next drain pass (returning true skips the
367+
// failure/backoff path) rather than sending a payload being edited.
369368
if(appAtomRegistry.get(editingQueuedMessageIdsAtom)[nextQueuedMessage.messageId]){
370369
returntrue;
371370
}
372-
constfreshThread=findThread(
373-
appAtomRegistry.get(environmentThreadShells.threadShellsAtom),
374-
nextQueuedMessage,
375-
);
376-
constfreshThreadBusy=
377-
freshThread?.session?.status==="running"||freshThread?.session?.status==="starting";
378-
if(deliveryAction==="send"&&creation===undefined&&freshThreadBusy){
379-
returntrue;
380-
}
381371
returndeliveryAction==="remove"
382372
? removeQueuedMessage("[thread-outbox] failed to remove message for a missing thread")
383373
: creation!==undefined

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 184d8ef

Browse files
authored
fix(mobile): steer active turns by default (#6543)
1 parent 038560e commit 184d8ef

7 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎apps/mobile/src/features/threads/ThreadComposer.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export interface ThreadComposerProps {
105105
readonlyselectedThread: OrchestrationThreadShell;
106106
readonlyserverConfig: T3ServerConfig|null;
107107
readonlyqueueCount: number;
108-
readonlyactiveThreadBusy: boolean;
109108
readonlyenvironmentId: EnvironmentId;
110109
readonlyprojectCwd: string|null;
111110
readonlyeditorRef?: RefObject<ComposerEditorHandle|null>;
@@ -327,9 +326,7 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
327326
props.selectedThread.session?.status==="starting";
328327

329328
constsendLabel=
330-
props.connectionState!=="connected"||props.activeThreadBusy||props.queueCount>0
331-
? "Queue"
332-
: "Send";
329+
props.connectionState!=="connected"||props.queueCount>0 ? "Queue" : "Send";
333330
constcurrentModelSelection=props.selectedThread.modelSelection;
334331
constcurrentRuntimeMode=props.selectedThread.runtimeMode;
335332
constconnectionStatus=composerConnectionStatus({

‎apps/mobile/src/features/threads/ThreadDetailScreen.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export interface ThreadDetailScreenProps {
101101
readonlythreadSyncStatus?: EnvironmentThreadStatus;
102102
/** Non-null when older turns exist beyond the loaded window. */
103103
readonlyloadEarlier?: {readonlyloading: boolean;readonlyonLoadEarlier: ()=>void}|null;
104-
readonlyactiveThreadBusy: boolean;
105104
readonlyenvironmentId: EnvironmentId;
106105
readonlyprojectWorkspaceRoot: string|null;
107106
readonlythreadCwd: string|null;
@@ -727,7 +726,6 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
727726
selectedThread={props.selectedThread}
728727
serverConfig={props.serverConfig}
729728
queueCount={props.selectedThreadQueueCount}
730-
activeThreadBusy={props.activeThreadBusy}
731729
environmentId={props.environmentId}
732730
projectCwd={props.projectWorkspaceRoot}
733731
bottomInset={composerBottomInset}

‎apps/mobile/src/features/threads/ThreadRouteScreen.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,6 @@ function ThreadRouteContent(
785785
connectionStateLabel={routeConnectionState}
786786
threadSyncStatus={selectedThreadDetailState.status}
787787
loadEarlier={loadEarlierTurns}
788-
activeThreadBusy={composer.activeThreadBusy}
789788
environmentId={selectedThread.environmentId}
790789
projectWorkspaceRoot={selectedThreadProject?.workspaceRoot??null}
791790
threadCwd={selectedThreadCwd}

‎apps/mobile/src/state/thread-outbox-model.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export function resolveThreadOutboxDeliveryAction(input: {
169169
if(!input.threadExists){
170170
returninput.shellStatus==="live" ? "remove" : "wait";
171171
}
172-
returninput.environmentConnected&&!input.threadBusy? "send" : "wait";
172+
returninput.environmentConnected ? "send" : "wait";
173173
}
174174

175175
/**

‎apps/mobile/src/state/thread-outbox.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,27 @@ describe("thread outbox", () => {
487487
).toBe("send");
488488
});
489489

490+
it("sends existing-thread messages whenever connected so queued messages can steer",()=>{
491+
expect(
492+
resolveThreadOutboxDeliveryAction({
493+
isCreation: false,
494+
threadExists: true,
495+
shellStatus: "live",
496+
environmentConnected: true,
497+
threadBusy: true,
498+
}),
499+
).toBe("send");
500+
expect(
501+
resolveThreadOutboxDeliveryAction({
502+
isCreation: false,
503+
threadExists: true,
504+
shellStatus: "live",
505+
environmentConnected: false,
506+
threadBusy: true,
507+
}),
508+
).toBe("wait");
509+
});
510+
490511
it("sends queued creations once connected and live, removing already-created ones",()=>{
491512
expect(
492513
resolveThreadOutboxDeliveryAction({

‎apps/mobile/src/state/use-thread-composer-state.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,6 @@ export function useThreadComposerState() {
129129
);
130130
},[selectedThreadDetail,selectedThreadSessionActivity,selectedThreadShell]);
131131

132-
constactiveThreadBusy=
133-
!!selectedThread&&
134-
(selectedThread.session?.status==="running"||selectedThread.session?.status==="starting");
135-
136132
constonSendMessage=useCallback(async()=>{
137133
if(!selectedThreadShell){
138134
returnnull;
@@ -308,7 +304,6 @@ export function useThreadComposerState() {
308304
modelSelection,
309305
runtimeMode,
310306
interactionMode,
311-
activeThreadBusy,
312307
onChangeDraftMessage,
313308
onPickDraftImages,
314309
onPasteIntoDraft,

‎apps/mobile/src/state/use-thread-outbox-drain.ts‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
typeQueuedThreadMessage,
3838
typeThreadOutboxCommandStage,
3939
}from"./thread-outbox-model";
40-
import{environmentThreadShells,threadEnvironment}from"./threads";
40+
import{threadEnvironment}from"./threads";
4141
import{useAtomCommand}from"./use-atom-command";
4242
import{
4343
editingQueuedMessageIdsAtom,
@@ -362,22 +362,12 @@ export function useThreadOutboxDrain(): void {
362362
returntrue;
363363
}
364364
// The guards evaluated before the confirmation await are stale by now:
365-
// the thread may have gone busy, or the user may have opened this
366-
// message in the editor. Re-read both and defer to the next drain pass
367-
// (returning true skips the failure/backoff path) rather than sending
368-
// a payload the user is editing or racing an active turn.
365+
// the user may have opened this message in the editor. Re-read that
366+
// guard and defer to the next drain pass (returning true skips the
367+
// failure/backoff path) rather than sending a payload being edited.
369368
if(appAtomRegistry.get(editingQueuedMessageIdsAtom)[nextQueuedMessage.messageId]){
370369
returntrue;
371370
}
372-
constfreshThread=findThread(
373-
appAtomRegistry.get(environmentThreadShells.threadShellsAtom),
374-
nextQueuedMessage,
375-
);
376-
constfreshThreadBusy=
377-
freshThread?.session?.status==="running"||freshThread?.session?.status==="starting";
378-
if(deliveryAction==="send"&&creation===undefined&&freshThreadBusy){
379-
returntrue;
380-
}
381371
returndeliveryAction==="remove"
382372
? removeQueuedMessage("[thread-outbox] failed to remove message for a missing thread")
383373
: creation!==undefined

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 184d8ef

Browse files
authored
fix(mobile): steer active turns by default (#6543)
1 parent 038560e commit 184d8ef

7 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎apps/mobile/src/features/threads/ThreadComposer.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export interface ThreadComposerProps {
105105
readonlyselectedThread: OrchestrationThreadShell;
106106
readonlyserverConfig: T3ServerConfig|null;
107107
readonlyqueueCount: number;
108-
readonlyactiveThreadBusy: boolean;
109108
readonlyenvironmentId: EnvironmentId;
110109
readonlyprojectCwd: string|null;
111110
readonlyeditorRef?: RefObject<ComposerEditorHandle|null>;
@@ -327,9 +326,7 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
327326
props.selectedThread.session?.status==="starting";
328327

329328
constsendLabel=
330-
props.connectionState!=="connected"||props.activeThreadBusy||props.queueCount>0
331-
? "Queue"
332-
: "Send";
329+
props.connectionState!=="connected"||props.queueCount>0 ? "Queue" : "Send";
333330
constcurrentModelSelection=props.selectedThread.modelSelection;
334331
constcurrentRuntimeMode=props.selectedThread.runtimeMode;
335332
constconnectionStatus=composerConnectionStatus({

‎apps/mobile/src/features/threads/ThreadDetailScreen.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export interface ThreadDetailScreenProps {
101101
readonlythreadSyncStatus?: EnvironmentThreadStatus;
102102
/** Non-null when older turns exist beyond the loaded window. */
103103
readonlyloadEarlier?: {readonlyloading: boolean;readonlyonLoadEarlier: ()=>void}|null;
104-
readonlyactiveThreadBusy: boolean;
105104
readonlyenvironmentId: EnvironmentId;
106105
readonlyprojectWorkspaceRoot: string|null;
107106
readonlythreadCwd: string|null;
@@ -727,7 +726,6 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
727726
selectedThread={props.selectedThread}
728727
serverConfig={props.serverConfig}
729728
queueCount={props.selectedThreadQueueCount}
730-
activeThreadBusy={props.activeThreadBusy}
731729
environmentId={props.environmentId}
732730
projectCwd={props.projectWorkspaceRoot}
733731
bottomInset={composerBottomInset}

‎apps/mobile/src/features/threads/ThreadRouteScreen.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,6 @@ function ThreadRouteContent(
785785
connectionStateLabel={routeConnectionState}
786786
threadSyncStatus={selectedThreadDetailState.status}
787787
loadEarlier={loadEarlierTurns}
788-
activeThreadBusy={composer.activeThreadBusy}
789788
environmentId={selectedThread.environmentId}
790789
projectWorkspaceRoot={selectedThreadProject?.workspaceRoot??null}
791790
threadCwd={selectedThreadCwd}

‎apps/mobile/src/state/thread-outbox-model.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export function resolveThreadOutboxDeliveryAction(input: {
169169
if(!input.threadExists){
170170
returninput.shellStatus==="live" ? "remove" : "wait";
171171
}
172-
returninput.environmentConnected&&!input.threadBusy? "send" : "wait";
172+
returninput.environmentConnected ? "send" : "wait";
173173
}
174174

175175
/**

‎apps/mobile/src/state/thread-outbox.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,27 @@ describe("thread outbox", () => {
487487
).toBe("send");
488488
});
489489

490+
it("sends existing-thread messages whenever connected so queued messages can steer",()=>{
491+
expect(
492+
resolveThreadOutboxDeliveryAction({
493+
isCreation: false,
494+
threadExists: true,
495+
shellStatus: "live",
496+
environmentConnected: true,
497+
threadBusy: true,
498+
}),
499+
).toBe("send");
500+
expect(
501+
resolveThreadOutboxDeliveryAction({
502+
isCreation: false,
503+
threadExists: true,
504+
shellStatus: "live",
505+
environmentConnected: false,
506+
threadBusy: true,
507+
}),
508+
).toBe("wait");
509+
});
510+
490511
it("sends queued creations once connected and live, removing already-created ones",()=>{
491512
expect(
492513
resolveThreadOutboxDeliveryAction({

‎apps/mobile/src/state/use-thread-composer-state.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,6 @@ export function useThreadComposerState() {
129129
);
130130
},[selectedThreadDetail,selectedThreadSessionActivity,selectedThreadShell]);
131131

132-
constactiveThreadBusy=
133-
!!selectedThread&&
134-
(selectedThread.session?.status==="running"||selectedThread.session?.status==="starting");
135-
136132
constonSendMessage=useCallback(async()=>{
137133
if(!selectedThreadShell){
138134
returnnull;
@@ -308,7 +304,6 @@ export function useThreadComposerState() {
308304
modelSelection,
309305
runtimeMode,
310306
interactionMode,
311-
activeThreadBusy,
312307
onChangeDraftMessage,
313308
onPickDraftImages,
314309
onPasteIntoDraft,

‎apps/mobile/src/state/use-thread-outbox-drain.ts‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
typeQueuedThreadMessage,
3838
typeThreadOutboxCommandStage,
3939
}from"./thread-outbox-model";
40-
import{environmentThreadShells,threadEnvironment}from"./threads";
40+
import{threadEnvironment}from"./threads";
4141
import{useAtomCommand}from"./use-atom-command";
4242
import{
4343
editingQueuedMessageIdsAtom,
@@ -362,22 +362,12 @@ export function useThreadOutboxDrain(): void {
362362
returntrue;
363363
}
364364
// The guards evaluated before the confirmation await are stale by now:
365-
// the thread may have gone busy, or the user may have opened this
366-
// message in the editor. Re-read both and defer to the next drain pass
367-
// (returning true skips the failure/backoff path) rather than sending
368-
// a payload the user is editing or racing an active turn.
365+
// the user may have opened this message in the editor. Re-read that
366+
// guard and defer to the next drain pass (returning true skips the
367+
// failure/backoff path) rather than sending a payload being edited.
369368
if(appAtomRegistry.get(editingQueuedMessageIdsAtom)[nextQueuedMessage.messageId]){
370369
returntrue;
371370
}
372-
constfreshThread=findThread(
373-
appAtomRegistry.get(environmentThreadShells.threadShellsAtom),
374-
nextQueuedMessage,
375-
);
376-
constfreshThreadBusy=
377-
freshThread?.session?.status==="running"||freshThread?.session?.status==="starting";
378-
if(deliveryAction==="send"&&creation===undefined&&freshThreadBusy){
379-
returntrue;
380-
}
381371
returndeliveryAction==="remove"
382372
? removeQueuedMessage("[thread-outbox] failed to remove message for a missing thread")
383373
: creation!==undefined

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 184d8ef

Browse files
authored
fix(mobile): steer active turns by default (#6543)
1 parent 038560e commit 184d8ef

7 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎apps/mobile/src/features/threads/ThreadComposer.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export interface ThreadComposerProps {
105105
readonlyselectedThread: OrchestrationThreadShell;
106106
readonlyserverConfig: T3ServerConfig|null;
107107
readonlyqueueCount: number;
108-
readonlyactiveThreadBusy: boolean;
109108
readonlyenvironmentId: EnvironmentId;
110109
readonlyprojectCwd: string|null;
111110
readonlyeditorRef?: RefObject<ComposerEditorHandle|null>;
@@ -327,9 +326,7 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
327326
props.selectedThread.session?.status==="starting";
328327

329328
constsendLabel=
330-
props.connectionState!=="connected"||props.activeThreadBusy||props.queueCount>0
331-
? "Queue"
332-
: "Send";
329+
props.connectionState!=="connected"||props.queueCount>0 ? "Queue" : "Send";
333330
constcurrentModelSelection=props.selectedThread.modelSelection;
334331
constcurrentRuntimeMode=props.selectedThread.runtimeMode;
335332
constconnectionStatus=composerConnectionStatus({

‎apps/mobile/src/features/threads/ThreadDetailScreen.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export interface ThreadDetailScreenProps {
101101
readonlythreadSyncStatus?: EnvironmentThreadStatus;
102102
/** Non-null when older turns exist beyond the loaded window. */
103103
readonlyloadEarlier?: {readonlyloading: boolean;readonlyonLoadEarlier: ()=>void}|null;
104-
readonlyactiveThreadBusy: boolean;
105104
readonlyenvironmentId: EnvironmentId;
106105
readonlyprojectWorkspaceRoot: string|null;
107106
readonlythreadCwd: string|null;
@@ -727,7 +726,6 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
727726
selectedThread={props.selectedThread}
728727
serverConfig={props.serverConfig}
729728
queueCount={props.selectedThreadQueueCount}
730-
activeThreadBusy={props.activeThreadBusy}
731729
environmentId={props.environmentId}
732730
projectCwd={props.projectWorkspaceRoot}
733731
bottomInset={composerBottomInset}

‎apps/mobile/src/features/threads/ThreadRouteScreen.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,6 @@ function ThreadRouteContent(
785785
connectionStateLabel={routeConnectionState}
786786
threadSyncStatus={selectedThreadDetailState.status}
787787
loadEarlier={loadEarlierTurns}
788-
activeThreadBusy={composer.activeThreadBusy}
789788
environmentId={selectedThread.environmentId}
790789
projectWorkspaceRoot={selectedThreadProject?.workspaceRoot??null}
791790
threadCwd={selectedThreadCwd}

‎apps/mobile/src/state/thread-outbox-model.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export function resolveThreadOutboxDeliveryAction(input: {
169169
if(!input.threadExists){
170170
returninput.shellStatus==="live" ? "remove" : "wait";
171171
}
172-
returninput.environmentConnected&&!input.threadBusy? "send" : "wait";
172+
returninput.environmentConnected ? "send" : "wait";
173173
}
174174

175175
/**

‎apps/mobile/src/state/thread-outbox.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,27 @@ describe("thread outbox", () => {
487487
).toBe("send");
488488
});
489489

490+
it("sends existing-thread messages whenever connected so queued messages can steer",()=>{
491+
expect(
492+
resolveThreadOutboxDeliveryAction({
493+
isCreation: false,
494+
threadExists: true,
495+
shellStatus: "live",
496+
environmentConnected: true,
497+
threadBusy: true,
498+
}),
499+
).toBe("send");
500+
expect(
501+
resolveThreadOutboxDeliveryAction({
502+
isCreation: false,
503+
threadExists: true,
504+
shellStatus: "live",
505+
environmentConnected: false,
506+
threadBusy: true,
507+
}),
508+
).toBe("wait");
509+
});
510+
490511
it("sends queued creations once connected and live, removing already-created ones",()=>{
491512
expect(
492513
resolveThreadOutboxDeliveryAction({

‎apps/mobile/src/state/use-thread-composer-state.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,6 @@ export function useThreadComposerState() {
129129
);
130130
},[selectedThreadDetail,selectedThreadSessionActivity,selectedThreadShell]);
131131

132-
constactiveThreadBusy=
133-
!!selectedThread&&
134-
(selectedThread.session?.status==="running"||selectedThread.session?.status==="starting");
135-
136132
constonSendMessage=useCallback(async()=>{
137133
if(!selectedThreadShell){
138134
returnnull;
@@ -308,7 +304,6 @@ export function useThreadComposerState() {
308304
modelSelection,
309305
runtimeMode,
310306
interactionMode,
311-
activeThreadBusy,
312307
onChangeDraftMessage,
313308
onPickDraftImages,
314309
onPasteIntoDraft,

‎apps/mobile/src/state/use-thread-outbox-drain.ts‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
typeQueuedThreadMessage,
3838
typeThreadOutboxCommandStage,
3939
}from"./thread-outbox-model";
40-
import{environmentThreadShells,threadEnvironment}from"./threads";
40+
import{threadEnvironment}from"./threads";
4141
import{useAtomCommand}from"./use-atom-command";
4242
import{
4343
editingQueuedMessageIdsAtom,
@@ -362,22 +362,12 @@ export function useThreadOutboxDrain(): void {
362362
returntrue;
363363
}
364364
// The guards evaluated before the confirmation await are stale by now:
365-
// the thread may have gone busy, or the user may have opened this
366-
// message in the editor. Re-read both and defer to the next drain pass
367-
// (returning true skips the failure/backoff path) rather than sending
368-
// a payload the user is editing or racing an active turn.
365+
// the user may have opened this message in the editor. Re-read that
366+
// guard and defer to the next drain pass (returning true skips the
367+
// failure/backoff path) rather than sending a payload being edited.
369368
if(appAtomRegistry.get(editingQueuedMessageIdsAtom)[nextQueuedMessage.messageId]){
370369
returntrue;
371370
}
372-
constfreshThread=findThread(
373-
appAtomRegistry.get(environmentThreadShells.threadShellsAtom),
374-
nextQueuedMessage,
375-
);
376-
constfreshThreadBusy=
377-
freshThread?.session?.status==="running"||freshThread?.session?.status==="starting";
378-
if(deliveryAction==="send"&&creation===undefined&&freshThreadBusy){
379-
returntrue;
380-
}
381371
returndeliveryAction==="remove"
382372
? removeQueuedMessage("[thread-outbox] failed to remove message for a missing thread")
383373
: creation!==undefined

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 184d8ef

Browse files
authored
fix(mobile): steer active turns by default (#6543)
1 parent 038560e commit 184d8ef

7 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎apps/mobile/src/features/threads/ThreadComposer.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export interface ThreadComposerProps {
105105
readonlyselectedThread: OrchestrationThreadShell;
106106
readonlyserverConfig: T3ServerConfig|null;
107107
readonlyqueueCount: number;
108-
readonlyactiveThreadBusy: boolean;
109108
readonlyenvironmentId: EnvironmentId;
110109
readonlyprojectCwd: string|null;
111110
readonlyeditorRef?: RefObject<ComposerEditorHandle|null>;
@@ -327,9 +326,7 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
327326
props.selectedThread.session?.status==="starting";
328327

329328
constsendLabel=
330-
props.connectionState!=="connected"||props.activeThreadBusy||props.queueCount>0
331-
? "Queue"
332-
: "Send";
329+
props.connectionState!=="connected"||props.queueCount>0 ? "Queue" : "Send";
333330
constcurrentModelSelection=props.selectedThread.modelSelection;
334331
constcurrentRuntimeMode=props.selectedThread.runtimeMode;
335332
constconnectionStatus=composerConnectionStatus({

‎apps/mobile/src/features/threads/ThreadDetailScreen.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export interface ThreadDetailScreenProps {
101101
readonlythreadSyncStatus?: EnvironmentThreadStatus;
102102
/** Non-null when older turns exist beyond the loaded window. */
103103
readonlyloadEarlier?: {readonlyloading: boolean;readonlyonLoadEarlier: ()=>void}|null;
104-
readonlyactiveThreadBusy: boolean;
105104
readonlyenvironmentId: EnvironmentId;
106105
readonlyprojectWorkspaceRoot: string|null;
107106
readonlythreadCwd: string|null;
@@ -727,7 +726,6 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
727726
selectedThread={props.selectedThread}
728727
serverConfig={props.serverConfig}
729728
queueCount={props.selectedThreadQueueCount}
730-
activeThreadBusy={props.activeThreadBusy}
731729
environmentId={props.environmentId}
732730
projectCwd={props.projectWorkspaceRoot}
733731
bottomInset={composerBottomInset}

‎apps/mobile/src/features/threads/ThreadRouteScreen.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,6 @@ function ThreadRouteContent(
785785
connectionStateLabel={routeConnectionState}
786786
threadSyncStatus={selectedThreadDetailState.status}
787787
loadEarlier={loadEarlierTurns}
788-
activeThreadBusy={composer.activeThreadBusy}
789788
environmentId={selectedThread.environmentId}
790789
projectWorkspaceRoot={selectedThreadProject?.workspaceRoot??null}
791790
threadCwd={selectedThreadCwd}

‎apps/mobile/src/state/thread-outbox-model.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export function resolveThreadOutboxDeliveryAction(input: {
169169
if(!input.threadExists){
170170
returninput.shellStatus==="live" ? "remove" : "wait";
171171
}
172-
returninput.environmentConnected&&!input.threadBusy? "send" : "wait";
172+
returninput.environmentConnected ? "send" : "wait";
173173
}
174174

175175
/**

‎apps/mobile/src/state/thread-outbox.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,27 @@ describe("thread outbox", () => {
487487
).toBe("send");
488488
});
489489

490+
it("sends existing-thread messages whenever connected so queued messages can steer",()=>{
491+
expect(
492+
resolveThreadOutboxDeliveryAction({
493+
isCreation: false,
494+
threadExists: true,
495+
shellStatus: "live",
496+
environmentConnected: true,
497+
threadBusy: true,
498+
}),
499+
).toBe("send");
500+
expect(
501+
resolveThreadOutboxDeliveryAction({
502+
isCreation: false,
503+
threadExists: true,
504+
shellStatus: "live",
505+
environmentConnected: false,
506+
threadBusy: true,
507+
}),
508+
).toBe("wait");
509+
});
510+
490511
it("sends queued creations once connected and live, removing already-created ones",()=>{
491512
expect(
492513
resolveThreadOutboxDeliveryAction({

‎apps/mobile/src/state/use-thread-composer-state.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,6 @@ export function useThreadComposerState() {
129129
);
130130
},[selectedThreadDetail,selectedThreadSessionActivity,selectedThreadShell]);
131131

132-
constactiveThreadBusy=
133-
!!selectedThread&&
134-
(selectedThread.session?.status==="running"||selectedThread.session?.status==="starting");
135-
136132
constonSendMessage=useCallback(async()=>{
137133
if(!selectedThreadShell){
138134
returnnull;
@@ -308,7 +304,6 @@ export function useThreadComposerState() {
308304
modelSelection,
309305
runtimeMode,
310306
interactionMode,
311-
activeThreadBusy,
312307
onChangeDraftMessage,
313308
onPickDraftImages,
314309
onPasteIntoDraft,

‎apps/mobile/src/state/use-thread-outbox-drain.ts‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
typeQueuedThreadMessage,
3838
typeThreadOutboxCommandStage,
3939
}from"./thread-outbox-model";
40-
import{environmentThreadShells,threadEnvironment}from"./threads";
40+
import{threadEnvironment}from"./threads";
4141
import{useAtomCommand}from"./use-atom-command";
4242
import{
4343
editingQueuedMessageIdsAtom,
@@ -362,22 +362,12 @@ export function useThreadOutboxDrain(): void {
362362
returntrue;
363363
}
364364
// The guards evaluated before the confirmation await are stale by now:
365-
// the thread may have gone busy, or the user may have opened this
366-
// message in the editor. Re-read both and defer to the next drain pass
367-
// (returning true skips the failure/backoff path) rather than sending
368-
// a payload the user is editing or racing an active turn.
365+
// the user may have opened this message in the editor. Re-read that
366+
// guard and defer to the next drain pass (returning true skips the
367+
// failure/backoff path) rather than sending a payload being edited.
369368
if(appAtomRegistry.get(editingQueuedMessageIdsAtom)[nextQueuedMessage.messageId]){
370369
returntrue;
371370
}
372-
constfreshThread=findThread(
373-
appAtomRegistry.get(environmentThreadShells.threadShellsAtom),
374-
nextQueuedMessage,
375-
);
376-
constfreshThreadBusy=
377-
freshThread?.session?.status==="running"||freshThread?.session?.status==="starting";
378-
if(deliveryAction==="send"&&creation===undefined&&freshThreadBusy){
379-
returntrue;
380-
}
381371
returndeliveryAction==="remove"
382372
? removeQueuedMessage("[thread-outbox] failed to remove message for a missing thread")
383373
: creation!==undefined

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 184d8ef

Browse files
authored
fix(mobile): steer active turns by default (#6543)
1 parent 038560e commit 184d8ef

7 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎apps/mobile/src/features/threads/ThreadComposer.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export interface ThreadComposerProps {
105105
readonlyselectedThread: OrchestrationThreadShell;
106106
readonlyserverConfig: T3ServerConfig|null;
107107
readonlyqueueCount: number;
108-
readonlyactiveThreadBusy: boolean;
109108
readonlyenvironmentId: EnvironmentId;
110109
readonlyprojectCwd: string|null;
111110
readonlyeditorRef?: RefObject<ComposerEditorHandle|null>;
@@ -327,9 +326,7 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
327326
props.selectedThread.session?.status==="starting";
328327

329328
constsendLabel=
330-
props.connectionState!=="connected"||props.activeThreadBusy||props.queueCount>0
331-
? "Queue"
332-
: "Send";
329+
props.connectionState!=="connected"||props.queueCount>0 ? "Queue" : "Send";
333330
constcurrentModelSelection=props.selectedThread.modelSelection;
334331
constcurrentRuntimeMode=props.selectedThread.runtimeMode;
335332
constconnectionStatus=composerConnectionStatus({

‎apps/mobile/src/features/threads/ThreadDetailScreen.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export interface ThreadDetailScreenProps {
101101
readonlythreadSyncStatus?: EnvironmentThreadStatus;
102102
/** Non-null when older turns exist beyond the loaded window. */
103103
readonlyloadEarlier?: {readonlyloading: boolean;readonlyonLoadEarlier: ()=>void}|null;
104-
readonlyactiveThreadBusy: boolean;
105104
readonlyenvironmentId: EnvironmentId;
106105
readonlyprojectWorkspaceRoot: string|null;
107106
readonlythreadCwd: string|null;
@@ -727,7 +726,6 @@ export const ThreadDetailScreen = memo(function ThreadDetailScreen(props: Thread
727726
selectedThread={props.selectedThread}
728727
serverConfig={props.serverConfig}
729728
queueCount={props.selectedThreadQueueCount}
730-
activeThreadBusy={props.activeThreadBusy}
731729
environmentId={props.environmentId}
732730
projectCwd={props.projectWorkspaceRoot}
733731
bottomInset={composerBottomInset}

‎apps/mobile/src/features/threads/ThreadRouteScreen.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,6 @@ function ThreadRouteContent(
785785
connectionStateLabel={routeConnectionState}
786786
threadSyncStatus={selectedThreadDetailState.status}
787787
loadEarlier={loadEarlierTurns}
788-
activeThreadBusy={composer.activeThreadBusy}
789788
environmentId={selectedThread.environmentId}
790789
projectWorkspaceRoot={selectedThreadProject?.workspaceRoot??null}
791790
threadCwd={selectedThreadCwd}

‎apps/mobile/src/state/thread-outbox-model.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export function resolveThreadOutboxDeliveryAction(input: {
169169
if(!input.threadExists){
170170
returninput.shellStatus==="live" ? "remove" : "wait";
171171
}
172-
returninput.environmentConnected&&!input.threadBusy? "send" : "wait";
172+
returninput.environmentConnected ? "send" : "wait";
173173
}
174174

175175
/**

‎apps/mobile/src/state/thread-outbox.test.ts‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,27 @@ describe("thread outbox", () => {
487487
).toBe("send");
488488
});
489489

490+
it("sends existing-thread messages whenever connected so queued messages can steer",()=>{
491+
expect(
492+
resolveThreadOutboxDeliveryAction({
493+
isCreation: false,
494+
threadExists: true,
495+
shellStatus: "live",
496+
environmentConnected: true,
497+
threadBusy: true,
498+
}),
499+
).toBe("send");
500+
expect(
501+
resolveThreadOutboxDeliveryAction({
502+
isCreation: false,
503+
threadExists: true,
504+
shellStatus: "live",
505+
environmentConnected: false,
506+
threadBusy: true,
507+
}),
508+
).toBe("wait");
509+
});
510+
490511
it("sends queued creations once connected and live, removing already-created ones",()=>{
491512
expect(
492513
resolveThreadOutboxDeliveryAction({

‎apps/mobile/src/state/use-thread-composer-state.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,6 @@ export function useThreadComposerState() {
129129
);
130130
},[selectedThreadDetail,selectedThreadSessionActivity,selectedThreadShell]);
131131

132-
constactiveThreadBusy=
133-
!!selectedThread&&
134-
(selectedThread.session?.status==="running"||selectedThread.session?.status==="starting");
135-
136132
constonSendMessage=useCallback(async()=>{
137133
if(!selectedThreadShell){
138134
returnnull;
@@ -308,7 +304,6 @@ export function useThreadComposerState() {
308304
modelSelection,
309305
runtimeMode,
310306
interactionMode,
311-
activeThreadBusy,
312307
onChangeDraftMessage,
313308
onPickDraftImages,
314309
onPasteIntoDraft,

‎apps/mobile/src/state/use-thread-outbox-drain.ts‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
typeQueuedThreadMessage,
3838
typeThreadOutboxCommandStage,
3939
}from"./thread-outbox-model";
40-
import{environmentThreadShells,threadEnvironment}from"./threads";
40+
import{threadEnvironment}from"./threads";
4141
import{useAtomCommand}from"./use-atom-command";
4242
import{
4343
editingQueuedMessageIdsAtom,
@@ -362,22 +362,12 @@ export function useThreadOutboxDrain(): void {
362362
returntrue;
363363
}
364364
// The guards evaluated before the confirmation await are stale by now:
365-
// the thread may have gone busy, or the user may have opened this
366-
// message in the editor. Re-read both and defer to the next drain pass
367-
// (returning true skips the failure/backoff path) rather than sending
368-
// a payload the user is editing or racing an active turn.
365+
// the user may have opened this message in the editor. Re-read that
366+
// guard and defer to the next drain pass (returning true skips the
367+
// failure/backoff path) rather than sending a payload being edited.
369368
if(appAtomRegistry.get(editingQueuedMessageIdsAtom)[nextQueuedMessage.messageId]){
370369
returntrue;
371370
}
372-
constfreshThread=findThread(
373-
appAtomRegistry.get(environmentThreadShells.threadShellsAtom),
374-
nextQueuedMessage,
375-
);
376-
constfreshThreadBusy=
377-
freshThread?.session?.status==="running"||freshThread?.session?.status==="starting";
378-
if(deliveryAction==="send"&&creation===undefined&&freshThreadBusy){
379-
returntrue;
380-
}
381371
returndeliveryAction==="remove"
382372
? removeQueuedMessage("[thread-outbox] failed to remove message for a missing thread")
383373
: creation!==undefined

0 commit comments

Comments
 (0)