Commit 409a118

Browse files
committed
Fix: clear maximized state on last surface close, add cache-invalidating refresh RPC, probe truncated files for binary content
- ChatView: clear maximizedRightPanelThreadKey when closeRightPanelSurface leaves no active surface, preventing the chat column from staying at w-0 after the last right-panel tab is closed. - Add projects.refreshEntries RPC that invalidates the workspace index cache before listing, so the explicit refresh button in FileBrowserPanel returns up-to-date filesystem state instead of stale cached data. - WorkspaceFileSystem.readFile: when a file is truncated (>1 MB), read an additional 8 KB probe from the end of the file and check for NUL bytes, catching binary files whose first null appears beyond the preview window.
1 parent e18504c commit 409a118

10 files changed

Lines changed: 85 additions & 30 deletions

File tree

‎apps/server/src/workspace/Layers/WorkspaceFileSystem.ts‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,20 @@ export const makeWorkspaceFileSystem = Effect.gen(function* () {
5757
if(fileBytes.includes(0)){
5858
thrownewError("Binary files cannot be previewed as text.");
5959
}
60+
if(stat.size>PROJECT_READ_FILE_MAX_BYTES){
61+
constprobeSize=8192;
62+
constprobeOffset=Math.max(bytesToRead,stat.size-probeSize);
63+
constprobeBuf=Buffer.alloc(Math.min(probeSize,stat.size-probeOffset));
64+
const{bytesRead: probeRead}=awaithandle.read(
65+
probeBuf,
66+
0,
67+
probeBuf.length,
68+
probeOffset,
69+
);
70+
if(probeBuf.subarray(0,probeRead).includes(0)){
71+
thrownewError("Binary files cannot be previewed as text.");
72+
}
73+
}
6074
constcontents=newTextDecoder("utf-8").decode(fileBytes);
6175
return{
6276
relativePath: target.relativePath,

‎apps/server/src/ws.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ const RPC_REQUIRED_SCOPE = new Map<string, AuthEnvironmentScope>([
163163
[WS_METHODS.sourceControlCloneRepository,AuthOrchestrationOperateScope],
164164
[WS_METHODS.sourceControlPublishRepository,AuthOrchestrationOperateScope],
165165
[WS_METHODS.projectsListEntries,AuthOrchestrationReadScope],
166+
[WS_METHODS.projectsRefreshEntries,AuthOrchestrationReadScope],
166167
[WS_METHODS.projectsReadFile,AuthOrchestrationReadScope],
167168
[WS_METHODS.projectsSearchEntries,AuthOrchestrationReadScope],
168169
[WS_METHODS.projectsWriteFile,AuthOrchestrationOperateScope],
@@ -1190,6 +1191,21 @@ const makeWsRpcLayer = (currentSession: AuthenticatedSession) =>
11901191
),
11911192
{"rpc.aggregate": "workspace"},
11921193
),
1194+
[WS_METHODS.projectsRefreshEntries]: (input)=>
1195+
observeRpcEffect(
1196+
WS_METHODS.projectsRefreshEntries,
1197+
workspaceEntries.invalidate(input.cwd).pipe(
1198+
Effect.andThen(()=>workspaceEntries.list(input)),
1199+
Effect.mapError(
1200+
(cause)=>
1201+
newProjectListEntriesError({
1202+
message: `Failed to refresh workspace entries: ${cause.detail}`,
1203+
cause,
1204+
}),
1205+
),
1206+
),
1207+
{"rpc.aggregate": "workspace"},
1208+
),
11931209
[WS_METHODS.projectsReadFile]: (input)=>
11941210
observeRpcEffect(
11951211
WS_METHODS.projectsReadFile,

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3067,6 +3067,9 @@ export default function ChatView(props: ChatViewProps) {
30673067
useRightPanelStore.getState().byThreadKey,
30683068
activeThreadRef,
30693069
);
3070+
if(!nextActiveSurface){
3071+
setMaximizedRightPanelThreadKey(null);
3072+
}
30703073
if(nextActiveSurface?.kind==="preview"&&nextActiveSurface.resourceId){
30713074
usePreviewStateStore.getState().setActiveTab(activeThreadRef,nextActiveSurface.resourceId);
30723075
}

‎apps/web/src/components/files/FileBrowserPanel.tsx‎

Lines changed: 37 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,44 @@ export default function FileBrowserPanel({
6262
unsafeCSS: TREE_UNSAFE_CSS,
6363
});
6464

65-
constloadEntries=useCallback(()=>{
66-
constapi=readEnvironmentApi(environmentId);
67-
requestGenerationRef.current+=1;
68-
constgeneration=requestGenerationRef.current;
69-
setIsLoadingEntries(true);
70-
setEntriesError(null);
71-
72-
if(!api){
73-
setEntriesError("Environment is not connected.");
74-
setIsLoadingEntries(false);
75-
return;
76-
}
65+
constloadEntries=useCallback(
66+
(options?: {refresh?: boolean})=>{
67+
constapi=readEnvironmentApi(environmentId);
68+
requestGenerationRef.current+=1;
69+
constgeneration=requestGenerationRef.current;
70+
setIsLoadingEntries(true);
71+
setEntriesError(null);
7772

78-
voidapi.projects.listEntries({ cwd }).then(
79-
(result)=>{
80-
if(generation!==requestGenerationRef.current)return;
81-
entryKindsRef.current=newMap(
82-
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
83-
);
84-
setEntries(result.entries);
85-
setIsTruncated(result.truncated);
86-
model.resetPaths(result.entries.map(treePath));
73+
if(!api){
74+
setEntriesError("Environment is not connected.");
8775
setIsLoadingEntries(false);
88-
},
89-
(error: unknown)=>{
90-
if(generation!==requestGenerationRef.current)return;
91-
setEntriesError(errorinstanceofError ? error.message : String(error));
92-
setIsLoadingEntries(false);
93-
},
94-
);
95-
},[cwd,environmentId,model]);
76+
return;
77+
}
78+
79+
constrequest=options?.refresh
80+
? api.projects.refreshEntries({ cwd })
81+
: api.projects.listEntries({ cwd });
82+
83+
voidrequest.then(
84+
(result)=>{
85+
if(generation!==requestGenerationRef.current)return;
86+
entryKindsRef.current=newMap(
87+
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
88+
);
89+
setEntries(result.entries);
90+
setIsTruncated(result.truncated);
91+
model.resetPaths(result.entries.map(treePath));
92+
setIsLoadingEntries(false);
93+
},
94+
(error: unknown)=>{
95+
if(generation!==requestGenerationRef.current)return;
96+
setEntriesError(errorinstanceofError ? error.message : String(error));
97+
setIsLoadingEntries(false);
98+
},
99+
);
100+
},
101+
[cwd,environmentId,model],
102+
);
96103

97104
useEffect(()=>{
98105
loadEntries();
@@ -128,7 +135,7 @@ export default function FileBrowserPanel({
128135
type="button"
129136
className="rounded-md p-1.5 text-muted-foreground hover:bg-accent hover:text-foreground"
130137
aria-label="Refresh workspace files"
131-
onClick={loadEntries}
138+
onClick={()=>loadEntries({refresh: true})}
132139
>
133140
<RefreshCwclassName={cn("size-3.5",isLoadingEntries&&"animate-spin")}/>
134141
</button>

‎apps/web/src/environmentApi.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export function createEnvironmentApi(rpcClient: WsRpcClient): EnvironmentApi {
2020
},
2121
projects: {
2222
listEntries: rpcClient.projects.listEntries,
23+
refreshEntries: rpcClient.projects.refreshEntries,
2324
readFile: rpcClient.projects.readFile,
2425
searchEntries: rpcClient.projects.searchEntries,
2526
writeFile: rpcClient.projects.writeFile,

‎apps/web/src/environments/runtime/service.threadSubscriptions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ vi.mock("@t3tools/client-runtime", async (importOriginal) => {
122122
},
123123
projects: {
124124
listEntries: vi.fn(),
125+
refreshEntries: vi.fn(),
125126
readFile: vi.fn(),
126127
searchEntries: vi.fn(),
127128
writeFile: vi.fn(),

‎apps/web/src/localApi.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const rpcClientMock = {
5656
},
5757
projects: {
5858
listEntries: vi.fn(),
59+
refreshEntries: vi.fn(),
5960
readFile: vi.fn(),
6061
searchEntries: vi.fn(),
6162
writeFile: vi.fn(),

‎packages/client-runtime/src/wsRpcClient.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export interface WsRpcClient {
9797
};
9898
readonlyprojects: {
9999
readonlylistEntries: RpcUnaryMethod<typeofWS_METHODS.projectsListEntries>;
100+
readonlyrefreshEntries: RpcUnaryMethod<typeofWS_METHODS.projectsRefreshEntries>;
100101
readonlyreadFile: RpcUnaryMethod<typeofWS_METHODS.projectsReadFile>;
101102
readonlysearchEntries: RpcUnaryMethod<typeofWS_METHODS.projectsSearchEntries>;
102103
readonlywriteFile: RpcUnaryMethod<typeofWS_METHODS.projectsWriteFile>;
@@ -271,6 +272,8 @@ export function createWsRpcClient(
271272
projects: {
272273
listEntries: (input)=>
273274
transport.request((client)=>client[WS_METHODS.projectsListEntries](input)),
275+
refreshEntries: (input)=>
276+
transport.request((client)=>client[WS_METHODS.projectsRefreshEntries](input)),
274277
readFile: (input)=>
275278
transport.request((client)=>client[WS_METHODS.projectsReadFile](input)),
276279
searchEntries: (input)=>

‎packages/contracts/src/ipc.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,6 +1115,7 @@ export interface EnvironmentApi {
11151115
};
11161116
projects: {
11171117
listEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
1118+
refreshEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
11181119
readFile: (input: ProjectReadFileInput)=>Promise<ProjectReadFileResult>;
11191120
searchEntries: (input: ProjectSearchEntriesInput)=>Promise<ProjectSearchEntriesResult>;
11201121
writeFile: (input: ProjectWriteFileInput)=>Promise<ProjectWriteFileResult>;

‎packages/contracts/src/rpc.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ export const WS_METHODS = {
148148
projectsAdd: "projects.add",
149149
projectsRemove: "projects.remove",
150150
projectsListEntries: "projects.listEntries",
151+
projectsRefreshEntries: "projects.refreshEntries",
151152
projectsReadFile: "projects.readFile",
152153
projectsSearchEntries: "projects.searchEntries",
153154
projectsWriteFile: "projects.writeFile",
@@ -364,6 +365,12 @@ export const WsProjectsListEntriesRpc = Rpc.make(WS_METHODS.projectsListEntries,
364365
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
365366
});
366367

368+
exportconstWsProjectsRefreshEntriesRpc=Rpc.make(WS_METHODS.projectsRefreshEntries,{
369+
payload: ProjectListEntriesInput,
370+
success: ProjectListEntriesResult,
371+
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
372+
});
373+
367374
exportconstWsProjectsReadFileRpc=Rpc.make(WS_METHODS.projectsReadFile,{
368375
payload: ProjectReadFileInput,
369376
success: ProjectReadFileResult,
@@ -697,6 +704,7 @@ export const WsRpcGroup = RpcGroup.make(
697704
WsSourceControlCloneRepositoryRpc,
698705
WsSourceControlPublishRepositoryRpc,
699706
WsProjectsListEntriesRpc,
707+
WsProjectsRefreshEntriesRpc,
700708
WsProjectsReadFileRpc,
701709
WsProjectsSearchEntriesRpc,
702710
WsProjectsWriteFileRpc,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 409a118

Browse files
committed
Fix: clear maximized state on last surface close, add cache-invalidating refresh RPC, probe truncated files for binary content
- ChatView: clear maximizedRightPanelThreadKey when closeRightPanelSurface leaves no active surface, preventing the chat column from staying at w-0 after the last right-panel tab is closed. - Add projects.refreshEntries RPC that invalidates the workspace index cache before listing, so the explicit refresh button in FileBrowserPanel returns up-to-date filesystem state instead of stale cached data. - WorkspaceFileSystem.readFile: when a file is truncated (>1 MB), read an additional 8 KB probe from the end of the file and check for NUL bytes, catching binary files whose first null appears beyond the preview window.
1 parent e18504c commit 409a118

10 files changed

Lines changed: 85 additions & 30 deletions

File tree

‎apps/server/src/workspace/Layers/WorkspaceFileSystem.ts‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,20 @@ export const makeWorkspaceFileSystem = Effect.gen(function* () {
5757
if(fileBytes.includes(0)){
5858
thrownewError("Binary files cannot be previewed as text.");
5959
}
60+
if(stat.size>PROJECT_READ_FILE_MAX_BYTES){
61+
constprobeSize=8192;
62+
constprobeOffset=Math.max(bytesToRead,stat.size-probeSize);
63+
constprobeBuf=Buffer.alloc(Math.min(probeSize,stat.size-probeOffset));
64+
const{bytesRead: probeRead}=awaithandle.read(
65+
probeBuf,
66+
0,
67+
probeBuf.length,
68+
probeOffset,
69+
);
70+
if(probeBuf.subarray(0,probeRead).includes(0)){
71+
thrownewError("Binary files cannot be previewed as text.");
72+
}
73+
}
6074
constcontents=newTextDecoder("utf-8").decode(fileBytes);
6175
return{
6276
relativePath: target.relativePath,

‎apps/server/src/ws.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ const RPC_REQUIRED_SCOPE = new Map<string, AuthEnvironmentScope>([
163163
[WS_METHODS.sourceControlCloneRepository,AuthOrchestrationOperateScope],
164164
[WS_METHODS.sourceControlPublishRepository,AuthOrchestrationOperateScope],
165165
[WS_METHODS.projectsListEntries,AuthOrchestrationReadScope],
166+
[WS_METHODS.projectsRefreshEntries,AuthOrchestrationReadScope],
166167
[WS_METHODS.projectsReadFile,AuthOrchestrationReadScope],
167168
[WS_METHODS.projectsSearchEntries,AuthOrchestrationReadScope],
168169
[WS_METHODS.projectsWriteFile,AuthOrchestrationOperateScope],
@@ -1190,6 +1191,21 @@ const makeWsRpcLayer = (currentSession: AuthenticatedSession) =>
11901191
),
11911192
{"rpc.aggregate": "workspace"},
11921193
),
1194+
[WS_METHODS.projectsRefreshEntries]: (input)=>
1195+
observeRpcEffect(
1196+
WS_METHODS.projectsRefreshEntries,
1197+
workspaceEntries.invalidate(input.cwd).pipe(
1198+
Effect.andThen(()=>workspaceEntries.list(input)),
1199+
Effect.mapError(
1200+
(cause)=>
1201+
newProjectListEntriesError({
1202+
message: `Failed to refresh workspace entries: ${cause.detail}`,
1203+
cause,
1204+
}),
1205+
),
1206+
),
1207+
{"rpc.aggregate": "workspace"},
1208+
),
11931209
[WS_METHODS.projectsReadFile]: (input)=>
11941210
observeRpcEffect(
11951211
WS_METHODS.projectsReadFile,

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3067,6 +3067,9 @@ export default function ChatView(props: ChatViewProps) {
30673067
useRightPanelStore.getState().byThreadKey,
30683068
activeThreadRef,
30693069
);
3070+
if(!nextActiveSurface){
3071+
setMaximizedRightPanelThreadKey(null);
3072+
}
30703073
if(nextActiveSurface?.kind==="preview"&&nextActiveSurface.resourceId){
30713074
usePreviewStateStore.getState().setActiveTab(activeThreadRef,nextActiveSurface.resourceId);
30723075
}

‎apps/web/src/components/files/FileBrowserPanel.tsx‎

Lines changed: 37 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,44 @@ export default function FileBrowserPanel({
6262
unsafeCSS: TREE_UNSAFE_CSS,
6363
});
6464

65-
constloadEntries=useCallback(()=>{
66-
constapi=readEnvironmentApi(environmentId);
67-
requestGenerationRef.current+=1;
68-
constgeneration=requestGenerationRef.current;
69-
setIsLoadingEntries(true);
70-
setEntriesError(null);
71-
72-
if(!api){
73-
setEntriesError("Environment is not connected.");
74-
setIsLoadingEntries(false);
75-
return;
76-
}
65+
constloadEntries=useCallback(
66+
(options?: {refresh?: boolean})=>{
67+
constapi=readEnvironmentApi(environmentId);
68+
requestGenerationRef.current+=1;
69+
constgeneration=requestGenerationRef.current;
70+
setIsLoadingEntries(true);
71+
setEntriesError(null);
7772

78-
voidapi.projects.listEntries({ cwd }).then(
79-
(result)=>{
80-
if(generation!==requestGenerationRef.current)return;
81-
entryKindsRef.current=newMap(
82-
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
83-
);
84-
setEntries(result.entries);
85-
setIsTruncated(result.truncated);
86-
model.resetPaths(result.entries.map(treePath));
73+
if(!api){
74+
setEntriesError("Environment is not connected.");
8775
setIsLoadingEntries(false);
88-
},
89-
(error: unknown)=>{
90-
if(generation!==requestGenerationRef.current)return;
91-
setEntriesError(errorinstanceofError ? error.message : String(error));
92-
setIsLoadingEntries(false);
93-
},
94-
);
95-
},[cwd,environmentId,model]);
76+
return;
77+
}
78+
79+
constrequest=options?.refresh
80+
? api.projects.refreshEntries({ cwd })
81+
: api.projects.listEntries({ cwd });
82+
83+
voidrequest.then(
84+
(result)=>{
85+
if(generation!==requestGenerationRef.current)return;
86+
entryKindsRef.current=newMap(
87+
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
88+
);
89+
setEntries(result.entries);
90+
setIsTruncated(result.truncated);
91+
model.resetPaths(result.entries.map(treePath));
92+
setIsLoadingEntries(false);
93+
},
94+
(error: unknown)=>{
95+
if(generation!==requestGenerationRef.current)return;
96+
setEntriesError(errorinstanceofError ? error.message : String(error));
97+
setIsLoadingEntries(false);
98+
},
99+
);
100+
},
101+
[cwd,environmentId,model],
102+
);
96103

97104
useEffect(()=>{
98105
loadEntries();
@@ -128,7 +135,7 @@ export default function FileBrowserPanel({
128135
type="button"
129136
className="rounded-md p-1.5 text-muted-foreground hover:bg-accent hover:text-foreground"
130137
aria-label="Refresh workspace files"
131-
onClick={loadEntries}
138+
onClick={()=>loadEntries({refresh: true})}
132139
>
133140
<RefreshCwclassName={cn("size-3.5",isLoadingEntries&&"animate-spin")}/>
134141
</button>

‎apps/web/src/environmentApi.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export function createEnvironmentApi(rpcClient: WsRpcClient): EnvironmentApi {
2020
},
2121
projects: {
2222
listEntries: rpcClient.projects.listEntries,
23+
refreshEntries: rpcClient.projects.refreshEntries,
2324
readFile: rpcClient.projects.readFile,
2425
searchEntries: rpcClient.projects.searchEntries,
2526
writeFile: rpcClient.projects.writeFile,

‎apps/web/src/environments/runtime/service.threadSubscriptions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ vi.mock("@t3tools/client-runtime", async (importOriginal) => {
122122
},
123123
projects: {
124124
listEntries: vi.fn(),
125+
refreshEntries: vi.fn(),
125126
readFile: vi.fn(),
126127
searchEntries: vi.fn(),
127128
writeFile: vi.fn(),

‎apps/web/src/localApi.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const rpcClientMock = {
5656
},
5757
projects: {
5858
listEntries: vi.fn(),
59+
refreshEntries: vi.fn(),
5960
readFile: vi.fn(),
6061
searchEntries: vi.fn(),
6162
writeFile: vi.fn(),

‎packages/client-runtime/src/wsRpcClient.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export interface WsRpcClient {
9797
};
9898
readonlyprojects: {
9999
readonlylistEntries: RpcUnaryMethod<typeofWS_METHODS.projectsListEntries>;
100+
readonlyrefreshEntries: RpcUnaryMethod<typeofWS_METHODS.projectsRefreshEntries>;
100101
readonlyreadFile: RpcUnaryMethod<typeofWS_METHODS.projectsReadFile>;
101102
readonlysearchEntries: RpcUnaryMethod<typeofWS_METHODS.projectsSearchEntries>;
102103
readonlywriteFile: RpcUnaryMethod<typeofWS_METHODS.projectsWriteFile>;
@@ -271,6 +272,8 @@ export function createWsRpcClient(
271272
projects: {
272273
listEntries: (input)=>
273274
transport.request((client)=>client[WS_METHODS.projectsListEntries](input)),
275+
refreshEntries: (input)=>
276+
transport.request((client)=>client[WS_METHODS.projectsRefreshEntries](input)),
274277
readFile: (input)=>
275278
transport.request((client)=>client[WS_METHODS.projectsReadFile](input)),
276279
searchEntries: (input)=>

‎packages/contracts/src/ipc.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,6 +1115,7 @@ export interface EnvironmentApi {
11151115
};
11161116
projects: {
11171117
listEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
1118+
refreshEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
11181119
readFile: (input: ProjectReadFileInput)=>Promise<ProjectReadFileResult>;
11191120
searchEntries: (input: ProjectSearchEntriesInput)=>Promise<ProjectSearchEntriesResult>;
11201121
writeFile: (input: ProjectWriteFileInput)=>Promise<ProjectWriteFileResult>;

‎packages/contracts/src/rpc.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ export const WS_METHODS = {
148148
projectsAdd: "projects.add",
149149
projectsRemove: "projects.remove",
150150
projectsListEntries: "projects.listEntries",
151+
projectsRefreshEntries: "projects.refreshEntries",
151152
projectsReadFile: "projects.readFile",
152153
projectsSearchEntries: "projects.searchEntries",
153154
projectsWriteFile: "projects.writeFile",
@@ -364,6 +365,12 @@ export const WsProjectsListEntriesRpc = Rpc.make(WS_METHODS.projectsListEntries,
364365
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
365366
});
366367

368+
exportconstWsProjectsRefreshEntriesRpc=Rpc.make(WS_METHODS.projectsRefreshEntries,{
369+
payload: ProjectListEntriesInput,
370+
success: ProjectListEntriesResult,
371+
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
372+
});
373+
367374
exportconstWsProjectsReadFileRpc=Rpc.make(WS_METHODS.projectsReadFile,{
368375
payload: ProjectReadFileInput,
369376
success: ProjectReadFileResult,
@@ -697,6 +704,7 @@ export const WsRpcGroup = RpcGroup.make(
697704
WsSourceControlCloneRepositoryRpc,
698705
WsSourceControlPublishRepositoryRpc,
699706
WsProjectsListEntriesRpc,
707+
WsProjectsRefreshEntriesRpc,
700708
WsProjectsReadFileRpc,
701709
WsProjectsSearchEntriesRpc,
702710
WsProjectsWriteFileRpc,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 409a118

Browse files
committed
Fix: clear maximized state on last surface close, add cache-invalidating refresh RPC, probe truncated files for binary content
- ChatView: clear maximizedRightPanelThreadKey when closeRightPanelSurface leaves no active surface, preventing the chat column from staying at w-0 after the last right-panel tab is closed. - Add projects.refreshEntries RPC that invalidates the workspace index cache before listing, so the explicit refresh button in FileBrowserPanel returns up-to-date filesystem state instead of stale cached data. - WorkspaceFileSystem.readFile: when a file is truncated (>1 MB), read an additional 8 KB probe from the end of the file and check for NUL bytes, catching binary files whose first null appears beyond the preview window.
1 parent e18504c commit 409a118

10 files changed

Lines changed: 85 additions & 30 deletions

File tree

‎apps/server/src/workspace/Layers/WorkspaceFileSystem.ts‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,20 @@ export const makeWorkspaceFileSystem = Effect.gen(function* () {
5757
if(fileBytes.includes(0)){
5858
thrownewError("Binary files cannot be previewed as text.");
5959
}
60+
if(stat.size>PROJECT_READ_FILE_MAX_BYTES){
61+
constprobeSize=8192;
62+
constprobeOffset=Math.max(bytesToRead,stat.size-probeSize);
63+
constprobeBuf=Buffer.alloc(Math.min(probeSize,stat.size-probeOffset));
64+
const{bytesRead: probeRead}=awaithandle.read(
65+
probeBuf,
66+
0,
67+
probeBuf.length,
68+
probeOffset,
69+
);
70+
if(probeBuf.subarray(0,probeRead).includes(0)){
71+
thrownewError("Binary files cannot be previewed as text.");
72+
}
73+
}
6074
constcontents=newTextDecoder("utf-8").decode(fileBytes);
6175
return{
6276
relativePath: target.relativePath,

‎apps/server/src/ws.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ const RPC_REQUIRED_SCOPE = new Map<string, AuthEnvironmentScope>([
163163
[WS_METHODS.sourceControlCloneRepository,AuthOrchestrationOperateScope],
164164
[WS_METHODS.sourceControlPublishRepository,AuthOrchestrationOperateScope],
165165
[WS_METHODS.projectsListEntries,AuthOrchestrationReadScope],
166+
[WS_METHODS.projectsRefreshEntries,AuthOrchestrationReadScope],
166167
[WS_METHODS.projectsReadFile,AuthOrchestrationReadScope],
167168
[WS_METHODS.projectsSearchEntries,AuthOrchestrationReadScope],
168169
[WS_METHODS.projectsWriteFile,AuthOrchestrationOperateScope],
@@ -1190,6 +1191,21 @@ const makeWsRpcLayer = (currentSession: AuthenticatedSession) =>
11901191
),
11911192
{"rpc.aggregate": "workspace"},
11921193
),
1194+
[WS_METHODS.projectsRefreshEntries]: (input)=>
1195+
observeRpcEffect(
1196+
WS_METHODS.projectsRefreshEntries,
1197+
workspaceEntries.invalidate(input.cwd).pipe(
1198+
Effect.andThen(()=>workspaceEntries.list(input)),
1199+
Effect.mapError(
1200+
(cause)=>
1201+
newProjectListEntriesError({
1202+
message: `Failed to refresh workspace entries: ${cause.detail}`,
1203+
cause,
1204+
}),
1205+
),
1206+
),
1207+
{"rpc.aggregate": "workspace"},
1208+
),
11931209
[WS_METHODS.projectsReadFile]: (input)=>
11941210
observeRpcEffect(
11951211
WS_METHODS.projectsReadFile,

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3067,6 +3067,9 @@ export default function ChatView(props: ChatViewProps) {
30673067
useRightPanelStore.getState().byThreadKey,
30683068
activeThreadRef,
30693069
);
3070+
if(!nextActiveSurface){
3071+
setMaximizedRightPanelThreadKey(null);
3072+
}
30703073
if(nextActiveSurface?.kind==="preview"&&nextActiveSurface.resourceId){
30713074
usePreviewStateStore.getState().setActiveTab(activeThreadRef,nextActiveSurface.resourceId);
30723075
}

‎apps/web/src/components/files/FileBrowserPanel.tsx‎

Lines changed: 37 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,44 @@ export default function FileBrowserPanel({
6262
unsafeCSS: TREE_UNSAFE_CSS,
6363
});
6464

65-
constloadEntries=useCallback(()=>{
66-
constapi=readEnvironmentApi(environmentId);
67-
requestGenerationRef.current+=1;
68-
constgeneration=requestGenerationRef.current;
69-
setIsLoadingEntries(true);
70-
setEntriesError(null);
71-
72-
if(!api){
73-
setEntriesError("Environment is not connected.");
74-
setIsLoadingEntries(false);
75-
return;
76-
}
65+
constloadEntries=useCallback(
66+
(options?: {refresh?: boolean})=>{
67+
constapi=readEnvironmentApi(environmentId);
68+
requestGenerationRef.current+=1;
69+
constgeneration=requestGenerationRef.current;
70+
setIsLoadingEntries(true);
71+
setEntriesError(null);
7772

78-
voidapi.projects.listEntries({ cwd }).then(
79-
(result)=>{
80-
if(generation!==requestGenerationRef.current)return;
81-
entryKindsRef.current=newMap(
82-
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
83-
);
84-
setEntries(result.entries);
85-
setIsTruncated(result.truncated);
86-
model.resetPaths(result.entries.map(treePath));
73+
if(!api){
74+
setEntriesError("Environment is not connected.");
8775
setIsLoadingEntries(false);
88-
},
89-
(error: unknown)=>{
90-
if(generation!==requestGenerationRef.current)return;
91-
setEntriesError(errorinstanceofError ? error.message : String(error));
92-
setIsLoadingEntries(false);
93-
},
94-
);
95-
},[cwd,environmentId,model]);
76+
return;
77+
}
78+
79+
constrequest=options?.refresh
80+
? api.projects.refreshEntries({ cwd })
81+
: api.projects.listEntries({ cwd });
82+
83+
voidrequest.then(
84+
(result)=>{
85+
if(generation!==requestGenerationRef.current)return;
86+
entryKindsRef.current=newMap(
87+
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
88+
);
89+
setEntries(result.entries);
90+
setIsTruncated(result.truncated);
91+
model.resetPaths(result.entries.map(treePath));
92+
setIsLoadingEntries(false);
93+
},
94+
(error: unknown)=>{
95+
if(generation!==requestGenerationRef.current)return;
96+
setEntriesError(errorinstanceofError ? error.message : String(error));
97+
setIsLoadingEntries(false);
98+
},
99+
);
100+
},
101+
[cwd,environmentId,model],
102+
);
96103

97104
useEffect(()=>{
98105
loadEntries();
@@ -128,7 +135,7 @@ export default function FileBrowserPanel({
128135
type="button"
129136
className="rounded-md p-1.5 text-muted-foreground hover:bg-accent hover:text-foreground"
130137
aria-label="Refresh workspace files"
131-
onClick={loadEntries}
138+
onClick={()=>loadEntries({refresh: true})}
132139
>
133140
<RefreshCwclassName={cn("size-3.5",isLoadingEntries&&"animate-spin")}/>
134141
</button>

‎apps/web/src/environmentApi.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export function createEnvironmentApi(rpcClient: WsRpcClient): EnvironmentApi {
2020
},
2121
projects: {
2222
listEntries: rpcClient.projects.listEntries,
23+
refreshEntries: rpcClient.projects.refreshEntries,
2324
readFile: rpcClient.projects.readFile,
2425
searchEntries: rpcClient.projects.searchEntries,
2526
writeFile: rpcClient.projects.writeFile,

‎apps/web/src/environments/runtime/service.threadSubscriptions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ vi.mock("@t3tools/client-runtime", async (importOriginal) => {
122122
},
123123
projects: {
124124
listEntries: vi.fn(),
125+
refreshEntries: vi.fn(),
125126
readFile: vi.fn(),
126127
searchEntries: vi.fn(),
127128
writeFile: vi.fn(),

‎apps/web/src/localApi.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const rpcClientMock = {
5656
},
5757
projects: {
5858
listEntries: vi.fn(),
59+
refreshEntries: vi.fn(),
5960
readFile: vi.fn(),
6061
searchEntries: vi.fn(),
6162
writeFile: vi.fn(),

‎packages/client-runtime/src/wsRpcClient.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export interface WsRpcClient {
9797
};
9898
readonlyprojects: {
9999
readonlylistEntries: RpcUnaryMethod<typeofWS_METHODS.projectsListEntries>;
100+
readonlyrefreshEntries: RpcUnaryMethod<typeofWS_METHODS.projectsRefreshEntries>;
100101
readonlyreadFile: RpcUnaryMethod<typeofWS_METHODS.projectsReadFile>;
101102
readonlysearchEntries: RpcUnaryMethod<typeofWS_METHODS.projectsSearchEntries>;
102103
readonlywriteFile: RpcUnaryMethod<typeofWS_METHODS.projectsWriteFile>;
@@ -271,6 +272,8 @@ export function createWsRpcClient(
271272
projects: {
272273
listEntries: (input)=>
273274
transport.request((client)=>client[WS_METHODS.projectsListEntries](input)),
275+
refreshEntries: (input)=>
276+
transport.request((client)=>client[WS_METHODS.projectsRefreshEntries](input)),
274277
readFile: (input)=>
275278
transport.request((client)=>client[WS_METHODS.projectsReadFile](input)),
276279
searchEntries: (input)=>

‎packages/contracts/src/ipc.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,6 +1115,7 @@ export interface EnvironmentApi {
11151115
};
11161116
projects: {
11171117
listEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
1118+
refreshEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
11181119
readFile: (input: ProjectReadFileInput)=>Promise<ProjectReadFileResult>;
11191120
searchEntries: (input: ProjectSearchEntriesInput)=>Promise<ProjectSearchEntriesResult>;
11201121
writeFile: (input: ProjectWriteFileInput)=>Promise<ProjectWriteFileResult>;

‎packages/contracts/src/rpc.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ export const WS_METHODS = {
148148
projectsAdd: "projects.add",
149149
projectsRemove: "projects.remove",
150150
projectsListEntries: "projects.listEntries",
151+
projectsRefreshEntries: "projects.refreshEntries",
151152
projectsReadFile: "projects.readFile",
152153
projectsSearchEntries: "projects.searchEntries",
153154
projectsWriteFile: "projects.writeFile",
@@ -364,6 +365,12 @@ export const WsProjectsListEntriesRpc = Rpc.make(WS_METHODS.projectsListEntries,
364365
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
365366
});
366367

368+
exportconstWsProjectsRefreshEntriesRpc=Rpc.make(WS_METHODS.projectsRefreshEntries,{
369+
payload: ProjectListEntriesInput,
370+
success: ProjectListEntriesResult,
371+
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
372+
});
373+
367374
exportconstWsProjectsReadFileRpc=Rpc.make(WS_METHODS.projectsReadFile,{
368375
payload: ProjectReadFileInput,
369376
success: ProjectReadFileResult,
@@ -697,6 +704,7 @@ export const WsRpcGroup = RpcGroup.make(
697704
WsSourceControlCloneRepositoryRpc,
698705
WsSourceControlPublishRepositoryRpc,
699706
WsProjectsListEntriesRpc,
707+
WsProjectsRefreshEntriesRpc,
700708
WsProjectsReadFileRpc,
701709
WsProjectsSearchEntriesRpc,
702710
WsProjectsWriteFileRpc,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 409a118

Browse files
committed
Fix: clear maximized state on last surface close, add cache-invalidating refresh RPC, probe truncated files for binary content
- ChatView: clear maximizedRightPanelThreadKey when closeRightPanelSurface leaves no active surface, preventing the chat column from staying at w-0 after the last right-panel tab is closed. - Add projects.refreshEntries RPC that invalidates the workspace index cache before listing, so the explicit refresh button in FileBrowserPanel returns up-to-date filesystem state instead of stale cached data. - WorkspaceFileSystem.readFile: when a file is truncated (>1 MB), read an additional 8 KB probe from the end of the file and check for NUL bytes, catching binary files whose first null appears beyond the preview window.
1 parent e18504c commit 409a118

10 files changed

Lines changed: 85 additions & 30 deletions

File tree

‎apps/server/src/workspace/Layers/WorkspaceFileSystem.ts‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,20 @@ export const makeWorkspaceFileSystem = Effect.gen(function* () {
5757
if(fileBytes.includes(0)){
5858
thrownewError("Binary files cannot be previewed as text.");
5959
}
60+
if(stat.size>PROJECT_READ_FILE_MAX_BYTES){
61+
constprobeSize=8192;
62+
constprobeOffset=Math.max(bytesToRead,stat.size-probeSize);
63+
constprobeBuf=Buffer.alloc(Math.min(probeSize,stat.size-probeOffset));
64+
const{bytesRead: probeRead}=awaithandle.read(
65+
probeBuf,
66+
0,
67+
probeBuf.length,
68+
probeOffset,
69+
);
70+
if(probeBuf.subarray(0,probeRead).includes(0)){
71+
thrownewError("Binary files cannot be previewed as text.");
72+
}
73+
}
6074
constcontents=newTextDecoder("utf-8").decode(fileBytes);
6175
return{
6276
relativePath: target.relativePath,

‎apps/server/src/ws.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ const RPC_REQUIRED_SCOPE = new Map<string, AuthEnvironmentScope>([
163163
[WS_METHODS.sourceControlCloneRepository,AuthOrchestrationOperateScope],
164164
[WS_METHODS.sourceControlPublishRepository,AuthOrchestrationOperateScope],
165165
[WS_METHODS.projectsListEntries,AuthOrchestrationReadScope],
166+
[WS_METHODS.projectsRefreshEntries,AuthOrchestrationReadScope],
166167
[WS_METHODS.projectsReadFile,AuthOrchestrationReadScope],
167168
[WS_METHODS.projectsSearchEntries,AuthOrchestrationReadScope],
168169
[WS_METHODS.projectsWriteFile,AuthOrchestrationOperateScope],
@@ -1190,6 +1191,21 @@ const makeWsRpcLayer = (currentSession: AuthenticatedSession) =>
11901191
),
11911192
{"rpc.aggregate": "workspace"},
11921193
),
1194+
[WS_METHODS.projectsRefreshEntries]: (input)=>
1195+
observeRpcEffect(
1196+
WS_METHODS.projectsRefreshEntries,
1197+
workspaceEntries.invalidate(input.cwd).pipe(
1198+
Effect.andThen(()=>workspaceEntries.list(input)),
1199+
Effect.mapError(
1200+
(cause)=>
1201+
newProjectListEntriesError({
1202+
message: `Failed to refresh workspace entries: ${cause.detail}`,
1203+
cause,
1204+
}),
1205+
),
1206+
),
1207+
{"rpc.aggregate": "workspace"},
1208+
),
11931209
[WS_METHODS.projectsReadFile]: (input)=>
11941210
observeRpcEffect(
11951211
WS_METHODS.projectsReadFile,

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3067,6 +3067,9 @@ export default function ChatView(props: ChatViewProps) {
30673067
useRightPanelStore.getState().byThreadKey,
30683068
activeThreadRef,
30693069
);
3070+
if(!nextActiveSurface){
3071+
setMaximizedRightPanelThreadKey(null);
3072+
}
30703073
if(nextActiveSurface?.kind==="preview"&&nextActiveSurface.resourceId){
30713074
usePreviewStateStore.getState().setActiveTab(activeThreadRef,nextActiveSurface.resourceId);
30723075
}

‎apps/web/src/components/files/FileBrowserPanel.tsx‎

Lines changed: 37 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,44 @@ export default function FileBrowserPanel({
6262
unsafeCSS: TREE_UNSAFE_CSS,
6363
});
6464

65-
constloadEntries=useCallback(()=>{
66-
constapi=readEnvironmentApi(environmentId);
67-
requestGenerationRef.current+=1;
68-
constgeneration=requestGenerationRef.current;
69-
setIsLoadingEntries(true);
70-
setEntriesError(null);
71-
72-
if(!api){
73-
setEntriesError("Environment is not connected.");
74-
setIsLoadingEntries(false);
75-
return;
76-
}
65+
constloadEntries=useCallback(
66+
(options?: {refresh?: boolean})=>{
67+
constapi=readEnvironmentApi(environmentId);
68+
requestGenerationRef.current+=1;
69+
constgeneration=requestGenerationRef.current;
70+
setIsLoadingEntries(true);
71+
setEntriesError(null);
7772

78-
voidapi.projects.listEntries({ cwd }).then(
79-
(result)=>{
80-
if(generation!==requestGenerationRef.current)return;
81-
entryKindsRef.current=newMap(
82-
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
83-
);
84-
setEntries(result.entries);
85-
setIsTruncated(result.truncated);
86-
model.resetPaths(result.entries.map(treePath));
73+
if(!api){
74+
setEntriesError("Environment is not connected.");
8775
setIsLoadingEntries(false);
88-
},
89-
(error: unknown)=>{
90-
if(generation!==requestGenerationRef.current)return;
91-
setEntriesError(errorinstanceofError ? error.message : String(error));
92-
setIsLoadingEntries(false);
93-
},
94-
);
95-
},[cwd,environmentId,model]);
76+
return;
77+
}
78+
79+
constrequest=options?.refresh
80+
? api.projects.refreshEntries({ cwd })
81+
: api.projects.listEntries({ cwd });
82+
83+
voidrequest.then(
84+
(result)=>{
85+
if(generation!==requestGenerationRef.current)return;
86+
entryKindsRef.current=newMap(
87+
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
88+
);
89+
setEntries(result.entries);
90+
setIsTruncated(result.truncated);
91+
model.resetPaths(result.entries.map(treePath));
92+
setIsLoadingEntries(false);
93+
},
94+
(error: unknown)=>{
95+
if(generation!==requestGenerationRef.current)return;
96+
setEntriesError(errorinstanceofError ? error.message : String(error));
97+
setIsLoadingEntries(false);
98+
},
99+
);
100+
},
101+
[cwd,environmentId,model],
102+
);
96103

97104
useEffect(()=>{
98105
loadEntries();
@@ -128,7 +135,7 @@ export default function FileBrowserPanel({
128135
type="button"
129136
className="rounded-md p-1.5 text-muted-foreground hover:bg-accent hover:text-foreground"
130137
aria-label="Refresh workspace files"
131-
onClick={loadEntries}
138+
onClick={()=>loadEntries({refresh: true})}
132139
>
133140
<RefreshCwclassName={cn("size-3.5",isLoadingEntries&&"animate-spin")}/>
134141
</button>

‎apps/web/src/environmentApi.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export function createEnvironmentApi(rpcClient: WsRpcClient): EnvironmentApi {
2020
},
2121
projects: {
2222
listEntries: rpcClient.projects.listEntries,
23+
refreshEntries: rpcClient.projects.refreshEntries,
2324
readFile: rpcClient.projects.readFile,
2425
searchEntries: rpcClient.projects.searchEntries,
2526
writeFile: rpcClient.projects.writeFile,

‎apps/web/src/environments/runtime/service.threadSubscriptions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ vi.mock("@t3tools/client-runtime", async (importOriginal) => {
122122
},
123123
projects: {
124124
listEntries: vi.fn(),
125+
refreshEntries: vi.fn(),
125126
readFile: vi.fn(),
126127
searchEntries: vi.fn(),
127128
writeFile: vi.fn(),

‎apps/web/src/localApi.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const rpcClientMock = {
5656
},
5757
projects: {
5858
listEntries: vi.fn(),
59+
refreshEntries: vi.fn(),
5960
readFile: vi.fn(),
6061
searchEntries: vi.fn(),
6162
writeFile: vi.fn(),

‎packages/client-runtime/src/wsRpcClient.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export interface WsRpcClient {
9797
};
9898
readonlyprojects: {
9999
readonlylistEntries: RpcUnaryMethod<typeofWS_METHODS.projectsListEntries>;
100+
readonlyrefreshEntries: RpcUnaryMethod<typeofWS_METHODS.projectsRefreshEntries>;
100101
readonlyreadFile: RpcUnaryMethod<typeofWS_METHODS.projectsReadFile>;
101102
readonlysearchEntries: RpcUnaryMethod<typeofWS_METHODS.projectsSearchEntries>;
102103
readonlywriteFile: RpcUnaryMethod<typeofWS_METHODS.projectsWriteFile>;
@@ -271,6 +272,8 @@ export function createWsRpcClient(
271272
projects: {
272273
listEntries: (input)=>
273274
transport.request((client)=>client[WS_METHODS.projectsListEntries](input)),
275+
refreshEntries: (input)=>
276+
transport.request((client)=>client[WS_METHODS.projectsRefreshEntries](input)),
274277
readFile: (input)=>
275278
transport.request((client)=>client[WS_METHODS.projectsReadFile](input)),
276279
searchEntries: (input)=>

‎packages/contracts/src/ipc.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,6 +1115,7 @@ export interface EnvironmentApi {
11151115
};
11161116
projects: {
11171117
listEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
1118+
refreshEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
11181119
readFile: (input: ProjectReadFileInput)=>Promise<ProjectReadFileResult>;
11191120
searchEntries: (input: ProjectSearchEntriesInput)=>Promise<ProjectSearchEntriesResult>;
11201121
writeFile: (input: ProjectWriteFileInput)=>Promise<ProjectWriteFileResult>;

‎packages/contracts/src/rpc.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ export const WS_METHODS = {
148148
projectsAdd: "projects.add",
149149
projectsRemove: "projects.remove",
150150
projectsListEntries: "projects.listEntries",
151+
projectsRefreshEntries: "projects.refreshEntries",
151152
projectsReadFile: "projects.readFile",
152153
projectsSearchEntries: "projects.searchEntries",
153154
projectsWriteFile: "projects.writeFile",
@@ -364,6 +365,12 @@ export const WsProjectsListEntriesRpc = Rpc.make(WS_METHODS.projectsListEntries,
364365
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
365366
});
366367

368+
exportconstWsProjectsRefreshEntriesRpc=Rpc.make(WS_METHODS.projectsRefreshEntries,{
369+
payload: ProjectListEntriesInput,
370+
success: ProjectListEntriesResult,
371+
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
372+
});
373+
367374
exportconstWsProjectsReadFileRpc=Rpc.make(WS_METHODS.projectsReadFile,{
368375
payload: ProjectReadFileInput,
369376
success: ProjectReadFileResult,
@@ -697,6 +704,7 @@ export const WsRpcGroup = RpcGroup.make(
697704
WsSourceControlCloneRepositoryRpc,
698705
WsSourceControlPublishRepositoryRpc,
699706
WsProjectsListEntriesRpc,
707+
WsProjectsRefreshEntriesRpc,
700708
WsProjectsReadFileRpc,
701709
WsProjectsSearchEntriesRpc,
702710
WsProjectsWriteFileRpc,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 409a118

Browse files
committed
Fix: clear maximized state on last surface close, add cache-invalidating refresh RPC, probe truncated files for binary content
- ChatView: clear maximizedRightPanelThreadKey when closeRightPanelSurface leaves no active surface, preventing the chat column from staying at w-0 after the last right-panel tab is closed. - Add projects.refreshEntries RPC that invalidates the workspace index cache before listing, so the explicit refresh button in FileBrowserPanel returns up-to-date filesystem state instead of stale cached data. - WorkspaceFileSystem.readFile: when a file is truncated (>1 MB), read an additional 8 KB probe from the end of the file and check for NUL bytes, catching binary files whose first null appears beyond the preview window.
1 parent e18504c commit 409a118

10 files changed

Lines changed: 85 additions & 30 deletions

File tree

‎apps/server/src/workspace/Layers/WorkspaceFileSystem.ts‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,20 @@ export const makeWorkspaceFileSystem = Effect.gen(function* () {
5757
if(fileBytes.includes(0)){
5858
thrownewError("Binary files cannot be previewed as text.");
5959
}
60+
if(stat.size>PROJECT_READ_FILE_MAX_BYTES){
61+
constprobeSize=8192;
62+
constprobeOffset=Math.max(bytesToRead,stat.size-probeSize);
63+
constprobeBuf=Buffer.alloc(Math.min(probeSize,stat.size-probeOffset));
64+
const{bytesRead: probeRead}=awaithandle.read(
65+
probeBuf,
66+
0,
67+
probeBuf.length,
68+
probeOffset,
69+
);
70+
if(probeBuf.subarray(0,probeRead).includes(0)){
71+
thrownewError("Binary files cannot be previewed as text.");
72+
}
73+
}
6074
constcontents=newTextDecoder("utf-8").decode(fileBytes);
6175
return{
6276
relativePath: target.relativePath,

‎apps/server/src/ws.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ const RPC_REQUIRED_SCOPE = new Map<string, AuthEnvironmentScope>([
163163
[WS_METHODS.sourceControlCloneRepository,AuthOrchestrationOperateScope],
164164
[WS_METHODS.sourceControlPublishRepository,AuthOrchestrationOperateScope],
165165
[WS_METHODS.projectsListEntries,AuthOrchestrationReadScope],
166+
[WS_METHODS.projectsRefreshEntries,AuthOrchestrationReadScope],
166167
[WS_METHODS.projectsReadFile,AuthOrchestrationReadScope],
167168
[WS_METHODS.projectsSearchEntries,AuthOrchestrationReadScope],
168169
[WS_METHODS.projectsWriteFile,AuthOrchestrationOperateScope],
@@ -1190,6 +1191,21 @@ const makeWsRpcLayer = (currentSession: AuthenticatedSession) =>
11901191
),
11911192
{"rpc.aggregate": "workspace"},
11921193
),
1194+
[WS_METHODS.projectsRefreshEntries]: (input)=>
1195+
observeRpcEffect(
1196+
WS_METHODS.projectsRefreshEntries,
1197+
workspaceEntries.invalidate(input.cwd).pipe(
1198+
Effect.andThen(()=>workspaceEntries.list(input)),
1199+
Effect.mapError(
1200+
(cause)=>
1201+
newProjectListEntriesError({
1202+
message: `Failed to refresh workspace entries: ${cause.detail}`,
1203+
cause,
1204+
}),
1205+
),
1206+
),
1207+
{"rpc.aggregate": "workspace"},
1208+
),
11931209
[WS_METHODS.projectsReadFile]: (input)=>
11941210
observeRpcEffect(
11951211
WS_METHODS.projectsReadFile,

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3067,6 +3067,9 @@ export default function ChatView(props: ChatViewProps) {
30673067
useRightPanelStore.getState().byThreadKey,
30683068
activeThreadRef,
30693069
);
3070+
if(!nextActiveSurface){
3071+
setMaximizedRightPanelThreadKey(null);
3072+
}
30703073
if(nextActiveSurface?.kind==="preview"&&nextActiveSurface.resourceId){
30713074
usePreviewStateStore.getState().setActiveTab(activeThreadRef,nextActiveSurface.resourceId);
30723075
}

‎apps/web/src/components/files/FileBrowserPanel.tsx‎

Lines changed: 37 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,44 @@ export default function FileBrowserPanel({
6262
unsafeCSS: TREE_UNSAFE_CSS,
6363
});
6464

65-
constloadEntries=useCallback(()=>{
66-
constapi=readEnvironmentApi(environmentId);
67-
requestGenerationRef.current+=1;
68-
constgeneration=requestGenerationRef.current;
69-
setIsLoadingEntries(true);
70-
setEntriesError(null);
71-
72-
if(!api){
73-
setEntriesError("Environment is not connected.");
74-
setIsLoadingEntries(false);
75-
return;
76-
}
65+
constloadEntries=useCallback(
66+
(options?: {refresh?: boolean})=>{
67+
constapi=readEnvironmentApi(environmentId);
68+
requestGenerationRef.current+=1;
69+
constgeneration=requestGenerationRef.current;
70+
setIsLoadingEntries(true);
71+
setEntriesError(null);
7772

78-
voidapi.projects.listEntries({ cwd }).then(
79-
(result)=>{
80-
if(generation!==requestGenerationRef.current)return;
81-
entryKindsRef.current=newMap(
82-
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
83-
);
84-
setEntries(result.entries);
85-
setIsTruncated(result.truncated);
86-
model.resetPaths(result.entries.map(treePath));
73+
if(!api){
74+
setEntriesError("Environment is not connected.");
8775
setIsLoadingEntries(false);
88-
},
89-
(error: unknown)=>{
90-
if(generation!==requestGenerationRef.current)return;
91-
setEntriesError(errorinstanceofError ? error.message : String(error));
92-
setIsLoadingEntries(false);
93-
},
94-
);
95-
},[cwd,environmentId,model]);
76+
return;
77+
}
78+
79+
constrequest=options?.refresh
80+
? api.projects.refreshEntries({ cwd })
81+
: api.projects.listEntries({ cwd });
82+
83+
voidrequest.then(
84+
(result)=>{
85+
if(generation!==requestGenerationRef.current)return;
86+
entryKindsRef.current=newMap(
87+
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
88+
);
89+
setEntries(result.entries);
90+
setIsTruncated(result.truncated);
91+
model.resetPaths(result.entries.map(treePath));
92+
setIsLoadingEntries(false);
93+
},
94+
(error: unknown)=>{
95+
if(generation!==requestGenerationRef.current)return;
96+
setEntriesError(errorinstanceofError ? error.message : String(error));
97+
setIsLoadingEntries(false);
98+
},
99+
);
100+
},
101+
[cwd,environmentId,model],
102+
);
96103

97104
useEffect(()=>{
98105
loadEntries();
@@ -128,7 +135,7 @@ export default function FileBrowserPanel({
128135
type="button"
129136
className="rounded-md p-1.5 text-muted-foreground hover:bg-accent hover:text-foreground"
130137
aria-label="Refresh workspace files"
131-
onClick={loadEntries}
138+
onClick={()=>loadEntries({refresh: true})}
132139
>
133140
<RefreshCwclassName={cn("size-3.5",isLoadingEntries&&"animate-spin")}/>
134141
</button>

‎apps/web/src/environmentApi.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export function createEnvironmentApi(rpcClient: WsRpcClient): EnvironmentApi {
2020
},
2121
projects: {
2222
listEntries: rpcClient.projects.listEntries,
23+
refreshEntries: rpcClient.projects.refreshEntries,
2324
readFile: rpcClient.projects.readFile,
2425
searchEntries: rpcClient.projects.searchEntries,
2526
writeFile: rpcClient.projects.writeFile,

‎apps/web/src/environments/runtime/service.threadSubscriptions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ vi.mock("@t3tools/client-runtime", async (importOriginal) => {
122122
},
123123
projects: {
124124
listEntries: vi.fn(),
125+
refreshEntries: vi.fn(),
125126
readFile: vi.fn(),
126127
searchEntries: vi.fn(),
127128
writeFile: vi.fn(),

‎apps/web/src/localApi.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const rpcClientMock = {
5656
},
5757
projects: {
5858
listEntries: vi.fn(),
59+
refreshEntries: vi.fn(),
5960
readFile: vi.fn(),
6061
searchEntries: vi.fn(),
6162
writeFile: vi.fn(),

‎packages/client-runtime/src/wsRpcClient.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export interface WsRpcClient {
9797
};
9898
readonlyprojects: {
9999
readonlylistEntries: RpcUnaryMethod<typeofWS_METHODS.projectsListEntries>;
100+
readonlyrefreshEntries: RpcUnaryMethod<typeofWS_METHODS.projectsRefreshEntries>;
100101
readonlyreadFile: RpcUnaryMethod<typeofWS_METHODS.projectsReadFile>;
101102
readonlysearchEntries: RpcUnaryMethod<typeofWS_METHODS.projectsSearchEntries>;
102103
readonlywriteFile: RpcUnaryMethod<typeofWS_METHODS.projectsWriteFile>;
@@ -271,6 +272,8 @@ export function createWsRpcClient(
271272
projects: {
272273
listEntries: (input)=>
273274
transport.request((client)=>client[WS_METHODS.projectsListEntries](input)),
275+
refreshEntries: (input)=>
276+
transport.request((client)=>client[WS_METHODS.projectsRefreshEntries](input)),
274277
readFile: (input)=>
275278
transport.request((client)=>client[WS_METHODS.projectsReadFile](input)),
276279
searchEntries: (input)=>

‎packages/contracts/src/ipc.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,6 +1115,7 @@ export interface EnvironmentApi {
11151115
};
11161116
projects: {
11171117
listEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
1118+
refreshEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
11181119
readFile: (input: ProjectReadFileInput)=>Promise<ProjectReadFileResult>;
11191120
searchEntries: (input: ProjectSearchEntriesInput)=>Promise<ProjectSearchEntriesResult>;
11201121
writeFile: (input: ProjectWriteFileInput)=>Promise<ProjectWriteFileResult>;

‎packages/contracts/src/rpc.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ export const WS_METHODS = {
148148
projectsAdd: "projects.add",
149149
projectsRemove: "projects.remove",
150150
projectsListEntries: "projects.listEntries",
151+
projectsRefreshEntries: "projects.refreshEntries",
151152
projectsReadFile: "projects.readFile",
152153
projectsSearchEntries: "projects.searchEntries",
153154
projectsWriteFile: "projects.writeFile",
@@ -364,6 +365,12 @@ export const WsProjectsListEntriesRpc = Rpc.make(WS_METHODS.projectsListEntries,
364365
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
365366
});
366367

368+
exportconstWsProjectsRefreshEntriesRpc=Rpc.make(WS_METHODS.projectsRefreshEntries,{
369+
payload: ProjectListEntriesInput,
370+
success: ProjectListEntriesResult,
371+
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
372+
});
373+
367374
exportconstWsProjectsReadFileRpc=Rpc.make(WS_METHODS.projectsReadFile,{
368375
payload: ProjectReadFileInput,
369376
success: ProjectReadFileResult,
@@ -697,6 +704,7 @@ export const WsRpcGroup = RpcGroup.make(
697704
WsSourceControlCloneRepositoryRpc,
698705
WsSourceControlPublishRepositoryRpc,
699706
WsProjectsListEntriesRpc,
707+
WsProjectsRefreshEntriesRpc,
700708
WsProjectsReadFileRpc,
701709
WsProjectsSearchEntriesRpc,
702710
WsProjectsWriteFileRpc,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 409a118

Browse files
committed
Fix: clear maximized state on last surface close, add cache-invalidating refresh RPC, probe truncated files for binary content
- ChatView: clear maximizedRightPanelThreadKey when closeRightPanelSurface leaves no active surface, preventing the chat column from staying at w-0 after the last right-panel tab is closed. - Add projects.refreshEntries RPC that invalidates the workspace index cache before listing, so the explicit refresh button in FileBrowserPanel returns up-to-date filesystem state instead of stale cached data. - WorkspaceFileSystem.readFile: when a file is truncated (>1 MB), read an additional 8 KB probe from the end of the file and check for NUL bytes, catching binary files whose first null appears beyond the preview window.
1 parent e18504c commit 409a118

10 files changed

Lines changed: 85 additions & 30 deletions

File tree

‎apps/server/src/workspace/Layers/WorkspaceFileSystem.ts‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,20 @@ export const makeWorkspaceFileSystem = Effect.gen(function* () {
5757
if(fileBytes.includes(0)){
5858
thrownewError("Binary files cannot be previewed as text.");
5959
}
60+
if(stat.size>PROJECT_READ_FILE_MAX_BYTES){
61+
constprobeSize=8192;
62+
constprobeOffset=Math.max(bytesToRead,stat.size-probeSize);
63+
constprobeBuf=Buffer.alloc(Math.min(probeSize,stat.size-probeOffset));
64+
const{bytesRead: probeRead}=awaithandle.read(
65+
probeBuf,
66+
0,
67+
probeBuf.length,
68+
probeOffset,
69+
);
70+
if(probeBuf.subarray(0,probeRead).includes(0)){
71+
thrownewError("Binary files cannot be previewed as text.");
72+
}
73+
}
6074
constcontents=newTextDecoder("utf-8").decode(fileBytes);
6175
return{
6276
relativePath: target.relativePath,

‎apps/server/src/ws.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ const RPC_REQUIRED_SCOPE = new Map<string, AuthEnvironmentScope>([
163163
[WS_METHODS.sourceControlCloneRepository,AuthOrchestrationOperateScope],
164164
[WS_METHODS.sourceControlPublishRepository,AuthOrchestrationOperateScope],
165165
[WS_METHODS.projectsListEntries,AuthOrchestrationReadScope],
166+
[WS_METHODS.projectsRefreshEntries,AuthOrchestrationReadScope],
166167
[WS_METHODS.projectsReadFile,AuthOrchestrationReadScope],
167168
[WS_METHODS.projectsSearchEntries,AuthOrchestrationReadScope],
168169
[WS_METHODS.projectsWriteFile,AuthOrchestrationOperateScope],
@@ -1190,6 +1191,21 @@ const makeWsRpcLayer = (currentSession: AuthenticatedSession) =>
11901191
),
11911192
{"rpc.aggregate": "workspace"},
11921193
),
1194+
[WS_METHODS.projectsRefreshEntries]: (input)=>
1195+
observeRpcEffect(
1196+
WS_METHODS.projectsRefreshEntries,
1197+
workspaceEntries.invalidate(input.cwd).pipe(
1198+
Effect.andThen(()=>workspaceEntries.list(input)),
1199+
Effect.mapError(
1200+
(cause)=>
1201+
newProjectListEntriesError({
1202+
message: `Failed to refresh workspace entries: ${cause.detail}`,
1203+
cause,
1204+
}),
1205+
),
1206+
),
1207+
{"rpc.aggregate": "workspace"},
1208+
),
11931209
[WS_METHODS.projectsReadFile]: (input)=>
11941210
observeRpcEffect(
11951211
WS_METHODS.projectsReadFile,

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3067,6 +3067,9 @@ export default function ChatView(props: ChatViewProps) {
30673067
useRightPanelStore.getState().byThreadKey,
30683068
activeThreadRef,
30693069
);
3070+
if(!nextActiveSurface){
3071+
setMaximizedRightPanelThreadKey(null);
3072+
}
30703073
if(nextActiveSurface?.kind==="preview"&&nextActiveSurface.resourceId){
30713074
usePreviewStateStore.getState().setActiveTab(activeThreadRef,nextActiveSurface.resourceId);
30723075
}

‎apps/web/src/components/files/FileBrowserPanel.tsx‎

Lines changed: 37 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,44 @@ export default function FileBrowserPanel({
6262
unsafeCSS: TREE_UNSAFE_CSS,
6363
});
6464

65-
constloadEntries=useCallback(()=>{
66-
constapi=readEnvironmentApi(environmentId);
67-
requestGenerationRef.current+=1;
68-
constgeneration=requestGenerationRef.current;
69-
setIsLoadingEntries(true);
70-
setEntriesError(null);
71-
72-
if(!api){
73-
setEntriesError("Environment is not connected.");
74-
setIsLoadingEntries(false);
75-
return;
76-
}
65+
constloadEntries=useCallback(
66+
(options?: {refresh?: boolean})=>{
67+
constapi=readEnvironmentApi(environmentId);
68+
requestGenerationRef.current+=1;
69+
constgeneration=requestGenerationRef.current;
70+
setIsLoadingEntries(true);
71+
setEntriesError(null);
7772

78-
voidapi.projects.listEntries({ cwd }).then(
79-
(result)=>{
80-
if(generation!==requestGenerationRef.current)return;
81-
entryKindsRef.current=newMap(
82-
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
83-
);
84-
setEntries(result.entries);
85-
setIsTruncated(result.truncated);
86-
model.resetPaths(result.entries.map(treePath));
73+
if(!api){
74+
setEntriesError("Environment is not connected.");
8775
setIsLoadingEntries(false);
88-
},
89-
(error: unknown)=>{
90-
if(generation!==requestGenerationRef.current)return;
91-
setEntriesError(errorinstanceofError ? error.message : String(error));
92-
setIsLoadingEntries(false);
93-
},
94-
);
95-
},[cwd,environmentId,model]);
76+
return;
77+
}
78+
79+
constrequest=options?.refresh
80+
? api.projects.refreshEntries({ cwd })
81+
: api.projects.listEntries({ cwd });
82+
83+
voidrequest.then(
84+
(result)=>{
85+
if(generation!==requestGenerationRef.current)return;
86+
entryKindsRef.current=newMap(
87+
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
88+
);
89+
setEntries(result.entries);
90+
setIsTruncated(result.truncated);
91+
model.resetPaths(result.entries.map(treePath));
92+
setIsLoadingEntries(false);
93+
},
94+
(error: unknown)=>{
95+
if(generation!==requestGenerationRef.current)return;
96+
setEntriesError(errorinstanceofError ? error.message : String(error));
97+
setIsLoadingEntries(false);
98+
},
99+
);
100+
},
101+
[cwd,environmentId,model],
102+
);
96103

97104
useEffect(()=>{
98105
loadEntries();
@@ -128,7 +135,7 @@ export default function FileBrowserPanel({
128135
type="button"
129136
className="rounded-md p-1.5 text-muted-foreground hover:bg-accent hover:text-foreground"
130137
aria-label="Refresh workspace files"
131-
onClick={loadEntries}
138+
onClick={()=>loadEntries({refresh: true})}
132139
>
133140
<RefreshCwclassName={cn("size-3.5",isLoadingEntries&&"animate-spin")}/>
134141
</button>

‎apps/web/src/environmentApi.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export function createEnvironmentApi(rpcClient: WsRpcClient): EnvironmentApi {
2020
},
2121
projects: {
2222
listEntries: rpcClient.projects.listEntries,
23+
refreshEntries: rpcClient.projects.refreshEntries,
2324
readFile: rpcClient.projects.readFile,
2425
searchEntries: rpcClient.projects.searchEntries,
2526
writeFile: rpcClient.projects.writeFile,

‎apps/web/src/environments/runtime/service.threadSubscriptions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ vi.mock("@t3tools/client-runtime", async (importOriginal) => {
122122
},
123123
projects: {
124124
listEntries: vi.fn(),
125+
refreshEntries: vi.fn(),
125126
readFile: vi.fn(),
126127
searchEntries: vi.fn(),
127128
writeFile: vi.fn(),

‎apps/web/src/localApi.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const rpcClientMock = {
5656
},
5757
projects: {
5858
listEntries: vi.fn(),
59+
refreshEntries: vi.fn(),
5960
readFile: vi.fn(),
6061
searchEntries: vi.fn(),
6162
writeFile: vi.fn(),

‎packages/client-runtime/src/wsRpcClient.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export interface WsRpcClient {
9797
};
9898
readonlyprojects: {
9999
readonlylistEntries: RpcUnaryMethod<typeofWS_METHODS.projectsListEntries>;
100+
readonlyrefreshEntries: RpcUnaryMethod<typeofWS_METHODS.projectsRefreshEntries>;
100101
readonlyreadFile: RpcUnaryMethod<typeofWS_METHODS.projectsReadFile>;
101102
readonlysearchEntries: RpcUnaryMethod<typeofWS_METHODS.projectsSearchEntries>;
102103
readonlywriteFile: RpcUnaryMethod<typeofWS_METHODS.projectsWriteFile>;
@@ -271,6 +272,8 @@ export function createWsRpcClient(
271272
projects: {
272273
listEntries: (input)=>
273274
transport.request((client)=>client[WS_METHODS.projectsListEntries](input)),
275+
refreshEntries: (input)=>
276+
transport.request((client)=>client[WS_METHODS.projectsRefreshEntries](input)),
274277
readFile: (input)=>
275278
transport.request((client)=>client[WS_METHODS.projectsReadFile](input)),
276279
searchEntries: (input)=>

‎packages/contracts/src/ipc.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,6 +1115,7 @@ export interface EnvironmentApi {
11151115
};
11161116
projects: {
11171117
listEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
1118+
refreshEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
11181119
readFile: (input: ProjectReadFileInput)=>Promise<ProjectReadFileResult>;
11191120
searchEntries: (input: ProjectSearchEntriesInput)=>Promise<ProjectSearchEntriesResult>;
11201121
writeFile: (input: ProjectWriteFileInput)=>Promise<ProjectWriteFileResult>;

‎packages/contracts/src/rpc.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ export const WS_METHODS = {
148148
projectsAdd: "projects.add",
149149
projectsRemove: "projects.remove",
150150
projectsListEntries: "projects.listEntries",
151+
projectsRefreshEntries: "projects.refreshEntries",
151152
projectsReadFile: "projects.readFile",
152153
projectsSearchEntries: "projects.searchEntries",
153154
projectsWriteFile: "projects.writeFile",
@@ -364,6 +365,12 @@ export const WsProjectsListEntriesRpc = Rpc.make(WS_METHODS.projectsListEntries,
364365
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
365366
});
366367

368+
exportconstWsProjectsRefreshEntriesRpc=Rpc.make(WS_METHODS.projectsRefreshEntries,{
369+
payload: ProjectListEntriesInput,
370+
success: ProjectListEntriesResult,
371+
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
372+
});
373+
367374
exportconstWsProjectsReadFileRpc=Rpc.make(WS_METHODS.projectsReadFile,{
368375
payload: ProjectReadFileInput,
369376
success: ProjectReadFileResult,
@@ -697,6 +704,7 @@ export const WsRpcGroup = RpcGroup.make(
697704
WsSourceControlCloneRepositoryRpc,
698705
WsSourceControlPublishRepositoryRpc,
699706
WsProjectsListEntriesRpc,
707+
WsProjectsRefreshEntriesRpc,
700708
WsProjectsReadFileRpc,
701709
WsProjectsSearchEntriesRpc,
702710
WsProjectsWriteFileRpc,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 409a118

Browse files
committed
Fix: clear maximized state on last surface close, add cache-invalidating refresh RPC, probe truncated files for binary content
- ChatView: clear maximizedRightPanelThreadKey when closeRightPanelSurface leaves no active surface, preventing the chat column from staying at w-0 after the last right-panel tab is closed. - Add projects.refreshEntries RPC that invalidates the workspace index cache before listing, so the explicit refresh button in FileBrowserPanel returns up-to-date filesystem state instead of stale cached data. - WorkspaceFileSystem.readFile: when a file is truncated (>1 MB), read an additional 8 KB probe from the end of the file and check for NUL bytes, catching binary files whose first null appears beyond the preview window.
1 parent e18504c commit 409a118

10 files changed

Lines changed: 85 additions & 30 deletions

File tree

‎apps/server/src/workspace/Layers/WorkspaceFileSystem.ts‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,20 @@ export const makeWorkspaceFileSystem = Effect.gen(function* () {
5757
if(fileBytes.includes(0)){
5858
thrownewError("Binary files cannot be previewed as text.");
5959
}
60+
if(stat.size>PROJECT_READ_FILE_MAX_BYTES){
61+
constprobeSize=8192;
62+
constprobeOffset=Math.max(bytesToRead,stat.size-probeSize);
63+
constprobeBuf=Buffer.alloc(Math.min(probeSize,stat.size-probeOffset));
64+
const{bytesRead: probeRead}=awaithandle.read(
65+
probeBuf,
66+
0,
67+
probeBuf.length,
68+
probeOffset,
69+
);
70+
if(probeBuf.subarray(0,probeRead).includes(0)){
71+
thrownewError("Binary files cannot be previewed as text.");
72+
}
73+
}
6074
constcontents=newTextDecoder("utf-8").decode(fileBytes);
6175
return{
6276
relativePath: target.relativePath,

‎apps/server/src/ws.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ const RPC_REQUIRED_SCOPE = new Map<string, AuthEnvironmentScope>([
163163
[WS_METHODS.sourceControlCloneRepository,AuthOrchestrationOperateScope],
164164
[WS_METHODS.sourceControlPublishRepository,AuthOrchestrationOperateScope],
165165
[WS_METHODS.projectsListEntries,AuthOrchestrationReadScope],
166+
[WS_METHODS.projectsRefreshEntries,AuthOrchestrationReadScope],
166167
[WS_METHODS.projectsReadFile,AuthOrchestrationReadScope],
167168
[WS_METHODS.projectsSearchEntries,AuthOrchestrationReadScope],
168169
[WS_METHODS.projectsWriteFile,AuthOrchestrationOperateScope],
@@ -1190,6 +1191,21 @@ const makeWsRpcLayer = (currentSession: AuthenticatedSession) =>
11901191
),
11911192
{"rpc.aggregate": "workspace"},
11921193
),
1194+
[WS_METHODS.projectsRefreshEntries]: (input)=>
1195+
observeRpcEffect(
1196+
WS_METHODS.projectsRefreshEntries,
1197+
workspaceEntries.invalidate(input.cwd).pipe(
1198+
Effect.andThen(()=>workspaceEntries.list(input)),
1199+
Effect.mapError(
1200+
(cause)=>
1201+
newProjectListEntriesError({
1202+
message: `Failed to refresh workspace entries: ${cause.detail}`,
1203+
cause,
1204+
}),
1205+
),
1206+
),
1207+
{"rpc.aggregate": "workspace"},
1208+
),
11931209
[WS_METHODS.projectsReadFile]: (input)=>
11941210
observeRpcEffect(
11951211
WS_METHODS.projectsReadFile,

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3067,6 +3067,9 @@ export default function ChatView(props: ChatViewProps) {
30673067
useRightPanelStore.getState().byThreadKey,
30683068
activeThreadRef,
30693069
);
3070+
if(!nextActiveSurface){
3071+
setMaximizedRightPanelThreadKey(null);
3072+
}
30703073
if(nextActiveSurface?.kind==="preview"&&nextActiveSurface.resourceId){
30713074
usePreviewStateStore.getState().setActiveTab(activeThreadRef,nextActiveSurface.resourceId);
30723075
}

‎apps/web/src/components/files/FileBrowserPanel.tsx‎

Lines changed: 37 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,44 @@ export default function FileBrowserPanel({
6262
unsafeCSS: TREE_UNSAFE_CSS,
6363
});
6464

65-
constloadEntries=useCallback(()=>{
66-
constapi=readEnvironmentApi(environmentId);
67-
requestGenerationRef.current+=1;
68-
constgeneration=requestGenerationRef.current;
69-
setIsLoadingEntries(true);
70-
setEntriesError(null);
71-
72-
if(!api){
73-
setEntriesError("Environment is not connected.");
74-
setIsLoadingEntries(false);
75-
return;
76-
}
65+
constloadEntries=useCallback(
66+
(options?: {refresh?: boolean})=>{
67+
constapi=readEnvironmentApi(environmentId);
68+
requestGenerationRef.current+=1;
69+
constgeneration=requestGenerationRef.current;
70+
setIsLoadingEntries(true);
71+
setEntriesError(null);
7772

78-
voidapi.projects.listEntries({ cwd }).then(
79-
(result)=>{
80-
if(generation!==requestGenerationRef.current)return;
81-
entryKindsRef.current=newMap(
82-
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
83-
);
84-
setEntries(result.entries);
85-
setIsTruncated(result.truncated);
86-
model.resetPaths(result.entries.map(treePath));
73+
if(!api){
74+
setEntriesError("Environment is not connected.");
8775
setIsLoadingEntries(false);
88-
},
89-
(error: unknown)=>{
90-
if(generation!==requestGenerationRef.current)return;
91-
setEntriesError(errorinstanceofError ? error.message : String(error));
92-
setIsLoadingEntries(false);
93-
},
94-
);
95-
},[cwd,environmentId,model]);
76+
return;
77+
}
78+
79+
constrequest=options?.refresh
80+
? api.projects.refreshEntries({ cwd })
81+
: api.projects.listEntries({ cwd });
82+
83+
voidrequest.then(
84+
(result)=>{
85+
if(generation!==requestGenerationRef.current)return;
86+
entryKindsRef.current=newMap(
87+
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
88+
);
89+
setEntries(result.entries);
90+
setIsTruncated(result.truncated);
91+
model.resetPaths(result.entries.map(treePath));
92+
setIsLoadingEntries(false);
93+
},
94+
(error: unknown)=>{
95+
if(generation!==requestGenerationRef.current)return;
96+
setEntriesError(errorinstanceofError ? error.message : String(error));
97+
setIsLoadingEntries(false);
98+
},
99+
);
100+
},
101+
[cwd,environmentId,model],
102+
);
96103

97104
useEffect(()=>{
98105
loadEntries();
@@ -128,7 +135,7 @@ export default function FileBrowserPanel({
128135
type="button"
129136
className="rounded-md p-1.5 text-muted-foreground hover:bg-accent hover:text-foreground"
130137
aria-label="Refresh workspace files"
131-
onClick={loadEntries}
138+
onClick={()=>loadEntries({refresh: true})}
132139
>
133140
<RefreshCwclassName={cn("size-3.5",isLoadingEntries&&"animate-spin")}/>
134141
</button>

‎apps/web/src/environmentApi.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export function createEnvironmentApi(rpcClient: WsRpcClient): EnvironmentApi {
2020
},
2121
projects: {
2222
listEntries: rpcClient.projects.listEntries,
23+
refreshEntries: rpcClient.projects.refreshEntries,
2324
readFile: rpcClient.projects.readFile,
2425
searchEntries: rpcClient.projects.searchEntries,
2526
writeFile: rpcClient.projects.writeFile,

‎apps/web/src/environments/runtime/service.threadSubscriptions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ vi.mock("@t3tools/client-runtime", async (importOriginal) => {
122122
},
123123
projects: {
124124
listEntries: vi.fn(),
125+
refreshEntries: vi.fn(),
125126
readFile: vi.fn(),
126127
searchEntries: vi.fn(),
127128
writeFile: vi.fn(),

‎apps/web/src/localApi.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const rpcClientMock = {
5656
},
5757
projects: {
5858
listEntries: vi.fn(),
59+
refreshEntries: vi.fn(),
5960
readFile: vi.fn(),
6061
searchEntries: vi.fn(),
6162
writeFile: vi.fn(),

‎packages/client-runtime/src/wsRpcClient.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export interface WsRpcClient {
9797
};
9898
readonlyprojects: {
9999
readonlylistEntries: RpcUnaryMethod<typeofWS_METHODS.projectsListEntries>;
100+
readonlyrefreshEntries: RpcUnaryMethod<typeofWS_METHODS.projectsRefreshEntries>;
100101
readonlyreadFile: RpcUnaryMethod<typeofWS_METHODS.projectsReadFile>;
101102
readonlysearchEntries: RpcUnaryMethod<typeofWS_METHODS.projectsSearchEntries>;
102103
readonlywriteFile: RpcUnaryMethod<typeofWS_METHODS.projectsWriteFile>;
@@ -271,6 +272,8 @@ export function createWsRpcClient(
271272
projects: {
272273
listEntries: (input)=>
273274
transport.request((client)=>client[WS_METHODS.projectsListEntries](input)),
275+
refreshEntries: (input)=>
276+
transport.request((client)=>client[WS_METHODS.projectsRefreshEntries](input)),
274277
readFile: (input)=>
275278
transport.request((client)=>client[WS_METHODS.projectsReadFile](input)),
276279
searchEntries: (input)=>

‎packages/contracts/src/ipc.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,6 +1115,7 @@ export interface EnvironmentApi {
11151115
};
11161116
projects: {
11171117
listEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
1118+
refreshEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
11181119
readFile: (input: ProjectReadFileInput)=>Promise<ProjectReadFileResult>;
11191120
searchEntries: (input: ProjectSearchEntriesInput)=>Promise<ProjectSearchEntriesResult>;
11201121
writeFile: (input: ProjectWriteFileInput)=>Promise<ProjectWriteFileResult>;

‎packages/contracts/src/rpc.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ export const WS_METHODS = {
148148
projectsAdd: "projects.add",
149149
projectsRemove: "projects.remove",
150150
projectsListEntries: "projects.listEntries",
151+
projectsRefreshEntries: "projects.refreshEntries",
151152
projectsReadFile: "projects.readFile",
152153
projectsSearchEntries: "projects.searchEntries",
153154
projectsWriteFile: "projects.writeFile",
@@ -364,6 +365,12 @@ export const WsProjectsListEntriesRpc = Rpc.make(WS_METHODS.projectsListEntries,
364365
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
365366
});
366367

368+
exportconstWsProjectsRefreshEntriesRpc=Rpc.make(WS_METHODS.projectsRefreshEntries,{
369+
payload: ProjectListEntriesInput,
370+
success: ProjectListEntriesResult,
371+
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
372+
});
373+
367374
exportconstWsProjectsReadFileRpc=Rpc.make(WS_METHODS.projectsReadFile,{
368375
payload: ProjectReadFileInput,
369376
success: ProjectReadFileResult,
@@ -697,6 +704,7 @@ export const WsRpcGroup = RpcGroup.make(
697704
WsSourceControlCloneRepositoryRpc,
698705
WsSourceControlPublishRepositoryRpc,
699706
WsProjectsListEntriesRpc,
707+
WsProjectsRefreshEntriesRpc,
700708
WsProjectsReadFileRpc,
701709
WsProjectsSearchEntriesRpc,
702710
WsProjectsWriteFileRpc,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 409a118

Browse files
committed
Fix: clear maximized state on last surface close, add cache-invalidating refresh RPC, probe truncated files for binary content
- ChatView: clear maximizedRightPanelThreadKey when closeRightPanelSurface leaves no active surface, preventing the chat column from staying at w-0 after the last right-panel tab is closed. - Add projects.refreshEntries RPC that invalidates the workspace index cache before listing, so the explicit refresh button in FileBrowserPanel returns up-to-date filesystem state instead of stale cached data. - WorkspaceFileSystem.readFile: when a file is truncated (>1 MB), read an additional 8 KB probe from the end of the file and check for NUL bytes, catching binary files whose first null appears beyond the preview window.
1 parent e18504c commit 409a118

10 files changed

Lines changed: 85 additions & 30 deletions

File tree

‎apps/server/src/workspace/Layers/WorkspaceFileSystem.ts‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,20 @@ export const makeWorkspaceFileSystem = Effect.gen(function* () {
5757
if(fileBytes.includes(0)){
5858
thrownewError("Binary files cannot be previewed as text.");
5959
}
60+
if(stat.size>PROJECT_READ_FILE_MAX_BYTES){
61+
constprobeSize=8192;
62+
constprobeOffset=Math.max(bytesToRead,stat.size-probeSize);
63+
constprobeBuf=Buffer.alloc(Math.min(probeSize,stat.size-probeOffset));
64+
const{bytesRead: probeRead}=awaithandle.read(
65+
probeBuf,
66+
0,
67+
probeBuf.length,
68+
probeOffset,
69+
);
70+
if(probeBuf.subarray(0,probeRead).includes(0)){
71+
thrownewError("Binary files cannot be previewed as text.");
72+
}
73+
}
6074
constcontents=newTextDecoder("utf-8").decode(fileBytes);
6175
return{
6276
relativePath: target.relativePath,

‎apps/server/src/ws.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ const RPC_REQUIRED_SCOPE = new Map<string, AuthEnvironmentScope>([
163163
[WS_METHODS.sourceControlCloneRepository,AuthOrchestrationOperateScope],
164164
[WS_METHODS.sourceControlPublishRepository,AuthOrchestrationOperateScope],
165165
[WS_METHODS.projectsListEntries,AuthOrchestrationReadScope],
166+
[WS_METHODS.projectsRefreshEntries,AuthOrchestrationReadScope],
166167
[WS_METHODS.projectsReadFile,AuthOrchestrationReadScope],
167168
[WS_METHODS.projectsSearchEntries,AuthOrchestrationReadScope],
168169
[WS_METHODS.projectsWriteFile,AuthOrchestrationOperateScope],
@@ -1190,6 +1191,21 @@ const makeWsRpcLayer = (currentSession: AuthenticatedSession) =>
11901191
),
11911192
{"rpc.aggregate": "workspace"},
11921193
),
1194+
[WS_METHODS.projectsRefreshEntries]: (input)=>
1195+
observeRpcEffect(
1196+
WS_METHODS.projectsRefreshEntries,
1197+
workspaceEntries.invalidate(input.cwd).pipe(
1198+
Effect.andThen(()=>workspaceEntries.list(input)),
1199+
Effect.mapError(
1200+
(cause)=>
1201+
newProjectListEntriesError({
1202+
message: `Failed to refresh workspace entries: ${cause.detail}`,
1203+
cause,
1204+
}),
1205+
),
1206+
),
1207+
{"rpc.aggregate": "workspace"},
1208+
),
11931209
[WS_METHODS.projectsReadFile]: (input)=>
11941210
observeRpcEffect(
11951211
WS_METHODS.projectsReadFile,

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3067,6 +3067,9 @@ export default function ChatView(props: ChatViewProps) {
30673067
useRightPanelStore.getState().byThreadKey,
30683068
activeThreadRef,
30693069
);
3070+
if(!nextActiveSurface){
3071+
setMaximizedRightPanelThreadKey(null);
3072+
}
30703073
if(nextActiveSurface?.kind==="preview"&&nextActiveSurface.resourceId){
30713074
usePreviewStateStore.getState().setActiveTab(activeThreadRef,nextActiveSurface.resourceId);
30723075
}

‎apps/web/src/components/files/FileBrowserPanel.tsx‎

Lines changed: 37 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,44 @@ export default function FileBrowserPanel({
6262
unsafeCSS: TREE_UNSAFE_CSS,
6363
});
6464

65-
constloadEntries=useCallback(()=>{
66-
constapi=readEnvironmentApi(environmentId);
67-
requestGenerationRef.current+=1;
68-
constgeneration=requestGenerationRef.current;
69-
setIsLoadingEntries(true);
70-
setEntriesError(null);
71-
72-
if(!api){
73-
setEntriesError("Environment is not connected.");
74-
setIsLoadingEntries(false);
75-
return;
76-
}
65+
constloadEntries=useCallback(
66+
(options?: {refresh?: boolean})=>{
67+
constapi=readEnvironmentApi(environmentId);
68+
requestGenerationRef.current+=1;
69+
constgeneration=requestGenerationRef.current;
70+
setIsLoadingEntries(true);
71+
setEntriesError(null);
7772

78-
voidapi.projects.listEntries({ cwd }).then(
79-
(result)=>{
80-
if(generation!==requestGenerationRef.current)return;
81-
entryKindsRef.current=newMap(
82-
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
83-
);
84-
setEntries(result.entries);
85-
setIsTruncated(result.truncated);
86-
model.resetPaths(result.entries.map(treePath));
73+
if(!api){
74+
setEntriesError("Environment is not connected.");
8775
setIsLoadingEntries(false);
88-
},
89-
(error: unknown)=>{
90-
if(generation!==requestGenerationRef.current)return;
91-
setEntriesError(errorinstanceofError ? error.message : String(error));
92-
setIsLoadingEntries(false);
93-
},
94-
);
95-
},[cwd,environmentId,model]);
76+
return;
77+
}
78+
79+
constrequest=options?.refresh
80+
? api.projects.refreshEntries({ cwd })
81+
: api.projects.listEntries({ cwd });
82+
83+
voidrequest.then(
84+
(result)=>{
85+
if(generation!==requestGenerationRef.current)return;
86+
entryKindsRef.current=newMap(
87+
result.entries.map((entry)=>[entry.path,entry.kind]asconst),
88+
);
89+
setEntries(result.entries);
90+
setIsTruncated(result.truncated);
91+
model.resetPaths(result.entries.map(treePath));
92+
setIsLoadingEntries(false);
93+
},
94+
(error: unknown)=>{
95+
if(generation!==requestGenerationRef.current)return;
96+
setEntriesError(errorinstanceofError ? error.message : String(error));
97+
setIsLoadingEntries(false);
98+
},
99+
);
100+
},
101+
[cwd,environmentId,model],
102+
);
96103

97104
useEffect(()=>{
98105
loadEntries();
@@ -128,7 +135,7 @@ export default function FileBrowserPanel({
128135
type="button"
129136
className="rounded-md p-1.5 text-muted-foreground hover:bg-accent hover:text-foreground"
130137
aria-label="Refresh workspace files"
131-
onClick={loadEntries}
138+
onClick={()=>loadEntries({refresh: true})}
132139
>
133140
<RefreshCwclassName={cn("size-3.5",isLoadingEntries&&"animate-spin")}/>
134141
</button>

‎apps/web/src/environmentApi.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export function createEnvironmentApi(rpcClient: WsRpcClient): EnvironmentApi {
2020
},
2121
projects: {
2222
listEntries: rpcClient.projects.listEntries,
23+
refreshEntries: rpcClient.projects.refreshEntries,
2324
readFile: rpcClient.projects.readFile,
2425
searchEntries: rpcClient.projects.searchEntries,
2526
writeFile: rpcClient.projects.writeFile,

‎apps/web/src/environments/runtime/service.threadSubscriptions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ vi.mock("@t3tools/client-runtime", async (importOriginal) => {
122122
},
123123
projects: {
124124
listEntries: vi.fn(),
125+
refreshEntries: vi.fn(),
125126
readFile: vi.fn(),
126127
searchEntries: vi.fn(),
127128
writeFile: vi.fn(),

‎apps/web/src/localApi.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const rpcClientMock = {
5656
},
5757
projects: {
5858
listEntries: vi.fn(),
59+
refreshEntries: vi.fn(),
5960
readFile: vi.fn(),
6061
searchEntries: vi.fn(),
6162
writeFile: vi.fn(),

‎packages/client-runtime/src/wsRpcClient.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export interface WsRpcClient {
9797
};
9898
readonlyprojects: {
9999
readonlylistEntries: RpcUnaryMethod<typeofWS_METHODS.projectsListEntries>;
100+
readonlyrefreshEntries: RpcUnaryMethod<typeofWS_METHODS.projectsRefreshEntries>;
100101
readonlyreadFile: RpcUnaryMethod<typeofWS_METHODS.projectsReadFile>;
101102
readonlysearchEntries: RpcUnaryMethod<typeofWS_METHODS.projectsSearchEntries>;
102103
readonlywriteFile: RpcUnaryMethod<typeofWS_METHODS.projectsWriteFile>;
@@ -271,6 +272,8 @@ export function createWsRpcClient(
271272
projects: {
272273
listEntries: (input)=>
273274
transport.request((client)=>client[WS_METHODS.projectsListEntries](input)),
275+
refreshEntries: (input)=>
276+
transport.request((client)=>client[WS_METHODS.projectsRefreshEntries](input)),
274277
readFile: (input)=>
275278
transport.request((client)=>client[WS_METHODS.projectsReadFile](input)),
276279
searchEntries: (input)=>

‎packages/contracts/src/ipc.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,6 +1115,7 @@ export interface EnvironmentApi {
11151115
};
11161116
projects: {
11171117
listEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
1118+
refreshEntries: (input: ProjectListEntriesInput)=>Promise<ProjectListEntriesResult>;
11181119
readFile: (input: ProjectReadFileInput)=>Promise<ProjectReadFileResult>;
11191120
searchEntries: (input: ProjectSearchEntriesInput)=>Promise<ProjectSearchEntriesResult>;
11201121
writeFile: (input: ProjectWriteFileInput)=>Promise<ProjectWriteFileResult>;

‎packages/contracts/src/rpc.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ export const WS_METHODS = {
148148
projectsAdd: "projects.add",
149149
projectsRemove: "projects.remove",
150150
projectsListEntries: "projects.listEntries",
151+
projectsRefreshEntries: "projects.refreshEntries",
151152
projectsReadFile: "projects.readFile",
152153
projectsSearchEntries: "projects.searchEntries",
153154
projectsWriteFile: "projects.writeFile",
@@ -364,6 +365,12 @@ export const WsProjectsListEntriesRpc = Rpc.make(WS_METHODS.projectsListEntries,
364365
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
365366
});
366367

368+
exportconstWsProjectsRefreshEntriesRpc=Rpc.make(WS_METHODS.projectsRefreshEntries,{
369+
payload: ProjectListEntriesInput,
370+
success: ProjectListEntriesResult,
371+
error: Schema.Union([ProjectListEntriesError,EnvironmentAuthorizationError]),
372+
});
373+
367374
exportconstWsProjectsReadFileRpc=Rpc.make(WS_METHODS.projectsReadFile,{
368375
payload: ProjectReadFileInput,
369376
success: ProjectReadFileResult,
@@ -697,6 +704,7 @@ export const WsRpcGroup = RpcGroup.make(
697704
WsSourceControlCloneRepositoryRpc,
698705
WsSourceControlPublishRepositoryRpc,
699706
WsProjectsListEntriesRpc,
707+
WsProjectsRefreshEntriesRpc,
700708
WsProjectsReadFileRpc,
701709
WsProjectsSearchEntriesRpc,
702710
WsProjectsWriteFileRpc,

0 commit comments

Comments
 (0)