Commit 755bf3a

Browse files
committed
Fix Windows process tree traversal, remove dead code, deduplicate normalizeRunningPorts
- win32.ts: Replace direct-child-only query with full BFS traversal (collectWindowsProcessFamilyPids) to match POSIX behavior for detecting grandchild processes and their listening ports - index.ts: Remove unused subprocessCheckerToInspector export and clean up unused type imports - Deduplicate normalizeRunningPorts by exporting from terminalStateStore and importing in Sidebar.tsx and ThreadTerminalDrawer.tsx
1 parent 05a7018 commit 755bf3a

5 files changed

Lines changed: 58 additions & 45 deletions

File tree

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import{collectPosixProcessFamilyPids,checkPosixListeningPorts}from"./posix";
2-
import{
3-
typeTerminalSubprocessActivity,
4-
typeTerminalSubprocessChecker,
5-
typeTerminalSubprocessInspector,
6-
typeTerminalWebPortInspector,
7-
}from"./types";
8-
import{checkWindowsListeningPorts,collectWindowsChildPids}from"./win32";
2+
import{typeTerminalSubprocessActivity}from"./types";
3+
import{checkWindowsListeningPorts,collectWindowsProcessFamilyPids}from"./win32";
94

105
export{arePortListsEqual,normalizeRunningPorts}from"./utils";
116

@@ -24,11 +19,15 @@ export async function defaultSubprocessInspector(
2419
}
2520

2621
if(process.platform==="win32"){
27-
constchildPids=awaitcollectWindowsChildPids(terminalPid);
28-
constprocessPidsForPortScan=[terminalPid, ...childPids];
29-
construnningPorts=awaitcheckWindowsListeningPorts(processPidsForPortScan);
22+
constprocessFamilyPids=awaitcollectWindowsProcessFamilyPids(terminalPid);
23+
if(processFamilyPids.length===0){
24+
return{hasRunningSubprocess: false,runningPorts: []};
25+
}
26+
27+
constsubprocessPids=processFamilyPids.filter((pid)=>pid!==terminalPid);
28+
construnningPorts=awaitcheckWindowsListeningPorts(processFamilyPids);
3029
return{
31-
hasRunningSubprocess: childPids.length>0||runningPorts.length>0,
30+
hasRunningSubprocess: subprocessPids.length>0||runningPorts.length>0,
3231
runningPorts,
3332
};
3433
}
@@ -45,12 +44,3 @@ export async function defaultSubprocessInspector(
4544
runningPorts,
4645
};
4746
}
48-
49-
exportfunctionsubprocessCheckerToInspector(
50-
subprocessChecker: TerminalSubprocessChecker,
51-
): TerminalSubprocessInspector{
52-
returnasync(terminalPid: number)=>({
53-
hasRunningSubprocess: awaitsubprocessChecker(terminalPid),
54-
runningPorts: [],
55-
});
56-
}

‎apps/server/src/terminalProcessInspector/win32.ts‎

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,56 @@
11
import{runProcess}from"../processRunner";
2-
import{parsePidList,parsePortList}from"./utils";
2+
import{parsePortList}from"./utils";
33

4-
exportasyncfunctioncollectWindowsChildPids(terminalPid: number): Promise<number[]>{
4+
exportasyncfunctioncollectWindowsProcessFamilyPids(terminalPid: number): Promise<number[]>{
55
constcommand=[
6-
`$children = Get-CimInstance Win32_Process -Filter "ParentProcessId = ${terminalPid}" -ErrorAction SilentlyContinue`,
7-
"if (-not $children) { exit 0 }",
8-
"$children | Select-Object -ExpandProperty ProcessId",
6+
"$procs = Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId -ErrorAction SilentlyContinue",
7+
"if (-not $procs) { exit 0 }",
8+
'$procs | ForEach-Object { "$($_.ProcessId) $($_.ParentProcessId)" }',
99
].join("; ");
1010
try{
1111
constresult=awaitrunProcess(
1212
"powershell.exe",
1313
["-NoProfile","-NonInteractive","-Command",command],
1414
{
15-
timeoutMs: 1_500,
15+
timeoutMs: 2_000,
1616
allowNonZeroExit: true,
17-
maxBufferBytes: 32_768,
17+
maxBufferBytes: 262_144,
1818
outputMode: "truncate",
1919
},
2020
);
2121
if(result.code!==0){
2222
return[];
2323
}
24-
returnparsePidList(result.stdout);
24+
25+
constchildrenByParentPid=newMap<number,number[]>();
26+
for(constlineofresult.stdout.split(/\r?\n/g)){
27+
const[pidRaw,ppidRaw]=line.trim().split(/\s+/g);
28+
constpid=Number(pidRaw);
29+
constppid=Number(ppidRaw);
30+
if(!Number.isInteger(pid)||!Number.isInteger(ppid))continue;
31+
constchildren=childrenByParentPid.get(ppid);
32+
if(children){
33+
children.push(pid);
34+
}else{
35+
childrenByParentPid.set(ppid,[pid]);
36+
}
37+
}
38+
39+
constprocessFamily=newSet<number>([terminalPid]);
40+
constpendingParents=[terminalPid];
41+
while(pendingParents.length>0){
42+
constparentPid=pendingParents.shift();
43+
if(!parentPid)continue;
44+
constchildPids=childrenByParentPid.get(parentPid);
45+
if(!childPids||childPids.length===0)continue;
46+
for(constchildPidofchildPids){
47+
if(processFamily.has(childPid))continue;
48+
processFamily.add(childPid);
49+
pendingParents.push(childPid);
50+
}
51+
}
52+
53+
return[...processFamily];
2554
}catch{
2655
return[];
2756
}

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ import { APP_STAGE_LABEL, APP_VERSION } from "../branding";
6161
import{isTerminalFocused}from"../lib/terminalFocus";
6262
import{isLinuxPlatform,isMacPlatform,newCommandId,newProjectId}from"../lib/utils";
6363
import{useStore}from"../store";
64-
import{selectThreadTerminalState,useTerminalStateStore}from"../terminalStateStore";
64+
import{
65+
normalizeRunningPorts,
66+
selectThreadTerminalState,
67+
useTerminalStateStore,
68+
}from"../terminalStateStore";
6569
import{useUiStateStore}from"../uiStateStore";
6670
import{
6771
resolveShortcutCommand,
@@ -204,13 +208,6 @@ function ThreadStatusLabel({
204208
);
205209
}
206210

207-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
208-
if(!rawPorts)return[];
209-
return[...newSet(rawPorts)]
210-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
211-
.toSorted((left,right)=>left-right);
212-
}
213-
214211
functionterminalStatusFromTerminalState(
215212
runningTerminalIds: string[],
216213
runningTerminalPorts: Record<string,number[]>,

‎apps/web/src/components/ThreadTerminalDrawer.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ import {
3333
typeThreadTerminalGroup,
3434
}from"../types";
3535
import{readNativeApi}from"~/nativeApi";
36-
import{selectTerminalEventEntries,useTerminalStateStore}from"../terminalStateStore";
36+
import{
37+
normalizeRunningPorts,
38+
selectTerminalEventEntries,
39+
useTerminalStateStore,
40+
}from"../terminalStateStore";
3741

3842
constMIN_DRAWER_HEIGHT=180;
3943
constMAX_DRAWER_HEIGHT_RATIO=0.75;
@@ -81,13 +85,6 @@ interface TerminalRuntimeStatus {
8185
extraWebPortCount: number;
8286
}
8387

84-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
85-
if(!rawPorts)return[];
86-
return[...newSet(rawPorts)]
87-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
88-
.toSorted((left,right)=>left-right);
89-
}
90-
9188
functionterminalRuntimeStatus(
9289
terminalId: string,
9390
runningTerminalIds: Set<string>,

‎apps/web/src/terminalStateStore.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function normalizeRunningTerminalIds(
6262
.filter((id)=>id.length>0&&validTerminalIdSet.has(id));
6363
}
6464

65-
functionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
65+
exportfunctionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
6666
if(!ports||ports.length===0)return[];
6767
return[...newSet(ports)]
6868
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 755bf3a

Browse files
committed
Fix Windows process tree traversal, remove dead code, deduplicate normalizeRunningPorts
- win32.ts: Replace direct-child-only query with full BFS traversal (collectWindowsProcessFamilyPids) to match POSIX behavior for detecting grandchild processes and their listening ports - index.ts: Remove unused subprocessCheckerToInspector export and clean up unused type imports - Deduplicate normalizeRunningPorts by exporting from terminalStateStore and importing in Sidebar.tsx and ThreadTerminalDrawer.tsx
1 parent 05a7018 commit 755bf3a

5 files changed

Lines changed: 58 additions & 45 deletions

File tree

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import{collectPosixProcessFamilyPids,checkPosixListeningPorts}from"./posix";
2-
import{
3-
typeTerminalSubprocessActivity,
4-
typeTerminalSubprocessChecker,
5-
typeTerminalSubprocessInspector,
6-
typeTerminalWebPortInspector,
7-
}from"./types";
8-
import{checkWindowsListeningPorts,collectWindowsChildPids}from"./win32";
2+
import{typeTerminalSubprocessActivity}from"./types";
3+
import{checkWindowsListeningPorts,collectWindowsProcessFamilyPids}from"./win32";
94

105
export{arePortListsEqual,normalizeRunningPorts}from"./utils";
116

@@ -24,11 +19,15 @@ export async function defaultSubprocessInspector(
2419
}
2520

2621
if(process.platform==="win32"){
27-
constchildPids=awaitcollectWindowsChildPids(terminalPid);
28-
constprocessPidsForPortScan=[terminalPid, ...childPids];
29-
construnningPorts=awaitcheckWindowsListeningPorts(processPidsForPortScan);
22+
constprocessFamilyPids=awaitcollectWindowsProcessFamilyPids(terminalPid);
23+
if(processFamilyPids.length===0){
24+
return{hasRunningSubprocess: false,runningPorts: []};
25+
}
26+
27+
constsubprocessPids=processFamilyPids.filter((pid)=>pid!==terminalPid);
28+
construnningPorts=awaitcheckWindowsListeningPorts(processFamilyPids);
3029
return{
31-
hasRunningSubprocess: childPids.length>0||runningPorts.length>0,
30+
hasRunningSubprocess: subprocessPids.length>0||runningPorts.length>0,
3231
runningPorts,
3332
};
3433
}
@@ -45,12 +44,3 @@ export async function defaultSubprocessInspector(
4544
runningPorts,
4645
};
4746
}
48-
49-
exportfunctionsubprocessCheckerToInspector(
50-
subprocessChecker: TerminalSubprocessChecker,
51-
): TerminalSubprocessInspector{
52-
returnasync(terminalPid: number)=>({
53-
hasRunningSubprocess: awaitsubprocessChecker(terminalPid),
54-
runningPorts: [],
55-
});
56-
}

‎apps/server/src/terminalProcessInspector/win32.ts‎

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,56 @@
11
import{runProcess}from"../processRunner";
2-
import{parsePidList,parsePortList}from"./utils";
2+
import{parsePortList}from"./utils";
33

4-
exportasyncfunctioncollectWindowsChildPids(terminalPid: number): Promise<number[]>{
4+
exportasyncfunctioncollectWindowsProcessFamilyPids(terminalPid: number): Promise<number[]>{
55
constcommand=[
6-
`$children = Get-CimInstance Win32_Process -Filter "ParentProcessId = ${terminalPid}" -ErrorAction SilentlyContinue`,
7-
"if (-not $children) { exit 0 }",
8-
"$children | Select-Object -ExpandProperty ProcessId",
6+
"$procs = Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId -ErrorAction SilentlyContinue",
7+
"if (-not $procs) { exit 0 }",
8+
'$procs | ForEach-Object { "$($_.ProcessId) $($_.ParentProcessId)" }',
99
].join("; ");
1010
try{
1111
constresult=awaitrunProcess(
1212
"powershell.exe",
1313
["-NoProfile","-NonInteractive","-Command",command],
1414
{
15-
timeoutMs: 1_500,
15+
timeoutMs: 2_000,
1616
allowNonZeroExit: true,
17-
maxBufferBytes: 32_768,
17+
maxBufferBytes: 262_144,
1818
outputMode: "truncate",
1919
},
2020
);
2121
if(result.code!==0){
2222
return[];
2323
}
24-
returnparsePidList(result.stdout);
24+
25+
constchildrenByParentPid=newMap<number,number[]>();
26+
for(constlineofresult.stdout.split(/\r?\n/g)){
27+
const[pidRaw,ppidRaw]=line.trim().split(/\s+/g);
28+
constpid=Number(pidRaw);
29+
constppid=Number(ppidRaw);
30+
if(!Number.isInteger(pid)||!Number.isInteger(ppid))continue;
31+
constchildren=childrenByParentPid.get(ppid);
32+
if(children){
33+
children.push(pid);
34+
}else{
35+
childrenByParentPid.set(ppid,[pid]);
36+
}
37+
}
38+
39+
constprocessFamily=newSet<number>([terminalPid]);
40+
constpendingParents=[terminalPid];
41+
while(pendingParents.length>0){
42+
constparentPid=pendingParents.shift();
43+
if(!parentPid)continue;
44+
constchildPids=childrenByParentPid.get(parentPid);
45+
if(!childPids||childPids.length===0)continue;
46+
for(constchildPidofchildPids){
47+
if(processFamily.has(childPid))continue;
48+
processFamily.add(childPid);
49+
pendingParents.push(childPid);
50+
}
51+
}
52+
53+
return[...processFamily];
2554
}catch{
2655
return[];
2756
}

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ import { APP_STAGE_LABEL, APP_VERSION } from "../branding";
6161
import{isTerminalFocused}from"../lib/terminalFocus";
6262
import{isLinuxPlatform,isMacPlatform,newCommandId,newProjectId}from"../lib/utils";
6363
import{useStore}from"../store";
64-
import{selectThreadTerminalState,useTerminalStateStore}from"../terminalStateStore";
64+
import{
65+
normalizeRunningPorts,
66+
selectThreadTerminalState,
67+
useTerminalStateStore,
68+
}from"../terminalStateStore";
6569
import{useUiStateStore}from"../uiStateStore";
6670
import{
6771
resolveShortcutCommand,
@@ -204,13 +208,6 @@ function ThreadStatusLabel({
204208
);
205209
}
206210

207-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
208-
if(!rawPorts)return[];
209-
return[...newSet(rawPorts)]
210-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
211-
.toSorted((left,right)=>left-right);
212-
}
213-
214211
functionterminalStatusFromTerminalState(
215212
runningTerminalIds: string[],
216213
runningTerminalPorts: Record<string,number[]>,

‎apps/web/src/components/ThreadTerminalDrawer.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ import {
3333
typeThreadTerminalGroup,
3434
}from"../types";
3535
import{readNativeApi}from"~/nativeApi";
36-
import{selectTerminalEventEntries,useTerminalStateStore}from"../terminalStateStore";
36+
import{
37+
normalizeRunningPorts,
38+
selectTerminalEventEntries,
39+
useTerminalStateStore,
40+
}from"../terminalStateStore";
3741

3842
constMIN_DRAWER_HEIGHT=180;
3943
constMAX_DRAWER_HEIGHT_RATIO=0.75;
@@ -81,13 +85,6 @@ interface TerminalRuntimeStatus {
8185
extraWebPortCount: number;
8286
}
8387

84-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
85-
if(!rawPorts)return[];
86-
return[...newSet(rawPorts)]
87-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
88-
.toSorted((left,right)=>left-right);
89-
}
90-
9188
functionterminalRuntimeStatus(
9289
terminalId: string,
9390
runningTerminalIds: Set<string>,

‎apps/web/src/terminalStateStore.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function normalizeRunningTerminalIds(
6262
.filter((id)=>id.length>0&&validTerminalIdSet.has(id));
6363
}
6464

65-
functionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
65+
exportfunctionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
6666
if(!ports||ports.length===0)return[];
6767
return[...newSet(ports)]
6868
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 755bf3a

Browse files
committed
Fix Windows process tree traversal, remove dead code, deduplicate normalizeRunningPorts
- win32.ts: Replace direct-child-only query with full BFS traversal (collectWindowsProcessFamilyPids) to match POSIX behavior for detecting grandchild processes and their listening ports - index.ts: Remove unused subprocessCheckerToInspector export and clean up unused type imports - Deduplicate normalizeRunningPorts by exporting from terminalStateStore and importing in Sidebar.tsx and ThreadTerminalDrawer.tsx
1 parent 05a7018 commit 755bf3a

5 files changed

Lines changed: 58 additions & 45 deletions

File tree

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import{collectPosixProcessFamilyPids,checkPosixListeningPorts}from"./posix";
2-
import{
3-
typeTerminalSubprocessActivity,
4-
typeTerminalSubprocessChecker,
5-
typeTerminalSubprocessInspector,
6-
typeTerminalWebPortInspector,
7-
}from"./types";
8-
import{checkWindowsListeningPorts,collectWindowsChildPids}from"./win32";
2+
import{typeTerminalSubprocessActivity}from"./types";
3+
import{checkWindowsListeningPorts,collectWindowsProcessFamilyPids}from"./win32";
94

105
export{arePortListsEqual,normalizeRunningPorts}from"./utils";
116

@@ -24,11 +19,15 @@ export async function defaultSubprocessInspector(
2419
}
2520

2621
if(process.platform==="win32"){
27-
constchildPids=awaitcollectWindowsChildPids(terminalPid);
28-
constprocessPidsForPortScan=[terminalPid, ...childPids];
29-
construnningPorts=awaitcheckWindowsListeningPorts(processPidsForPortScan);
22+
constprocessFamilyPids=awaitcollectWindowsProcessFamilyPids(terminalPid);
23+
if(processFamilyPids.length===0){
24+
return{hasRunningSubprocess: false,runningPorts: []};
25+
}
26+
27+
constsubprocessPids=processFamilyPids.filter((pid)=>pid!==terminalPid);
28+
construnningPorts=awaitcheckWindowsListeningPorts(processFamilyPids);
3029
return{
31-
hasRunningSubprocess: childPids.length>0||runningPorts.length>0,
30+
hasRunningSubprocess: subprocessPids.length>0||runningPorts.length>0,
3231
runningPorts,
3332
};
3433
}
@@ -45,12 +44,3 @@ export async function defaultSubprocessInspector(
4544
runningPorts,
4645
};
4746
}
48-
49-
exportfunctionsubprocessCheckerToInspector(
50-
subprocessChecker: TerminalSubprocessChecker,
51-
): TerminalSubprocessInspector{
52-
returnasync(terminalPid: number)=>({
53-
hasRunningSubprocess: awaitsubprocessChecker(terminalPid),
54-
runningPorts: [],
55-
});
56-
}

‎apps/server/src/terminalProcessInspector/win32.ts‎

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,56 @@
11
import{runProcess}from"../processRunner";
2-
import{parsePidList,parsePortList}from"./utils";
2+
import{parsePortList}from"./utils";
33

4-
exportasyncfunctioncollectWindowsChildPids(terminalPid: number): Promise<number[]>{
4+
exportasyncfunctioncollectWindowsProcessFamilyPids(terminalPid: number): Promise<number[]>{
55
constcommand=[
6-
`$children = Get-CimInstance Win32_Process -Filter "ParentProcessId = ${terminalPid}" -ErrorAction SilentlyContinue`,
7-
"if (-not $children) { exit 0 }",
8-
"$children | Select-Object -ExpandProperty ProcessId",
6+
"$procs = Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId -ErrorAction SilentlyContinue",
7+
"if (-not $procs) { exit 0 }",
8+
'$procs | ForEach-Object { "$($_.ProcessId) $($_.ParentProcessId)" }',
99
].join("; ");
1010
try{
1111
constresult=awaitrunProcess(
1212
"powershell.exe",
1313
["-NoProfile","-NonInteractive","-Command",command],
1414
{
15-
timeoutMs: 1_500,
15+
timeoutMs: 2_000,
1616
allowNonZeroExit: true,
17-
maxBufferBytes: 32_768,
17+
maxBufferBytes: 262_144,
1818
outputMode: "truncate",
1919
},
2020
);
2121
if(result.code!==0){
2222
return[];
2323
}
24-
returnparsePidList(result.stdout);
24+
25+
constchildrenByParentPid=newMap<number,number[]>();
26+
for(constlineofresult.stdout.split(/\r?\n/g)){
27+
const[pidRaw,ppidRaw]=line.trim().split(/\s+/g);
28+
constpid=Number(pidRaw);
29+
constppid=Number(ppidRaw);
30+
if(!Number.isInteger(pid)||!Number.isInteger(ppid))continue;
31+
constchildren=childrenByParentPid.get(ppid);
32+
if(children){
33+
children.push(pid);
34+
}else{
35+
childrenByParentPid.set(ppid,[pid]);
36+
}
37+
}
38+
39+
constprocessFamily=newSet<number>([terminalPid]);
40+
constpendingParents=[terminalPid];
41+
while(pendingParents.length>0){
42+
constparentPid=pendingParents.shift();
43+
if(!parentPid)continue;
44+
constchildPids=childrenByParentPid.get(parentPid);
45+
if(!childPids||childPids.length===0)continue;
46+
for(constchildPidofchildPids){
47+
if(processFamily.has(childPid))continue;
48+
processFamily.add(childPid);
49+
pendingParents.push(childPid);
50+
}
51+
}
52+
53+
return[...processFamily];
2554
}catch{
2655
return[];
2756
}

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ import { APP_STAGE_LABEL, APP_VERSION } from "../branding";
6161
import{isTerminalFocused}from"../lib/terminalFocus";
6262
import{isLinuxPlatform,isMacPlatform,newCommandId,newProjectId}from"../lib/utils";
6363
import{useStore}from"../store";
64-
import{selectThreadTerminalState,useTerminalStateStore}from"../terminalStateStore";
64+
import{
65+
normalizeRunningPorts,
66+
selectThreadTerminalState,
67+
useTerminalStateStore,
68+
}from"../terminalStateStore";
6569
import{useUiStateStore}from"../uiStateStore";
6670
import{
6771
resolveShortcutCommand,
@@ -204,13 +208,6 @@ function ThreadStatusLabel({
204208
);
205209
}
206210

207-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
208-
if(!rawPorts)return[];
209-
return[...newSet(rawPorts)]
210-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
211-
.toSorted((left,right)=>left-right);
212-
}
213-
214211
functionterminalStatusFromTerminalState(
215212
runningTerminalIds: string[],
216213
runningTerminalPorts: Record<string,number[]>,

‎apps/web/src/components/ThreadTerminalDrawer.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ import {
3333
typeThreadTerminalGroup,
3434
}from"../types";
3535
import{readNativeApi}from"~/nativeApi";
36-
import{selectTerminalEventEntries,useTerminalStateStore}from"../terminalStateStore";
36+
import{
37+
normalizeRunningPorts,
38+
selectTerminalEventEntries,
39+
useTerminalStateStore,
40+
}from"../terminalStateStore";
3741

3842
constMIN_DRAWER_HEIGHT=180;
3943
constMAX_DRAWER_HEIGHT_RATIO=0.75;
@@ -81,13 +85,6 @@ interface TerminalRuntimeStatus {
8185
extraWebPortCount: number;
8286
}
8387

84-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
85-
if(!rawPorts)return[];
86-
return[...newSet(rawPorts)]
87-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
88-
.toSorted((left,right)=>left-right);
89-
}
90-
9188
functionterminalRuntimeStatus(
9289
terminalId: string,
9390
runningTerminalIds: Set<string>,

‎apps/web/src/terminalStateStore.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function normalizeRunningTerminalIds(
6262
.filter((id)=>id.length>0&&validTerminalIdSet.has(id));
6363
}
6464

65-
functionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
65+
exportfunctionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
6666
if(!ports||ports.length===0)return[];
6767
return[...newSet(ports)]
6868
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 755bf3a

Browse files
committed
Fix Windows process tree traversal, remove dead code, deduplicate normalizeRunningPorts
- win32.ts: Replace direct-child-only query with full BFS traversal (collectWindowsProcessFamilyPids) to match POSIX behavior for detecting grandchild processes and their listening ports - index.ts: Remove unused subprocessCheckerToInspector export and clean up unused type imports - Deduplicate normalizeRunningPorts by exporting from terminalStateStore and importing in Sidebar.tsx and ThreadTerminalDrawer.tsx
1 parent 05a7018 commit 755bf3a

5 files changed

Lines changed: 58 additions & 45 deletions

File tree

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import{collectPosixProcessFamilyPids,checkPosixListeningPorts}from"./posix";
2-
import{
3-
typeTerminalSubprocessActivity,
4-
typeTerminalSubprocessChecker,
5-
typeTerminalSubprocessInspector,
6-
typeTerminalWebPortInspector,
7-
}from"./types";
8-
import{checkWindowsListeningPorts,collectWindowsChildPids}from"./win32";
2+
import{typeTerminalSubprocessActivity}from"./types";
3+
import{checkWindowsListeningPorts,collectWindowsProcessFamilyPids}from"./win32";
94

105
export{arePortListsEqual,normalizeRunningPorts}from"./utils";
116

@@ -24,11 +19,15 @@ export async function defaultSubprocessInspector(
2419
}
2520

2621
if(process.platform==="win32"){
27-
constchildPids=awaitcollectWindowsChildPids(terminalPid);
28-
constprocessPidsForPortScan=[terminalPid, ...childPids];
29-
construnningPorts=awaitcheckWindowsListeningPorts(processPidsForPortScan);
22+
constprocessFamilyPids=awaitcollectWindowsProcessFamilyPids(terminalPid);
23+
if(processFamilyPids.length===0){
24+
return{hasRunningSubprocess: false,runningPorts: []};
25+
}
26+
27+
constsubprocessPids=processFamilyPids.filter((pid)=>pid!==terminalPid);
28+
construnningPorts=awaitcheckWindowsListeningPorts(processFamilyPids);
3029
return{
31-
hasRunningSubprocess: childPids.length>0||runningPorts.length>0,
30+
hasRunningSubprocess: subprocessPids.length>0||runningPorts.length>0,
3231
runningPorts,
3332
};
3433
}
@@ -45,12 +44,3 @@ export async function defaultSubprocessInspector(
4544
runningPorts,
4645
};
4746
}
48-
49-
exportfunctionsubprocessCheckerToInspector(
50-
subprocessChecker: TerminalSubprocessChecker,
51-
): TerminalSubprocessInspector{
52-
returnasync(terminalPid: number)=>({
53-
hasRunningSubprocess: awaitsubprocessChecker(terminalPid),
54-
runningPorts: [],
55-
});
56-
}

‎apps/server/src/terminalProcessInspector/win32.ts‎

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,56 @@
11
import{runProcess}from"../processRunner";
2-
import{parsePidList,parsePortList}from"./utils";
2+
import{parsePortList}from"./utils";
33

4-
exportasyncfunctioncollectWindowsChildPids(terminalPid: number): Promise<number[]>{
4+
exportasyncfunctioncollectWindowsProcessFamilyPids(terminalPid: number): Promise<number[]>{
55
constcommand=[
6-
`$children = Get-CimInstance Win32_Process -Filter "ParentProcessId = ${terminalPid}" -ErrorAction SilentlyContinue`,
7-
"if (-not $children) { exit 0 }",
8-
"$children | Select-Object -ExpandProperty ProcessId",
6+
"$procs = Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId -ErrorAction SilentlyContinue",
7+
"if (-not $procs) { exit 0 }",
8+
'$procs | ForEach-Object { "$($_.ProcessId) $($_.ParentProcessId)" }',
99
].join("; ");
1010
try{
1111
constresult=awaitrunProcess(
1212
"powershell.exe",
1313
["-NoProfile","-NonInteractive","-Command",command],
1414
{
15-
timeoutMs: 1_500,
15+
timeoutMs: 2_000,
1616
allowNonZeroExit: true,
17-
maxBufferBytes: 32_768,
17+
maxBufferBytes: 262_144,
1818
outputMode: "truncate",
1919
},
2020
);
2121
if(result.code!==0){
2222
return[];
2323
}
24-
returnparsePidList(result.stdout);
24+
25+
constchildrenByParentPid=newMap<number,number[]>();
26+
for(constlineofresult.stdout.split(/\r?\n/g)){
27+
const[pidRaw,ppidRaw]=line.trim().split(/\s+/g);
28+
constpid=Number(pidRaw);
29+
constppid=Number(ppidRaw);
30+
if(!Number.isInteger(pid)||!Number.isInteger(ppid))continue;
31+
constchildren=childrenByParentPid.get(ppid);
32+
if(children){
33+
children.push(pid);
34+
}else{
35+
childrenByParentPid.set(ppid,[pid]);
36+
}
37+
}
38+
39+
constprocessFamily=newSet<number>([terminalPid]);
40+
constpendingParents=[terminalPid];
41+
while(pendingParents.length>0){
42+
constparentPid=pendingParents.shift();
43+
if(!parentPid)continue;
44+
constchildPids=childrenByParentPid.get(parentPid);
45+
if(!childPids||childPids.length===0)continue;
46+
for(constchildPidofchildPids){
47+
if(processFamily.has(childPid))continue;
48+
processFamily.add(childPid);
49+
pendingParents.push(childPid);
50+
}
51+
}
52+
53+
return[...processFamily];
2554
}catch{
2655
return[];
2756
}

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ import { APP_STAGE_LABEL, APP_VERSION } from "../branding";
6161
import{isTerminalFocused}from"../lib/terminalFocus";
6262
import{isLinuxPlatform,isMacPlatform,newCommandId,newProjectId}from"../lib/utils";
6363
import{useStore}from"../store";
64-
import{selectThreadTerminalState,useTerminalStateStore}from"../terminalStateStore";
64+
import{
65+
normalizeRunningPorts,
66+
selectThreadTerminalState,
67+
useTerminalStateStore,
68+
}from"../terminalStateStore";
6569
import{useUiStateStore}from"../uiStateStore";
6670
import{
6771
resolveShortcutCommand,
@@ -204,13 +208,6 @@ function ThreadStatusLabel({
204208
);
205209
}
206210

207-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
208-
if(!rawPorts)return[];
209-
return[...newSet(rawPorts)]
210-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
211-
.toSorted((left,right)=>left-right);
212-
}
213-
214211
functionterminalStatusFromTerminalState(
215212
runningTerminalIds: string[],
216213
runningTerminalPorts: Record<string,number[]>,

‎apps/web/src/components/ThreadTerminalDrawer.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ import {
3333
typeThreadTerminalGroup,
3434
}from"../types";
3535
import{readNativeApi}from"~/nativeApi";
36-
import{selectTerminalEventEntries,useTerminalStateStore}from"../terminalStateStore";
36+
import{
37+
normalizeRunningPorts,
38+
selectTerminalEventEntries,
39+
useTerminalStateStore,
40+
}from"../terminalStateStore";
3741

3842
constMIN_DRAWER_HEIGHT=180;
3943
constMAX_DRAWER_HEIGHT_RATIO=0.75;
@@ -81,13 +85,6 @@ interface TerminalRuntimeStatus {
8185
extraWebPortCount: number;
8286
}
8387

84-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
85-
if(!rawPorts)return[];
86-
return[...newSet(rawPorts)]
87-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
88-
.toSorted((left,right)=>left-right);
89-
}
90-
9188
functionterminalRuntimeStatus(
9289
terminalId: string,
9390
runningTerminalIds: Set<string>,

‎apps/web/src/terminalStateStore.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function normalizeRunningTerminalIds(
6262
.filter((id)=>id.length>0&&validTerminalIdSet.has(id));
6363
}
6464

65-
functionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
65+
exportfunctionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
6666
if(!ports||ports.length===0)return[];
6767
return[...newSet(ports)]
6868
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 755bf3a

Browse files
committed
Fix Windows process tree traversal, remove dead code, deduplicate normalizeRunningPorts
- win32.ts: Replace direct-child-only query with full BFS traversal (collectWindowsProcessFamilyPids) to match POSIX behavior for detecting grandchild processes and their listening ports - index.ts: Remove unused subprocessCheckerToInspector export and clean up unused type imports - Deduplicate normalizeRunningPorts by exporting from terminalStateStore and importing in Sidebar.tsx and ThreadTerminalDrawer.tsx
1 parent 05a7018 commit 755bf3a

5 files changed

Lines changed: 58 additions & 45 deletions

File tree

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import{collectPosixProcessFamilyPids,checkPosixListeningPorts}from"./posix";
2-
import{
3-
typeTerminalSubprocessActivity,
4-
typeTerminalSubprocessChecker,
5-
typeTerminalSubprocessInspector,
6-
typeTerminalWebPortInspector,
7-
}from"./types";
8-
import{checkWindowsListeningPorts,collectWindowsChildPids}from"./win32";
2+
import{typeTerminalSubprocessActivity}from"./types";
3+
import{checkWindowsListeningPorts,collectWindowsProcessFamilyPids}from"./win32";
94

105
export{arePortListsEqual,normalizeRunningPorts}from"./utils";
116

@@ -24,11 +19,15 @@ export async function defaultSubprocessInspector(
2419
}
2520

2621
if(process.platform==="win32"){
27-
constchildPids=awaitcollectWindowsChildPids(terminalPid);
28-
constprocessPidsForPortScan=[terminalPid, ...childPids];
29-
construnningPorts=awaitcheckWindowsListeningPorts(processPidsForPortScan);
22+
constprocessFamilyPids=awaitcollectWindowsProcessFamilyPids(terminalPid);
23+
if(processFamilyPids.length===0){
24+
return{hasRunningSubprocess: false,runningPorts: []};
25+
}
26+
27+
constsubprocessPids=processFamilyPids.filter((pid)=>pid!==terminalPid);
28+
construnningPorts=awaitcheckWindowsListeningPorts(processFamilyPids);
3029
return{
31-
hasRunningSubprocess: childPids.length>0||runningPorts.length>0,
30+
hasRunningSubprocess: subprocessPids.length>0||runningPorts.length>0,
3231
runningPorts,
3332
};
3433
}
@@ -45,12 +44,3 @@ export async function defaultSubprocessInspector(
4544
runningPorts,
4645
};
4746
}
48-
49-
exportfunctionsubprocessCheckerToInspector(
50-
subprocessChecker: TerminalSubprocessChecker,
51-
): TerminalSubprocessInspector{
52-
returnasync(terminalPid: number)=>({
53-
hasRunningSubprocess: awaitsubprocessChecker(terminalPid),
54-
runningPorts: [],
55-
});
56-
}

‎apps/server/src/terminalProcessInspector/win32.ts‎

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,56 @@
11
import{runProcess}from"../processRunner";
2-
import{parsePidList,parsePortList}from"./utils";
2+
import{parsePortList}from"./utils";
33

4-
exportasyncfunctioncollectWindowsChildPids(terminalPid: number): Promise<number[]>{
4+
exportasyncfunctioncollectWindowsProcessFamilyPids(terminalPid: number): Promise<number[]>{
55
constcommand=[
6-
`$children = Get-CimInstance Win32_Process -Filter "ParentProcessId = ${terminalPid}" -ErrorAction SilentlyContinue`,
7-
"if (-not $children) { exit 0 }",
8-
"$children | Select-Object -ExpandProperty ProcessId",
6+
"$procs = Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId -ErrorAction SilentlyContinue",
7+
"if (-not $procs) { exit 0 }",
8+
'$procs | ForEach-Object { "$($_.ProcessId) $($_.ParentProcessId)" }',
99
].join("; ");
1010
try{
1111
constresult=awaitrunProcess(
1212
"powershell.exe",
1313
["-NoProfile","-NonInteractive","-Command",command],
1414
{
15-
timeoutMs: 1_500,
15+
timeoutMs: 2_000,
1616
allowNonZeroExit: true,
17-
maxBufferBytes: 32_768,
17+
maxBufferBytes: 262_144,
1818
outputMode: "truncate",
1919
},
2020
);
2121
if(result.code!==0){
2222
return[];
2323
}
24-
returnparsePidList(result.stdout);
24+
25+
constchildrenByParentPid=newMap<number,number[]>();
26+
for(constlineofresult.stdout.split(/\r?\n/g)){
27+
const[pidRaw,ppidRaw]=line.trim().split(/\s+/g);
28+
constpid=Number(pidRaw);
29+
constppid=Number(ppidRaw);
30+
if(!Number.isInteger(pid)||!Number.isInteger(ppid))continue;
31+
constchildren=childrenByParentPid.get(ppid);
32+
if(children){
33+
children.push(pid);
34+
}else{
35+
childrenByParentPid.set(ppid,[pid]);
36+
}
37+
}
38+
39+
constprocessFamily=newSet<number>([terminalPid]);
40+
constpendingParents=[terminalPid];
41+
while(pendingParents.length>0){
42+
constparentPid=pendingParents.shift();
43+
if(!parentPid)continue;
44+
constchildPids=childrenByParentPid.get(parentPid);
45+
if(!childPids||childPids.length===0)continue;
46+
for(constchildPidofchildPids){
47+
if(processFamily.has(childPid))continue;
48+
processFamily.add(childPid);
49+
pendingParents.push(childPid);
50+
}
51+
}
52+
53+
return[...processFamily];
2554
}catch{
2655
return[];
2756
}

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ import { APP_STAGE_LABEL, APP_VERSION } from "../branding";
6161
import{isTerminalFocused}from"../lib/terminalFocus";
6262
import{isLinuxPlatform,isMacPlatform,newCommandId,newProjectId}from"../lib/utils";
6363
import{useStore}from"../store";
64-
import{selectThreadTerminalState,useTerminalStateStore}from"../terminalStateStore";
64+
import{
65+
normalizeRunningPorts,
66+
selectThreadTerminalState,
67+
useTerminalStateStore,
68+
}from"../terminalStateStore";
6569
import{useUiStateStore}from"../uiStateStore";
6670
import{
6771
resolveShortcutCommand,
@@ -204,13 +208,6 @@ function ThreadStatusLabel({
204208
);
205209
}
206210

207-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
208-
if(!rawPorts)return[];
209-
return[...newSet(rawPorts)]
210-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
211-
.toSorted((left,right)=>left-right);
212-
}
213-
214211
functionterminalStatusFromTerminalState(
215212
runningTerminalIds: string[],
216213
runningTerminalPorts: Record<string,number[]>,

‎apps/web/src/components/ThreadTerminalDrawer.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ import {
3333
typeThreadTerminalGroup,
3434
}from"../types";
3535
import{readNativeApi}from"~/nativeApi";
36-
import{selectTerminalEventEntries,useTerminalStateStore}from"../terminalStateStore";
36+
import{
37+
normalizeRunningPorts,
38+
selectTerminalEventEntries,
39+
useTerminalStateStore,
40+
}from"../terminalStateStore";
3741

3842
constMIN_DRAWER_HEIGHT=180;
3943
constMAX_DRAWER_HEIGHT_RATIO=0.75;
@@ -81,13 +85,6 @@ interface TerminalRuntimeStatus {
8185
extraWebPortCount: number;
8286
}
8387

84-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
85-
if(!rawPorts)return[];
86-
return[...newSet(rawPorts)]
87-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
88-
.toSorted((left,right)=>left-right);
89-
}
90-
9188
functionterminalRuntimeStatus(
9289
terminalId: string,
9390
runningTerminalIds: Set<string>,

‎apps/web/src/terminalStateStore.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function normalizeRunningTerminalIds(
6262
.filter((id)=>id.length>0&&validTerminalIdSet.has(id));
6363
}
6464

65-
functionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
65+
exportfunctionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
6666
if(!ports||ports.length===0)return[];
6767
return[...newSet(ports)]
6868
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 755bf3a

Browse files
committed
Fix Windows process tree traversal, remove dead code, deduplicate normalizeRunningPorts
- win32.ts: Replace direct-child-only query with full BFS traversal (collectWindowsProcessFamilyPids) to match POSIX behavior for detecting grandchild processes and their listening ports - index.ts: Remove unused subprocessCheckerToInspector export and clean up unused type imports - Deduplicate normalizeRunningPorts by exporting from terminalStateStore and importing in Sidebar.tsx and ThreadTerminalDrawer.tsx
1 parent 05a7018 commit 755bf3a

5 files changed

Lines changed: 58 additions & 45 deletions

File tree

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import{collectPosixProcessFamilyPids,checkPosixListeningPorts}from"./posix";
2-
import{
3-
typeTerminalSubprocessActivity,
4-
typeTerminalSubprocessChecker,
5-
typeTerminalSubprocessInspector,
6-
typeTerminalWebPortInspector,
7-
}from"./types";
8-
import{checkWindowsListeningPorts,collectWindowsChildPids}from"./win32";
2+
import{typeTerminalSubprocessActivity}from"./types";
3+
import{checkWindowsListeningPorts,collectWindowsProcessFamilyPids}from"./win32";
94

105
export{arePortListsEqual,normalizeRunningPorts}from"./utils";
116

@@ -24,11 +19,15 @@ export async function defaultSubprocessInspector(
2419
}
2520

2621
if(process.platform==="win32"){
27-
constchildPids=awaitcollectWindowsChildPids(terminalPid);
28-
constprocessPidsForPortScan=[terminalPid, ...childPids];
29-
construnningPorts=awaitcheckWindowsListeningPorts(processPidsForPortScan);
22+
constprocessFamilyPids=awaitcollectWindowsProcessFamilyPids(terminalPid);
23+
if(processFamilyPids.length===0){
24+
return{hasRunningSubprocess: false,runningPorts: []};
25+
}
26+
27+
constsubprocessPids=processFamilyPids.filter((pid)=>pid!==terminalPid);
28+
construnningPorts=awaitcheckWindowsListeningPorts(processFamilyPids);
3029
return{
31-
hasRunningSubprocess: childPids.length>0||runningPorts.length>0,
30+
hasRunningSubprocess: subprocessPids.length>0||runningPorts.length>0,
3231
runningPorts,
3332
};
3433
}
@@ -45,12 +44,3 @@ export async function defaultSubprocessInspector(
4544
runningPorts,
4645
};
4746
}
48-
49-
exportfunctionsubprocessCheckerToInspector(
50-
subprocessChecker: TerminalSubprocessChecker,
51-
): TerminalSubprocessInspector{
52-
returnasync(terminalPid: number)=>({
53-
hasRunningSubprocess: awaitsubprocessChecker(terminalPid),
54-
runningPorts: [],
55-
});
56-
}

‎apps/server/src/terminalProcessInspector/win32.ts‎

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,56 @@
11
import{runProcess}from"../processRunner";
2-
import{parsePidList,parsePortList}from"./utils";
2+
import{parsePortList}from"./utils";
33

4-
exportasyncfunctioncollectWindowsChildPids(terminalPid: number): Promise<number[]>{
4+
exportasyncfunctioncollectWindowsProcessFamilyPids(terminalPid: number): Promise<number[]>{
55
constcommand=[
6-
`$children = Get-CimInstance Win32_Process -Filter "ParentProcessId = ${terminalPid}" -ErrorAction SilentlyContinue`,
7-
"if (-not $children) { exit 0 }",
8-
"$children | Select-Object -ExpandProperty ProcessId",
6+
"$procs = Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId -ErrorAction SilentlyContinue",
7+
"if (-not $procs) { exit 0 }",
8+
'$procs | ForEach-Object { "$($_.ProcessId) $($_.ParentProcessId)" }',
99
].join("; ");
1010
try{
1111
constresult=awaitrunProcess(
1212
"powershell.exe",
1313
["-NoProfile","-NonInteractive","-Command",command],
1414
{
15-
timeoutMs: 1_500,
15+
timeoutMs: 2_000,
1616
allowNonZeroExit: true,
17-
maxBufferBytes: 32_768,
17+
maxBufferBytes: 262_144,
1818
outputMode: "truncate",
1919
},
2020
);
2121
if(result.code!==0){
2222
return[];
2323
}
24-
returnparsePidList(result.stdout);
24+
25+
constchildrenByParentPid=newMap<number,number[]>();
26+
for(constlineofresult.stdout.split(/\r?\n/g)){
27+
const[pidRaw,ppidRaw]=line.trim().split(/\s+/g);
28+
constpid=Number(pidRaw);
29+
constppid=Number(ppidRaw);
30+
if(!Number.isInteger(pid)||!Number.isInteger(ppid))continue;
31+
constchildren=childrenByParentPid.get(ppid);
32+
if(children){
33+
children.push(pid);
34+
}else{
35+
childrenByParentPid.set(ppid,[pid]);
36+
}
37+
}
38+
39+
constprocessFamily=newSet<number>([terminalPid]);
40+
constpendingParents=[terminalPid];
41+
while(pendingParents.length>0){
42+
constparentPid=pendingParents.shift();
43+
if(!parentPid)continue;
44+
constchildPids=childrenByParentPid.get(parentPid);
45+
if(!childPids||childPids.length===0)continue;
46+
for(constchildPidofchildPids){
47+
if(processFamily.has(childPid))continue;
48+
processFamily.add(childPid);
49+
pendingParents.push(childPid);
50+
}
51+
}
52+
53+
return[...processFamily];
2554
}catch{
2655
return[];
2756
}

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ import { APP_STAGE_LABEL, APP_VERSION } from "../branding";
6161
import{isTerminalFocused}from"../lib/terminalFocus";
6262
import{isLinuxPlatform,isMacPlatform,newCommandId,newProjectId}from"../lib/utils";
6363
import{useStore}from"../store";
64-
import{selectThreadTerminalState,useTerminalStateStore}from"../terminalStateStore";
64+
import{
65+
normalizeRunningPorts,
66+
selectThreadTerminalState,
67+
useTerminalStateStore,
68+
}from"../terminalStateStore";
6569
import{useUiStateStore}from"../uiStateStore";
6670
import{
6771
resolveShortcutCommand,
@@ -204,13 +208,6 @@ function ThreadStatusLabel({
204208
);
205209
}
206210

207-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
208-
if(!rawPorts)return[];
209-
return[...newSet(rawPorts)]
210-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
211-
.toSorted((left,right)=>left-right);
212-
}
213-
214211
functionterminalStatusFromTerminalState(
215212
runningTerminalIds: string[],
216213
runningTerminalPorts: Record<string,number[]>,

‎apps/web/src/components/ThreadTerminalDrawer.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ import {
3333
typeThreadTerminalGroup,
3434
}from"../types";
3535
import{readNativeApi}from"~/nativeApi";
36-
import{selectTerminalEventEntries,useTerminalStateStore}from"../terminalStateStore";
36+
import{
37+
normalizeRunningPorts,
38+
selectTerminalEventEntries,
39+
useTerminalStateStore,
40+
}from"../terminalStateStore";
3741

3842
constMIN_DRAWER_HEIGHT=180;
3943
constMAX_DRAWER_HEIGHT_RATIO=0.75;
@@ -81,13 +85,6 @@ interface TerminalRuntimeStatus {
8185
extraWebPortCount: number;
8286
}
8387

84-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
85-
if(!rawPorts)return[];
86-
return[...newSet(rawPorts)]
87-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
88-
.toSorted((left,right)=>left-right);
89-
}
90-
9188
functionterminalRuntimeStatus(
9289
terminalId: string,
9390
runningTerminalIds: Set<string>,

‎apps/web/src/terminalStateStore.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function normalizeRunningTerminalIds(
6262
.filter((id)=>id.length>0&&validTerminalIdSet.has(id));
6363
}
6464

65-
functionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
65+
exportfunctionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
6666
if(!ports||ports.length===0)return[];
6767
return[...newSet(ports)]
6868
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 755bf3a

Browse files
committed
Fix Windows process tree traversal, remove dead code, deduplicate normalizeRunningPorts
- win32.ts: Replace direct-child-only query with full BFS traversal (collectWindowsProcessFamilyPids) to match POSIX behavior for detecting grandchild processes and their listening ports - index.ts: Remove unused subprocessCheckerToInspector export and clean up unused type imports - Deduplicate normalizeRunningPorts by exporting from terminalStateStore and importing in Sidebar.tsx and ThreadTerminalDrawer.tsx
1 parent 05a7018 commit 755bf3a

5 files changed

Lines changed: 58 additions & 45 deletions

File tree

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import{collectPosixProcessFamilyPids,checkPosixListeningPorts}from"./posix";
2-
import{
3-
typeTerminalSubprocessActivity,
4-
typeTerminalSubprocessChecker,
5-
typeTerminalSubprocessInspector,
6-
typeTerminalWebPortInspector,
7-
}from"./types";
8-
import{checkWindowsListeningPorts,collectWindowsChildPids}from"./win32";
2+
import{typeTerminalSubprocessActivity}from"./types";
3+
import{checkWindowsListeningPorts,collectWindowsProcessFamilyPids}from"./win32";
94

105
export{arePortListsEqual,normalizeRunningPorts}from"./utils";
116

@@ -24,11 +19,15 @@ export async function defaultSubprocessInspector(
2419
}
2520

2621
if(process.platform==="win32"){
27-
constchildPids=awaitcollectWindowsChildPids(terminalPid);
28-
constprocessPidsForPortScan=[terminalPid, ...childPids];
29-
construnningPorts=awaitcheckWindowsListeningPorts(processPidsForPortScan);
22+
constprocessFamilyPids=awaitcollectWindowsProcessFamilyPids(terminalPid);
23+
if(processFamilyPids.length===0){
24+
return{hasRunningSubprocess: false,runningPorts: []};
25+
}
26+
27+
constsubprocessPids=processFamilyPids.filter((pid)=>pid!==terminalPid);
28+
construnningPorts=awaitcheckWindowsListeningPorts(processFamilyPids);
3029
return{
31-
hasRunningSubprocess: childPids.length>0||runningPorts.length>0,
30+
hasRunningSubprocess: subprocessPids.length>0||runningPorts.length>0,
3231
runningPorts,
3332
};
3433
}
@@ -45,12 +44,3 @@ export async function defaultSubprocessInspector(
4544
runningPorts,
4645
};
4746
}
48-
49-
exportfunctionsubprocessCheckerToInspector(
50-
subprocessChecker: TerminalSubprocessChecker,
51-
): TerminalSubprocessInspector{
52-
returnasync(terminalPid: number)=>({
53-
hasRunningSubprocess: awaitsubprocessChecker(terminalPid),
54-
runningPorts: [],
55-
});
56-
}

‎apps/server/src/terminalProcessInspector/win32.ts‎

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,56 @@
11
import{runProcess}from"../processRunner";
2-
import{parsePidList,parsePortList}from"./utils";
2+
import{parsePortList}from"./utils";
33

4-
exportasyncfunctioncollectWindowsChildPids(terminalPid: number): Promise<number[]>{
4+
exportasyncfunctioncollectWindowsProcessFamilyPids(terminalPid: number): Promise<number[]>{
55
constcommand=[
6-
`$children = Get-CimInstance Win32_Process -Filter "ParentProcessId = ${terminalPid}" -ErrorAction SilentlyContinue`,
7-
"if (-not $children) { exit 0 }",
8-
"$children | Select-Object -ExpandProperty ProcessId",
6+
"$procs = Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId -ErrorAction SilentlyContinue",
7+
"if (-not $procs) { exit 0 }",
8+
'$procs | ForEach-Object { "$($_.ProcessId) $($_.ParentProcessId)" }',
99
].join("; ");
1010
try{
1111
constresult=awaitrunProcess(
1212
"powershell.exe",
1313
["-NoProfile","-NonInteractive","-Command",command],
1414
{
15-
timeoutMs: 1_500,
15+
timeoutMs: 2_000,
1616
allowNonZeroExit: true,
17-
maxBufferBytes: 32_768,
17+
maxBufferBytes: 262_144,
1818
outputMode: "truncate",
1919
},
2020
);
2121
if(result.code!==0){
2222
return[];
2323
}
24-
returnparsePidList(result.stdout);
24+
25+
constchildrenByParentPid=newMap<number,number[]>();
26+
for(constlineofresult.stdout.split(/\r?\n/g)){
27+
const[pidRaw,ppidRaw]=line.trim().split(/\s+/g);
28+
constpid=Number(pidRaw);
29+
constppid=Number(ppidRaw);
30+
if(!Number.isInteger(pid)||!Number.isInteger(ppid))continue;
31+
constchildren=childrenByParentPid.get(ppid);
32+
if(children){
33+
children.push(pid);
34+
}else{
35+
childrenByParentPid.set(ppid,[pid]);
36+
}
37+
}
38+
39+
constprocessFamily=newSet<number>([terminalPid]);
40+
constpendingParents=[terminalPid];
41+
while(pendingParents.length>0){
42+
constparentPid=pendingParents.shift();
43+
if(!parentPid)continue;
44+
constchildPids=childrenByParentPid.get(parentPid);
45+
if(!childPids||childPids.length===0)continue;
46+
for(constchildPidofchildPids){
47+
if(processFamily.has(childPid))continue;
48+
processFamily.add(childPid);
49+
pendingParents.push(childPid);
50+
}
51+
}
52+
53+
return[...processFamily];
2554
}catch{
2655
return[];
2756
}

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ import { APP_STAGE_LABEL, APP_VERSION } from "../branding";
6161
import{isTerminalFocused}from"../lib/terminalFocus";
6262
import{isLinuxPlatform,isMacPlatform,newCommandId,newProjectId}from"../lib/utils";
6363
import{useStore}from"../store";
64-
import{selectThreadTerminalState,useTerminalStateStore}from"../terminalStateStore";
64+
import{
65+
normalizeRunningPorts,
66+
selectThreadTerminalState,
67+
useTerminalStateStore,
68+
}from"../terminalStateStore";
6569
import{useUiStateStore}from"../uiStateStore";
6670
import{
6771
resolveShortcutCommand,
@@ -204,13 +208,6 @@ function ThreadStatusLabel({
204208
);
205209
}
206210

207-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
208-
if(!rawPorts)return[];
209-
return[...newSet(rawPorts)]
210-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
211-
.toSorted((left,right)=>left-right);
212-
}
213-
214211
functionterminalStatusFromTerminalState(
215212
runningTerminalIds: string[],
216213
runningTerminalPorts: Record<string,number[]>,

‎apps/web/src/components/ThreadTerminalDrawer.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ import {
3333
typeThreadTerminalGroup,
3434
}from"../types";
3535
import{readNativeApi}from"~/nativeApi";
36-
import{selectTerminalEventEntries,useTerminalStateStore}from"../terminalStateStore";
36+
import{
37+
normalizeRunningPorts,
38+
selectTerminalEventEntries,
39+
useTerminalStateStore,
40+
}from"../terminalStateStore";
3741

3842
constMIN_DRAWER_HEIGHT=180;
3943
constMAX_DRAWER_HEIGHT_RATIO=0.75;
@@ -81,13 +85,6 @@ interface TerminalRuntimeStatus {
8185
extraWebPortCount: number;
8286
}
8387

84-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
85-
if(!rawPorts)return[];
86-
return[...newSet(rawPorts)]
87-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
88-
.toSorted((left,right)=>left-right);
89-
}
90-
9188
functionterminalRuntimeStatus(
9289
terminalId: string,
9390
runningTerminalIds: Set<string>,

‎apps/web/src/terminalStateStore.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function normalizeRunningTerminalIds(
6262
.filter((id)=>id.length>0&&validTerminalIdSet.has(id));
6363
}
6464

65-
functionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
65+
exportfunctionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
6666
if(!ports||ports.length===0)return[];
6767
return[...newSet(ports)]
6868
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 755bf3a

Browse files
committed
Fix Windows process tree traversal, remove dead code, deduplicate normalizeRunningPorts
- win32.ts: Replace direct-child-only query with full BFS traversal (collectWindowsProcessFamilyPids) to match POSIX behavior for detecting grandchild processes and their listening ports - index.ts: Remove unused subprocessCheckerToInspector export and clean up unused type imports - Deduplicate normalizeRunningPorts by exporting from terminalStateStore and importing in Sidebar.tsx and ThreadTerminalDrawer.tsx
1 parent 05a7018 commit 755bf3a

5 files changed

Lines changed: 58 additions & 45 deletions

File tree

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import{collectPosixProcessFamilyPids,checkPosixListeningPorts}from"./posix";
2-
import{
3-
typeTerminalSubprocessActivity,
4-
typeTerminalSubprocessChecker,
5-
typeTerminalSubprocessInspector,
6-
typeTerminalWebPortInspector,
7-
}from"./types";
8-
import{checkWindowsListeningPorts,collectWindowsChildPids}from"./win32";
2+
import{typeTerminalSubprocessActivity}from"./types";
3+
import{checkWindowsListeningPorts,collectWindowsProcessFamilyPids}from"./win32";
94

105
export{arePortListsEqual,normalizeRunningPorts}from"./utils";
116

@@ -24,11 +19,15 @@ export async function defaultSubprocessInspector(
2419
}
2520

2621
if(process.platform==="win32"){
27-
constchildPids=awaitcollectWindowsChildPids(terminalPid);
28-
constprocessPidsForPortScan=[terminalPid, ...childPids];
29-
construnningPorts=awaitcheckWindowsListeningPorts(processPidsForPortScan);
22+
constprocessFamilyPids=awaitcollectWindowsProcessFamilyPids(terminalPid);
23+
if(processFamilyPids.length===0){
24+
return{hasRunningSubprocess: false,runningPorts: []};
25+
}
26+
27+
constsubprocessPids=processFamilyPids.filter((pid)=>pid!==terminalPid);
28+
construnningPorts=awaitcheckWindowsListeningPorts(processFamilyPids);
3029
return{
31-
hasRunningSubprocess: childPids.length>0||runningPorts.length>0,
30+
hasRunningSubprocess: subprocessPids.length>0||runningPorts.length>0,
3231
runningPorts,
3332
};
3433
}
@@ -45,12 +44,3 @@ export async function defaultSubprocessInspector(
4544
runningPorts,
4645
};
4746
}
48-
49-
exportfunctionsubprocessCheckerToInspector(
50-
subprocessChecker: TerminalSubprocessChecker,
51-
): TerminalSubprocessInspector{
52-
returnasync(terminalPid: number)=>({
53-
hasRunningSubprocess: awaitsubprocessChecker(terminalPid),
54-
runningPorts: [],
55-
});
56-
}

‎apps/server/src/terminalProcessInspector/win32.ts‎

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,56 @@
11
import{runProcess}from"../processRunner";
2-
import{parsePidList,parsePortList}from"./utils";
2+
import{parsePortList}from"./utils";
33

4-
exportasyncfunctioncollectWindowsChildPids(terminalPid: number): Promise<number[]>{
4+
exportasyncfunctioncollectWindowsProcessFamilyPids(terminalPid: number): Promise<number[]>{
55
constcommand=[
6-
`$children = Get-CimInstance Win32_Process -Filter "ParentProcessId = ${terminalPid}" -ErrorAction SilentlyContinue`,
7-
"if (-not $children) { exit 0 }",
8-
"$children | Select-Object -ExpandProperty ProcessId",
6+
"$procs = Get-CimInstance Win32_Process -Property ProcessId,ParentProcessId -ErrorAction SilentlyContinue",
7+
"if (-not $procs) { exit 0 }",
8+
'$procs | ForEach-Object { "$($_.ProcessId) $($_.ParentProcessId)" }',
99
].join("; ");
1010
try{
1111
constresult=awaitrunProcess(
1212
"powershell.exe",
1313
["-NoProfile","-NonInteractive","-Command",command],
1414
{
15-
timeoutMs: 1_500,
15+
timeoutMs: 2_000,
1616
allowNonZeroExit: true,
17-
maxBufferBytes: 32_768,
17+
maxBufferBytes: 262_144,
1818
outputMode: "truncate",
1919
},
2020
);
2121
if(result.code!==0){
2222
return[];
2323
}
24-
returnparsePidList(result.stdout);
24+
25+
constchildrenByParentPid=newMap<number,number[]>();
26+
for(constlineofresult.stdout.split(/\r?\n/g)){
27+
const[pidRaw,ppidRaw]=line.trim().split(/\s+/g);
28+
constpid=Number(pidRaw);
29+
constppid=Number(ppidRaw);
30+
if(!Number.isInteger(pid)||!Number.isInteger(ppid))continue;
31+
constchildren=childrenByParentPid.get(ppid);
32+
if(children){
33+
children.push(pid);
34+
}else{
35+
childrenByParentPid.set(ppid,[pid]);
36+
}
37+
}
38+
39+
constprocessFamily=newSet<number>([terminalPid]);
40+
constpendingParents=[terminalPid];
41+
while(pendingParents.length>0){
42+
constparentPid=pendingParents.shift();
43+
if(!parentPid)continue;
44+
constchildPids=childrenByParentPid.get(parentPid);
45+
if(!childPids||childPids.length===0)continue;
46+
for(constchildPidofchildPids){
47+
if(processFamily.has(childPid))continue;
48+
processFamily.add(childPid);
49+
pendingParents.push(childPid);
50+
}
51+
}
52+
53+
return[...processFamily];
2554
}catch{
2655
return[];
2756
}

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ import { APP_STAGE_LABEL, APP_VERSION } from "../branding";
6161
import{isTerminalFocused}from"../lib/terminalFocus";
6262
import{isLinuxPlatform,isMacPlatform,newCommandId,newProjectId}from"../lib/utils";
6363
import{useStore}from"../store";
64-
import{selectThreadTerminalState,useTerminalStateStore}from"../terminalStateStore";
64+
import{
65+
normalizeRunningPorts,
66+
selectThreadTerminalState,
67+
useTerminalStateStore,
68+
}from"../terminalStateStore";
6569
import{useUiStateStore}from"../uiStateStore";
6670
import{
6771
resolveShortcutCommand,
@@ -204,13 +208,6 @@ function ThreadStatusLabel({
204208
);
205209
}
206210

207-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
208-
if(!rawPorts)return[];
209-
return[...newSet(rawPorts)]
210-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
211-
.toSorted((left,right)=>left-right);
212-
}
213-
214211
functionterminalStatusFromTerminalState(
215212
runningTerminalIds: string[],
216213
runningTerminalPorts: Record<string,number[]>,

‎apps/web/src/components/ThreadTerminalDrawer.tsx‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ import {
3333
typeThreadTerminalGroup,
3434
}from"../types";
3535
import{readNativeApi}from"~/nativeApi";
36-
import{selectTerminalEventEntries,useTerminalStateStore}from"../terminalStateStore";
36+
import{
37+
normalizeRunningPorts,
38+
selectTerminalEventEntries,
39+
useTerminalStateStore,
40+
}from"../terminalStateStore";
3741

3842
constMIN_DRAWER_HEIGHT=180;
3943
constMAX_DRAWER_HEIGHT_RATIO=0.75;
@@ -81,13 +85,6 @@ interface TerminalRuntimeStatus {
8185
extraWebPortCount: number;
8286
}
8387

84-
functionnormalizeRunningPorts(rawPorts: number[]|undefined): number[]{
85-
if(!rawPorts)return[];
86-
return[...newSet(rawPorts)]
87-
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)
88-
.toSorted((left,right)=>left-right);
89-
}
90-
9188
functionterminalRuntimeStatus(
9289
terminalId: string,
9390
runningTerminalIds: Set<string>,

‎apps/web/src/terminalStateStore.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function normalizeRunningTerminalIds(
6262
.filter((id)=>id.length>0&&validTerminalIdSet.has(id));
6363
}
6464

65-
functionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
65+
exportfunctionnormalizeRunningPorts(ports: readonlynumber[]|undefined): number[]{
6666
if(!ports||ports.length===0)return[];
6767
return[...newSet(ports)]
6868
.filter((port)=>Number.isInteger(port)&&port>0&&port<=65_535)

0 commit comments

Comments
 (0)