Commit 78f235d

Browse files
committed
Fix preview automation: surface not-editable error, decouple zoom from nav sync, fix clear-only type
Bug 1: NotEditable error not surfaced - The desktop-side PreviewAutomationTargetNotEditableError was lost when crossing the Electron IPC boundary, causing agents/MCP to see a generic PreviewAutomationExecutionError instead of a structured not-editable response. - Changed the automationType IPC handler to catch the error and return it as structured data ({ notEditable: true }) instead of throwing. - Added a web-side PreviewAutomationTargetNotEditableError class with its own responseTag to the PreviewAutomationHostError union. - Updated PreviewAutomationHosts to detect the structured result and throw the web-side error for proper serialization. Bug 2: Zoom read blocks nav sync - syncWebContentsState read getZoomFactor through the same failing attempt path as navigation fields. If zoom lookup threw, the whole sync aborted and listeners like did-stop-loading never updated navStatus. - Made the zoom factor read non-fatal with Effect.orElseSucceed, falling back to the current tab's zoomFactor when the read fails. Bug 3: Clear-only type fails incorrectly - When clear:true with empty text, the in-page typing path used document.execCommand('delete') which often returns false on many inputs, incorrectly reporting PreviewAutomationTargetNotEditableError. - Changed clear-only logic to directly set element.value or textContent to empty instead of relying on execCommand('delete').
1 parent 27afced commit 78f235d

5 files changed

Lines changed: 55 additions & 12 deletions

File tree

‎apps/desktop/src/ipc/methods/preview.ts‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,17 @@ export const automationClick = DesktopIpc.makeIpcMethod({
277277
exportconstautomationType=DesktopIpc.makeIpcMethod({
278278
channel: IpcChannels.PREVIEW_AUTOMATION_TYPE_CHANNEL,
279279
payload: DesktopPreviewAutomationTypeInputSchema,
280-
result: Schema.Void,
281-
handler: Effect.fn("desktop.ipc.preview.automationType")(function*({ tabId, input }){
282-
constmanager=yield*PreviewManager.PreviewManager;
283-
yield*manager.automationType(tabId,input);
284-
}),
280+
result: Schema.NullOr(Schema.Struct({notEditable: Schema.Literal(true)})),
281+
handler: Effect.fn("desktop.ipc.preview.automationType")(
282+
function*({ tabId, input }){
283+
constmanager=yield*PreviewManager.PreviewManager;
284+
yield*manager.automationType(tabId,input);
285+
returnnull;
286+
},
287+
Effect.catchTag("PreviewAutomationTargetNotEditableError",()=>
288+
Effect.succeed({notEditable: trueasconst}),
289+
),
290+
),
285291
});
286292

287293
exportconstautomationPress=DesktopIpc.makeIpcMethod({

‎apps/desktop/src/preview/Manager.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11091109
constzoomFactor=yield*attempt(
11101110
{operation: "syncWebContentsState.getZoomFactor", tabId,webContentsId: wc.id},
11111111
()=>wc.getZoomFactor(),
1112-
);
1112+
).pipe(Effect.orElseSucceed(()=>undefinedasnumber|undefined));
11131113
constcomputedNavStatus=computeNavStatus(wc);
11141114
constcanGoBack=wc.navigationHistory.canGoBack();
11151115
constcanGoForward=wc.navigationHistory.canGoForward();
@@ -1129,7 +1129,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11291129
navStatus,
11301130
canGoBack,
11311131
canGoForward,
1132-
zoomFactor,
1132+
zoomFactor: zoomFactor??current.zoomFactor,
11331133
updatedAt,
11341134
};
11351135
return[
@@ -2108,9 +2108,12 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
21082108
}
21092109
}
21102110
const text = ${textJson};
2111-
const inserted = text.length > 0
2112-
? document.execCommand("insertText", false, text)
2113-
: !clear || document.execCommand("delete", false);
2111+
let inserted = true;
2112+
if (text.length > 0) {
2113+
inserted = document.execCommand("insertText", false, text);
2114+
} else if (clear) {
2115+
if (textControl) { element.value = ""; } else { element.textContent = ""; }
2116+
}
21142117
if (!inserted) return { notEditable: true };
21152118
element.dispatchEvent(new Event("change", { bubbles: true }));
21162119
return { ok: true };

‎apps/web/src/components/preview/PreviewAutomationHosts.tsx‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import {
4747
PreviewAutomationOperationError,
4848
PreviewAutomationOverlayTimeoutError,
4949
PreviewAutomationRecordingNotActiveError,
50+
PreviewAutomationTargetNotEditableError,
5051
PreviewAutomationTargetUnavailableError,
5152
}from"./previewAutomationErrors";
5253
import{createPreviewAutomationRequestConsumerAtom}from"./previewAutomationRequestConsumer";
@@ -429,10 +430,20 @@ function PreviewAutomationHost(props: { readonly environmentId: EnvironmentId })
429430
}
430431
case"type": {
431432
constready=awaitrequireReadyTab();
432-
returnawaitready.bridge.automation.type(
433+
consttypeResult=awaitready.bridge.automation.type(
433434
ready.tabId,
434435
request.inputasParameters<typeofready.bridge.automation.type>[1],
435436
);
437+
if(typeResult&&typeoftypeResult==="object"&&"notEditable"intypeResult){
438+
thrownewPreviewAutomationTargetNotEditableError({
439+
requestId: request.requestId,
440+
operation: request.operation,
441+
environmentId,
442+
threadId: request.threadId,
443+
tabId: ready.tabId,
444+
});
445+
}
446+
returntypeResult;
436447
}
437448
case"press": {
438449
constready=awaitrequireReadyTab();

‎apps/web/src/components/preview/previewAutomationErrors.ts‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,31 @@ export class PreviewAutomationOperationError extends Schema.TaggedErrorClass<Pre
122122
}
123123
}
124124

125+
exportclassPreviewAutomationTargetNotEditableErrorextendsSchema.TaggedErrorClass<PreviewAutomationTargetNotEditableError>()(
126+
"PreviewAutomationTargetNotEditableError",
127+
{
128+
requestId: TrimmedNonEmptyString,
129+
operation: PreviewAutomationOperation,
130+
environmentId: EnvironmentId,
131+
threadId: ThreadId,
132+
tabId: Schema.NullOr(PreviewTabId),
133+
},
134+
){
135+
getresponseTag(){
136+
return"PreviewAutomationTargetNotEditableError"asconst;
137+
}
138+
139+
overridegetmessage(): string{
140+
return`Preview automation ${this.operation} target is not editable for request ${this.requestId} on environment ${this.environmentId} thread ${this.threadId} (tab ${this.tabId??"unassigned"}).`;
141+
}
142+
}
143+
125144
exportconstPreviewAutomationHostError=Schema.Union([
126145
PreviewAutomationOverlayTimeoutError,
127146
PreviewAutomationNavigationTimeoutError,
128147
PreviewAutomationTargetUnavailableError,
129148
PreviewAutomationRecordingNotActiveError,
149+
PreviewAutomationTargetNotEditableError,
130150
PreviewAutomationOperationError,
131151
]);
132152
exporttypePreviewAutomationHostError=typeofPreviewAutomationHostError.Type;

‎packages/contracts/src/ipc.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,10 @@ export interface DesktopPreviewBridge {
987987
status: (tabId: string)=>Promise<PreviewAutomationStatus>;
988988
snapshot: (tabId: string)=>Promise<PreviewAutomationSnapshot>;
989989
click: (tabId: string,input: PreviewAutomationClickInput)=>Promise<void>;
990-
type: (tabId: string,input: PreviewAutomationTypeInput)=>Promise<void>;
990+
type: (
991+
tabId: string,
992+
input: PreviewAutomationTypeInput,
993+
)=>Promise<void|{notEditable: true}>;
991994
press: (tabId: string,input: PreviewAutomationPressInput)=>Promise<void>;
992995
scroll: (tabId: string,input: PreviewAutomationScrollInput)=>Promise<void>;
993996
evaluate: (tabId: string,input: PreviewAutomationEvaluateInput)=>Promise<unknown>;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 78f235d

Browse files
committed
Fix preview automation: surface not-editable error, decouple zoom from nav sync, fix clear-only type
Bug 1: NotEditable error not surfaced - The desktop-side PreviewAutomationTargetNotEditableError was lost when crossing the Electron IPC boundary, causing agents/MCP to see a generic PreviewAutomationExecutionError instead of a structured not-editable response. - Changed the automationType IPC handler to catch the error and return it as structured data ({ notEditable: true }) instead of throwing. - Added a web-side PreviewAutomationTargetNotEditableError class with its own responseTag to the PreviewAutomationHostError union. - Updated PreviewAutomationHosts to detect the structured result and throw the web-side error for proper serialization. Bug 2: Zoom read blocks nav sync - syncWebContentsState read getZoomFactor through the same failing attempt path as navigation fields. If zoom lookup threw, the whole sync aborted and listeners like did-stop-loading never updated navStatus. - Made the zoom factor read non-fatal with Effect.orElseSucceed, falling back to the current tab's zoomFactor when the read fails. Bug 3: Clear-only type fails incorrectly - When clear:true with empty text, the in-page typing path used document.execCommand('delete') which often returns false on many inputs, incorrectly reporting PreviewAutomationTargetNotEditableError. - Changed clear-only logic to directly set element.value or textContent to empty instead of relying on execCommand('delete').
1 parent 27afced commit 78f235d

5 files changed

Lines changed: 55 additions & 12 deletions

File tree

‎apps/desktop/src/ipc/methods/preview.ts‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,17 @@ export const automationClick = DesktopIpc.makeIpcMethod({
277277
exportconstautomationType=DesktopIpc.makeIpcMethod({
278278
channel: IpcChannels.PREVIEW_AUTOMATION_TYPE_CHANNEL,
279279
payload: DesktopPreviewAutomationTypeInputSchema,
280-
result: Schema.Void,
281-
handler: Effect.fn("desktop.ipc.preview.automationType")(function*({ tabId, input }){
282-
constmanager=yield*PreviewManager.PreviewManager;
283-
yield*manager.automationType(tabId,input);
284-
}),
280+
result: Schema.NullOr(Schema.Struct({notEditable: Schema.Literal(true)})),
281+
handler: Effect.fn("desktop.ipc.preview.automationType")(
282+
function*({ tabId, input }){
283+
constmanager=yield*PreviewManager.PreviewManager;
284+
yield*manager.automationType(tabId,input);
285+
returnnull;
286+
},
287+
Effect.catchTag("PreviewAutomationTargetNotEditableError",()=>
288+
Effect.succeed({notEditable: trueasconst}),
289+
),
290+
),
285291
});
286292

287293
exportconstautomationPress=DesktopIpc.makeIpcMethod({

‎apps/desktop/src/preview/Manager.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11091109
constzoomFactor=yield*attempt(
11101110
{operation: "syncWebContentsState.getZoomFactor", tabId,webContentsId: wc.id},
11111111
()=>wc.getZoomFactor(),
1112-
);
1112+
).pipe(Effect.orElseSucceed(()=>undefinedasnumber|undefined));
11131113
constcomputedNavStatus=computeNavStatus(wc);
11141114
constcanGoBack=wc.navigationHistory.canGoBack();
11151115
constcanGoForward=wc.navigationHistory.canGoForward();
@@ -1129,7 +1129,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11291129
navStatus,
11301130
canGoBack,
11311131
canGoForward,
1132-
zoomFactor,
1132+
zoomFactor: zoomFactor??current.zoomFactor,
11331133
updatedAt,
11341134
};
11351135
return[
@@ -2108,9 +2108,12 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
21082108
}
21092109
}
21102110
const text = ${textJson};
2111-
const inserted = text.length > 0
2112-
? document.execCommand("insertText", false, text)
2113-
: !clear || document.execCommand("delete", false);
2111+
let inserted = true;
2112+
if (text.length > 0) {
2113+
inserted = document.execCommand("insertText", false, text);
2114+
} else if (clear) {
2115+
if (textControl) { element.value = ""; } else { element.textContent = ""; }
2116+
}
21142117
if (!inserted) return { notEditable: true };
21152118
element.dispatchEvent(new Event("change", { bubbles: true }));
21162119
return { ok: true };

‎apps/web/src/components/preview/PreviewAutomationHosts.tsx‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import {
4747
PreviewAutomationOperationError,
4848
PreviewAutomationOverlayTimeoutError,
4949
PreviewAutomationRecordingNotActiveError,
50+
PreviewAutomationTargetNotEditableError,
5051
PreviewAutomationTargetUnavailableError,
5152
}from"./previewAutomationErrors";
5253
import{createPreviewAutomationRequestConsumerAtom}from"./previewAutomationRequestConsumer";
@@ -429,10 +430,20 @@ function PreviewAutomationHost(props: { readonly environmentId: EnvironmentId })
429430
}
430431
case"type": {
431432
constready=awaitrequireReadyTab();
432-
returnawaitready.bridge.automation.type(
433+
consttypeResult=awaitready.bridge.automation.type(
433434
ready.tabId,
434435
request.inputasParameters<typeofready.bridge.automation.type>[1],
435436
);
437+
if(typeResult&&typeoftypeResult==="object"&&"notEditable"intypeResult){
438+
thrownewPreviewAutomationTargetNotEditableError({
439+
requestId: request.requestId,
440+
operation: request.operation,
441+
environmentId,
442+
threadId: request.threadId,
443+
tabId: ready.tabId,
444+
});
445+
}
446+
returntypeResult;
436447
}
437448
case"press": {
438449
constready=awaitrequireReadyTab();

‎apps/web/src/components/preview/previewAutomationErrors.ts‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,31 @@ export class PreviewAutomationOperationError extends Schema.TaggedErrorClass<Pre
122122
}
123123
}
124124

125+
exportclassPreviewAutomationTargetNotEditableErrorextendsSchema.TaggedErrorClass<PreviewAutomationTargetNotEditableError>()(
126+
"PreviewAutomationTargetNotEditableError",
127+
{
128+
requestId: TrimmedNonEmptyString,
129+
operation: PreviewAutomationOperation,
130+
environmentId: EnvironmentId,
131+
threadId: ThreadId,
132+
tabId: Schema.NullOr(PreviewTabId),
133+
},
134+
){
135+
getresponseTag(){
136+
return"PreviewAutomationTargetNotEditableError"asconst;
137+
}
138+
139+
overridegetmessage(): string{
140+
return`Preview automation ${this.operation} target is not editable for request ${this.requestId} on environment ${this.environmentId} thread ${this.threadId} (tab ${this.tabId??"unassigned"}).`;
141+
}
142+
}
143+
125144
exportconstPreviewAutomationHostError=Schema.Union([
126145
PreviewAutomationOverlayTimeoutError,
127146
PreviewAutomationNavigationTimeoutError,
128147
PreviewAutomationTargetUnavailableError,
129148
PreviewAutomationRecordingNotActiveError,
149+
PreviewAutomationTargetNotEditableError,
130150
PreviewAutomationOperationError,
131151
]);
132152
exporttypePreviewAutomationHostError=typeofPreviewAutomationHostError.Type;

‎packages/contracts/src/ipc.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,10 @@ export interface DesktopPreviewBridge {
987987
status: (tabId: string)=>Promise<PreviewAutomationStatus>;
988988
snapshot: (tabId: string)=>Promise<PreviewAutomationSnapshot>;
989989
click: (tabId: string,input: PreviewAutomationClickInput)=>Promise<void>;
990-
type: (tabId: string,input: PreviewAutomationTypeInput)=>Promise<void>;
990+
type: (
991+
tabId: string,
992+
input: PreviewAutomationTypeInput,
993+
)=>Promise<void|{notEditable: true}>;
991994
press: (tabId: string,input: PreviewAutomationPressInput)=>Promise<void>;
992995
scroll: (tabId: string,input: PreviewAutomationScrollInput)=>Promise<void>;
993996
evaluate: (tabId: string,input: PreviewAutomationEvaluateInput)=>Promise<unknown>;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 78f235d

Browse files
committed
Fix preview automation: surface not-editable error, decouple zoom from nav sync, fix clear-only type
Bug 1: NotEditable error not surfaced - The desktop-side PreviewAutomationTargetNotEditableError was lost when crossing the Electron IPC boundary, causing agents/MCP to see a generic PreviewAutomationExecutionError instead of a structured not-editable response. - Changed the automationType IPC handler to catch the error and return it as structured data ({ notEditable: true }) instead of throwing. - Added a web-side PreviewAutomationTargetNotEditableError class with its own responseTag to the PreviewAutomationHostError union. - Updated PreviewAutomationHosts to detect the structured result and throw the web-side error for proper serialization. Bug 2: Zoom read blocks nav sync - syncWebContentsState read getZoomFactor through the same failing attempt path as navigation fields. If zoom lookup threw, the whole sync aborted and listeners like did-stop-loading never updated navStatus. - Made the zoom factor read non-fatal with Effect.orElseSucceed, falling back to the current tab's zoomFactor when the read fails. Bug 3: Clear-only type fails incorrectly - When clear:true with empty text, the in-page typing path used document.execCommand('delete') which often returns false on many inputs, incorrectly reporting PreviewAutomationTargetNotEditableError. - Changed clear-only logic to directly set element.value or textContent to empty instead of relying on execCommand('delete').
1 parent 27afced commit 78f235d

5 files changed

Lines changed: 55 additions & 12 deletions

File tree

‎apps/desktop/src/ipc/methods/preview.ts‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,17 @@ export const automationClick = DesktopIpc.makeIpcMethod({
277277
exportconstautomationType=DesktopIpc.makeIpcMethod({
278278
channel: IpcChannels.PREVIEW_AUTOMATION_TYPE_CHANNEL,
279279
payload: DesktopPreviewAutomationTypeInputSchema,
280-
result: Schema.Void,
281-
handler: Effect.fn("desktop.ipc.preview.automationType")(function*({ tabId, input }){
282-
constmanager=yield*PreviewManager.PreviewManager;
283-
yield*manager.automationType(tabId,input);
284-
}),
280+
result: Schema.NullOr(Schema.Struct({notEditable: Schema.Literal(true)})),
281+
handler: Effect.fn("desktop.ipc.preview.automationType")(
282+
function*({ tabId, input }){
283+
constmanager=yield*PreviewManager.PreviewManager;
284+
yield*manager.automationType(tabId,input);
285+
returnnull;
286+
},
287+
Effect.catchTag("PreviewAutomationTargetNotEditableError",()=>
288+
Effect.succeed({notEditable: trueasconst}),
289+
),
290+
),
285291
});
286292

287293
exportconstautomationPress=DesktopIpc.makeIpcMethod({

‎apps/desktop/src/preview/Manager.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11091109
constzoomFactor=yield*attempt(
11101110
{operation: "syncWebContentsState.getZoomFactor", tabId,webContentsId: wc.id},
11111111
()=>wc.getZoomFactor(),
1112-
);
1112+
).pipe(Effect.orElseSucceed(()=>undefinedasnumber|undefined));
11131113
constcomputedNavStatus=computeNavStatus(wc);
11141114
constcanGoBack=wc.navigationHistory.canGoBack();
11151115
constcanGoForward=wc.navigationHistory.canGoForward();
@@ -1129,7 +1129,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11291129
navStatus,
11301130
canGoBack,
11311131
canGoForward,
1132-
zoomFactor,
1132+
zoomFactor: zoomFactor??current.zoomFactor,
11331133
updatedAt,
11341134
};
11351135
return[
@@ -2108,9 +2108,12 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
21082108
}
21092109
}
21102110
const text = ${textJson};
2111-
const inserted = text.length > 0
2112-
? document.execCommand("insertText", false, text)
2113-
: !clear || document.execCommand("delete", false);
2111+
let inserted = true;
2112+
if (text.length > 0) {
2113+
inserted = document.execCommand("insertText", false, text);
2114+
} else if (clear) {
2115+
if (textControl) { element.value = ""; } else { element.textContent = ""; }
2116+
}
21142117
if (!inserted) return { notEditable: true };
21152118
element.dispatchEvent(new Event("change", { bubbles: true }));
21162119
return { ok: true };

‎apps/web/src/components/preview/PreviewAutomationHosts.tsx‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import {
4747
PreviewAutomationOperationError,
4848
PreviewAutomationOverlayTimeoutError,
4949
PreviewAutomationRecordingNotActiveError,
50+
PreviewAutomationTargetNotEditableError,
5051
PreviewAutomationTargetUnavailableError,
5152
}from"./previewAutomationErrors";
5253
import{createPreviewAutomationRequestConsumerAtom}from"./previewAutomationRequestConsumer";
@@ -429,10 +430,20 @@ function PreviewAutomationHost(props: { readonly environmentId: EnvironmentId })
429430
}
430431
case"type": {
431432
constready=awaitrequireReadyTab();
432-
returnawaitready.bridge.automation.type(
433+
consttypeResult=awaitready.bridge.automation.type(
433434
ready.tabId,
434435
request.inputasParameters<typeofready.bridge.automation.type>[1],
435436
);
437+
if(typeResult&&typeoftypeResult==="object"&&"notEditable"intypeResult){
438+
thrownewPreviewAutomationTargetNotEditableError({
439+
requestId: request.requestId,
440+
operation: request.operation,
441+
environmentId,
442+
threadId: request.threadId,
443+
tabId: ready.tabId,
444+
});
445+
}
446+
returntypeResult;
436447
}
437448
case"press": {
438449
constready=awaitrequireReadyTab();

‎apps/web/src/components/preview/previewAutomationErrors.ts‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,31 @@ export class PreviewAutomationOperationError extends Schema.TaggedErrorClass<Pre
122122
}
123123
}
124124

125+
exportclassPreviewAutomationTargetNotEditableErrorextendsSchema.TaggedErrorClass<PreviewAutomationTargetNotEditableError>()(
126+
"PreviewAutomationTargetNotEditableError",
127+
{
128+
requestId: TrimmedNonEmptyString,
129+
operation: PreviewAutomationOperation,
130+
environmentId: EnvironmentId,
131+
threadId: ThreadId,
132+
tabId: Schema.NullOr(PreviewTabId),
133+
},
134+
){
135+
getresponseTag(){
136+
return"PreviewAutomationTargetNotEditableError"asconst;
137+
}
138+
139+
overridegetmessage(): string{
140+
return`Preview automation ${this.operation} target is not editable for request ${this.requestId} on environment ${this.environmentId} thread ${this.threadId} (tab ${this.tabId??"unassigned"}).`;
141+
}
142+
}
143+
125144
exportconstPreviewAutomationHostError=Schema.Union([
126145
PreviewAutomationOverlayTimeoutError,
127146
PreviewAutomationNavigationTimeoutError,
128147
PreviewAutomationTargetUnavailableError,
129148
PreviewAutomationRecordingNotActiveError,
149+
PreviewAutomationTargetNotEditableError,
130150
PreviewAutomationOperationError,
131151
]);
132152
exporttypePreviewAutomationHostError=typeofPreviewAutomationHostError.Type;

‎packages/contracts/src/ipc.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,10 @@ export interface DesktopPreviewBridge {
987987
status: (tabId: string)=>Promise<PreviewAutomationStatus>;
988988
snapshot: (tabId: string)=>Promise<PreviewAutomationSnapshot>;
989989
click: (tabId: string,input: PreviewAutomationClickInput)=>Promise<void>;
990-
type: (tabId: string,input: PreviewAutomationTypeInput)=>Promise<void>;
990+
type: (
991+
tabId: string,
992+
input: PreviewAutomationTypeInput,
993+
)=>Promise<void|{notEditable: true}>;
991994
press: (tabId: string,input: PreviewAutomationPressInput)=>Promise<void>;
992995
scroll: (tabId: string,input: PreviewAutomationScrollInput)=>Promise<void>;
993996
evaluate: (tabId: string,input: PreviewAutomationEvaluateInput)=>Promise<unknown>;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 78f235d

Browse files
committed
Fix preview automation: surface not-editable error, decouple zoom from nav sync, fix clear-only type
Bug 1: NotEditable error not surfaced - The desktop-side PreviewAutomationTargetNotEditableError was lost when crossing the Electron IPC boundary, causing agents/MCP to see a generic PreviewAutomationExecutionError instead of a structured not-editable response. - Changed the automationType IPC handler to catch the error and return it as structured data ({ notEditable: true }) instead of throwing. - Added a web-side PreviewAutomationTargetNotEditableError class with its own responseTag to the PreviewAutomationHostError union. - Updated PreviewAutomationHosts to detect the structured result and throw the web-side error for proper serialization. Bug 2: Zoom read blocks nav sync - syncWebContentsState read getZoomFactor through the same failing attempt path as navigation fields. If zoom lookup threw, the whole sync aborted and listeners like did-stop-loading never updated navStatus. - Made the zoom factor read non-fatal with Effect.orElseSucceed, falling back to the current tab's zoomFactor when the read fails. Bug 3: Clear-only type fails incorrectly - When clear:true with empty text, the in-page typing path used document.execCommand('delete') which often returns false on many inputs, incorrectly reporting PreviewAutomationTargetNotEditableError. - Changed clear-only logic to directly set element.value or textContent to empty instead of relying on execCommand('delete').
1 parent 27afced commit 78f235d

5 files changed

Lines changed: 55 additions & 12 deletions

File tree

‎apps/desktop/src/ipc/methods/preview.ts‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,17 @@ export const automationClick = DesktopIpc.makeIpcMethod({
277277
exportconstautomationType=DesktopIpc.makeIpcMethod({
278278
channel: IpcChannels.PREVIEW_AUTOMATION_TYPE_CHANNEL,
279279
payload: DesktopPreviewAutomationTypeInputSchema,
280-
result: Schema.Void,
281-
handler: Effect.fn("desktop.ipc.preview.automationType")(function*({ tabId, input }){
282-
constmanager=yield*PreviewManager.PreviewManager;
283-
yield*manager.automationType(tabId,input);
284-
}),
280+
result: Schema.NullOr(Schema.Struct({notEditable: Schema.Literal(true)})),
281+
handler: Effect.fn("desktop.ipc.preview.automationType")(
282+
function*({ tabId, input }){
283+
constmanager=yield*PreviewManager.PreviewManager;
284+
yield*manager.automationType(tabId,input);
285+
returnnull;
286+
},
287+
Effect.catchTag("PreviewAutomationTargetNotEditableError",()=>
288+
Effect.succeed({notEditable: trueasconst}),
289+
),
290+
),
285291
});
286292

287293
exportconstautomationPress=DesktopIpc.makeIpcMethod({

‎apps/desktop/src/preview/Manager.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11091109
constzoomFactor=yield*attempt(
11101110
{operation: "syncWebContentsState.getZoomFactor", tabId,webContentsId: wc.id},
11111111
()=>wc.getZoomFactor(),
1112-
);
1112+
).pipe(Effect.orElseSucceed(()=>undefinedasnumber|undefined));
11131113
constcomputedNavStatus=computeNavStatus(wc);
11141114
constcanGoBack=wc.navigationHistory.canGoBack();
11151115
constcanGoForward=wc.navigationHistory.canGoForward();
@@ -1129,7 +1129,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11291129
navStatus,
11301130
canGoBack,
11311131
canGoForward,
1132-
zoomFactor,
1132+
zoomFactor: zoomFactor??current.zoomFactor,
11331133
updatedAt,
11341134
};
11351135
return[
@@ -2108,9 +2108,12 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
21082108
}
21092109
}
21102110
const text = ${textJson};
2111-
const inserted = text.length > 0
2112-
? document.execCommand("insertText", false, text)
2113-
: !clear || document.execCommand("delete", false);
2111+
let inserted = true;
2112+
if (text.length > 0) {
2113+
inserted = document.execCommand("insertText", false, text);
2114+
} else if (clear) {
2115+
if (textControl) { element.value = ""; } else { element.textContent = ""; }
2116+
}
21142117
if (!inserted) return { notEditable: true };
21152118
element.dispatchEvent(new Event("change", { bubbles: true }));
21162119
return { ok: true };

‎apps/web/src/components/preview/PreviewAutomationHosts.tsx‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import {
4747
PreviewAutomationOperationError,
4848
PreviewAutomationOverlayTimeoutError,
4949
PreviewAutomationRecordingNotActiveError,
50+
PreviewAutomationTargetNotEditableError,
5051
PreviewAutomationTargetUnavailableError,
5152
}from"./previewAutomationErrors";
5253
import{createPreviewAutomationRequestConsumerAtom}from"./previewAutomationRequestConsumer";
@@ -429,10 +430,20 @@ function PreviewAutomationHost(props: { readonly environmentId: EnvironmentId })
429430
}
430431
case"type": {
431432
constready=awaitrequireReadyTab();
432-
returnawaitready.bridge.automation.type(
433+
consttypeResult=awaitready.bridge.automation.type(
433434
ready.tabId,
434435
request.inputasParameters<typeofready.bridge.automation.type>[1],
435436
);
437+
if(typeResult&&typeoftypeResult==="object"&&"notEditable"intypeResult){
438+
thrownewPreviewAutomationTargetNotEditableError({
439+
requestId: request.requestId,
440+
operation: request.operation,
441+
environmentId,
442+
threadId: request.threadId,
443+
tabId: ready.tabId,
444+
});
445+
}
446+
returntypeResult;
436447
}
437448
case"press": {
438449
constready=awaitrequireReadyTab();

‎apps/web/src/components/preview/previewAutomationErrors.ts‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,31 @@ export class PreviewAutomationOperationError extends Schema.TaggedErrorClass<Pre
122122
}
123123
}
124124

125+
exportclassPreviewAutomationTargetNotEditableErrorextendsSchema.TaggedErrorClass<PreviewAutomationTargetNotEditableError>()(
126+
"PreviewAutomationTargetNotEditableError",
127+
{
128+
requestId: TrimmedNonEmptyString,
129+
operation: PreviewAutomationOperation,
130+
environmentId: EnvironmentId,
131+
threadId: ThreadId,
132+
tabId: Schema.NullOr(PreviewTabId),
133+
},
134+
){
135+
getresponseTag(){
136+
return"PreviewAutomationTargetNotEditableError"asconst;
137+
}
138+
139+
overridegetmessage(): string{
140+
return`Preview automation ${this.operation} target is not editable for request ${this.requestId} on environment ${this.environmentId} thread ${this.threadId} (tab ${this.tabId??"unassigned"}).`;
141+
}
142+
}
143+
125144
exportconstPreviewAutomationHostError=Schema.Union([
126145
PreviewAutomationOverlayTimeoutError,
127146
PreviewAutomationNavigationTimeoutError,
128147
PreviewAutomationTargetUnavailableError,
129148
PreviewAutomationRecordingNotActiveError,
149+
PreviewAutomationTargetNotEditableError,
130150
PreviewAutomationOperationError,
131151
]);
132152
exporttypePreviewAutomationHostError=typeofPreviewAutomationHostError.Type;

‎packages/contracts/src/ipc.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,10 @@ export interface DesktopPreviewBridge {
987987
status: (tabId: string)=>Promise<PreviewAutomationStatus>;
988988
snapshot: (tabId: string)=>Promise<PreviewAutomationSnapshot>;
989989
click: (tabId: string,input: PreviewAutomationClickInput)=>Promise<void>;
990-
type: (tabId: string,input: PreviewAutomationTypeInput)=>Promise<void>;
990+
type: (
991+
tabId: string,
992+
input: PreviewAutomationTypeInput,
993+
)=>Promise<void|{notEditable: true}>;
991994
press: (tabId: string,input: PreviewAutomationPressInput)=>Promise<void>;
992995
scroll: (tabId: string,input: PreviewAutomationScrollInput)=>Promise<void>;
993996
evaluate: (tabId: string,input: PreviewAutomationEvaluateInput)=>Promise<unknown>;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 78f235d

Browse files
committed
Fix preview automation: surface not-editable error, decouple zoom from nav sync, fix clear-only type
Bug 1: NotEditable error not surfaced - The desktop-side PreviewAutomationTargetNotEditableError was lost when crossing the Electron IPC boundary, causing agents/MCP to see a generic PreviewAutomationExecutionError instead of a structured not-editable response. - Changed the automationType IPC handler to catch the error and return it as structured data ({ notEditable: true }) instead of throwing. - Added a web-side PreviewAutomationTargetNotEditableError class with its own responseTag to the PreviewAutomationHostError union. - Updated PreviewAutomationHosts to detect the structured result and throw the web-side error for proper serialization. Bug 2: Zoom read blocks nav sync - syncWebContentsState read getZoomFactor through the same failing attempt path as navigation fields. If zoom lookup threw, the whole sync aborted and listeners like did-stop-loading never updated navStatus. - Made the zoom factor read non-fatal with Effect.orElseSucceed, falling back to the current tab's zoomFactor when the read fails. Bug 3: Clear-only type fails incorrectly - When clear:true with empty text, the in-page typing path used document.execCommand('delete') which often returns false on many inputs, incorrectly reporting PreviewAutomationTargetNotEditableError. - Changed clear-only logic to directly set element.value or textContent to empty instead of relying on execCommand('delete').
1 parent 27afced commit 78f235d

5 files changed

Lines changed: 55 additions & 12 deletions

File tree

‎apps/desktop/src/ipc/methods/preview.ts‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,17 @@ export const automationClick = DesktopIpc.makeIpcMethod({
277277
exportconstautomationType=DesktopIpc.makeIpcMethod({
278278
channel: IpcChannels.PREVIEW_AUTOMATION_TYPE_CHANNEL,
279279
payload: DesktopPreviewAutomationTypeInputSchema,
280-
result: Schema.Void,
281-
handler: Effect.fn("desktop.ipc.preview.automationType")(function*({ tabId, input }){
282-
constmanager=yield*PreviewManager.PreviewManager;
283-
yield*manager.automationType(tabId,input);
284-
}),
280+
result: Schema.NullOr(Schema.Struct({notEditable: Schema.Literal(true)})),
281+
handler: Effect.fn("desktop.ipc.preview.automationType")(
282+
function*({ tabId, input }){
283+
constmanager=yield*PreviewManager.PreviewManager;
284+
yield*manager.automationType(tabId,input);
285+
returnnull;
286+
},
287+
Effect.catchTag("PreviewAutomationTargetNotEditableError",()=>
288+
Effect.succeed({notEditable: trueasconst}),
289+
),
290+
),
285291
});
286292

287293
exportconstautomationPress=DesktopIpc.makeIpcMethod({

‎apps/desktop/src/preview/Manager.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11091109
constzoomFactor=yield*attempt(
11101110
{operation: "syncWebContentsState.getZoomFactor", tabId,webContentsId: wc.id},
11111111
()=>wc.getZoomFactor(),
1112-
);
1112+
).pipe(Effect.orElseSucceed(()=>undefinedasnumber|undefined));
11131113
constcomputedNavStatus=computeNavStatus(wc);
11141114
constcanGoBack=wc.navigationHistory.canGoBack();
11151115
constcanGoForward=wc.navigationHistory.canGoForward();
@@ -1129,7 +1129,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11291129
navStatus,
11301130
canGoBack,
11311131
canGoForward,
1132-
zoomFactor,
1132+
zoomFactor: zoomFactor??current.zoomFactor,
11331133
updatedAt,
11341134
};
11351135
return[
@@ -2108,9 +2108,12 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
21082108
}
21092109
}
21102110
const text = ${textJson};
2111-
const inserted = text.length > 0
2112-
? document.execCommand("insertText", false, text)
2113-
: !clear || document.execCommand("delete", false);
2111+
let inserted = true;
2112+
if (text.length > 0) {
2113+
inserted = document.execCommand("insertText", false, text);
2114+
} else if (clear) {
2115+
if (textControl) { element.value = ""; } else { element.textContent = ""; }
2116+
}
21142117
if (!inserted) return { notEditable: true };
21152118
element.dispatchEvent(new Event("change", { bubbles: true }));
21162119
return { ok: true };

‎apps/web/src/components/preview/PreviewAutomationHosts.tsx‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import {
4747
PreviewAutomationOperationError,
4848
PreviewAutomationOverlayTimeoutError,
4949
PreviewAutomationRecordingNotActiveError,
50+
PreviewAutomationTargetNotEditableError,
5051
PreviewAutomationTargetUnavailableError,
5152
}from"./previewAutomationErrors";
5253
import{createPreviewAutomationRequestConsumerAtom}from"./previewAutomationRequestConsumer";
@@ -429,10 +430,20 @@ function PreviewAutomationHost(props: { readonly environmentId: EnvironmentId })
429430
}
430431
case"type": {
431432
constready=awaitrequireReadyTab();
432-
returnawaitready.bridge.automation.type(
433+
consttypeResult=awaitready.bridge.automation.type(
433434
ready.tabId,
434435
request.inputasParameters<typeofready.bridge.automation.type>[1],
435436
);
437+
if(typeResult&&typeoftypeResult==="object"&&"notEditable"intypeResult){
438+
thrownewPreviewAutomationTargetNotEditableError({
439+
requestId: request.requestId,
440+
operation: request.operation,
441+
environmentId,
442+
threadId: request.threadId,
443+
tabId: ready.tabId,
444+
});
445+
}
446+
returntypeResult;
436447
}
437448
case"press": {
438449
constready=awaitrequireReadyTab();

‎apps/web/src/components/preview/previewAutomationErrors.ts‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,31 @@ export class PreviewAutomationOperationError extends Schema.TaggedErrorClass<Pre
122122
}
123123
}
124124

125+
exportclassPreviewAutomationTargetNotEditableErrorextendsSchema.TaggedErrorClass<PreviewAutomationTargetNotEditableError>()(
126+
"PreviewAutomationTargetNotEditableError",
127+
{
128+
requestId: TrimmedNonEmptyString,
129+
operation: PreviewAutomationOperation,
130+
environmentId: EnvironmentId,
131+
threadId: ThreadId,
132+
tabId: Schema.NullOr(PreviewTabId),
133+
},
134+
){
135+
getresponseTag(){
136+
return"PreviewAutomationTargetNotEditableError"asconst;
137+
}
138+
139+
overridegetmessage(): string{
140+
return`Preview automation ${this.operation} target is not editable for request ${this.requestId} on environment ${this.environmentId} thread ${this.threadId} (tab ${this.tabId??"unassigned"}).`;
141+
}
142+
}
143+
125144
exportconstPreviewAutomationHostError=Schema.Union([
126145
PreviewAutomationOverlayTimeoutError,
127146
PreviewAutomationNavigationTimeoutError,
128147
PreviewAutomationTargetUnavailableError,
129148
PreviewAutomationRecordingNotActiveError,
149+
PreviewAutomationTargetNotEditableError,
130150
PreviewAutomationOperationError,
131151
]);
132152
exporttypePreviewAutomationHostError=typeofPreviewAutomationHostError.Type;

‎packages/contracts/src/ipc.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,10 @@ export interface DesktopPreviewBridge {
987987
status: (tabId: string)=>Promise<PreviewAutomationStatus>;
988988
snapshot: (tabId: string)=>Promise<PreviewAutomationSnapshot>;
989989
click: (tabId: string,input: PreviewAutomationClickInput)=>Promise<void>;
990-
type: (tabId: string,input: PreviewAutomationTypeInput)=>Promise<void>;
990+
type: (
991+
tabId: string,
992+
input: PreviewAutomationTypeInput,
993+
)=>Promise<void|{notEditable: true}>;
991994
press: (tabId: string,input: PreviewAutomationPressInput)=>Promise<void>;
992995
scroll: (tabId: string,input: PreviewAutomationScrollInput)=>Promise<void>;
993996
evaluate: (tabId: string,input: PreviewAutomationEvaluateInput)=>Promise<unknown>;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 78f235d

Browse files
committed
Fix preview automation: surface not-editable error, decouple zoom from nav sync, fix clear-only type
Bug 1: NotEditable error not surfaced - The desktop-side PreviewAutomationTargetNotEditableError was lost when crossing the Electron IPC boundary, causing agents/MCP to see a generic PreviewAutomationExecutionError instead of a structured not-editable response. - Changed the automationType IPC handler to catch the error and return it as structured data ({ notEditable: true }) instead of throwing. - Added a web-side PreviewAutomationTargetNotEditableError class with its own responseTag to the PreviewAutomationHostError union. - Updated PreviewAutomationHosts to detect the structured result and throw the web-side error for proper serialization. Bug 2: Zoom read blocks nav sync - syncWebContentsState read getZoomFactor through the same failing attempt path as navigation fields. If zoom lookup threw, the whole sync aborted and listeners like did-stop-loading never updated navStatus. - Made the zoom factor read non-fatal with Effect.orElseSucceed, falling back to the current tab's zoomFactor when the read fails. Bug 3: Clear-only type fails incorrectly - When clear:true with empty text, the in-page typing path used document.execCommand('delete') which often returns false on many inputs, incorrectly reporting PreviewAutomationTargetNotEditableError. - Changed clear-only logic to directly set element.value or textContent to empty instead of relying on execCommand('delete').
1 parent 27afced commit 78f235d

5 files changed

Lines changed: 55 additions & 12 deletions

File tree

‎apps/desktop/src/ipc/methods/preview.ts‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,17 @@ export const automationClick = DesktopIpc.makeIpcMethod({
277277
exportconstautomationType=DesktopIpc.makeIpcMethod({
278278
channel: IpcChannels.PREVIEW_AUTOMATION_TYPE_CHANNEL,
279279
payload: DesktopPreviewAutomationTypeInputSchema,
280-
result: Schema.Void,
281-
handler: Effect.fn("desktop.ipc.preview.automationType")(function*({ tabId, input }){
282-
constmanager=yield*PreviewManager.PreviewManager;
283-
yield*manager.automationType(tabId,input);
284-
}),
280+
result: Schema.NullOr(Schema.Struct({notEditable: Schema.Literal(true)})),
281+
handler: Effect.fn("desktop.ipc.preview.automationType")(
282+
function*({ tabId, input }){
283+
constmanager=yield*PreviewManager.PreviewManager;
284+
yield*manager.automationType(tabId,input);
285+
returnnull;
286+
},
287+
Effect.catchTag("PreviewAutomationTargetNotEditableError",()=>
288+
Effect.succeed({notEditable: trueasconst}),
289+
),
290+
),
285291
});
286292

287293
exportconstautomationPress=DesktopIpc.makeIpcMethod({

‎apps/desktop/src/preview/Manager.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11091109
constzoomFactor=yield*attempt(
11101110
{operation: "syncWebContentsState.getZoomFactor", tabId,webContentsId: wc.id},
11111111
()=>wc.getZoomFactor(),
1112-
);
1112+
).pipe(Effect.orElseSucceed(()=>undefinedasnumber|undefined));
11131113
constcomputedNavStatus=computeNavStatus(wc);
11141114
constcanGoBack=wc.navigationHistory.canGoBack();
11151115
constcanGoForward=wc.navigationHistory.canGoForward();
@@ -1129,7 +1129,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11291129
navStatus,
11301130
canGoBack,
11311131
canGoForward,
1132-
zoomFactor,
1132+
zoomFactor: zoomFactor??current.zoomFactor,
11331133
updatedAt,
11341134
};
11351135
return[
@@ -2108,9 +2108,12 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
21082108
}
21092109
}
21102110
const text = ${textJson};
2111-
const inserted = text.length > 0
2112-
? document.execCommand("insertText", false, text)
2113-
: !clear || document.execCommand("delete", false);
2111+
let inserted = true;
2112+
if (text.length > 0) {
2113+
inserted = document.execCommand("insertText", false, text);
2114+
} else if (clear) {
2115+
if (textControl) { element.value = ""; } else { element.textContent = ""; }
2116+
}
21142117
if (!inserted) return { notEditable: true };
21152118
element.dispatchEvent(new Event("change", { bubbles: true }));
21162119
return { ok: true };

‎apps/web/src/components/preview/PreviewAutomationHosts.tsx‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import {
4747
PreviewAutomationOperationError,
4848
PreviewAutomationOverlayTimeoutError,
4949
PreviewAutomationRecordingNotActiveError,
50+
PreviewAutomationTargetNotEditableError,
5051
PreviewAutomationTargetUnavailableError,
5152
}from"./previewAutomationErrors";
5253
import{createPreviewAutomationRequestConsumerAtom}from"./previewAutomationRequestConsumer";
@@ -429,10 +430,20 @@ function PreviewAutomationHost(props: { readonly environmentId: EnvironmentId })
429430
}
430431
case"type": {
431432
constready=awaitrequireReadyTab();
432-
returnawaitready.bridge.automation.type(
433+
consttypeResult=awaitready.bridge.automation.type(
433434
ready.tabId,
434435
request.inputasParameters<typeofready.bridge.automation.type>[1],
435436
);
437+
if(typeResult&&typeoftypeResult==="object"&&"notEditable"intypeResult){
438+
thrownewPreviewAutomationTargetNotEditableError({
439+
requestId: request.requestId,
440+
operation: request.operation,
441+
environmentId,
442+
threadId: request.threadId,
443+
tabId: ready.tabId,
444+
});
445+
}
446+
returntypeResult;
436447
}
437448
case"press": {
438449
constready=awaitrequireReadyTab();

‎apps/web/src/components/preview/previewAutomationErrors.ts‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,31 @@ export class PreviewAutomationOperationError extends Schema.TaggedErrorClass<Pre
122122
}
123123
}
124124

125+
exportclassPreviewAutomationTargetNotEditableErrorextendsSchema.TaggedErrorClass<PreviewAutomationTargetNotEditableError>()(
126+
"PreviewAutomationTargetNotEditableError",
127+
{
128+
requestId: TrimmedNonEmptyString,
129+
operation: PreviewAutomationOperation,
130+
environmentId: EnvironmentId,
131+
threadId: ThreadId,
132+
tabId: Schema.NullOr(PreviewTabId),
133+
},
134+
){
135+
getresponseTag(){
136+
return"PreviewAutomationTargetNotEditableError"asconst;
137+
}
138+
139+
overridegetmessage(): string{
140+
return`Preview automation ${this.operation} target is not editable for request ${this.requestId} on environment ${this.environmentId} thread ${this.threadId} (tab ${this.tabId??"unassigned"}).`;
141+
}
142+
}
143+
125144
exportconstPreviewAutomationHostError=Schema.Union([
126145
PreviewAutomationOverlayTimeoutError,
127146
PreviewAutomationNavigationTimeoutError,
128147
PreviewAutomationTargetUnavailableError,
129148
PreviewAutomationRecordingNotActiveError,
149+
PreviewAutomationTargetNotEditableError,
130150
PreviewAutomationOperationError,
131151
]);
132152
exporttypePreviewAutomationHostError=typeofPreviewAutomationHostError.Type;

‎packages/contracts/src/ipc.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,10 @@ export interface DesktopPreviewBridge {
987987
status: (tabId: string)=>Promise<PreviewAutomationStatus>;
988988
snapshot: (tabId: string)=>Promise<PreviewAutomationSnapshot>;
989989
click: (tabId: string,input: PreviewAutomationClickInput)=>Promise<void>;
990-
type: (tabId: string,input: PreviewAutomationTypeInput)=>Promise<void>;
990+
type: (
991+
tabId: string,
992+
input: PreviewAutomationTypeInput,
993+
)=>Promise<void|{notEditable: true}>;
991994
press: (tabId: string,input: PreviewAutomationPressInput)=>Promise<void>;
992995
scroll: (tabId: string,input: PreviewAutomationScrollInput)=>Promise<void>;
993996
evaluate: (tabId: string,input: PreviewAutomationEvaluateInput)=>Promise<unknown>;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 78f235d

Browse files
committed
Fix preview automation: surface not-editable error, decouple zoom from nav sync, fix clear-only type
Bug 1: NotEditable error not surfaced - The desktop-side PreviewAutomationTargetNotEditableError was lost when crossing the Electron IPC boundary, causing agents/MCP to see a generic PreviewAutomationExecutionError instead of a structured not-editable response. - Changed the automationType IPC handler to catch the error and return it as structured data ({ notEditable: true }) instead of throwing. - Added a web-side PreviewAutomationTargetNotEditableError class with its own responseTag to the PreviewAutomationHostError union. - Updated PreviewAutomationHosts to detect the structured result and throw the web-side error for proper serialization. Bug 2: Zoom read blocks nav sync - syncWebContentsState read getZoomFactor through the same failing attempt path as navigation fields. If zoom lookup threw, the whole sync aborted and listeners like did-stop-loading never updated navStatus. - Made the zoom factor read non-fatal with Effect.orElseSucceed, falling back to the current tab's zoomFactor when the read fails. Bug 3: Clear-only type fails incorrectly - When clear:true with empty text, the in-page typing path used document.execCommand('delete') which often returns false on many inputs, incorrectly reporting PreviewAutomationTargetNotEditableError. - Changed clear-only logic to directly set element.value or textContent to empty instead of relying on execCommand('delete').
1 parent 27afced commit 78f235d

5 files changed

Lines changed: 55 additions & 12 deletions

File tree

‎apps/desktop/src/ipc/methods/preview.ts‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,17 @@ export const automationClick = DesktopIpc.makeIpcMethod({
277277
exportconstautomationType=DesktopIpc.makeIpcMethod({
278278
channel: IpcChannels.PREVIEW_AUTOMATION_TYPE_CHANNEL,
279279
payload: DesktopPreviewAutomationTypeInputSchema,
280-
result: Schema.Void,
281-
handler: Effect.fn("desktop.ipc.preview.automationType")(function*({ tabId, input }){
282-
constmanager=yield*PreviewManager.PreviewManager;
283-
yield*manager.automationType(tabId,input);
284-
}),
280+
result: Schema.NullOr(Schema.Struct({notEditable: Schema.Literal(true)})),
281+
handler: Effect.fn("desktop.ipc.preview.automationType")(
282+
function*({ tabId, input }){
283+
constmanager=yield*PreviewManager.PreviewManager;
284+
yield*manager.automationType(tabId,input);
285+
returnnull;
286+
},
287+
Effect.catchTag("PreviewAutomationTargetNotEditableError",()=>
288+
Effect.succeed({notEditable: trueasconst}),
289+
),
290+
),
285291
});
286292

287293
exportconstautomationPress=DesktopIpc.makeIpcMethod({

‎apps/desktop/src/preview/Manager.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11091109
constzoomFactor=yield*attempt(
11101110
{operation: "syncWebContentsState.getZoomFactor", tabId,webContentsId: wc.id},
11111111
()=>wc.getZoomFactor(),
1112-
);
1112+
).pipe(Effect.orElseSucceed(()=>undefinedasnumber|undefined));
11131113
constcomputedNavStatus=computeNavStatus(wc);
11141114
constcanGoBack=wc.navigationHistory.canGoBack();
11151115
constcanGoForward=wc.navigationHistory.canGoForward();
@@ -1129,7 +1129,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11291129
navStatus,
11301130
canGoBack,
11311131
canGoForward,
1132-
zoomFactor,
1132+
zoomFactor: zoomFactor??current.zoomFactor,
11331133
updatedAt,
11341134
};
11351135
return[
@@ -2108,9 +2108,12 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
21082108
}
21092109
}
21102110
const text = ${textJson};
2111-
const inserted = text.length > 0
2112-
? document.execCommand("insertText", false, text)
2113-
: !clear || document.execCommand("delete", false);
2111+
let inserted = true;
2112+
if (text.length > 0) {
2113+
inserted = document.execCommand("insertText", false, text);
2114+
} else if (clear) {
2115+
if (textControl) { element.value = ""; } else { element.textContent = ""; }
2116+
}
21142117
if (!inserted) return { notEditable: true };
21152118
element.dispatchEvent(new Event("change", { bubbles: true }));
21162119
return { ok: true };

‎apps/web/src/components/preview/PreviewAutomationHosts.tsx‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import {
4747
PreviewAutomationOperationError,
4848
PreviewAutomationOverlayTimeoutError,
4949
PreviewAutomationRecordingNotActiveError,
50+
PreviewAutomationTargetNotEditableError,
5051
PreviewAutomationTargetUnavailableError,
5152
}from"./previewAutomationErrors";
5253
import{createPreviewAutomationRequestConsumerAtom}from"./previewAutomationRequestConsumer";
@@ -429,10 +430,20 @@ function PreviewAutomationHost(props: { readonly environmentId: EnvironmentId })
429430
}
430431
case"type": {
431432
constready=awaitrequireReadyTab();
432-
returnawaitready.bridge.automation.type(
433+
consttypeResult=awaitready.bridge.automation.type(
433434
ready.tabId,
434435
request.inputasParameters<typeofready.bridge.automation.type>[1],
435436
);
437+
if(typeResult&&typeoftypeResult==="object"&&"notEditable"intypeResult){
438+
thrownewPreviewAutomationTargetNotEditableError({
439+
requestId: request.requestId,
440+
operation: request.operation,
441+
environmentId,
442+
threadId: request.threadId,
443+
tabId: ready.tabId,
444+
});
445+
}
446+
returntypeResult;
436447
}
437448
case"press": {
438449
constready=awaitrequireReadyTab();

‎apps/web/src/components/preview/previewAutomationErrors.ts‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,31 @@ export class PreviewAutomationOperationError extends Schema.TaggedErrorClass<Pre
122122
}
123123
}
124124

125+
exportclassPreviewAutomationTargetNotEditableErrorextendsSchema.TaggedErrorClass<PreviewAutomationTargetNotEditableError>()(
126+
"PreviewAutomationTargetNotEditableError",
127+
{
128+
requestId: TrimmedNonEmptyString,
129+
operation: PreviewAutomationOperation,
130+
environmentId: EnvironmentId,
131+
threadId: ThreadId,
132+
tabId: Schema.NullOr(PreviewTabId),
133+
},
134+
){
135+
getresponseTag(){
136+
return"PreviewAutomationTargetNotEditableError"asconst;
137+
}
138+
139+
overridegetmessage(): string{
140+
return`Preview automation ${this.operation} target is not editable for request ${this.requestId} on environment ${this.environmentId} thread ${this.threadId} (tab ${this.tabId??"unassigned"}).`;
141+
}
142+
}
143+
125144
exportconstPreviewAutomationHostError=Schema.Union([
126145
PreviewAutomationOverlayTimeoutError,
127146
PreviewAutomationNavigationTimeoutError,
128147
PreviewAutomationTargetUnavailableError,
129148
PreviewAutomationRecordingNotActiveError,
149+
PreviewAutomationTargetNotEditableError,
130150
PreviewAutomationOperationError,
131151
]);
132152
exporttypePreviewAutomationHostError=typeofPreviewAutomationHostError.Type;

‎packages/contracts/src/ipc.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,10 @@ export interface DesktopPreviewBridge {
987987
status: (tabId: string)=>Promise<PreviewAutomationStatus>;
988988
snapshot: (tabId: string)=>Promise<PreviewAutomationSnapshot>;
989989
click: (tabId: string,input: PreviewAutomationClickInput)=>Promise<void>;
990-
type: (tabId: string,input: PreviewAutomationTypeInput)=>Promise<void>;
990+
type: (
991+
tabId: string,
992+
input: PreviewAutomationTypeInput,
993+
)=>Promise<void|{notEditable: true}>;
991994
press: (tabId: string,input: PreviewAutomationPressInput)=>Promise<void>;
992995
scroll: (tabId: string,input: PreviewAutomationScrollInput)=>Promise<void>;
993996
evaluate: (tabId: string,input: PreviewAutomationEvaluateInput)=>Promise<unknown>;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 78f235d

Browse files
committed
Fix preview automation: surface not-editable error, decouple zoom from nav sync, fix clear-only type
Bug 1: NotEditable error not surfaced - The desktop-side PreviewAutomationTargetNotEditableError was lost when crossing the Electron IPC boundary, causing agents/MCP to see a generic PreviewAutomationExecutionError instead of a structured not-editable response. - Changed the automationType IPC handler to catch the error and return it as structured data ({ notEditable: true }) instead of throwing. - Added a web-side PreviewAutomationTargetNotEditableError class with its own responseTag to the PreviewAutomationHostError union. - Updated PreviewAutomationHosts to detect the structured result and throw the web-side error for proper serialization. Bug 2: Zoom read blocks nav sync - syncWebContentsState read getZoomFactor through the same failing attempt path as navigation fields. If zoom lookup threw, the whole sync aborted and listeners like did-stop-loading never updated navStatus. - Made the zoom factor read non-fatal with Effect.orElseSucceed, falling back to the current tab's zoomFactor when the read fails. Bug 3: Clear-only type fails incorrectly - When clear:true with empty text, the in-page typing path used document.execCommand('delete') which often returns false on many inputs, incorrectly reporting PreviewAutomationTargetNotEditableError. - Changed clear-only logic to directly set element.value or textContent to empty instead of relying on execCommand('delete').
1 parent 27afced commit 78f235d

5 files changed

Lines changed: 55 additions & 12 deletions

File tree

‎apps/desktop/src/ipc/methods/preview.ts‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,17 @@ export const automationClick = DesktopIpc.makeIpcMethod({
277277
exportconstautomationType=DesktopIpc.makeIpcMethod({
278278
channel: IpcChannels.PREVIEW_AUTOMATION_TYPE_CHANNEL,
279279
payload: DesktopPreviewAutomationTypeInputSchema,
280-
result: Schema.Void,
281-
handler: Effect.fn("desktop.ipc.preview.automationType")(function*({ tabId, input }){
282-
constmanager=yield*PreviewManager.PreviewManager;
283-
yield*manager.automationType(tabId,input);
284-
}),
280+
result: Schema.NullOr(Schema.Struct({notEditable: Schema.Literal(true)})),
281+
handler: Effect.fn("desktop.ipc.preview.automationType")(
282+
function*({ tabId, input }){
283+
constmanager=yield*PreviewManager.PreviewManager;
284+
yield*manager.automationType(tabId,input);
285+
returnnull;
286+
},
287+
Effect.catchTag("PreviewAutomationTargetNotEditableError",()=>
288+
Effect.succeed({notEditable: trueasconst}),
289+
),
290+
),
285291
});
286292

287293
exportconstautomationPress=DesktopIpc.makeIpcMethod({

‎apps/desktop/src/preview/Manager.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11091109
constzoomFactor=yield*attempt(
11101110
{operation: "syncWebContentsState.getZoomFactor", tabId,webContentsId: wc.id},
11111111
()=>wc.getZoomFactor(),
1112-
);
1112+
).pipe(Effect.orElseSucceed(()=>undefinedasnumber|undefined));
11131113
constcomputedNavStatus=computeNavStatus(wc);
11141114
constcanGoBack=wc.navigationHistory.canGoBack();
11151115
constcanGoForward=wc.navigationHistory.canGoForward();
@@ -1129,7 +1129,7 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
11291129
navStatus,
11301130
canGoBack,
11311131
canGoForward,
1132-
zoomFactor,
1132+
zoomFactor: zoomFactor??current.zoomFactor,
11331133
updatedAt,
11341134
};
11351135
return[
@@ -2108,9 +2108,12 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function
21082108
}
21092109
}
21102110
const text = ${textJson};
2111-
const inserted = text.length > 0
2112-
? document.execCommand("insertText", false, text)
2113-
: !clear || document.execCommand("delete", false);
2111+
let inserted = true;
2112+
if (text.length > 0) {
2113+
inserted = document.execCommand("insertText", false, text);
2114+
} else if (clear) {
2115+
if (textControl) { element.value = ""; } else { element.textContent = ""; }
2116+
}
21142117
if (!inserted) return { notEditable: true };
21152118
element.dispatchEvent(new Event("change", { bubbles: true }));
21162119
return { ok: true };

‎apps/web/src/components/preview/PreviewAutomationHosts.tsx‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import {
4747
PreviewAutomationOperationError,
4848
PreviewAutomationOverlayTimeoutError,
4949
PreviewAutomationRecordingNotActiveError,
50+
PreviewAutomationTargetNotEditableError,
5051
PreviewAutomationTargetUnavailableError,
5152
}from"./previewAutomationErrors";
5253
import{createPreviewAutomationRequestConsumerAtom}from"./previewAutomationRequestConsumer";
@@ -429,10 +430,20 @@ function PreviewAutomationHost(props: { readonly environmentId: EnvironmentId })
429430
}
430431
case"type": {
431432
constready=awaitrequireReadyTab();
432-
returnawaitready.bridge.automation.type(
433+
consttypeResult=awaitready.bridge.automation.type(
433434
ready.tabId,
434435
request.inputasParameters<typeofready.bridge.automation.type>[1],
435436
);
437+
if(typeResult&&typeoftypeResult==="object"&&"notEditable"intypeResult){
438+
thrownewPreviewAutomationTargetNotEditableError({
439+
requestId: request.requestId,
440+
operation: request.operation,
441+
environmentId,
442+
threadId: request.threadId,
443+
tabId: ready.tabId,
444+
});
445+
}
446+
returntypeResult;
436447
}
437448
case"press": {
438449
constready=awaitrequireReadyTab();

‎apps/web/src/components/preview/previewAutomationErrors.ts‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,31 @@ export class PreviewAutomationOperationError extends Schema.TaggedErrorClass<Pre
122122
}
123123
}
124124

125+
exportclassPreviewAutomationTargetNotEditableErrorextendsSchema.TaggedErrorClass<PreviewAutomationTargetNotEditableError>()(
126+
"PreviewAutomationTargetNotEditableError",
127+
{
128+
requestId: TrimmedNonEmptyString,
129+
operation: PreviewAutomationOperation,
130+
environmentId: EnvironmentId,
131+
threadId: ThreadId,
132+
tabId: Schema.NullOr(PreviewTabId),
133+
},
134+
){
135+
getresponseTag(){
136+
return"PreviewAutomationTargetNotEditableError"asconst;
137+
}
138+
139+
overridegetmessage(): string{
140+
return`Preview automation ${this.operation} target is not editable for request ${this.requestId} on environment ${this.environmentId} thread ${this.threadId} (tab ${this.tabId??"unassigned"}).`;
141+
}
142+
}
143+
125144
exportconstPreviewAutomationHostError=Schema.Union([
126145
PreviewAutomationOverlayTimeoutError,
127146
PreviewAutomationNavigationTimeoutError,
128147
PreviewAutomationTargetUnavailableError,
129148
PreviewAutomationRecordingNotActiveError,
149+
PreviewAutomationTargetNotEditableError,
130150
PreviewAutomationOperationError,
131151
]);
132152
exporttypePreviewAutomationHostError=typeofPreviewAutomationHostError.Type;

‎packages/contracts/src/ipc.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,10 @@ export interface DesktopPreviewBridge {
987987
status: (tabId: string)=>Promise<PreviewAutomationStatus>;
988988
snapshot: (tabId: string)=>Promise<PreviewAutomationSnapshot>;
989989
click: (tabId: string,input: PreviewAutomationClickInput)=>Promise<void>;
990-
type: (tabId: string,input: PreviewAutomationTypeInput)=>Promise<void>;
990+
type: (
991+
tabId: string,
992+
input: PreviewAutomationTypeInput,
993+
)=>Promise<void|{notEditable: true}>;
991994
press: (tabId: string,input: PreviewAutomationPressInput)=>Promise<void>;
992995
scroll: (tabId: string,input: PreviewAutomationScrollInput)=>Promise<void>;
993996
evaluate: (tabId: string,input: PreviewAutomationEvaluateInput)=>Promise<unknown>;

0 commit comments

Comments
 (0)