Commit b1670ac

Browse files
t3dotggt3dotgg
authored
fix(web): stop recovered tool failures from marking work logs red (#7999)
1 parent ea8c9e5 commit b1670ac

3 files changed

Lines changed: 103 additions & 53 deletions

File tree

‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎

Lines changed: 47 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,57 +1470,54 @@ describe("deriveMessagesTimelineRows", () => {
14701470
});
14711471
});
14721472

1473-
it("keeps a failure visible when other hidden entries succeeded",()=>{
1474-
constrows=deriveMessagesTimelineRows({
1475-
timelineEntries: [
1476-
{
1477-
id: "failed-work-entry",
1478-
kind: "work",
1479-
createdAt: "2026-01-01T00:00:01Z",
1480-
entry: {
1481-
id: "failed-work",
1482-
createdAt: "2026-01-01T00:00:01Z",
1483-
label: "Ran command",
1484-
tone: "tool",
1485-
toolLifecycleStatus: "failed",
1486-
},
1487-
},
1488-
{
1489-
id: "completed-work-entry",
1490-
kind: "work",
1491-
createdAt: "2026-01-01T00:00:02Z",
1492-
entry: {
1493-
id: "completed-work",
1494-
createdAt: "2026-01-01T00:00:02Z",
1495-
label: "Ran command",
1496-
tone: "tool",
1497-
toolLifecycleStatus: "completed",
1498-
},
1499-
},
1500-
{
1501-
id: "visible-info-entry",
1502-
kind: "work",
1503-
createdAt: "2026-01-01T00:00:03Z",
1504-
entry: {
1505-
id: "visible-info",
1506-
createdAt: "2026-01-01T00:00:03Z",
1507-
label: "Status updated",
1508-
tone: "info",
1509-
},
1510-
},
1511-
],
1512-
isWorking: false,
1513-
activeTurnStartedAt: null,
1514-
turnDiffSummaryByAssistantMessageId: newMap(),
1515-
revertTurnCountByUserMessageId: newMap(),
1516-
});
1473+
it.each([
1474+
["the later success is hidden",["failed","completed","info"],false],
1475+
["the later success is visible",["failed","info","completed"],false],
1476+
["an error-toned entry recovers",["error","info","completed"],false],
1477+
["the final failure is hidden",["completed","failed","info"],true],
1478+
["the final failure is visible",["failed","info","failed"],true],
1479+
["the only failure is visible",["completed","info","failed"],false],
1480+
]asconst)(
1481+
"uses the final tool call for mixed work groups when %s",
1482+
(_,statuses,hasFailure)=>{
1483+
consttimelineEntries=statuses.map((status,index)=>{
1484+
constid=`work-${index}`;
1485+
constcreatedAt=`2026-01-01T00:00:0${index}Z`;
1486+
1487+
return{
1488+
id: `work-entry-${index}`,
1489+
kind: "work"asconst,
1490+
createdAt,
1491+
entry:
1492+
status==="info"
1493+
? { id, createdAt,label: "Status updated",tone: "info"asconst}
1494+
: status==="error"
1495+
? { id, createdAt,label: "Command failed",tone: "error"asconst}
1496+
: {
1497+
id,
1498+
createdAt,
1499+
label: "Ran command",
1500+
tone: "tool"asconst,
1501+
toolLifecycleStatus: status,
1502+
},
1503+
};
1504+
});
15171505

1518-
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1519-
hiddenCount: 2,
1520-
summary: null,
1521-
hasFailure: true,
1522-
});
1523-
});
1506+
constrows=deriveMessagesTimelineRows({
1507+
timelineEntries,
1508+
isWorking: false,
1509+
activeTurnStartedAt: null,
1510+
turnDiffSummaryByAssistantMessageId: newMap(),
1511+
revertTurnCountByUserMessageId: newMap(),
1512+
});
1513+
1514+
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1515+
hiddenCount: 2,
1516+
summary: null,
1517+
hasFailure,
1518+
});
1519+
},
1520+
);
15241521
});
15251522

15261523
describe("computeStableMessagesTimelineRows",()=>{

‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,6 +953,8 @@ export function deriveMessagesTimelineRows(input: {
953953
}
954954

955955
if(hiddenEntries.length>0){
956+
constlatestToolEntry=visibleGroupedEntries.findLast(workLogEntryIsToolLike);
957+
956958
nextRows.push({
957959
kind: "work-toggle",
958960
id: `work-toggle:${timelineEntry.id}`,
@@ -963,9 +965,10 @@ export function deriveMessagesTimelineRows(input: {
963965
onlyToolEntries: hiddenEntries.every(workLogEntryIsToolLike),
964966
summary: null,
965967
summaryKind: null,
966-
hasFailure: hiddenEntries.some((entry)=>
967-
workEntryDisplayIndicatesToolFailure(entry),
968-
),
968+
hasFailure:
969+
latestToolEntry!==undefined&&
970+
workEntryDisplayIndicatesToolFailure(latestToolEntry)&&
971+
hiddenEntries.some(workEntryDisplayIndicatesToolFailure),
969972
});
970973
}
971974
}

‎apps/web/src/components/chat/MessagesTimeline.test.tsx‎

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,56 @@ describe("MessagesTimeline", () => {
973973
expect(markup).not.toContain('aria-label="Tool call failed"');
974974
});
975975

976+
it("keeps mixed work logs neutral after a later tool call succeeds",()=>{
977+
constmarkup=renderToStaticMarkup(
978+
<MessagesTimeline
979+
{...buildProps()}
980+
timelineEntries={[
981+
{
982+
id: "entry-failed",
983+
kind: "work",
984+
createdAt: "2026-03-17T19:12:28.000Z",
985+
entry: {
986+
id: "work-failed",
987+
createdAt: "2026-03-17T19:12:28.000Z",
988+
label: "Run search",
989+
tone: "tool",
990+
itemType: "command_execution",
991+
toolLifecycleStatus: "failed",
992+
},
993+
},
994+
{
995+
id: "entry-info",
996+
kind: "work",
997+
createdAt: "2026-03-17T19:12:29.000Z",
998+
entry: {
999+
id: "work-info",
1000+
createdAt: "2026-03-17T19:12:29.000Z",
1001+
label: "Status updated",
1002+
tone: "info",
1003+
},
1004+
},
1005+
{
1006+
id: "entry-completed",
1007+
kind: "work",
1008+
createdAt: "2026-03-17T19:12:30.000Z",
1009+
entry: {
1010+
id: "work-completed",
1011+
createdAt: "2026-03-17T19:12:30.000Z",
1012+
label: "Run tests",
1013+
tone: "tool",
1014+
itemType: "command_execution",
1015+
toolLifecycleStatus: "completed",
1016+
},
1017+
},
1018+
]}
1019+
/>,
1020+
);
1021+
1022+
expect(markup).toContain("+2 previous log entries");
1023+
expect(markup).not.toContain('aria-label="Hidden work includes a failure"');
1024+
});
1025+
9761026
it("shows the animated one-line label for a live tool group",()=>{
9771027
constturnId=TurnId.make("turn-live");
9781028
constmarkup=renderToStaticMarkup(

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Commit b1670ac
Browse files
t3dotggt3dotgg
authored
fix(web): stop recovered tool failures from marking work logs red (#7999)
1 parent ea8c9e5 commit b1670ac
3 files changed
Lines changed: 103 additions & 53 deletions
File tree
‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎
Lines changed: 47 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,57 +1470,54 @@ describe("deriveMessagesTimelineRows", () => {
14701470
});
14711471
});
14721472

1473-
it("keeps a failure visible when other hidden entries succeeded",()=>{
1474-
constrows=deriveMessagesTimelineRows({
1475-
timelineEntries: [
1476-
{
1477-
id: "failed-work-entry",
1478-
kind: "work",
1479-
createdAt: "2026-01-01T00:00:01Z",
1480-
entry: {
1481-
id: "failed-work",
1482-
createdAt: "2026-01-01T00:00:01Z",
1483-
label: "Ran command",
1484-
tone: "tool",
1485-
toolLifecycleStatus: "failed",
1486-
},
1487-
},
1488-
{
1489-
id: "completed-work-entry",
1490-
kind: "work",
1491-
createdAt: "2026-01-01T00:00:02Z",
1492-
entry: {
1493-
id: "completed-work",
1494-
createdAt: "2026-01-01T00:00:02Z",
1495-
label: "Ran command",
1496-
tone: "tool",
1497-
toolLifecycleStatus: "completed",
1498-
},
1499-
},
1500-
{
1501-
id: "visible-info-entry",
1502-
kind: "work",
1503-
createdAt: "2026-01-01T00:00:03Z",
1504-
entry: {
1505-
id: "visible-info",
1506-
createdAt: "2026-01-01T00:00:03Z",
1507-
label: "Status updated",
1508-
tone: "info",
1509-
},
1510-
},
1511-
],
1512-
isWorking: false,
1513-
activeTurnStartedAt: null,
1514-
turnDiffSummaryByAssistantMessageId: newMap(),
1515-
revertTurnCountByUserMessageId: newMap(),
1516-
});
1473+
it.each([
1474+
["the later success is hidden",["failed","completed","info"],false],
1475+
["the later success is visible",["failed","info","completed"],false],
1476+
["an error-toned entry recovers",["error","info","completed"],false],
1477+
["the final failure is hidden",["completed","failed","info"],true],
1478+
["the final failure is visible",["failed","info","failed"],true],
1479+
["the only failure is visible",["completed","info","failed"],false],
1480+
]asconst)(
1481+
"uses the final tool call for mixed work groups when %s",
1482+
(_,statuses,hasFailure)=>{
1483+
consttimelineEntries=statuses.map((status,index)=>{
1484+
constid=`work-${index}`;
1485+
constcreatedAt=`2026-01-01T00:00:0${index}Z`;
1486+
1487+
return{
1488+
id: `work-entry-${index}`,
1489+
kind: "work"asconst,
1490+
 createdAt,
1491+
entry:
1492+
status==="info"
1493+
 ? { id, createdAt,label: "Status updated",tone: "info"asconst}
1494+
 : status==="error"
1495+
 ? { id, createdAt,label: "Command failed",tone: "error"asconst}
1496+
 : {
1497+
 id,
1498+
 createdAt,
1499+
label: "Ran command",
1500+
tone: "tool"asconst,
1501+
toolLifecycleStatus: status,
1502+
},
1503+
};
1504+
});
15171505

1518-
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1519-
hiddenCount: 2,
1520-
summary: null,
1521-
hasFailure: true,
1522-
});
1523-
});
1506+
constrows=deriveMessagesTimelineRows({
1507+
 timelineEntries,
1508+
isWorking: false,
1509+
activeTurnStartedAt: null,
1510+
turnDiffSummaryByAssistantMessageId: newMap(),
1511+
revertTurnCountByUserMessageId: newMap(),
1512+
});
1513+
1514+
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1515+
hiddenCount: 2,
1516+
summary: null,
1517+
 hasFailure,
1518+
});
1519+
},
1520+
);
15241521
});
15251522

15261523
describe("computeStableMessagesTimelineRows",()=>{
‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,6 +953,8 @@ export function deriveMessagesTimelineRows(input: {
953953
}
954954

955955
if(hiddenEntries.length>0){
956+
constlatestToolEntry=visibleGroupedEntries.findLast(workLogEntryIsToolLike);
957+
956958
nextRows.push({
957959
kind: "work-toggle",
958960
id: `work-toggle:${timelineEntry.id}`,
@@ -963,9 +965,10 @@ export function deriveMessagesTimelineRows(input: {
963965
onlyToolEntries: hiddenEntries.every(workLogEntryIsToolLike),
964966
summary: null,
965967
summaryKind: null,
966-
hasFailure: hiddenEntries.some((entry)=>
967-
workEntryDisplayIndicatesToolFailure(entry),
968-
),
968+
hasFailure:
969+
latestToolEntry!==undefined&&
970+
workEntryDisplayIndicatesToolFailure(latestToolEntry)&&
971+
hiddenEntries.some(workEntryDisplayIndicatesToolFailure),
969972
});
970973
}
971974
}
‎apps/web/src/components/chat/MessagesTimeline.test.tsx‎
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,56 @@ describe("MessagesTimeline", () => {
973973
expect(markup).not.toContain('aria-label="Tool call failed"');
974974
});
975975

976+
it("keeps mixed work logs neutral after a later tool call succeeds",()=>{
977+
constmarkup=renderToStaticMarkup(
978+
<MessagesTimeline
979+
{...buildProps()}
980+
timelineEntries={[
981+
{
982+
id: "entry-failed",
983+
kind: "work",
984+
createdAt: "2026-03-17T19:12:28.000Z",
985+
entry: {
986+
id: "work-failed",
987+
createdAt: "2026-03-17T19:12:28.000Z",
988+
label: "Run search",
989+
tone: "tool",
990+
itemType: "command_execution",
991+
toolLifecycleStatus: "failed",
992+
},
993+
},
994+
{
995+
id: "entry-info",
996+
kind: "work",
997+
createdAt: "2026-03-17T19:12:29.000Z",
998+
entry: {
999+
id: "work-info",
1000+
createdAt: "2026-03-17T19:12:29.000Z",
1001+
label: "Status updated",
1002+
tone: "info",
1003+
},
1004+
},
1005+
{
1006+
id: "entry-completed",
1007+
kind: "work",
1008+
createdAt: "2026-03-17T19:12:30.000Z",
1009+
entry: {
1010+
id: "work-completed",
1011+
createdAt: "2026-03-17T19:12:30.000Z",
1012+
label: "Run tests",
1013+
tone: "tool",
1014+
itemType: "command_execution",
1015+
toolLifecycleStatus: "completed",
1016+
},
1017+
},
1018+
]}
1019+
/>,
1020+
);
1021+
1022+
expect(markup).toContain("+2 previous log entries");
1023+
expect(markup).not.toContain('aria-label="Hidden work includes a failure"');
1024+
});
1025+
9761026
it("shows the animated one-line label for a live tool group",()=>{
9771027
constturnId=TurnId.make("turn-live");
9781028
constmarkup=renderToStaticMarkup(
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit b1670ac
Browse files
t3dotggt3dotgg
authored
fix(web): stop recovered tool failures from marking work logs red (#7999)
1 parent ea8c9e5 commit b1670ac
3 files changed
Lines changed: 103 additions & 53 deletions
File tree
‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎
Lines changed: 47 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,57 +1470,54 @@ describe("deriveMessagesTimelineRows", () => {
14701470
});
14711471
});
14721472

1473-
it("keeps a failure visible when other hidden entries succeeded",()=>{
1474-
constrows=deriveMessagesTimelineRows({
1475-
timelineEntries: [
1476-
{
1477-
id: "failed-work-entry",
1478-
kind: "work",
1479-
createdAt: "2026-01-01T00:00:01Z",
1480-
entry: {
1481-
id: "failed-work",
1482-
createdAt: "2026-01-01T00:00:01Z",
1483-
label: "Ran command",
1484-
tone: "tool",
1485-
toolLifecycleStatus: "failed",
1486-
},
1487-
},
1488-
{
1489-
id: "completed-work-entry",
1490-
kind: "work",
1491-
createdAt: "2026-01-01T00:00:02Z",
1492-
entry: {
1493-
id: "completed-work",
1494-
createdAt: "2026-01-01T00:00:02Z",
1495-
label: "Ran command",
1496-
tone: "tool",
1497-
toolLifecycleStatus: "completed",
1498-
},
1499-
},
1500-
{
1501-
id: "visible-info-entry",
1502-
kind: "work",
1503-
createdAt: "2026-01-01T00:00:03Z",
1504-
entry: {
1505-
id: "visible-info",
1506-
createdAt: "2026-01-01T00:00:03Z",
1507-
label: "Status updated",
1508-
tone: "info",
1509-
},
1510-
},
1511-
],
1512-
isWorking: false,
1513-
activeTurnStartedAt: null,
1514-
turnDiffSummaryByAssistantMessageId: newMap(),
1515-
revertTurnCountByUserMessageId: newMap(),
1516-
});
1473+
it.each([
1474+
["the later success is hidden",["failed","completed","info"],false],
1475+
["the later success is visible",["failed","info","completed"],false],
1476+
["an error-toned entry recovers",["error","info","completed"],false],
1477+
["the final failure is hidden",["completed","failed","info"],true],
1478+
["the final failure is visible",["failed","info","failed"],true],
1479+
["the only failure is visible",["completed","info","failed"],false],
1480+
]asconst)(
1481+
"uses the final tool call for mixed work groups when %s",
1482+
(_,statuses,hasFailure)=>{
1483+
consttimelineEntries=statuses.map((status,index)=>{
1484+
constid=`work-${index}`;
1485+
constcreatedAt=`2026-01-01T00:00:0${index}Z`;
1486+
1487+
return{
1488+
id: `work-entry-${index}`,
1489+
kind: "work"asconst,
1490+
 createdAt,
1491+
entry:
1492+
status==="info"
1493+
 ? { id, createdAt,label: "Status updated",tone: "info"asconst}
1494+
 : status==="error"
1495+
 ? { id, createdAt,label: "Command failed",tone: "error"asconst}
1496+
 : {
1497+
 id,
1498+
 createdAt,
1499+
label: "Ran command",
1500+
tone: "tool"asconst,
1501+
toolLifecycleStatus: status,
1502+
},
1503+
};
1504+
});
15171505

1518-
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1519-
hiddenCount: 2,
1520-
summary: null,
1521-
hasFailure: true,
1522-
});
1523-
});
1506+
constrows=deriveMessagesTimelineRows({
1507+
 timelineEntries,
1508+
isWorking: false,
1509+
activeTurnStartedAt: null,
1510+
turnDiffSummaryByAssistantMessageId: newMap(),
1511+
revertTurnCountByUserMessageId: newMap(),
1512+
});
1513+
1514+
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1515+
hiddenCount: 2,
1516+
summary: null,
1517+
 hasFailure,
1518+
});
1519+
},
1520+
);
15241521
});
15251522

15261523
describe("computeStableMessagesTimelineRows",()=>{
‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,6 +953,8 @@ export function deriveMessagesTimelineRows(input: {
953953
}
954954

955955
if(hiddenEntries.length>0){
956+
constlatestToolEntry=visibleGroupedEntries.findLast(workLogEntryIsToolLike);
957+
956958
nextRows.push({
957959
kind: "work-toggle",
958960
id: `work-toggle:${timelineEntry.id}`,
@@ -963,9 +965,10 @@ export function deriveMessagesTimelineRows(input: {
963965
onlyToolEntries: hiddenEntries.every(workLogEntryIsToolLike),
964966
summary: null,
965967
summaryKind: null,
966-
hasFailure: hiddenEntries.some((entry)=>
967-
workEntryDisplayIndicatesToolFailure(entry),
968-
),
968+
hasFailure:
969+
latestToolEntry!==undefined&&
970+
workEntryDisplayIndicatesToolFailure(latestToolEntry)&&
971+
hiddenEntries.some(workEntryDisplayIndicatesToolFailure),
969972
});
970973
}
971974
}
‎apps/web/src/components/chat/MessagesTimeline.test.tsx‎
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,56 @@ describe("MessagesTimeline", () => {
973973
expect(markup).not.toContain('aria-label="Tool call failed"');
974974
});
975975

976+
it("keeps mixed work logs neutral after a later tool call succeeds",()=>{
977+
constmarkup=renderToStaticMarkup(
978+
<MessagesTimeline
979+
{...buildProps()}
980+
timelineEntries={[
981+
{
982+
id: "entry-failed",
983+
kind: "work",
984+
createdAt: "2026-03-17T19:12:28.000Z",
985+
entry: {
986+
id: "work-failed",
987+
createdAt: "2026-03-17T19:12:28.000Z",
988+
label: "Run search",
989+
tone: "tool",
990+
itemType: "command_execution",
991+
toolLifecycleStatus: "failed",
992+
},
993+
},
994+
{
995+
id: "entry-info",
996+
kind: "work",
997+
createdAt: "2026-03-17T19:12:29.000Z",
998+
entry: {
999+
id: "work-info",
1000+
createdAt: "2026-03-17T19:12:29.000Z",
1001+
label: "Status updated",
1002+
tone: "info",
1003+
},
1004+
},
1005+
{
1006+
id: "entry-completed",
1007+
kind: "work",
1008+
createdAt: "2026-03-17T19:12:30.000Z",
1009+
entry: {
1010+
id: "work-completed",
1011+
createdAt: "2026-03-17T19:12:30.000Z",
1012+
label: "Run tests",
1013+
tone: "tool",
1014+
itemType: "command_execution",
1015+
toolLifecycleStatus: "completed",
1016+
},
1017+
},
1018+
]}
1019+
/>,
1020+
);
1021+
1022+
expect(markup).toContain("+2 previous log entries");
1023+
expect(markup).not.toContain('aria-label="Hidden work includes a failure"');
1024+
});
1025+
9761026
it("shows the animated one-line label for a live tool group",()=>{
9771027
constturnId=TurnId.make("turn-live");
9781028
constmarkup=renderToStaticMarkup(
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit b1670ac
Browse files
t3dotggt3dotgg
authored
fix(web): stop recovered tool failures from marking work logs red (#7999)
1 parent ea8c9e5 commit b1670ac
3 files changed
Lines changed: 103 additions & 53 deletions
File tree
‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎
Lines changed: 47 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,57 +1470,54 @@ describe("deriveMessagesTimelineRows", () => {
14701470
});
14711471
});
14721472

1473-
it("keeps a failure visible when other hidden entries succeeded",()=>{
1474-
constrows=deriveMessagesTimelineRows({
1475-
timelineEntries: [
1476-
{
1477-
id: "failed-work-entry",
1478-
kind: "work",
1479-
createdAt: "2026-01-01T00:00:01Z",
1480-
entry: {
1481-
id: "failed-work",
1482-
createdAt: "2026-01-01T00:00:01Z",
1483-
label: "Ran command",
1484-
tone: "tool",
1485-
toolLifecycleStatus: "failed",
1486-
},
1487-
},
1488-
{
1489-
id: "completed-work-entry",
1490-
kind: "work",
1491-
createdAt: "2026-01-01T00:00:02Z",
1492-
entry: {
1493-
id: "completed-work",
1494-
createdAt: "2026-01-01T00:00:02Z",
1495-
label: "Ran command",
1496-
tone: "tool",
1497-
toolLifecycleStatus: "completed",
1498-
},
1499-
},
1500-
{
1501-
id: "visible-info-entry",
1502-
kind: "work",
1503-
createdAt: "2026-01-01T00:00:03Z",
1504-
entry: {
1505-
id: "visible-info",
1506-
createdAt: "2026-01-01T00:00:03Z",
1507-
label: "Status updated",
1508-
tone: "info",
1509-
},
1510-
},
1511-
],
1512-
isWorking: false,
1513-
activeTurnStartedAt: null,
1514-
turnDiffSummaryByAssistantMessageId: newMap(),
1515-
revertTurnCountByUserMessageId: newMap(),
1516-
});
1473+
it.each([
1474+
["the later success is hidden",["failed","completed","info"],false],
1475+
["the later success is visible",["failed","info","completed"],false],
1476+
["an error-toned entry recovers",["error","info","completed"],false],
1477+
["the final failure is hidden",["completed","failed","info"],true],
1478+
["the final failure is visible",["failed","info","failed"],true],
1479+
["the only failure is visible",["completed","info","failed"],false],
1480+
]asconst)(
1481+
"uses the final tool call for mixed work groups when %s",
1482+
(_,statuses,hasFailure)=>{
1483+
consttimelineEntries=statuses.map((status,index)=>{
1484+
constid=`work-${index}`;
1485+
constcreatedAt=`2026-01-01T00:00:0${index}Z`;
1486+
1487+
return{
1488+
id: `work-entry-${index}`,
1489+
kind: "work"asconst,
1490+
 createdAt,
1491+
entry:
1492+
status==="info"
1493+
 ? { id, createdAt,label: "Status updated",tone: "info"asconst}
1494+
 : status==="error"
1495+
 ? { id, createdAt,label: "Command failed",tone: "error"asconst}
1496+
 : {
1497+
 id,
1498+
 createdAt,
1499+
label: "Ran command",
1500+
tone: "tool"asconst,
1501+
toolLifecycleStatus: status,
1502+
},
1503+
};
1504+
});
15171505

1518-
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1519-
hiddenCount: 2,
1520-
summary: null,
1521-
hasFailure: true,
1522-
});
1523-
});
1506+
constrows=deriveMessagesTimelineRows({
1507+
 timelineEntries,
1508+
isWorking: false,
1509+
activeTurnStartedAt: null,
1510+
turnDiffSummaryByAssistantMessageId: newMap(),
1511+
revertTurnCountByUserMessageId: newMap(),
1512+
});
1513+
1514+
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1515+
hiddenCount: 2,
1516+
summary: null,
1517+
 hasFailure,
1518+
});
1519+
},
1520+
);
15241521
});
15251522

15261523
describe("computeStableMessagesTimelineRows",()=>{
‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,6 +953,8 @@ export function deriveMessagesTimelineRows(input: {
953953
}
954954

955955
if(hiddenEntries.length>0){
956+
constlatestToolEntry=visibleGroupedEntries.findLast(workLogEntryIsToolLike);
957+
956958
nextRows.push({
957959
kind: "work-toggle",
958960
id: `work-toggle:${timelineEntry.id}`,
@@ -963,9 +965,10 @@ export function deriveMessagesTimelineRows(input: {
963965
onlyToolEntries: hiddenEntries.every(workLogEntryIsToolLike),
964966
summary: null,
965967
summaryKind: null,
966-
hasFailure: hiddenEntries.some((entry)=>
967-
workEntryDisplayIndicatesToolFailure(entry),
968-
),
968+
hasFailure:
969+
latestToolEntry!==undefined&&
970+
workEntryDisplayIndicatesToolFailure(latestToolEntry)&&
971+
hiddenEntries.some(workEntryDisplayIndicatesToolFailure),
969972
});
970973
}
971974
}
‎apps/web/src/components/chat/MessagesTimeline.test.tsx‎
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,56 @@ describe("MessagesTimeline", () => {
973973
expect(markup).not.toContain('aria-label="Tool call failed"');
974974
});
975975

976+
it("keeps mixed work logs neutral after a later tool call succeeds",()=>{
977+
constmarkup=renderToStaticMarkup(
978+
<MessagesTimeline
979+
{...buildProps()}
980+
timelineEntries={[
981+
{
982+
id: "entry-failed",
983+
kind: "work",
984+
createdAt: "2026-03-17T19:12:28.000Z",
985+
entry: {
986+
id: "work-failed",
987+
createdAt: "2026-03-17T19:12:28.000Z",
988+
label: "Run search",
989+
tone: "tool",
990+
itemType: "command_execution",
991+
toolLifecycleStatus: "failed",
992+
},
993+
},
994+
{
995+
id: "entry-info",
996+
kind: "work",
997+
createdAt: "2026-03-17T19:12:29.000Z",
998+
entry: {
999+
id: "work-info",
1000+
createdAt: "2026-03-17T19:12:29.000Z",
1001+
label: "Status updated",
1002+
tone: "info",
1003+
},
1004+
},
1005+
{
1006+
id: "entry-completed",
1007+
kind: "work",
1008+
createdAt: "2026-03-17T19:12:30.000Z",
1009+
entry: {
1010+
id: "work-completed",
1011+
createdAt: "2026-03-17T19:12:30.000Z",
1012+
label: "Run tests",
1013+
tone: "tool",
1014+
itemType: "command_execution",
1015+
toolLifecycleStatus: "completed",
1016+
},
1017+
},
1018+
]}
1019+
/>,
1020+
);
1021+
1022+
expect(markup).toContain("+2 previous log entries");
1023+
expect(markup).not.toContain('aria-label="Hidden work includes a failure"');
1024+
});
1025+
9761026
it("shows the animated one-line label for a live tool group",()=>{
9771027
constturnId=TurnId.make("turn-live");
9781028
constmarkup=renderToStaticMarkup(
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Commit b1670ac
Browse files
t3dotggt3dotgg
authored
fix(web): stop recovered tool failures from marking work logs red (#7999)
1 parent ea8c9e5 commit b1670ac
3 files changed
Lines changed: 103 additions & 53 deletions
File tree
‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎
Lines changed: 47 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,57 +1470,54 @@ describe("deriveMessagesTimelineRows", () => {
14701470
});
14711471
});
14721472

1473-
it("keeps a failure visible when other hidden entries succeeded",()=>{
1474-
constrows=deriveMessagesTimelineRows({
1475-
timelineEntries: [
1476-
{
1477-
id: "failed-work-entry",
1478-
kind: "work",
1479-
createdAt: "2026-01-01T00:00:01Z",
1480-
entry: {
1481-
id: "failed-work",
1482-
createdAt: "2026-01-01T00:00:01Z",
1483-
label: "Ran command",
1484-
tone: "tool",
1485-
toolLifecycleStatus: "failed",
1486-
},
1487-
},
1488-
{
1489-
id: "completed-work-entry",
1490-
kind: "work",
1491-
createdAt: "2026-01-01T00:00:02Z",
1492-
entry: {
1493-
id: "completed-work",
1494-
createdAt: "2026-01-01T00:00:02Z",
1495-
label: "Ran command",
1496-
tone: "tool",
1497-
toolLifecycleStatus: "completed",
1498-
},
1499-
},
1500-
{
1501-
id: "visible-info-entry",
1502-
kind: "work",
1503-
createdAt: "2026-01-01T00:00:03Z",
1504-
entry: {
1505-
id: "visible-info",
1506-
createdAt: "2026-01-01T00:00:03Z",
1507-
label: "Status updated",
1508-
tone: "info",
1509-
},
1510-
},
1511-
],
1512-
isWorking: false,
1513-
activeTurnStartedAt: null,
1514-
turnDiffSummaryByAssistantMessageId: newMap(),
1515-
revertTurnCountByUserMessageId: newMap(),
1516-
});
1473+
it.each([
1474+
["the later success is hidden",["failed","completed","info"],false],
1475+
["the later success is visible",["failed","info","completed"],false],
1476+
["an error-toned entry recovers",["error","info","completed"],false],
1477+
["the final failure is hidden",["completed","failed","info"],true],
1478+
["the final failure is visible",["failed","info","failed"],true],
1479+
["the only failure is visible",["completed","info","failed"],false],
1480+
]asconst)(
1481+
"uses the final tool call for mixed work groups when %s",
1482+
(_,statuses,hasFailure)=>{
1483+
consttimelineEntries=statuses.map((status,index)=>{
1484+
constid=`work-${index}`;
1485+
constcreatedAt=`2026-01-01T00:00:0${index}Z`;
1486+
1487+
return{
1488+
id: `work-entry-${index}`,
1489+
kind: "work"asconst,
1490+
 createdAt,
1491+
entry:
1492+
status==="info"
1493+
 ? { id, createdAt,label: "Status updated",tone: "info"asconst}
1494+
 : status==="error"
1495+
 ? { id, createdAt,label: "Command failed",tone: "error"asconst}
1496+
 : {
1497+
 id,
1498+
 createdAt,
1499+
label: "Ran command",
1500+
tone: "tool"asconst,
1501+
toolLifecycleStatus: status,
1502+
},
1503+
};
1504+
});
15171505

1518-
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1519-
hiddenCount: 2,
1520-
summary: null,
1521-
hasFailure: true,
1522-
});
1523-
});
1506+
constrows=deriveMessagesTimelineRows({
1507+
 timelineEntries,
1508+
isWorking: false,
1509+
activeTurnStartedAt: null,
1510+
turnDiffSummaryByAssistantMessageId: newMap(),
1511+
revertTurnCountByUserMessageId: newMap(),
1512+
});
1513+
1514+
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1515+
hiddenCount: 2,
1516+
summary: null,
1517+
 hasFailure,
1518+
});
1519+
},
1520+
);
15241521
});
15251522

15261523
describe("computeStableMessagesTimelineRows",()=>{
‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,6 +953,8 @@ export function deriveMessagesTimelineRows(input: {
953953
}
954954

955955
if(hiddenEntries.length>0){
956+
constlatestToolEntry=visibleGroupedEntries.findLast(workLogEntryIsToolLike);
957+
956958
nextRows.push({
957959
kind: "work-toggle",
958960
id: `work-toggle:${timelineEntry.id}`,
@@ -963,9 +965,10 @@ export function deriveMessagesTimelineRows(input: {
963965
onlyToolEntries: hiddenEntries.every(workLogEntryIsToolLike),
964966
summary: null,
965967
summaryKind: null,
966-
hasFailure: hiddenEntries.some((entry)=>
967-
workEntryDisplayIndicatesToolFailure(entry),
968-
),
968+
hasFailure:
969+
latestToolEntry!==undefined&&
970+
workEntryDisplayIndicatesToolFailure(latestToolEntry)&&
971+
hiddenEntries.some(workEntryDisplayIndicatesToolFailure),
969972
});
970973
}
971974
}
‎apps/web/src/components/chat/MessagesTimeline.test.tsx‎
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,56 @@ describe("MessagesTimeline", () => {
973973
expect(markup).not.toContain('aria-label="Tool call failed"');
974974
});
975975

976+
it("keeps mixed work logs neutral after a later tool call succeeds",()=>{
977+
constmarkup=renderToStaticMarkup(
978+
<MessagesTimeline
979+
{...buildProps()}
980+
timelineEntries={[
981+
{
982+
id: "entry-failed",
983+
kind: "work",
984+
createdAt: "2026-03-17T19:12:28.000Z",
985+
entry: {
986+
id: "work-failed",
987+
createdAt: "2026-03-17T19:12:28.000Z",
988+
label: "Run search",
989+
tone: "tool",
990+
itemType: "command_execution",
991+
toolLifecycleStatus: "failed",
992+
},
993+
},
994+
{
995+
id: "entry-info",
996+
kind: "work",
997+
createdAt: "2026-03-17T19:12:29.000Z",
998+
entry: {
999+
id: "work-info",
1000+
createdAt: "2026-03-17T19:12:29.000Z",
1001+
label: "Status updated",
1002+
tone: "info",
1003+
},
1004+
},
1005+
{
1006+
id: "entry-completed",
1007+
kind: "work",
1008+
createdAt: "2026-03-17T19:12:30.000Z",
1009+
entry: {
1010+
id: "work-completed",
1011+
createdAt: "2026-03-17T19:12:30.000Z",
1012+
label: "Run tests",
1013+
tone: "tool",
1014+
itemType: "command_execution",
1015+
toolLifecycleStatus: "completed",
1016+
},
1017+
},
1018+
]}
1019+
/>,
1020+
);
1021+
1022+
expect(markup).toContain("+2 previous log entries");
1023+
expect(markup).not.toContain('aria-label="Hidden work includes a failure"');
1024+
});
1025+
9761026
it("shows the animated one-line label for a live tool group",()=>{
9771027
constturnId=TurnId.make("turn-live");
9781028
constmarkup=renderToStaticMarkup(
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit b1670ac
Browse files
t3dotggt3dotgg
authored
fix(web): stop recovered tool failures from marking work logs red (#7999)
1 parent ea8c9e5 commit b1670ac
3 files changed
Lines changed: 103 additions & 53 deletions
File tree
‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎
Lines changed: 47 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,57 +1470,54 @@ describe("deriveMessagesTimelineRows", () => {
14701470
});
14711471
});
14721472

1473-
it("keeps a failure visible when other hidden entries succeeded",()=>{
1474-
constrows=deriveMessagesTimelineRows({
1475-
timelineEntries: [
1476-
{
1477-
id: "failed-work-entry",
1478-
kind: "work",
1479-
createdAt: "2026-01-01T00:00:01Z",
1480-
entry: {
1481-
id: "failed-work",
1482-
createdAt: "2026-01-01T00:00:01Z",
1483-
label: "Ran command",
1484-
tone: "tool",
1485-
toolLifecycleStatus: "failed",
1486-
},
1487-
},
1488-
{
1489-
id: "completed-work-entry",
1490-
kind: "work",
1491-
createdAt: "2026-01-01T00:00:02Z",
1492-
entry: {
1493-
id: "completed-work",
1494-
createdAt: "2026-01-01T00:00:02Z",
1495-
label: "Ran command",
1496-
tone: "tool",
1497-
toolLifecycleStatus: "completed",
1498-
},
1499-
},
1500-
{
1501-
id: "visible-info-entry",
1502-
kind: "work",
1503-
createdAt: "2026-01-01T00:00:03Z",
1504-
entry: {
1505-
id: "visible-info",
1506-
createdAt: "2026-01-01T00:00:03Z",
1507-
label: "Status updated",
1508-
tone: "info",
1509-
},
1510-
},
1511-
],
1512-
isWorking: false,
1513-
activeTurnStartedAt: null,
1514-
turnDiffSummaryByAssistantMessageId: newMap(),
1515-
revertTurnCountByUserMessageId: newMap(),
1516-
});
1473+
it.each([
1474+
["the later success is hidden",["failed","completed","info"],false],
1475+
["the later success is visible",["failed","info","completed"],false],
1476+
["an error-toned entry recovers",["error","info","completed"],false],
1477+
["the final failure is hidden",["completed","failed","info"],true],
1478+
["the final failure is visible",["failed","info","failed"],true],
1479+
["the only failure is visible",["completed","info","failed"],false],
1480+
]asconst)(
1481+
"uses the final tool call for mixed work groups when %s",
1482+
(_,statuses,hasFailure)=>{
1483+
consttimelineEntries=statuses.map((status,index)=>{
1484+
constid=`work-${index}`;
1485+
constcreatedAt=`2026-01-01T00:00:0${index}Z`;
1486+
1487+
return{
1488+
id: `work-entry-${index}`,
1489+
kind: "work"asconst,
1490+
 createdAt,
1491+
entry:
1492+
status==="info"
1493+
 ? { id, createdAt,label: "Status updated",tone: "info"asconst}
1494+
 : status==="error"
1495+
 ? { id, createdAt,label: "Command failed",tone: "error"asconst}
1496+
 : {
1497+
 id,
1498+
 createdAt,
1499+
label: "Ran command",
1500+
tone: "tool"asconst,
1501+
toolLifecycleStatus: status,
1502+
},
1503+
};
1504+
});
15171505

1518-
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1519-
hiddenCount: 2,
1520-
summary: null,
1521-
hasFailure: true,
1522-
});
1523-
});
1506+
constrows=deriveMessagesTimelineRows({
1507+
 timelineEntries,
1508+
isWorking: false,
1509+
activeTurnStartedAt: null,
1510+
turnDiffSummaryByAssistantMessageId: newMap(),
1511+
revertTurnCountByUserMessageId: newMap(),
1512+
});
1513+
1514+
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1515+
hiddenCount: 2,
1516+
summary: null,
1517+
 hasFailure,
1518+
});
1519+
},
1520+
);
15241521
});
15251522

15261523
describe("computeStableMessagesTimelineRows",()=>{
‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,6 +953,8 @@ export function deriveMessagesTimelineRows(input: {
953953
}
954954

955955
if(hiddenEntries.length>0){
956+
constlatestToolEntry=visibleGroupedEntries.findLast(workLogEntryIsToolLike);
957+
956958
nextRows.push({
957959
kind: "work-toggle",
958960
id: `work-toggle:${timelineEntry.id}`,
@@ -963,9 +965,10 @@ export function deriveMessagesTimelineRows(input: {
963965
onlyToolEntries: hiddenEntries.every(workLogEntryIsToolLike),
964966
summary: null,
965967
summaryKind: null,
966-
hasFailure: hiddenEntries.some((entry)=>
967-
workEntryDisplayIndicatesToolFailure(entry),
968-
),
968+
hasFailure:
969+
latestToolEntry!==undefined&&
970+
workEntryDisplayIndicatesToolFailure(latestToolEntry)&&
971+
hiddenEntries.some(workEntryDisplayIndicatesToolFailure),
969972
});
970973
}
971974
}
‎apps/web/src/components/chat/MessagesTimeline.test.tsx‎
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,56 @@ describe("MessagesTimeline", () => {
973973
expect(markup).not.toContain('aria-label="Tool call failed"');
974974
});
975975

976+
it("keeps mixed work logs neutral after a later tool call succeeds",()=>{
977+
constmarkup=renderToStaticMarkup(
978+
<MessagesTimeline
979+
{...buildProps()}
980+
timelineEntries={[
981+
{
982+
id: "entry-failed",
983+
kind: "work",
984+
createdAt: "2026-03-17T19:12:28.000Z",
985+
entry: {
986+
id: "work-failed",
987+
createdAt: "2026-03-17T19:12:28.000Z",
988+
label: "Run search",
989+
tone: "tool",
990+
itemType: "command_execution",
991+
toolLifecycleStatus: "failed",
992+
},
993+
},
994+
{
995+
id: "entry-info",
996+
kind: "work",
997+
createdAt: "2026-03-17T19:12:29.000Z",
998+
entry: {
999+
id: "work-info",
1000+
createdAt: "2026-03-17T19:12:29.000Z",
1001+
label: "Status updated",
1002+
tone: "info",
1003+
},
1004+
},
1005+
{
1006+
id: "entry-completed",
1007+
kind: "work",
1008+
createdAt: "2026-03-17T19:12:30.000Z",
1009+
entry: {
1010+
id: "work-completed",
1011+
createdAt: "2026-03-17T19:12:30.000Z",
1012+
label: "Run tests",
1013+
tone: "tool",
1014+
itemType: "command_execution",
1015+
toolLifecycleStatus: "completed",
1016+
},
1017+
},
1018+
]}
1019+
/>,
1020+
);
1021+
1022+
expect(markup).toContain("+2 previous log entries");
1023+
expect(markup).not.toContain('aria-label="Hidden work includes a failure"');
1024+
});
1025+
9761026
it("shows the animated one-line label for a live tool group",()=>{
9771027
constturnId=TurnId.make("turn-live");
9781028
constmarkup=renderToStaticMarkup(
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit b1670ac
Browse files
t3dotggt3dotgg
authored
fix(web): stop recovered tool failures from marking work logs red (#7999)
1 parent ea8c9e5 commit b1670ac
3 files changed
Lines changed: 103 additions & 53 deletions
File tree
‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎
Lines changed: 47 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,57 +1470,54 @@ describe("deriveMessagesTimelineRows", () => {
14701470
});
14711471
});
14721472

1473-
it("keeps a failure visible when other hidden entries succeeded",()=>{
1474-
constrows=deriveMessagesTimelineRows({
1475-
timelineEntries: [
1476-
{
1477-
id: "failed-work-entry",
1478-
kind: "work",
1479-
createdAt: "2026-01-01T00:00:01Z",
1480-
entry: {
1481-
id: "failed-work",
1482-
createdAt: "2026-01-01T00:00:01Z",
1483-
label: "Ran command",
1484-
tone: "tool",
1485-
toolLifecycleStatus: "failed",
1486-
},
1487-
},
1488-
{
1489-
id: "completed-work-entry",
1490-
kind: "work",
1491-
createdAt: "2026-01-01T00:00:02Z",
1492-
entry: {
1493-
id: "completed-work",
1494-
createdAt: "2026-01-01T00:00:02Z",
1495-
label: "Ran command",
1496-
tone: "tool",
1497-
toolLifecycleStatus: "completed",
1498-
},
1499-
},
1500-
{
1501-
id: "visible-info-entry",
1502-
kind: "work",
1503-
createdAt: "2026-01-01T00:00:03Z",
1504-
entry: {
1505-
id: "visible-info",
1506-
createdAt: "2026-01-01T00:00:03Z",
1507-
label: "Status updated",
1508-
tone: "info",
1509-
},
1510-
},
1511-
],
1512-
isWorking: false,
1513-
activeTurnStartedAt: null,
1514-
turnDiffSummaryByAssistantMessageId: newMap(),
1515-
revertTurnCountByUserMessageId: newMap(),
1516-
});
1473+
it.each([
1474+
["the later success is hidden",["failed","completed","info"],false],
1475+
["the later success is visible",["failed","info","completed"],false],
1476+
["an error-toned entry recovers",["error","info","completed"],false],
1477+
["the final failure is hidden",["completed","failed","info"],true],
1478+
["the final failure is visible",["failed","info","failed"],true],
1479+
["the only failure is visible",["completed","info","failed"],false],
1480+
]asconst)(
1481+
"uses the final tool call for mixed work groups when %s",
1482+
(_,statuses,hasFailure)=>{
1483+
consttimelineEntries=statuses.map((status,index)=>{
1484+
constid=`work-${index}`;
1485+
constcreatedAt=`2026-01-01T00:00:0${index}Z`;
1486+
1487+
return{
1488+
id: `work-entry-${index}`,
1489+
kind: "work"asconst,
1490+
 createdAt,
1491+
entry:
1492+
status==="info"
1493+
 ? { id, createdAt,label: "Status updated",tone: "info"asconst}
1494+
 : status==="error"
1495+
 ? { id, createdAt,label: "Command failed",tone: "error"asconst}
1496+
 : {
1497+
 id,
1498+
 createdAt,
1499+
label: "Ran command",
1500+
tone: "tool"asconst,
1501+
toolLifecycleStatus: status,
1502+
},
1503+
};
1504+
});
15171505

1518-
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1519-
hiddenCount: 2,
1520-
summary: null,
1521-
hasFailure: true,
1522-
});
1523-
});
1506+
constrows=deriveMessagesTimelineRows({
1507+
 timelineEntries,
1508+
isWorking: false,
1509+
activeTurnStartedAt: null,
1510+
turnDiffSummaryByAssistantMessageId: newMap(),
1511+
revertTurnCountByUserMessageId: newMap(),
1512+
});
1513+
1514+
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1515+
hiddenCount: 2,
1516+
summary: null,
1517+
 hasFailure,
1518+
});
1519+
},
1520+
);
15241521
});
15251522

15261523
describe("computeStableMessagesTimelineRows",()=>{
‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,6 +953,8 @@ export function deriveMessagesTimelineRows(input: {
953953
}
954954

955955
if(hiddenEntries.length>0){
956+
constlatestToolEntry=visibleGroupedEntries.findLast(workLogEntryIsToolLike);
957+
956958
nextRows.push({
957959
kind: "work-toggle",
958960
id: `work-toggle:${timelineEntry.id}`,
@@ -963,9 +965,10 @@ export function deriveMessagesTimelineRows(input: {
963965
onlyToolEntries: hiddenEntries.every(workLogEntryIsToolLike),
964966
summary: null,
965967
summaryKind: null,
966-
hasFailure: hiddenEntries.some((entry)=>
967-
workEntryDisplayIndicatesToolFailure(entry),
968-
),
968+
hasFailure:
969+
latestToolEntry!==undefined&&
970+
workEntryDisplayIndicatesToolFailure(latestToolEntry)&&
971+
hiddenEntries.some(workEntryDisplayIndicatesToolFailure),
969972
});
970973
}
971974
}
‎apps/web/src/components/chat/MessagesTimeline.test.tsx‎
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,56 @@ describe("MessagesTimeline", () => {
973973
expect(markup).not.toContain('aria-label="Tool call failed"');
974974
});
975975

976+
it("keeps mixed work logs neutral after a later tool call succeeds",()=>{
977+
constmarkup=renderToStaticMarkup(
978+
<MessagesTimeline
979+
{...buildProps()}
980+
timelineEntries={[
981+
{
982+
id: "entry-failed",
983+
kind: "work",
984+
createdAt: "2026-03-17T19:12:28.000Z",
985+
entry: {
986+
id: "work-failed",
987+
createdAt: "2026-03-17T19:12:28.000Z",
988+
label: "Run search",
989+
tone: "tool",
990+
itemType: "command_execution",
991+
toolLifecycleStatus: "failed",
992+
},
993+
},
994+
{
995+
id: "entry-info",
996+
kind: "work",
997+
createdAt: "2026-03-17T19:12:29.000Z",
998+
entry: {
999+
id: "work-info",
1000+
createdAt: "2026-03-17T19:12:29.000Z",
1001+
label: "Status updated",
1002+
tone: "info",
1003+
},
1004+
},
1005+
{
1006+
id: "entry-completed",
1007+
kind: "work",
1008+
createdAt: "2026-03-17T19:12:30.000Z",
1009+
entry: {
1010+
id: "work-completed",
1011+
createdAt: "2026-03-17T19:12:30.000Z",
1012+
label: "Run tests",
1013+
tone: "tool",
1014+
itemType: "command_execution",
1015+
toolLifecycleStatus: "completed",
1016+
},
1017+
},
1018+
]}
1019+
/>,
1020+
);
1021+
1022+
expect(markup).toContain("+2 previous log entries");
1023+
expect(markup).not.toContain('aria-label="Hidden work includes a failure"');
1024+
});
1025+
9761026
it("shows the animated one-line label for a live tool group",()=>{
9771027
constturnId=TurnId.make("turn-live");
9781028
constmarkup=renderToStaticMarkup(
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Commit b1670ac
Browse files
t3dotggt3dotgg
authored
fix(web): stop recovered tool failures from marking work logs red (#7999)
1 parent ea8c9e5 commit b1670ac
3 files changed
Lines changed: 103 additions & 53 deletions
File tree
‎apps/web/src/components/chat/MessagesTimeline.logic.test.ts‎
Lines changed: 47 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,57 +1470,54 @@ describe("deriveMessagesTimelineRows", () => {
14701470
});
14711471
});
14721472

1473-
it("keeps a failure visible when other hidden entries succeeded",()=>{
1474-
constrows=deriveMessagesTimelineRows({
1475-
timelineEntries: [
1476-
{
1477-
id: "failed-work-entry",
1478-
kind: "work",
1479-
createdAt: "2026-01-01T00:00:01Z",
1480-
entry: {
1481-
id: "failed-work",
1482-
createdAt: "2026-01-01T00:00:01Z",
1483-
label: "Ran command",
1484-
tone: "tool",
1485-
toolLifecycleStatus: "failed",
1486-
},
1487-
},
1488-
{
1489-
id: "completed-work-entry",
1490-
kind: "work",
1491-
createdAt: "2026-01-01T00:00:02Z",
1492-
entry: {
1493-
id: "completed-work",
1494-
createdAt: "2026-01-01T00:00:02Z",
1495-
label: "Ran command",
1496-
tone: "tool",
1497-
toolLifecycleStatus: "completed",
1498-
},
1499-
},
1500-
{
1501-
id: "visible-info-entry",
1502-
kind: "work",
1503-
createdAt: "2026-01-01T00:00:03Z",
1504-
entry: {
1505-
id: "visible-info",
1506-
createdAt: "2026-01-01T00:00:03Z",
1507-
label: "Status updated",
1508-
tone: "info",
1509-
},
1510-
},
1511-
],
1512-
isWorking: false,
1513-
activeTurnStartedAt: null,
1514-
turnDiffSummaryByAssistantMessageId: newMap(),
1515-
revertTurnCountByUserMessageId: newMap(),
1516-
});
1473+
it.each([
1474+
["the later success is hidden",["failed","completed","info"],false],
1475+
["the later success is visible",["failed","info","completed"],false],
1476+
["an error-toned entry recovers",["error","info","completed"],false],
1477+
["the final failure is hidden",["completed","failed","info"],true],
1478+
["the final failure is visible",["failed","info","failed"],true],
1479+
["the only failure is visible",["completed","info","failed"],false],
1480+
]asconst)(
1481+
"uses the final tool call for mixed work groups when %s",
1482+
(_,statuses,hasFailure)=>{
1483+
consttimelineEntries=statuses.map((status,index)=>{
1484+
constid=`work-${index}`;
1485+
constcreatedAt=`2026-01-01T00:00:0${index}Z`;
1486+
1487+
return{
1488+
id: `work-entry-${index}`,
1489+
kind: "work"asconst,
1490+
 createdAt,
1491+
entry:
1492+
status==="info"
1493+
 ? { id, createdAt,label: "Status updated",tone: "info"asconst}
1494+
 : status==="error"
1495+
 ? { id, createdAt,label: "Command failed",tone: "error"asconst}
1496+
 : {
1497+
 id,
1498+
 createdAt,
1499+
label: "Ran command",
1500+
tone: "tool"asconst,
1501+
toolLifecycleStatus: status,
1502+
},
1503+
};
1504+
});
15171505

1518-
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1519-
hiddenCount: 2,
1520-
summary: null,
1521-
hasFailure: true,
1522-
});
1523-
});
1506+
constrows=deriveMessagesTimelineRows({
1507+
 timelineEntries,
1508+
isWorking: false,
1509+
activeTurnStartedAt: null,
1510+
turnDiffSummaryByAssistantMessageId: newMap(),
1511+
revertTurnCountByUserMessageId: newMap(),
1512+
});
1513+
1514+
expect(rows.find((row)=>row.kind==="work-toggle")).toMatchObject({
1515+
hiddenCount: 2,
1516+
summary: null,
1517+
 hasFailure,
1518+
});
1519+
},
1520+
);
15241521
});
15251522

15261523
describe("computeStableMessagesTimelineRows",()=>{
‎apps/web/src/components/chat/MessagesTimeline.logic.ts‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -953,6 +953,8 @@ export function deriveMessagesTimelineRows(input: {
953953
}
954954

955955
if(hiddenEntries.length>0){
956+
constlatestToolEntry=visibleGroupedEntries.findLast(workLogEntryIsToolLike);
957+
956958
nextRows.push({
957959
kind: "work-toggle",
958960
id: `work-toggle:${timelineEntry.id}`,
@@ -963,9 +965,10 @@ export function deriveMessagesTimelineRows(input: {
963965
onlyToolEntries: hiddenEntries.every(workLogEntryIsToolLike),
964966
summary: null,
965967
summaryKind: null,
966-
hasFailure: hiddenEntries.some((entry)=>
967-
workEntryDisplayIndicatesToolFailure(entry),
968-
),
968+
hasFailure:
969+
latestToolEntry!==undefined&&
970+
workEntryDisplayIndicatesToolFailure(latestToolEntry)&&
971+
hiddenEntries.some(workEntryDisplayIndicatesToolFailure),
969972
});
970973
}
971974
}
‎apps/web/src/components/chat/MessagesTimeline.test.tsx‎
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,56 @@ describe("MessagesTimeline", () => {
973973
expect(markup).not.toContain('aria-label="Tool call failed"');
974974
});
975975

976+
it("keeps mixed work logs neutral after a later tool call succeeds",()=>{
977+
constmarkup=renderToStaticMarkup(
978+
<MessagesTimeline
979+
{...buildProps()}
980+
timelineEntries={[
981+
{
982+
id: "entry-failed",
983+
kind: "work",
984+
createdAt: "2026-03-17T19:12:28.000Z",
985+
entry: {
986+
id: "work-failed",
987+
createdAt: "2026-03-17T19:12:28.000Z",
988+
label: "Run search",
989+
tone: "tool",
990+
itemType: "command_execution",
991+
toolLifecycleStatus: "failed",
992+
},
993+
},
994+
{
995+
id: "entry-info",
996+
kind: "work",
997+
createdAt: "2026-03-17T19:12:29.000Z",
998+
entry: {
999+
id: "work-info",
1000+
createdAt: "2026-03-17T19:12:29.000Z",
1001+
label: "Status updated",
1002+
tone: "info",
1003+
},
1004+
},
1005+
{
1006+
id: "entry-completed",
1007+
kind: "work",
1008+
createdAt: "2026-03-17T19:12:30.000Z",
1009+
entry: {
1010+
id: "work-completed",
1011+
createdAt: "2026-03-17T19:12:30.000Z",
1012+
label: "Run tests",
1013+
tone: "tool",
1014+
itemType: "command_execution",
1015+
toolLifecycleStatus: "completed",
1016+
},
1017+
},
1018+
]}
1019+
/>,
1020+
);
1021+
1022+
expect(markup).toContain("+2 previous log entries");
1023+
expect(markup).not.toContain('aria-label="Hidden work includes a failure"');
1024+
});
1025+
9761026
it("shows the animated one-line label for a live tool group",()=>{
9771027
constturnId=TurnId.make("turn-live");
9781028
constmarkup=renderToStaticMarkup(
0 commit comments
Comments
 (0)