From e7536e840b1923dab5d574e0aa8318a72b076d7c Mon Sep 17 00:00:00 2001 From: Nicolle Romero Date: Thu, 15 Sep 2022 12:47:12 -0700 Subject: [PATCH 1/2] Only run replaceChildren with htmlContainer change --- src/drafts/MarkdownViewer/MarkdownViewer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drafts/MarkdownViewer/MarkdownViewer.tsx b/src/drafts/MarkdownViewer/MarkdownViewer.tsx index 5e0b0afa8f3..209ecd4274a 100644 --- a/src/drafts/MarkdownViewer/MarkdownViewer.tsx +++ b/src/drafts/MarkdownViewer/MarkdownViewer.tsx @@ -107,7 +107,7 @@ const MarkdownViewer = ({ // If we were to inject the `...htmlContainer.children` instead of the container element itself, // those children elements would be moved from the `htmlContainer` to the `outputContainer`. Then if // other effects use `htmlContainer.querySelectorAll`, they wouldn't find any elements to affect - useEffect(() => outputContainerRef.current?.replaceChildren(htmlContainer)) + useEffect(() => outputContainerRef.current?.replaceChildren(htmlContainer), [htmlContainer]) return loading ? ( From ff4b1482ffeed043fc441047c06d061356254348 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Wed, 21 Sep 2022 10:33:35 -0700 Subject: [PATCH 2/2] Create weak-hotels-shout.md --- .changeset/weak-hotels-shout.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/weak-hotels-shout.md diff --git a/.changeset/weak-hotels-shout.md b/.changeset/weak-hotels-shout.md new file mode 100644 index 00000000000..48b0be09f5d --- /dev/null +++ b/.changeset/weak-hotels-shout.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +MarkdownViewer bug fix: Only run `replaceChildren` when `htmlContainer` changes