From 0d92dcd793aea9a20897b889cc5e6ea737b41272 Mon Sep 17 00:00:00 2001
From: Armagan Ersoz <broccolinisoup@github.com>
Date: Tue, 8 Nov 2022 13:26:31 +1000
Subject: [PATCH 1/6] aria-hidden for visible More menu text and sr-only
 equavalent for screen readers and add list for tul

---
 src/UnderlineNav2/UnderlineNav.tsx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/UnderlineNav2/UnderlineNav.tsx b/src/UnderlineNav2/UnderlineNav.tsx
index b58470ecdc3..6d9fa255b0c 100644
--- a/src/UnderlineNav2/UnderlineNav.tsx
+++ b/src/UnderlineNav2/UnderlineNav.tsx
@@ -312,7 +312,7 @@ export const UnderlineNav = forwardRef(
           aria-label={ariaLabel}
           ref={navRef}
         >
-          <NavigationList sx={ulStyles} ref={listRef}>
+          <NavigationList sx={ulStyles} ref={listRef} role="list">
             {responsiveProps.items}
             {actions.length > 0 && (
               <MoreMenuListItem ref={moreMenuRef}>
@@ -325,7 +325,10 @@ export const UnderlineNav = forwardRef(
                   onClick={onAnchorClick}
                   trailingIcon={TriangleDownIcon}
                 >
-                  More
+                  <Box as="span" aria-hidden="true">
+                    More
+                  </Box>
+                  <VisuallyHidden as="span">{`More: ${ariaLabel} items`}</VisuallyHidden>
                 </Button>
                 <ActionList
                   selectionVariant="single"

From 87e1346fb0144fba5b3b3dba2ba3d170c13e2885 Mon Sep 17 00:00:00 2001
From: Armagan Ersoz <broccolinisoup@github.com>
Date: Tue, 8 Nov 2022 13:31:21 +1000
Subject: [PATCH 2/6] add changeset

---
 .changeset/great-shirts-sort.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/great-shirts-sort.md

diff --git a/.changeset/great-shirts-sort.md b/.changeset/great-shirts-sort.md
new file mode 100644
index 00000000000..aec40b9a858
--- /dev/null
+++ b/.changeset/great-shirts-sort.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+UnderlineNav2: Add aria-hidden and sr-only class support for a descriptive "More" button label

From b81f66c62c2a8f7eed9ddb554aeb5d3fb0e542d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arma=C4=9Fan?= <broccolinisoup@github.com>
Date: Wed, 9 Nov 2022 08:39:51 +1000
Subject: [PATCH 3/6] Make sure to have "More" text command between visible and
 accessible button label

Co-authored-by: Josh Black <joshblack@github.com>
---
 src/UnderlineNav2/UnderlineNav.tsx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/UnderlineNav2/UnderlineNav.tsx b/src/UnderlineNav2/UnderlineNav.tsx
index 6d9fa255b0c..b8a9665aa0f 100644
--- a/src/UnderlineNav2/UnderlineNav.tsx
+++ b/src/UnderlineNav2/UnderlineNav.tsx
@@ -325,10 +325,10 @@ export const UnderlineNav = forwardRef(
                   onClick={onAnchorClick}
                   trailingIcon={TriangleDownIcon}
                 >
-                  <Box as="span" aria-hidden="true">
-                    More
+                  <Box as="span">
+                    More <VisuallyHidden as="span">{`${ariaLabel} items`}</VisuallyHidden>
                   </Box>
-                  <VisuallyHidden as="span">{`More: ${ariaLabel} items`}</VisuallyHidden>
+                  
                 </Button>
                 <ActionList
                   selectionVariant="single"

From 695688e0df59922d02eb206c9899a5ddd2fd06a1 Mon Sep 17 00:00:00 2001
From: Armagan Ersoz <broccolinisoup@github.com>
Date: Wed, 9 Nov 2022 08:50:42 +1000
Subject: [PATCH 4/6] apply prettier because committed via GitHub UI

---
 src/UnderlineNav2/UnderlineNav.tsx | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/UnderlineNav2/UnderlineNav.tsx b/src/UnderlineNav2/UnderlineNav.tsx
index b8a9665aa0f..be7b52f29b5 100644
--- a/src/UnderlineNav2/UnderlineNav.tsx
+++ b/src/UnderlineNav2/UnderlineNav.tsx
@@ -328,7 +328,6 @@ export const UnderlineNav = forwardRef(
                   <Box as="span">
                     More <VisuallyHidden as="span">{`${ariaLabel} items`}</VisuallyHidden>
                   </Box>
-                  
                 </Button>
                 <ActionList
                   selectionVariant="single"

From aa07685ef5c0f61f4f681e1170b53ffe5f391c58 Mon Sep 17 00:00:00 2001
From: Armagan Ersoz <broccolinisoup@github.com>
Date: Thu, 10 Nov 2022 11:15:31 +1000
Subject: [PATCH 5/6] Update interaction test to include button's new
 accessible name

---
 src/UnderlineNav2/interactions.stories.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/UnderlineNav2/interactions.stories.tsx b/src/UnderlineNav2/interactions.stories.tsx
index 5853d66407b..c38e1aa0e82 100644
--- a/src/UnderlineNav2/interactions.stories.tsx
+++ b/src/UnderlineNav2/interactions.stories.tsx
@@ -79,7 +79,7 @@ SelectAMenuItem.play = async ({canvasElement}: {canvasElement: HTMLElement}) =>
   canvasElement.style.width = '800px'
   await delay(2000)
   const canvas = within(canvasElement)
-  const moreBtn = canvas.getByRole('button', {name: 'More'})
+  const moreBtn = canvas.getByRole('button', {name: 'More Repository items'})
   userEvent.hover(moreBtn)
   await delay(1000)
   userEvent.click(moreBtn)

From eaeff03464722ee34862b514123e1f46cb2d0857 Mon Sep 17 00:00:00 2001
From: Armagan Ersoz <broccolinisoup@github.com>
Date: Thu, 10 Nov 2022 11:32:27 +1000
Subject: [PATCH 6/6] update snapshots

---
 src/UnderlineNav2/__snapshots__/UnderlineNav.test.tsx.snap | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/UnderlineNav2/__snapshots__/UnderlineNav.test.tsx.snap b/src/UnderlineNav2/__snapshots__/UnderlineNav.test.tsx.snap
index a31b5ea8a09..593e604d97e 100644
--- a/src/UnderlineNav2/__snapshots__/UnderlineNav.test.tsx.snap
+++ b/src/UnderlineNav2/__snapshots__/UnderlineNav.test.tsx.snap
@@ -200,6 +200,7 @@ exports[`UnderlineNav renders consistently 1`] = `
   >
     <ul
       className="c2"
+      role="list"
     >
       <li
         className="c3"