From a1d7afcd8eae3b548870e34ae145662c31f548e4 Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Wed, 5 Feb 2025 09:51:02 -0500 Subject: [PATCH 1/3] Add `aria-current` to `SubNav` --- packages/react/src/SubNav/SubNav.tsx | 1 + packages/react/src/__tests__/SubNav.test.tsx | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/packages/react/src/SubNav/SubNav.tsx b/packages/react/src/SubNav/SubNav.tsx index 76af9d36061..0f99bfa9252 100644 --- a/packages/react/src/SubNav/SubNav.tsx +++ b/packages/react/src/SubNav/SubNav.tsx @@ -156,6 +156,7 @@ const SubNavLink = React.forwardRef(function ref={forwardRef} className={clsx(className, enabled && styles.Link)} data-selected={rest.selected} + aria-current={rest.selected} {...rest} > {children} diff --git a/packages/react/src/__tests__/SubNav.test.tsx b/packages/react/src/__tests__/SubNav.test.tsx index b3ca29f5d7a..6744dc24c30 100644 --- a/packages/react/src/__tests__/SubNav.test.tsx +++ b/packages/react/src/__tests__/SubNav.test.tsx @@ -66,4 +66,20 @@ describe('SubNav', () => { expect(getByTestId('action')).toBeInTheDocument() expect(getByTestId('action').parentElement).toHaveClass('SubNav-actions') }) + + it('sets aria-current on the selected child', () => { + const {getByTestId} = HTMLRender( + + + Foo + + + Bar + + , + ) + + expect(getByTestId('foo')).toHaveAttribute('aria-current', 'true') + expect(getByTestId('bar')).not.toHaveAttribute('aria-current') + }) }) From 9caad951fbdd909a4d6aa646f4f7f0ab9a1b6845 Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Wed, 5 Feb 2025 10:10:33 -0500 Subject: [PATCH 2/3] Add changeset --- .changeset/khaki-pillows-change.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/khaki-pillows-change.md diff --git a/.changeset/khaki-pillows-change.md b/.changeset/khaki-pillows-change.md new file mode 100644 index 00000000000..0575abf4cf5 --- /dev/null +++ b/.changeset/khaki-pillows-change.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +SubNav: Adds `aria-current` to selected links From c4ae6c019c2c8bde227fbe30e669fc5bc4b5154c Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Wed, 5 Feb 2025 10:23:05 -0500 Subject: [PATCH 3/3] Update snapshot --- .../react/src/__tests__/__snapshots__/SubNavLink.test.tsx.snap | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react/src/__tests__/__snapshots__/SubNavLink.test.tsx.snap b/packages/react/src/__tests__/__snapshots__/SubNavLink.test.tsx.snap index b9018c8172a..f26fef0bee6 100644 --- a/packages/react/src/__tests__/__snapshots__/SubNavLink.test.tsx.snap +++ b/packages/react/src/__tests__/__snapshots__/SubNavLink.test.tsx.snap @@ -52,6 +52,7 @@ exports[`SubNav.Link respects the "selected" prop 1`] = ` }