From d664d2a609814e36e036ffcc27e161175675a017 Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Tue, 1 Jul 2025 08:23:54 -0400 Subject: [PATCH 1/3] Add focus indicator to disabled `SelectPanel` items --- packages/react/src/ActionList/ActionList.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/ActionList/ActionList.module.css b/packages/react/src/ActionList/ActionList.module.css index b5fec848a47..253894a963f 100644 --- a/packages/react/src/ActionList/ActionList.module.css +++ b/packages/react/src/ActionList/ActionList.module.css @@ -114,7 +114,7 @@ } } - &:not(:has([aria-disabled], [disabled]), [aria-disabled='true'], [data-has-subitem='true']) { + &:not(:has([aria-disabled], [disabled]), [data-has-subitem='true']) { @media (hover: hover) { &:hover, &:active { From 2301f1d0f055d1f48300ef2ac2fe29cb70f9f7c1 Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Tue, 1 Jul 2025 08:28:38 -0400 Subject: [PATCH 2/3] Add example --- .../SelectPanel.features.stories.tsx | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/packages/react/src/SelectPanel/SelectPanel.features.stories.tsx b/packages/react/src/SelectPanel/SelectPanel.features.stories.tsx index b5bbe272502..23b144733dd 100644 --- a/packages/react/src/SelectPanel/SelectPanel.features.stories.tsx +++ b/packages/react/src/SelectPanel/SelectPanel.features.stories.tsx @@ -209,6 +209,37 @@ export const MultiSelect = () => { ) } +export const WithDisabledItem = () => { + const [selected, setSelected] = useState(items.slice(1, 3)) + const [filter, setFilter] = useState('') + const filteredItems = items.map((item, index) => (index === 3 ? {...item, disabled: true} : item)) + const [open, setOpen] = useState(false) + + return ( + + Labels + ( + + )} + open={open} + onOpenChange={setOpen} + items={filteredItems} + selected={selected} + onSelectedChange={setSelected} + onFilterChange={setFilter} + width="medium" + message={filteredItems.length === 0 ? NoResultsMessage(filter) : undefined} + /> + + ) +} + export const WithExternalAnchor = () => { const [selected, setSelected] = useState(items.slice(1, 3)) const [filter, setFilter] = useState('') From 95d8b9992946f935de8a20629ae490b1cd5cd205 Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Tue, 1 Jul 2025 08:33:55 -0400 Subject: [PATCH 3/3] Add changeset --- .changeset/puny-yaks-bake.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/puny-yaks-bake.md diff --git a/.changeset/puny-yaks-bake.md b/.changeset/puny-yaks-bake.md new file mode 100644 index 00000000000..2f09b4e68d0 --- /dev/null +++ b/.changeset/puny-yaks-bake.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +SelectPanel: Adds focus indicator to disabled items