From c2d9c8138170dd9badcd30454ad6797bab173f6a Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Wed, 9 Jul 2025 09:52:57 -0700 Subject: [PATCH 01/10] link style --- packages/react/src/BaseStyles.module.css | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/react/src/BaseStyles.module.css b/packages/react/src/BaseStyles.module.css index 24f4ce63dd6..9c01a8fc7ff 100644 --- a/packages/react/src/BaseStyles.module.css +++ b/packages/react/src/BaseStyles.module.css @@ -73,4 +73,14 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { color-scheme: dark; } } -} + + /* Global link styles */ + a { + color: var(--fgColor-accent, var(--color-accent-fg)); + text-decoration: none; + + &:hover { + text-decoration: underline; + } + } +} \ No newline at end of file From ede53227ee3afbcb8f1f5b85e09b5240ad860990 Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Thu, 10 Jul 2025 13:08:28 -0700 Subject: [PATCH 02/10] changeset --- .changeset/tidy-drinks-speak.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tidy-drinks-speak.md diff --git a/.changeset/tidy-drinks-speak.md b/.changeset/tidy-drinks-speak.md new file mode 100644 index 00000000000..2dfce213fb4 --- /dev/null +++ b/.changeset/tidy-drinks-speak.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Add basic link styles to BaseStyles. From cee904b750581b75137a109104db2266bdd7e389 Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Thu, 10 Jul 2025 13:19:18 -0700 Subject: [PATCH 03/10] format --- packages/react/src/BaseStyles.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/BaseStyles.module.css b/packages/react/src/BaseStyles.module.css index 9c01a8fc7ff..44c4f548346 100644 --- a/packages/react/src/BaseStyles.module.css +++ b/packages/react/src/BaseStyles.module.css @@ -83,4 +83,4 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { text-decoration: underline; } } -} \ No newline at end of file +} From 104ce368fc7bd9fbd6d4ec99927f0592cda8abc6 Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Thu, 10 Jul 2025 14:08:15 -0700 Subject: [PATCH 04/10] add text decoration back --- packages/react/src/BaseStyles.module.css | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/react/src/BaseStyles.module.css b/packages/react/src/BaseStyles.module.css index 44c4f548346..91064b47a3b 100644 --- a/packages/react/src/BaseStyles.module.css +++ b/packages/react/src/BaseStyles.module.css @@ -77,10 +77,5 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { /* Global link styles */ a { color: var(--fgColor-accent, var(--color-accent-fg)); - text-decoration: none; - - &:hover { - text-decoration: underline; - } } } From 9faf849bbf44745e3a1c030b3eb72f192d597cea Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Thu, 10 Jul 2025 15:43:54 -0700 Subject: [PATCH 05/10] don't apply link style to components --- packages/react/src/BaseStyles.module.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/BaseStyles.module.css b/packages/react/src/BaseStyles.module.css index 91064b47a3b..9a67c2a0a94 100644 --- a/packages/react/src/BaseStyles.module.css +++ b/packages/react/src/BaseStyles.module.css @@ -74,8 +74,8 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { } } - /* Global link styles */ - a { + /* Global link styles - only for plain links, not components */ + a:not([class]) { color: var(--fgColor-accent, var(--color-accent-fg)); } } From 4b8ff64699f5e1c17624511147b9836ac184cd40 Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Thu, 10 Jul 2025 15:52:58 -0700 Subject: [PATCH 06/10] only exclude primer components --- packages/react/src/BaseStyles.module.css | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/react/src/BaseStyles.module.css b/packages/react/src/BaseStyles.module.css index 9a67c2a0a94..acf9c75d01c 100644 --- a/packages/react/src/BaseStyles.module.css +++ b/packages/react/src/BaseStyles.module.css @@ -74,8 +74,13 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { } } - /* Global link styles - only for plain links, not components */ - a:not([class]) { + /* Global link styles - exclude Primer components */ + a:not([class*='prc-']) { color: var(--fgColor-accent, var(--color-accent-fg)); + text-decoration: none; + + &:hover { + text-decoration: underline; + } } } From f0695bd616e35d52651a673ade66e58539bbca56 Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Thu, 10 Jul 2025 16:07:18 -0700 Subject: [PATCH 07/10] uppercase class prefix PRC --- packages/react/src/BaseStyles.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/BaseStyles.module.css b/packages/react/src/BaseStyles.module.css index acf9c75d01c..c506a23250b 100644 --- a/packages/react/src/BaseStyles.module.css +++ b/packages/react/src/BaseStyles.module.css @@ -75,7 +75,7 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { } /* Global link styles - exclude Primer components */ - a:not([class*='prc-']) { + a:not([class*='prc-']):not([class*='PRC-']) { color: var(--fgColor-accent, var(--color-accent-fg)); text-decoration: none; From ac76487107f8d7249d648908593656f624214e02 Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Fri, 11 Jul 2025 10:49:33 -0700 Subject: [PATCH 08/10] only target links without classes --- packages/react/src/BaseStyles.module.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/BaseStyles.module.css b/packages/react/src/BaseStyles.module.css index c506a23250b..dc0259f4af6 100644 --- a/packages/react/src/BaseStyles.module.css +++ b/packages/react/src/BaseStyles.module.css @@ -74,8 +74,8 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { } } - /* Global link styles - exclude Primer components */ - a:not([class*='prc-']):not([class*='PRC-']) { + /* Global link styles - only target plain links with no classes */ + a:not([class]) { color: var(--fgColor-accent, var(--color-accent-fg)); text-decoration: none; From 4a9a0429fab1e428151a321c0372de78a9aee7eb Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Fri, 11 Jul 2025 14:51:11 -0700 Subject: [PATCH 09/10] use where for low specificity --- packages/react/src/BaseStyles.module.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react/src/BaseStyles.module.css b/packages/react/src/BaseStyles.module.css index dc0259f4af6..567548f3000 100644 --- a/packages/react/src/BaseStyles.module.css +++ b/packages/react/src/BaseStyles.module.css @@ -74,8 +74,8 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { } } - /* Global link styles - only target plain links with no classes */ - a:not([class]) { + /* Low-specificity default link styling */ + :where(a:not([class*='prc-']):not([class*='PRC-']):not([class*='Primer_Brand__'])) { color: var(--fgColor-accent, var(--color-accent-fg)); text-decoration: none; @@ -83,4 +83,4 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { text-decoration: underline; } } -} +} \ No newline at end of file From ccd8ecd6be995994caa9e7d74d36a73ff8d4812a Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Fri, 11 Jul 2025 14:52:53 -0700 Subject: [PATCH 10/10] format --- packages/react/src/BaseStyles.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/BaseStyles.module.css b/packages/react/src/BaseStyles.module.css index 567548f3000..76259ac05dd 100644 --- a/packages/react/src/BaseStyles.module.css +++ b/packages/react/src/BaseStyles.module.css @@ -83,4 +83,4 @@ details-dialog:focus:not(:focus-visible):not(:global(.focus-visible)) { text-decoration: underline; } } -} \ No newline at end of file +}