diff --git a/.changeset/gold-dingos-sneeze.md b/.changeset/gold-dingos-sneeze.md new file mode 100644 index 00000000000..a2aa897240c --- /dev/null +++ b/.changeset/gold-dingos-sneeze.md @@ -0,0 +1,5 @@ +--- +'@primer/react': major +--- + +Removes styled-system usage from TextInputWrapper and related components and Storybook stories. diff --git a/e2e/components/TextInput.test.ts b/e2e/components/TextInput.test.ts index fceb98ca879..114854866b2 100644 --- a/e2e/components/TextInput.test.ts +++ b/e2e/components/TextInput.test.ts @@ -219,24 +219,6 @@ test.describe('TextInput', () => { } }) - test.describe('Dev: With Sx', () => { - for (const theme of themes) { - test.describe(theme, () => { - test('default @vrt', async ({page}) => { - await visit(page, { - id: 'components-textinput-dev--with-sx', - globals: { - colorScheme: theme, - }, - }) - - // Default state - expect(await page.screenshot()).toMatchSnapshot(`TextInput.Dev.WithSx.${theme}.png`) - }) - }) - } - }) - test.describe('Dev: With CSS', () => { for (const theme of themes) { test.describe(theme, () => { @@ -254,22 +236,4 @@ test.describe('TextInput', () => { }) } }) - - test.describe('Dev: With Sx and CSS', () => { - for (const theme of themes) { - test.describe(theme, () => { - test('default @vrt', async ({page}) => { - await visit(page, { - id: 'components-textinput-dev--with-sx-and-css', - globals: { - colorScheme: theme, - }, - }) - - // Default state - expect(await page.screenshot()).toMatchSnapshot(`TextInput.Dev.WithSxAndCSS.${theme}.png`) - }) - }) - } - }) }) diff --git a/packages/react/src/Breadcrumbs/Breadcrumbs.dev.stories.module.css b/packages/react/src/Breadcrumbs/Breadcrumbs.dev.stories.module.css new file mode 100644 index 00000000000..195e4a4de45 --- /dev/null +++ b/packages/react/src/Breadcrumbs/Breadcrumbs.dev.stories.module.css @@ -0,0 +1,10 @@ +.EditableTextInput { + min-width: 120px; + max-width: 180px; + font-size: inherit; + border: var(--borderWidth-thin) dashed var(--borderColor-muted); +} + +.EditableTextInput:focus { + border: var(--borderWidth-thin) solid var(--borderColor-accent-emphasis); +} diff --git a/packages/react/src/Breadcrumbs/Breadcrumbs.dev.stories.tsx b/packages/react/src/Breadcrumbs/Breadcrumbs.dev.stories.tsx index d122887dc6c..45dd4b80712 100644 --- a/packages/react/src/Breadcrumbs/Breadcrumbs.dev.stories.tsx +++ b/packages/react/src/Breadcrumbs/Breadcrumbs.dev.stories.tsx @@ -1,6 +1,7 @@ import {useState} from 'react' import Breadcrumbs from '.' import TextInput from '../TextInput' +import classes from './Breadcrumbs.dev.stories.module.css' export default { title: 'Components/Breadcrumbs/Dev', @@ -146,15 +147,7 @@ export const WithEditableNameInput = () => ( diff --git a/packages/react/src/Overlay/Overlay.features.stories.module.css b/packages/react/src/Overlay/Overlay.features.stories.module.css index cbc6d20555c..b8fedfc4532 100644 --- a/packages/react/src/Overlay/Overlay.features.stories.module.css +++ b/packages/react/src/Overlay/Overlay.features.stories.module.css @@ -58,6 +58,24 @@ padding: var(--base-size-12); } +.TextInputWithMargin { + margin-bottom: var(--base-size-8); +} + +.IssueTitleInput { + width: 100%; + padding: var(--base-size-2) var(--base-size-8); + text-align: left; + color: var(--fgColor-default); +} + +.IssueTitleInput input { + font-weight: var(--base-text-weight-semibold); + font-size: var(--text-title-size-medium); + padding-left: 0; + padding-right: 0; +} + .IssueEditorContainer { padding: var(--base-size-24); height: 100vh; diff --git a/packages/react/src/Overlay/Overlay.features.stories.tsx b/packages/react/src/Overlay/Overlay.features.stories.tsx index a7d2bb11a09..4b89797ea61 100644 --- a/packages/react/src/Overlay/Overlay.features.stories.tsx +++ b/packages/react/src/Overlay/Overlay.features.stories.tsx @@ -16,6 +16,7 @@ import { ActionList, ActionMenu, useFocusTrap, + Textarea, } from '..' import {Tooltip} from '../TooltipV2' import classes from './Overlay.features.stories.module.css' @@ -386,8 +387,8 @@ export const NestedOverlays = ({role, open}: Args) => { Create a list to organize your starred repositories. - - + +