diff --git a/.changeset/three-vans-join.md b/.changeset/three-vans-join.md new file mode 100644 index 00000000000..09fc482ae1b --- /dev/null +++ b/.changeset/three-vans-join.md @@ -0,0 +1,5 @@ +--- +'@primer/react': major +--- + +Update ProgressBar to no longer support sx diff --git a/packages/react/src/ProgressBar/ProgressBar.tsx b/packages/react/src/ProgressBar/ProgressBar.tsx index c0b0975f8a7..4f6f9a117ee 100644 --- a/packages/react/src/ProgressBar/ProgressBar.tsx +++ b/packages/react/src/ProgressBar/ProgressBar.tsx @@ -1,8 +1,6 @@ import React, {forwardRef} from 'react' -import type {SxProp} from '../sx' import {clsx} from 'clsx' import classes from './ProgressBar.module.css' -import {BoxWithFallback} from '../internal/components/BoxWithFallback' type ProgressProp = { className?: string @@ -14,13 +12,12 @@ type StyledProgressContainerProps = { inline?: boolean barSize?: 'small' | 'default' | 'large' animated?: boolean -} & SxProp +} export type ProgressBarItemProps = React.HTMLAttributes & { 'aria-label'?: string className?: string -} & ProgressProp & - SxProp +} & ProgressProp export const Item = forwardRef( ( @@ -56,14 +53,12 @@ export const Item = forwardRef( (bgType && `var(--bgColor-${bgType[0]}-${bgType[1] || 'emphasis'})`) || 'var(--bgColor-success-emphasis)' return ( - @@ -105,8 +100,7 @@ export const ProgressBar = forwardRef( const validChildren = React.Children.toArray(children).length return ( - ( bg={bg} /> )} - + ) }, ) diff --git a/packages/styled-react/src/__tests__/__snapshots__/exports.test.ts.snap b/packages/styled-react/src/__tests__/__snapshots__/exports.test.ts.snap index fbb4eb59ca8..3cef707a5e0 100644 --- a/packages/styled-react/src/__tests__/__snapshots__/exports.test.ts.snap +++ b/packages/styled-react/src/__tests__/__snapshots__/exports.test.ts.snap @@ -28,7 +28,6 @@ exports[`@primer/styled-react exports 1`] = ` "Overlay", "PageHeader", "PageLayout", - "ProgressBar", "RadioGroup", "RelativeTime", "SegmentedControl", diff --git a/packages/styled-react/src/__tests__/primer-react.browser.test.tsx b/packages/styled-react/src/__tests__/primer-react.browser.test.tsx index 2b061a08546..ab95baeada7 100644 --- a/packages/styled-react/src/__tests__/primer-react.browser.test.tsx +++ b/packages/styled-react/src/__tests__/primer-react.browser.test.tsx @@ -27,7 +27,6 @@ import { Overlay, PageHeader, PageLayout, - ProgressBar, RadioGroup, RelativeTime, SegmentedControl, @@ -286,16 +285,6 @@ describe('@primer/react', () => { expect(window.getComputedStyle(container.firstElementChild!).backgroundColor).toBe('rgb(255, 0, 0)') }) - test('ProgressBar supports `sx` prop', () => { - const {container} = render() - expect(window.getComputedStyle(container.firstElementChild!).backgroundColor).toBe('rgb(255, 0, 0)') - }) - - test('ProgressBar.Item supports `sx` prop', () => { - const {container} = render() - expect(window.getComputedStyle(container.firstElementChild!).backgroundColor).toBe('rgb(255, 0, 0)') - }) - test('RadioGroup supports `sx` prop', () => { const {container} = render( diff --git a/packages/styled-react/src/index.tsx b/packages/styled-react/src/index.tsx index 621ffec54fd..fd9659e627a 100644 --- a/packages/styled-react/src/index.tsx +++ b/packages/styled-react/src/index.tsx @@ -237,7 +237,6 @@ export { Overlay, PageHeader, PageLayout, - ProgressBar, Select, Spinner, Text,