From 2635dec9e162dca39685643c0f1a49625b099355 Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Tue, 21 Jul 2026 18:22:54 -0400 Subject: [PATCH 1/4] chore(Link): remove unnecessary `data-hover-color` attribute --- packages/react/src/Link/Link.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react/src/Link/Link.tsx b/packages/react/src/Link/Link.tsx index 5ae1e74f5ba..74236f48386 100644 --- a/packages/react/src/Link/Link.tsx +++ b/packages/react/src/Link/Link.tsx @@ -44,7 +44,6 @@ export const UnwrappedLink = ( data-component="Link" data-muted={muted} data-inline={inline} - data-hover-color={hoverColor} {...restProps} // eslint-disable-next-line @typescript-eslint/no-explicit-any ref={mergedRef as any} From c41f395a69065686c8cc89a84494ec3524fc778b Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Tue, 21 Jul 2026 18:25:24 -0400 Subject: [PATCH 2/4] add changeset --- .changeset/remove-link-data-hover-color.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/remove-link-data-hover-color.md diff --git a/.changeset/remove-link-data-hover-color.md b/.changeset/remove-link-data-hover-color.md new file mode 100644 index 00000000000..75a8f711492 --- /dev/null +++ b/.changeset/remove-link-data-hover-color.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Link: Remove unnecessary `data-hover-color` attribute from rendered DOM element From 3788861fb8f4c7e5b8aeef0ee195516213c7ed7c Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Tue, 21 Jul 2026 18:31:34 -0400 Subject: [PATCH 3/4] chore(Link): rename `hoverColor` to `_hoverColor` for clarity --- packages/react/src/Link/Link.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/Link/Link.tsx b/packages/react/src/Link/Link.tsx index 74236f48386..27b3c6662f9 100644 --- a/packages/react/src/Link/Link.tsx +++ b/packages/react/src/Link/Link.tsx @@ -19,7 +19,7 @@ export const UnwrappedLink = ( props: PolymorphicProps, ref: ForwardedRef, ) => { - const {as: Component = 'a', className, inline, muted, hoverColor, ...restProps} = props + const {as: Component = 'a', className, inline, muted, hoverColor: _hoverColor, ...restProps} = props const innerRef = React.useRef>(null) const mergedRef = useMergedRefs(ref, innerRef) From 9201a7aeaac519d1257e42f489b758029b3afcd8 Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Tue, 21 Jul 2026 18:42:47 -0400 Subject: [PATCH 4/4] add eslint disable --- packages/react/src/Link/Link.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react/src/Link/Link.tsx b/packages/react/src/Link/Link.tsx index 27b3c6662f9..ca0b1734417 100644 --- a/packages/react/src/Link/Link.tsx +++ b/packages/react/src/Link/Link.tsx @@ -19,6 +19,7 @@ export const UnwrappedLink = ( props: PolymorphicProps, ref: ForwardedRef, ) => { + // eslint-disable-next-line @typescript-eslint/no-unused-vars const {as: Component = 'a', className, inline, muted, hoverColor: _hoverColor, ...restProps} = props const innerRef = React.useRef>(null) const mergedRef = useMergedRefs(ref, innerRef)